{"id":2226642,"url":"http://patchwork.ozlabs.org/api/patches/2226642/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260422174305.2899095-2-daniel.lezcano@oss.qualcomm.com/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422174305.2899095-2-daniel.lezcano@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-22T17:42:50","name":"[v2,01/12] thermal/driver/tegra/soctherm: Use devm_ variant when registering a cooling device","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f5b53e9fdbde3b090c126b91f6c8e4e2a37a5f77","submitter":{"id":92879,"url":"http://patchwork.ozlabs.org/api/people/92879/?format=json","name":"Daniel Lezcano","email":"daniel.lezcano@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260422174305.2899095-2-daniel.lezcano@oss.qualcomm.com/mbox/","series":[{"id":501054,"url":"http://patchwork.ozlabs.org/api/series/501054/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=501054","date":"2026-04-22T17:42:50","name":"[v2,01/12] thermal/driver/tegra/soctherm: Use devm_ variant when registering a cooling device","version":2,"mbox":"http://patchwork.ozlabs.org/series/501054/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226642/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226642/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=HSSKvqma;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=K33xB6Ph;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13849-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"HSSKvqma\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"K33xB6Ph\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g165Z0Ph2z1yGs\n\tfor ; Thu, 23 Apr 2026 03:43:29 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id CAA3B3014A2A\n\tfor ; Wed, 22 Apr 2026 17:43:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 734BE38B7D6;\n\tWed, 22 Apr 2026 17:43:19 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D298438C423\n\tfor ; Wed, 22 Apr 2026 17:43:17 +0000 (UTC)","from pps.filterd (m0279865.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63MG5BRu2185778\n\tfor ; Wed, 22 Apr 2026 17:43:17 GMT","from mail-qt1-f197.google.com (mail-qt1-f197.google.com\n [209.85.160.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1hvgby0-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Wed, 22 Apr 2026 17:43:17 +0000 (GMT)","by mail-qt1-f197.google.com with SMTP id\n d75a77b69052e-50f817c3240so40110541cf.1\n for ;\n Wed, 22 Apr 2026 10:43:17 -0700 (PDT)","from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7a051dsm142511965e9.18.2026.04.22.10.43.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 10:43:12 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776879799; cv=none;\n b=jpJN4pxMyJWpPbAPQiZEjYw/qJo9UCqbeq1j8L74yWD9c9tlT1Z5bN+StdGd2kdi1AAp7XgetEAe/3L2bOj9aqt082T3bWQQt8HvAn1iVGMjVSdfBFKF0drWGcLZKMxSFIraC9fSr41G/Jd1GCC/0k6f/+43sbDs1wIZWuAkXow=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776879799; c=relaxed/simple;\n\tbh=zWS8PuwEBAA/aKTsS1W5V1wcu3h80TjX0hW2zjl2YyY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=TWj43QLYA2ST9w387cyJQbsFO8F8UvRvARkNMM+HNmdNviPnshf4NuQL9XVdesR3tm8OvLR9ar+S9C7alj2PBrXOuxuR4OWdzA9tPoR5Cjq9iC2Rpszl1ngbBPjGUUkpCxIS5rbE2AB+R++7fuU0jnMoqufDsNzjPJR7acyBdMs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=HSSKvqma;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=K33xB6Ph; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=YAVmnQsYcnQ\n\tYdpKJBDYnCqGDQ8o6FQwjhG98mPvL/qc=; b=HSSKvqma7woJ8Qi+alo+1LO+g3F\n\tAPsb5flzPPCga7UTDbNJ9FADQ/PDuMLPilBhhyDDq7LMVGdXJzoRLxdIBgDCdYfS\n\t+mcJsC89mfQZ/Xe4T1LaLzO1XjWRfysO/gziDYQKYsIuKBP+8iYt8hZgXuhLIEky\n\tNVsYRhZA1LrLi2Jfgc/GF074nfLcZrNS/nL0bN0/wmo6w5vAHIwlyVgyCJzIaldB\n\tID/t7fB5pU7fyiJf03J4m0DOXmnW8WY/TN7gn5hiB0bAImJbOqR/7xjDyyiAnOkc\n\tNu9qTnlH3eVeNbkTEngP7ksBI+gXGnQfXOpAY05RfqwLkjIRF9SJCwOKXUw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776879796; x=1777484596;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=YAVmnQsYcnQYdpKJBDYnCqGDQ8o6FQwjhG98mPvL/qc=;\n b=K33xB6PhqHeIFi/UMMSq9mYTMTqCy2gjPgfva+ROpCitvOiRiPDxjW48lrHbFBhcZE\n JDwK/udiY4F/KQpajSE+S9t6PbVhDGgmtJmx2S6B6lvBn5+RYLAXdfP0XrnuzAt1Nx2Y\n jtNTamZ7RtNlMWE/8GLNqAApC8JBgu8gN4knTchgBs5l1wZgik+vMfDsjIfI4JhzgnSR\n fLEQkwuzfuovUFvf+wkLCNiUmlvFYfux7mW8J3OoiKx7mPmYSSN8EAYQmUrpc8C911Uc\n 5L9sSHPk3pfurYHvxK0PxBT/8yEPQXbDHLQH+hfuG2A9ctVChRQBNcCagUR6AuIppQeg\n ktuw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776879796; x=1777484596;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=YAVmnQsYcnQYdpKJBDYnCqGDQ8o6FQwjhG98mPvL/qc=;\n b=UuDrENt0LWAJOSLX2AXG6W7VBaoclPdE0bTgV9p15YiDX2mKq/FkJmBC5v6+FGJrT/\n ODt5W3QDx+Mian9m4m/70JCtyUsIyVX5lYQ/tjN1zHgEm77DZebwyhn85NZysXair6E5\n lt1BuiS+fQxyVUs98L0L0++2FxTROPefblq6FKkriOv/j2A/pu2u5mHjQymphWTp9JKY\n kxS51zdfEYqbi8DpSTyyQLRdnI63VwUFjnAw2xDmPqjO4qWvX1Tk6S/5d1M9Mvk26QmQ\n HieMwfO5h2Zcvbb6d4fGJb7mxyPebz0H2nsMwjDSM+SB9jJkPEhJco1hMFQQniXkzj7f\n 8wQg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/iJXEFTcGwNHUNprZh5UqbS/V/yRH44LTAt8J5Vu6eRmJ3GzBhBSVJjzjiHqGw5rFBoG/0R1WO6PqPzg==@vger.kernel.org","X-Gm-Message-State":"AOJu0YzUJ4W3o78jGc8+u7wHncmCulzR6Cwz+xjgJkwVnKoEyP+4G8JD\n\tx/BrlJRWkSGLY2wlpsZekZRl+b3tShdx9tkMbg473f0M3UGMSqqGPTw5TsvPLKTnOJk2QZAnyWw\n\tL7iU9uY3RiWAAbla1jkBvdkS+lmErLwgAD/Drbp9RBRTtlsQNYL1SIhSnnvMu5TbR/g==","X-Gm-Gg":"AeBDiet5/uUmFneNBeWMiFzS7qmUxOtetCS3R0gpksZOJnPVA7JbVFQlpjBY5HKkbmZ\n\t09dwfCV5f9VvSI9c1jcfN8WnKN2f/3Fawu3H+jDIA7UXBMzXb+Od9+dWWP9DKjssVDhzBrMNn11\n\tt29ra2aFlSTXXC3gvGMACORYl70YFiwXIM7jr+xoANKDXGkgwXn+1ZPSP7YNbM3qfPGTIGuz87P\n\tBVhx4DzXdY7Wm6EGekmGLbYIvOCfv5yNLslhgJ07B93heGY01yXyspBt3YGNYWiB6b2Bqob1l/v\n\tNZJIoI4MH4TWpuTYj7D1Mxklr1UWm/HsYv7xQz6XmE7i0iPquUjGCipVBsY6NOzVOtYAJaZ1Sa3\n\toWAkVreGE8pfdG2lfKj0CvJ7Eh4MnoSn3QkhpZZbDiKlI4mGydELIF1Q9EMrS","X-Received":["by 2002:a05:622a:5516:b0:50f:b904:457 with SMTP id\n d75a77b69052e-50fb9040613mr96316131cf.25.1776879796173;\n Wed, 22 Apr 2026 10:43:16 -0700 (PDT)","by 2002:a05:622a:5516:b0:50f:b904:457 with SMTP id\n d75a77b69052e-50fb9040613mr96315451cf.25.1776879795605;\n Wed, 22 Apr 2026 10:43:15 -0700 (PDT)"],"From":"Daniel Lezcano ","To":"rafael@kernel.org, daniel.lezcano@kernel.org","Cc":"gaurav.kohli@oss.qualcomm.com, Zhang Rui ,\n Lukasz Luba , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley ,\n Lucas Stach ,\n Russell King ,\n Christian Gmeiner ,\n David Airlie , Simona Vetter ,\n Guenter Roeck , Joel Stanley ,\n Andrew Jeffery , =?utf-8?q?Thomas_Wei=C3=9Fsch?=\n\t=?utf-8?q?uh?= , Benson Leung ,\n\t=?utf-8?q?Pali_Roh=C3=A1r?= ,\n Avi Fishman , Tomer Maimon ,\n Tali Perry , Patrick Venture ,\n Nancy Yuen , Benjamin Fair ,\n Heiko Stuebner , Thierry Reding ,\n Jonathan Hunter ,\n Bjorn Andersson ,\n Konrad Dybcio ,\n Amit Daniel Kachhap ,\n Viresh Kumar ,\n Neil Armstrong , Amit Kucheria ,\n linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-hwmon@vger.kernel.org, \"Jiri Slaby (SUSE)\" ,\n Mikko Perttunen ,\n Svyatoslav Ryhel , Thomas Gleixner ,\n linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE SUPPORT)","Subject":"[PATCH v2 01/12] thermal/driver/tegra/soctherm: Use devm_ variant\n when registering a cooling device","Date":"Wed, 22 Apr 2026 19:42:50 +0200","Message-ID":"<20260422174305.2899095-2-daniel.lezcano@oss.qualcomm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260422174305.2899095-1-daniel.lezcano@oss.qualcomm.com>","References":"<20260422174305.2899095-1-daniel.lezcano@oss.qualcomm.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIyMDE3MSBTYWx0ZWRfX/Rz11vKPScAf\n XA60UizSPY0JlK42ubz57exMpa7qrj+BIphzhmSI0yI3w+GfWPZ/cbhRJuWqLr+8nD1S2BYpEca\n z35hWHDzUIiezs2m+TEUUE8SV96lv4uv1V5tP8wJV/CywhKp+f5g5h7cOGyZrGXyuf8xt/a/mYo\n sP0U88JGC6O0myxjGNfa/6czsPNPvTw4lDQTTfu9Y44vj/u2Oj04RgSwcpx8IWA0aL9+QAA7m4r\n H9EmqLJrsGt1gDKkrfxlTlzQkpXj6/PftNEzmzH19Iej3SD19vm1PRv/0yK/xRU3LAWFWiMujgy\n CO93sax8nX2HZazxPEXcHD3GMVadrXWoY+CJ73LG4ym/GaABREa/Vb5fKm38pGTrJ/f7bc6j8vz\n oORK8ZRFRgXDNzjuCDCzMgq1eNoRY3Pfn8jY3J9u1fODAzBK9ZejRoiKJjfELZivxbHy/P+KgnV\n Ldw1IZ+pz/p7KmxBEJg==","X-Proofpoint-GUID":"SSGRfzxVfyNc4wyPeqSQfjNo2Wtk5duP","X-Proofpoint-ORIG-GUID":"SSGRfzxVfyNc4wyPeqSQfjNo2Wtk5duP","X-Authority-Analysis":"v=2.4 cv=HJvz0Itv c=1 sm=1 tr=0 ts=69e908b5 cx=c_pps\n a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=oPkgDEUO7JvNfMSusBkA:9\n a=a_PwQJl-kcHnX1M80qC6:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-22_02,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n phishscore=0 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0\n spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220171"},"content":"The driver invokes thermal_of_cooling_device_register() at probe time\nbut without unregistering it at remove time.\n\nAs we have a devm_ variant, use it and the cooling device should be\nautomatically removed.\n\nWhile this prevents the cooling device from leaking, the unregistration is now\ndeferred until devres_release_all() runs (after probe() returns an error or\nremove() completes).\n\nA bug can be subtly introduced by this change because the driver still\nmanually disables the hardware clocks during the probe error path and\nin tegra_soctherm_remove(). This creates a window where the cooling\ndevice remains registered and exposed to the thermal core and sysfs\nwhile the underlying hardware is powered down.\n\nIn order to prevent this potential issue, use the devm_ variant for the\nclk.\n\nCompiled-tested only.\n\nSigned-off-by: Daniel Lezcano \n---\n drivers/thermal/tegra/soctherm.c | 29 +++++++++--------------------\n 1 file changed, 9 insertions(+), 20 deletions(-)","diff":"diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c\nindex 5d26b52beaba..790c4c96a9b5 100644\n--- a/drivers/thermal/tegra/soctherm.c\n+++ b/drivers/thermal/tegra/soctherm.c\n@@ -1700,9 +1700,9 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)\n \t\t\tstc->init = true;\n \t\t} else {\n \n-\t\t\ttcd = thermal_of_cooling_device_register(np_stcc,\n-\t\t\t\t\t\t\t (char *)name, ts,\n-\t\t\t\t\t\t\t &throt_cooling_ops);\n+\t\t\ttcd = devm_thermal_of_cooling_device_register(dev, np_stcc,\n+\t\t\t\t\t\t\t\t (char *)name, ts,\n+\t\t\t\t\t\t\t\t &throt_cooling_ops);\n \t\t\tif (IS_ERR_OR_NULL(tcd)) {\n \t\t\t\tdev_err(dev,\n \t\t\t\t\t\"throttle-cfg: %s: failed to register cooling device\\n\",\n@@ -2133,13 +2133,13 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \t\treturn PTR_ERR(tegra->reset);\n \t}\n \n-\ttegra->clock_tsensor = devm_clk_get(&pdev->dev, \"tsensor\");\n+\ttegra->clock_tsensor = devm_clk_get_enabled(&pdev->dev, \"tsensor\");\n \tif (IS_ERR(tegra->clock_tsensor)) {\n \t\tdev_err(&pdev->dev, \"can't get tsensor clock\\n\");\n \t\treturn PTR_ERR(tegra->clock_tsensor);\n \t}\n \n-\ttegra->clock_soctherm = devm_clk_get(&pdev->dev, \"soctherm\");\n+\ttegra->clock_soctherm = devm_clk_get_enabled(&pdev->dev, \"soctherm\");\n \tif (IS_ERR(tegra->clock_soctherm)) {\n \t\tdev_err(&pdev->dev, \"can't get soctherm clock\\n\");\n \t\treturn PTR_ERR(tegra->clock_soctherm);\n@@ -2171,10 +2171,6 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \tif (!tegra->thermctl_tzs)\n \t\treturn -ENOMEM;\n \n-\terr = soctherm_clk_enable(pdev, true);\n-\tif (err)\n-\t\treturn err;\n-\n \tsoctherm_thermtrips_parse(pdev);\n \n \tsoctherm_init_hw_throt_cdev(pdev);\n@@ -2184,10 +2180,8 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \tfor (i = 0; i < soc->num_ttgs; ++i) {\n \t\tstruct tegra_thermctl_zone *zone =\n \t\t\tdevm_kzalloc(&pdev->dev, sizeof(*zone), GFP_KERNEL);\n-\t\tif (!zone) {\n-\t\t\terr = -ENOMEM;\n-\t\t\tgoto disable_clocks;\n-\t\t}\n+\t\tif (!zone)\n+\t\t\treturn -ENOMEM;\n \n \t\tzone->reg = tegra->regs + soc->ttgs[i]->sensor_temp_offset;\n \t\tzone->dev = &pdev->dev;\n@@ -2201,7 +2195,7 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \t\t\terr = PTR_ERR(z);\n \t\t\tdev_err(&pdev->dev, \"failed to register sensor: %d\\n\",\n \t\t\t\terr);\n-\t\t\tgoto disable_clocks;\n+\t\t\treturn err;\n \t\t}\n \n \t\tzone->tz = z;\n@@ -2210,7 +2204,7 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \t\t/* Configure hw trip points */\n \t\terr = tegra_soctherm_set_hwtrips(&pdev->dev, soc->ttgs[i], z);\n \t\tif (err)\n-\t\t\tgoto disable_clocks;\n+\t\t\treturn err;\n \t}\n \n \terr = soctherm_interrupts_init(pdev, tegra);\n@@ -2218,11 +2212,6 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \tsoctherm_debug_init(pdev);\n \n \treturn 0;\n-\n-disable_clocks:\n-\tsoctherm_clk_enable(pdev, false);\n-\n-\treturn err;\n }\n \n static void tegra_soctherm_remove(struct platform_device *pdev)\n","prefixes":["v2","01/12"]}