{"id":2226633,"url":"http://patchwork.ozlabs.org/api/patches/2226633/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260422170946.3394481-5-rs@ti.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422170946.3394481-5-rs@ti.com>","list_archive_url":null,"date":"2026-04-22T17:09:44","name":"[PATCHv5,4/6] efi_selftest_memory: check for duplicates first","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"da0f9363d32d580d85e2574334ebbd352fbde8ac","submitter":{"id":88727,"url":"http://patchwork.ozlabs.org/api/people/88727/?format=json","name":"Randolph Sapp","email":"rs@ti.com"},"delegate":{"id":68728,"url":"http://patchwork.ozlabs.org/api/users/68728/?format=json","username":"xypron","first_name":"Heinrich","last_name":"Schuchardt","email":"xypron.glpk@gmx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260422170946.3394481-5-rs@ti.com/mbox/","series":[{"id":501048,"url":"http://patchwork.ozlabs.org/api/series/501048/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=501048","date":"2026-04-22T17:09:42","name":"various memory related fixups","version":1,"mbox":"http://patchwork.ozlabs.org/series/501048/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226633/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226633/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=selector1 header.b=sYj84r23;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"sYj84r23\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de; spf=pass smtp.mailfrom=rs@ti.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g15Mh1FLmz1y2d\n\tfor ; Thu, 23 Apr 2026 03:10:40 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1BF8C843AF;\n\tWed, 22 Apr 2026 19:10:17 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D41D984370; Wed, 22 Apr 2026 19:10:08 +0200 (CEST)","from BN1PR04CU002.outbound.protection.outlook.com\n (mail-eastus2azlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c110::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6A80E8439F\n for ; Wed, 22 Apr 2026 19:10:05 +0200 (CEST)","from DS7PR03CA0327.namprd03.prod.outlook.com (2603:10b6:8:2b::35) by\n CO1PR10MB4404.namprd10.prod.outlook.com (2603:10b6:303:90::8) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9818.32; Wed, 22 Apr 2026 17:10:02 +0000","from CY4PEPF0000EDD7.namprd03.prod.outlook.com\n (2603:10b6:8:2b:cafe::e1) by DS7PR03CA0327.outlook.office365.com\n (2603:10b6:8:2b::35) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9791.48 via Frontend Transport; Wed,\n 22 Apr 2026 17:10:02 +0000","from lewvzet201.ext.ti.com (198.47.23.195) by\n CY4PEPF0000EDD7.mail.protection.outlook.com (10.167.241.203) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9846.18 via Frontend Transport; Wed, 22 Apr 2026 17:10:01 +0000","from DLEE212.ent.ti.com (157.170.170.114) by lewvzet201.ext.ti.com\n (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 22 Apr\n 2026 12:09:57 -0500","from DLEE201.ent.ti.com (157.170.170.76) by DLEE212.ent.ti.com\n (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 22 Apr\n 2026 12:09:57 -0500","from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE201.ent.ti.com\n (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Wed, 22 Apr 2026 12:09:57 -0500","from rs-desk.dhcp.ti.com (rs-desk.dhcp.ti.com [128.247.81.39])\n by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 63MH9uPO2769561;\n Wed, 22 Apr 2026 12:09:57 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=IT8YQat6yKgcUHib8x2y+Be3JBMaSYwvTuHzwrTuoKqEVFtO4LQrIda4Grp6xBl8PbA/tGlMfaSA9ksq+mqAvEl/p14TgmtMjXdAFwWXhnJuj4f6e+FnKfKdAMleSASTEfUKd24FlmIHtqgYzAFfEift53l1/aIaOtk/CqtgjFcwXRVHMfu+NTqyloEf1PGSmR5x5XJFPZ+qSeoq3F7wkzy1m04A5W9xZONG01vQyfR/+PGNrBBVGzQJs/xZ0U6x/J6ztHx6XarEq9eATTnhf6NPwm6byMoTbjOXQXONI7ERK8aYBGmPSa9yYwuyKkPmYTBGzHOPLlG/TVd2gX75ZA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=l5cKaYWEXpJkj+DHzenphJ9FKgkoigICiqjvva2Nupk=;\n b=MUDsoeHPc7noyLlfq3TjzXbd9IJl0qYBDUnt5Z2nWBzmX1mKJKZa6AF/kZp1wr9o9rESAFnqXY9k+CVHe+vujwIwT0QFSscB+hxyJd2SqimLKL28DsuBt1suU1YOb6WX+AcDmo9DCzhpk+BxmWDSd2jAPG/f62fn61XUWSAiO2U8GNOZ81X50xeaX0lZCPaa9qSjmMACqwWtA9Xgdy7Xy8cxJZRhbO2vvSg+ot16fWFR8RK44Dr36CCUAKZVLNDhsk1WLES8qB0mKqoOom+jUpv19dwzHFK3+tTp0B9bDtgAAAd++u9zfUJ6gDm/ag0TXPGdMpiewTfDs+v3JgrPzA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 198.47.23.195) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=ti.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=l5cKaYWEXpJkj+DHzenphJ9FKgkoigICiqjvva2Nupk=;\n b=sYj84r23DOrZAt0mIgN0ASUM2qxL+5J3q6kZlD/tog6agCK/qTCtAaR4THHgQmtgn+GaWup3pMtHqExvO7rcX5X2iIKYWBzsw3lDTko8IZx9HPD/dRO4X6hRTxkjvZpN7FpDnyoRdvJZzOEZi7pJx8odHtIqcOw0UBLOX/Cl4zM=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 198.47.23.195)\n smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;\n dmarc=pass\n action=none header.from=ti.com;","Received-SPF":"Pass (protection.outlook.com: domain of ti.com designates\n 198.47.23.195 as permitted sender) receiver=protection.outlook.com;\n client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C","From":"","To":", ,\n , , ,\n , , ,\n ","CC":"","Subject":"[PATCHv5 4/6] efi_selftest_memory: check for duplicates first","Date":"Wed, 22 Apr 2026 12:09:44 -0500","Message-ID":"<20260422170946.3394481-5-rs@ti.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260422170946.3394481-1-rs@ti.com>","References":"<20260422170946.3394481-1-rs@ti.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-C2ProcessedOrg":"333ef613-75bf-4e12-a4b1-8e3623f5dcea","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CY4PEPF0000EDD7:EE_|CO1PR10MB4404:EE_","X-MS-Office365-Filtering-Correlation-Id":"5cb1ed73-d2b8-44ea-08f6-08dea091fdb9","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700016|376014|1800799024|82310400026|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n Wk7uY9cIkR5dYG42SOPCGtn3+2ybi8r/4yUgUUKSpXBmXUC5Cvg3H5fJRNpLoz4FUFoR0U0XK5QPP/swrzRK2pj80fXSUC4ZH10WWHOLWLA8bwFq3XgOzsvHOx/jL+3T5tEN6y69xS+0D+AxafHdOSrptdQV6qzl1fDfh1vNy7r9fp4Wt935YfCQrxhUybg4SDGySO6C0cjaLqiTc47tPboEBijMuO5qp2ZGrEcdmxsgdCOFK25Yg6qOMzG40m/1lRM+NTq79P1nX6JvBDXwc0P4I+MWU+lpHQYrybNHki6aeQPths2EC2Nttnt/JhWg5iCYSaY3awQX4tVt23HKq0ObRrDchudKX9FFOySyqWjpdO6uKF4/rDlLctrU4SKsQh+GcirBQBdLhYEY4YieGyLyVZ3BUIvHB81T9FtFbv4RJ1Mf4eDpQBGhhPvfwqZzlEkgFsB0q75dO3/yxvEsz9AFBhqMKYVyQLwVe6TQfIIRYuMInNlBVm5bNcmNH+rtrz+5/RCxWXJ7ufXZDRop6KYHo7i+Wx3cdIwF6vE2H7nTa3JNhGFQ37JcICD3vnMJhMOE2aPIgsajVYouatMKWIJ0yJONQqFegCTPkUNKBtPRPgMPBlTcfKXzs9gndWrtjWHPa5+Qjha5R2jqhBWx0WzpfxRsIK7O+Aa6clLVRORU0GgBZZiFS26HWz0KZ3FYPf0MULbWn5jtSjZKPs+g9O+1ED9JPi1dVBl/Q2TNdDnD41MT58x9kLJ7pIrupc1W22HHRiXRKRs223K1Z3EP7w==","X-Forefront-Antispam-Report":"CIP:198.47.23.195; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:lewvzet201.ext.ti.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(36860700016)(376014)(1800799024)(82310400026)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n MFdcBMShbChfpFATZiVyi4dXxwfAQZyYJcFRSjzwVt8tfqNYPOm0ClSrehbSAG4PhLURODLrsqrMCEwv1KAW1GtmTYdUxT6xnc6Pql7E2l9Yw4tzX/Q2qvhBfzRp2hVYwFLOPMruNodyaR/RN20tBx6a+xH2b5AKNMDlr3bAvxbve0A63Bux8QUdeEtjajXX1BdMb0adVukggMJrO8JQ0wVH4X5AU0wjwNDn/x6bBccyiPmkAfZ1NRTYbWTObUcP66ykuh6f9OsY8F+o2G70sp2+ImgYgbw/ozqlTr/Yq7vYaFjALq8XPlEANPsftC/zlE2+tWyhJxEfcjoC6mkIa9vzs94tcA9IjUVOtXeWXfcFO8MPFxKydGDSUp7x+uopuCJ22FRmJ4T/M7wSQqghkOMWfVm0ehs1axhShuTraObjeKRkozhifFexAzDzQQCB","X-OriginatorOrg":"ti.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Apr 2026 17:10:01.9814 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 5cb1ed73-d2b8-44ea-08f6-08dea091fdb9","X-MS-Exchange-CrossTenant-Id":"e5b49634-450b-4709-8abb-1e2b19b982b7","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7; Ip=[198.47.23.195];\n Helo=[lewvzet201.ext.ti.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n CY4PEPF0000EDD7.namprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CO1PR10MB4404","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Randolph Sapp \n\nCheck for duplicate memory mappings before reporting any incorrect\nattributes. Could be that second allocation has the correct type while\nthe first doesn't. Knowing there is a duplicate in this scenario is\nmore helpful than just reporting the first mismatch.\n\nSigned-off-by: Randolph Sapp \nReviewed-by: Ilias Apalodimas \nReviewed-by: Simon Glass \n---\n lib/efi_selftest/efi_selftest_memory.c | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)","diff":"diff --git a/lib/efi_selftest/efi_selftest_memory.c b/lib/efi_selftest/efi_selftest_memory.c\nindex 4d32a280061..7320964c129 100644\n--- a/lib/efi_selftest/efi_selftest_memory.c\n+++ b/lib/efi_selftest/efi_selftest_memory.c\n@@ -60,7 +60,7 @@ static int find_in_memory_map(efi_uintn_t map_size,\n \t\t\t u64 addr, int memory_type)\n {\n \tefi_uintn_t i;\n-\tbool found = false;\n+\tstruct efi_mem_desc *match = NULL;\n \n \tfor (i = 0; map_size; ++i, map_size -= desc_size) {\n \t\tstruct efi_mem_desc *entry = &memory_map[i];\n@@ -72,24 +72,23 @@ static int find_in_memory_map(efi_uintn_t map_size,\n \n \t\tif (addr >= entry->physical_start &&\n \t\t addr < entry->physical_start +\n-\t\t\t (entry->num_pages << EFI_PAGE_SHIFT)) {\n-\t\t\tif (found) {\n+\t\t\t\t (entry->num_pages << EFI_PAGE_SHIFT)) {\n+\t\t\tif (match) {\n \t\t\t\tefi_st_error(\"Duplicate memory map entry\\n\");\n \t\t\t\treturn EFI_ST_FAILURE;\n \t\t\t}\n-\t\t\tfound = true;\n-\t\t\tif (memory_type != entry->type) {\n-\t\t\t\tefi_st_error\n-\t\t\t\t\t(\"Wrong memory type %d, expected %d\\n\",\n-\t\t\t\t\t entry->type, memory_type);\n-\t\t\t\treturn EFI_ST_FAILURE;\n-\t\t\t}\n+\t\t\tmatch = entry;\n \t\t}\n \t}\n-\tif (!found) {\n+\tif (!match) {\n \t\tefi_st_error(\"Missing memory map entry\\n\");\n \t\treturn EFI_ST_FAILURE;\n \t}\n+\tif (memory_type != match->type) {\n+\t\tefi_st_error(\"Wrong memory type %d, expected %d\\n\", match->type,\n+\t\t\t memory_type);\n+\t\treturn EFI_ST_FAILURE;\n+\t}\n \treturn EFI_ST_SUCCESS;\n }\n \n","prefixes":["PATCHv5","4/6"]}