{"id":2226593,"url":"http://patchwork.ozlabs.org/api/patches/2226593/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260422161407.118748-24-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260422161407.118748-24-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260422161407.118748-24-kwilczynski@kernel.org/","date":"2026-04-22T16:14:06","name":"[v6,23/24] PCI/sysfs: Remove pci_create_legacy_files() and pci_sysfs_init()","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"d63f8bb74481714fa326708a5f2b363e6a4187f4","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260422161407.118748-24-kwilczynski@kernel.org/mbox/","series":[{"id":501040,"url":"http://patchwork.ozlabs.org/api/series/501040/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=501040","date":"2026-04-22T16:13:43","name":"[v6,01/24] PCI/sysfs: Use PCI resource accessor macros","version":6,"mbox":"http://patchwork.ozlabs.org/series/501040/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226593/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226593/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=aPg1yjqD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19971-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=aPg1yjqD;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14B90ry5z1y2d\n\tfor ; Thu, 23 Apr 2026 02:17:21 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g148D0lxhz3dXH;\n\tThu, 23 Apr 2026 02:15:40 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g14865gDCz2yvZ\n\tfor ; Thu, 23 Apr 2026 02:15:34 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 4531040233;\n\tWed, 22 Apr 2026 16:15:33 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id DA7B4C2BCAF;\n\tWed, 22 Apr 2026 16:15:29 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776874539;\n\tcv=none;\n b=Trdd0Iog20N1/JpjwmDNYuuEFYYZyIky2kHyrT8po+C5USS2HKXtjXFJmxu9+G7ZJ2uWIkY3bEjNme54nuiAO0++wutENWGdn94VUraCcTbDCNq3imiO5eDRezwKtmofMcAwotkkuqpquJAb6J60b++URwZmDFmYML1zyCJv5RmqPR32WJE0wc2uC3r/GnviQWKP2wAVj6wmhKdxfLgKTG9xGBCmUwvGIbhGU9sWfSECr9TrSZkJrTid0NUS/d0WR9Il7gwV0L8kNInYklBx2UZ4J4t3EsMFX2YQHZHH/9obokoxNEmS8+H5CNli5eMjj9GVdYX51Daiu3bdSGfkvQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776874539; c=relaxed/relaxed;\n\tbh=6JRRcZ5bjx6U0Vv0xQfJVglW+lKn7TyhaRXMYQVIUa4=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=b1VJBXL7EHebTwgFWtOAXnzhmCrYYXpWwqpmDaqTebOlFzm5dBjJNhw4MBvVz4N+EEttyrwiIod0TUbr2IL6xSB7QT4+bLj51CEFJ1UG56ItbnJpsvwm2w34PnpApFDIHmzG7IkDn4V7q3T4fVpNGVn9oWmWdYOxVIQNDcmW8hXYqPYJL9Sgb0ZgMTSGy0LUUqD0Ru1U3eDsUrLFMcMtwwBmRIwwoL7iFt/2sQZo/Kd9+Czpa4tpHVyReLntuj8WOKcOL64EfDUpqqzWJftjx2ZUDWfCP9GcqAPx/n5kezg/Q44QGQnX45/gzTkaU4GdvENk+HPi7kSDVue+EEjSMg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=aPg1yjqD; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874533;\n\tbh=QcKLAuNXdwuDFZulZsorapN+pqvS/XJnyZNkfZ/5Mmw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aPg1yjqDyzSSSzK+wD+ZR09CE8iL407schn/Nou0vzd7OsFGQNScGWhvnF12v366h\n\t pIjBaviGt4vWLL3tcQ4Py/Cl8m2AQLFkhYiOI9SgsNpEceHwgBQOBIxYPzV9LKQ1R8\n\t OTIFxBxWeuIP+t2GqaaUwVRlQSd1QKe5I1D0jDS+7h+EQze6i8UBGCb6+iB0CFl0E2\n\t 1OUn5qtMzOA0Y2SudvCAC5KYCvZ4pL3V26B8HOMg7u3wiy9SogurwwwD0WJZm4T7Cz\n\t FrIc76bt9pvzNUv8uu6zzMn1loqGCB/umtNglibtfx8mXVZu+CevZCY7Rww+u4f9eP\n\t vYSeDNQ1QavFQ==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v6 23/24] PCI/sysfs: Remove pci_create_legacy_files() and\n pci_sysfs_init()","Date":"Wed, 22 Apr 2026 16:14:06 +0000","Message-ID":"<20260422161407.118748-24-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422161407.118748-1-kwilczynski@kernel.org>","References":"<20260422161407.118748-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Currently, pci_create_legacy_files() and pci_remove_legacy_files() are\nno-op stubs. With legacy attributes now handled by static groups\nregistered via pcibus_groups[], no call site needs them.\n\nRemove both functions, their declarations, and the call sites in\npci_register_host_bridge(), pci_alloc_child_bus(), and pci_remove_bus().\n\nRemove the pci_sysfs_init() late_initcall and sysfs_initialized. The\nlate_initcall originally existed to create all the dynamic PCI sysfs\nfiles, but with both resource and legacy attributes now handled by\nstatic groups, it is no longer needed.\n\nRemove the legacy_io and legacy_mem fields from struct pci_bus which\nwere used to track the dynamically allocated legacy attributes.\n\nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 21 ---------------------\n drivers/pci/pci.h | 8 --------\n drivers/pci/probe.c | 6 ------\n drivers/pci/remove.c | 2 --\n include/linux/pci.h | 2 --\n 5 files changed, 39 deletions(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex c81d3964cfa4..b167e32d55ac 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -37,10 +37,6 @@\n #define ARCH_PCI_DEV_GROUPS\n #endif\n \n-#ifdef HAVE_PCI_LEGACY\n-static int sysfs_initialized;\t/* = 0 */\n-#endif\n-\n /* show configuration fields */\n #define pci_config_attr(field, format_string)\t\t\t\t\\\n static ssize_t\t\t\t\t\t\t\t\t\\\n@@ -1135,8 +1131,6 @@ static const struct attribute_group pci_legacy_mem_sparse_group = {\n \t.is_bin_visible = pci_legacy_mem_sparse_is_visible,\n };\n \n-void pci_create_legacy_files(struct pci_bus *b) { }\n-void pci_remove_legacy_files(struct pci_bus *b) { }\n #endif /* HAVE_PCI_LEGACY */\n \n const struct attribute_group *pcibus_groups[] = {\n@@ -1811,21 +1805,6 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.is_visible = resource_resize_attr_is_visible,\n };\n \n-#ifdef HAVE_PCI_LEGACY\n-static int __init pci_sysfs_init(void)\n-{\n-\tstruct pci_bus *pbus = NULL;\n-\n-\tsysfs_initialized = 1;\n-\n-\twhile ((pbus = pci_find_next_bus(pbus)))\n-\t\tpci_create_legacy_files(pbus);\n-\n-\treturn 0;\n-}\n-late_initcall(pci_sysfs_init);\n-#endif\n-\n static struct attribute *pci_dev_dev_attrs[] = {\n \t&dev_attr_boot_vga.attr,\n \t&dev_attr_serial_number.attr,\ndiff --git a/drivers/pci/pci.h b/drivers/pci/pci.h\nindex f52caf7e4d13..63f249d4833a 100644\n--- a/drivers/pci/pci.h\n+++ b/drivers/pci/pci.h\n@@ -356,14 +356,6 @@ static inline int pci_proc_detach_bus(struct pci_bus *bus) { return 0; }\n int pci_hp_add_bridge(struct pci_dev *dev);\n bool pci_hp_spurious_link_change(struct pci_dev *pdev);\n \n-#if defined(CONFIG_SYSFS) && defined(HAVE_PCI_LEGACY)\n-void pci_create_legacy_files(struct pci_bus *bus);\n-void pci_remove_legacy_files(struct pci_bus *bus);\n-#else\n-static inline void pci_create_legacy_files(struct pci_bus *bus) { }\n-static inline void pci_remove_legacy_files(struct pci_bus *bus) { }\n-#endif\n-\n /* Lock for read/write access to pci device and bus lists */\n extern struct rw_semaphore pci_bus_sem;\n extern struct mutex pci_slot_mutex;\ndiff --git a/drivers/pci/probe.c b/drivers/pci/probe.c\nindex bccc7a4bdd79..94c52bf3a65c 100644\n--- a/drivers/pci/probe.c\n+++ b/drivers/pci/probe.c\n@@ -1068,9 +1068,6 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge)\n \t\t\tdev_err(&bus->dev, \"failed to add bus: %d\\n\", err);\n \t}\n \n-\t/* Create legacy_io and legacy_mem files for this bus */\n-\tpci_create_legacy_files(bus);\n-\n \tif (parent)\n \t\tdev_info(parent, \"PCI host bridge to bus %s\\n\", name);\n \telse\n@@ -1276,9 +1273,6 @@ static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent,\n \t\t\tdev_err(&child->dev, \"failed to add bus: %d\\n\", ret);\n \t}\n \n-\t/* Create legacy_io and legacy_mem files for this bus */\n-\tpci_create_legacy_files(child);\n-\n \treturn child;\n }\n \ndiff --git a/drivers/pci/remove.c b/drivers/pci/remove.c\nindex 6e796dbc5b29..d8bffa21498a 100644\n--- a/drivers/pci/remove.c\n+++ b/drivers/pci/remove.c\n@@ -65,8 +65,6 @@ void pci_remove_bus(struct pci_bus *bus)\n \tlist_del(&bus->node);\n \tpci_bus_release_busn_res(bus);\n \tup_write(&pci_bus_sem);\n-\tpci_remove_legacy_files(bus);\n-\n \tif (bus->ops->remove_bus)\n \t\tbus->ops->remove_bus(bus);\n \ndiff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 6b630bac8c08..1859c0bf4e35 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -724,8 +724,6 @@ struct pci_bus {\n \tpci_bus_flags_t bus_flags;\t/* Inherited by child buses */\n \tstruct device\t\t*bridge;\n \tstruct device\t\tdev;\n-\tstruct bin_attribute\t*legacy_io;\t/* Legacy I/O for this bus */\n-\tstruct bin_attribute\t*legacy_mem;\t/* Legacy mem */\n \tunsigned int\t\tis_added:1;\n \tunsigned int\t\tunsafe_warn:1;\t/* warned about RW1C config write */\n \tunsigned int\t\tflit_mode:1;\t/* Link in Flit mode */\n","prefixes":["v6","23/24"]}