{"id":2226581,"url":"http://patchwork.ozlabs.org/api/patches/2226581/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260422161407.118748-15-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260422161407.118748-15-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260422161407.118748-15-kwilczynski@kernel.org/","date":"2026-04-22T16:13:57","name":"[v6,14/24] alpha/PCI: Fix __pci_mmap_fits() overflow for zero-length BARs","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"100c4fa502870b129bd76114dccda63012eede9a","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260422161407.118748-15-kwilczynski@kernel.org/mbox/","series":[{"id":501040,"url":"http://patchwork.ozlabs.org/api/series/501040/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=501040","date":"2026-04-22T16:13:43","name":"[v6,01/24] PCI/sysfs: Use PCI resource accessor macros","version":6,"mbox":"http://patchwork.ozlabs.org/series/501040/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226581/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226581/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=rrE1j7uy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19962-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=rrE1j7uy;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g148t5VTJz1y2d\n\tfor ; Thu, 23 Apr 2026 02:16:14 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g147c1ZVgz2yvD;\n\tThu, 23 Apr 2026 02:15:08 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g147V6QlWz2ysZ\n\tfor ; Thu, 23 Apr 2026 02:15:02 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 0A92660581;\n\tWed, 22 Apr 2026 16:15:01 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7D06BC2BCB4;\n\tWed, 22 Apr 2026 16:14:57 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776874508;\n\tcv=none;\n b=LPRFpTjNN8VCVMM16vdGewIpAMfkW5P1NSieDQpyGArJW2bDXWygva6nZpXmGhyNQ2LGiYWWb+rKkF/iQR0BEe45lFWM+GsMzmZ5gKM3XGwBaI9fmVvgvadb64WjO4kvHF1gNgg31ZlFKxnnx1VDY2bheiuWpeBi5tlAJpEKlYVUlU7XilUXntHvGm/rpKkv/m7waakAC4OSR0bv9pqRHIe3sX4zpcaT3pW0zR8p5YWmmFT/1sPVUn4FOq0MPeqN+C1s16VOLi6wpkLYPvSrC4Kfg1Jp/uc79mARnNebCBliKIqhgKEeZF7iQm8E9diGv71iRB6HWxDqstKYaqaxgQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776874508; c=relaxed/relaxed;\n\tbh=dDjlkloGmwHD4vgFKTD8OFMqGFNr61u/M+E9P0ufF1g=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=cEBpGNvICKJGQykkp7NyO5p83tDxi8aZAKmq7HYSpiwRtjzZ1tVWD0rjKQageuVtAZ5HqO6mxAaknBE0jeUJqdw+GxBZun5oZjHBcgHRSc0cvHXcKdp/6iQLFk1jIPn78onlCOMpHywLK4jTXJ+TVBbkTPWLwOx7/XfLEygL98k15b8r9b87vq41Aa+TxTs+gO+tpNgDnEeEJs1R3PhGHEND7OvXQVPEyJxKWZ1kRVyBOFnnd4vJ8yH7VZpGzHrvDuaD2HkwHoAXX4H6yvj0hqVadJz0/Z6rm/n9xVm/r6OM8OJ18Ql1qBKNiBDygVk0lUijalsOT9vep77wfc5BDg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=rrE1j7uy; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874500;\n\tbh=dkenDLAyAT+KiwXEFM4WIJAXbFTQKkHWTcI169/tbfw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rrE1j7uyIswhjn2yhrQSx3VK/tgsSMYjSTaeOjMIf6xQaDlUfI/U2ig03JKGS0G73\n\t 3z72S4W+GaTnOdwG+Q6AtZKdOt1fowfIdzK0ctGVLkUu6ej1jsNtlvhfYyKSeBN4b1\n\t GO0/sXri35yNoYsoLhmqaue3t5lYJeQqukI7z9COrJb3gbzUz0xZIsxu5UwPCGKX3a\n\t UJg8HyWTzAUExXlkKb1DGD3EZtVZ+S71QT7V8aB5wxpPgAM4lRdrgGnSCo9eE8+hdG\n\t dr3jT9Z90eVH8cCS/aKFoFaIfZi0J8oc95v6zs3ThvvkSSQCPzb6VUxnpm5pj+5/PG\n\t DI1b/hxppuyBw==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v6 14/24] alpha/PCI: Fix __pci_mmap_fits() overflow for\n zero-length BARs","Date":"Wed, 22 Apr 2026 16:13:57 +0000","Message-ID":"<20260422161407.118748-15-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422161407.118748-1-kwilczynski@kernel.org>","References":"<20260422161407.118748-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Currently, __pci_mmap_fits() computes the BAR size using\npci_resource_len() - 1, which wraps to a large value when the\nBAR length is zero, causing the bounds check to incorrectly\nsucceed.\n\nThus, add an early return for empty resources.\n\nFixes: 10a0ef39fbd1 (\"PCI/alpha: pci sysfs resources\")\nTested-by: Magnus Lindholm \nReviewed-by: Ilpo Järvinen \nAcked-by: Magnus Lindholm \nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/kernel/pci-sysfs.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 5c29f1d2821c..8802f955256e 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -37,12 +37,16 @@ static int hose_mmap_page_range(struct pci_controller *hose,\n static int __pci_mmap_fits(struct pci_dev *pdev, int num,\n \t\t\t struct vm_area_struct *vma, int sparse)\n {\n+\tresource_size_t len = pci_resource_len(pdev, num);\n \tunsigned long nr, start, size;\n \tint shift = sparse ? 5 : 0;\n \n+\tif (!len)\n+\t\treturn 0;\n+\n \tnr = vma_pages(vma);\n \tstart = vma->vm_pgoff;\n-\tsize = ((pci_resource_len(pdev, num) - 1) >> (PAGE_SHIFT - shift)) + 1;\n+\tsize = ((len - 1) >> (PAGE_SHIFT - shift)) + 1;\n \n \tif (start < size && size - start >= nr)\n \t\treturn 1;\n","prefixes":["v6","14/24"]}