{"id":2226575,"url":"http://patchwork.ozlabs.org/api/patches/2226575/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260422161407.118748-9-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260422161407.118748-9-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260422161407.118748-9-kwilczynski@kernel.org/","date":"2026-04-22T16:13:51","name":"[v6,08/24] PCI/sysfs: Warn about BAR resize failure in __resource_resize_store()","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"59dc2111873ebb11231ed7590e5f6a1bc6db8075","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260422161407.118748-9-kwilczynski@kernel.org/mbox/","series":[{"id":501040,"url":"http://patchwork.ozlabs.org/api/series/501040/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=501040","date":"2026-04-22T16:13:43","name":"[v6,01/24] PCI/sysfs: Use PCI resource accessor macros","version":6,"mbox":"http://patchwork.ozlabs.org/series/501040/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226575/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226575/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=eIy7Urip;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19956-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=eIy7Urip;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g147w0jsyz1y2d\n\tfor ; Thu, 23 Apr 2026 02:15:24 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g147C4nmPz2yv3;\n\tThu, 23 Apr 2026 02:14:47 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g14761Ylfz2yv1\n\tfor ; Thu, 23 Apr 2026 02:14:42 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 2CBC36057A;\n\tWed, 22 Apr 2026 16:14:40 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id B7FA2C2BCB2;\n\tWed, 22 Apr 2026 16:14:36 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776874487;\n\tcv=none;\n b=CnpbU0LWieMt8iE9yxJW4dpJTqF7sv5v5sEz5f7ZetT9o+IIKEnV2AzUBebaYIwhN5uGBCKkpmLteN+cRhS3XbYp90F38Byb/04wffs/UCQUnPqsutSPA1/bfytsBBpnpuAZqWXHzZK74RfFzfUJW/9vTsj6cSbDq8t/rEOP0/5hzue2saJ7Z7V8rsLiJ0qmdHNKkB58SQxSWrOdGXONQ5Wn8hh2xJOSdWwSRr2vgLUfCXpl5DVBxuXhM4TOhTbIQNVuONgMpp9DUmEZgvorEMNsfhfR2AiU1OCR7rZPH/qxJNHFFqw5zunwFAllN8X+SFFzlbPWGBOAqBTPzDD5Kg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776874487; c=relaxed/relaxed;\n\tbh=KWYtbmJf3a3UDl6fsni42j/4SglEWy2e1noV/d07org=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=SJZ7F4f01s+Xba5652oZYSgh5TodowCRF1gubQzaboBiAKMAVIxHP1nSdAQREKZqL0gAUYsZ4/haScjZw0atsVqYBHlgWmwDfcvf6lb8RHgeNrg4VBTbFgRuk3q1q850Hi1MstA0bMl/6woHu6M8g0H9F8Zw1NOkOffEgHHuU4euzvAbppkPeoItv0cDiSAJtOzBHY/ZyU1fJmhmb4mOcKF+RSuVRQc/M/IS0rFHvJKXXNd9zX7Jl0GtiGXZ8FMD5qbe5sXgtAp8yCrLG32B+jN6vnzjE3+NI8ZGFFWzOJ6tc81XcEgRUByel+Q5UQ8u6474xRfLNWvodquy3YgrwQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=eIy7Urip; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874479;\n\tbh=tPC3J3ZhBEH6py/uCTWgJRVGCTKnpjJlJA0/I3j9P2E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eIy7UripanPcwv0lcuvpN+LC+hvGpFWR4gvFU0nG+S4dMTz0zbh0L0Rro2gNPgIqU\n\t MQgN/EIbpsPzR2bfNN5K4/GxS/7qge8+CTlD8vA1Kr990ZENvd73NqkFRZigpT4Juv\n\t mtx7SGoHAu4WtHEnmEhNvDJhqsWPzBfRshYvQURZyR3ckGX2rZOtGQiIkOEVmQQYGo\n\t 7zAodRktmezQzJRsQVYUp8Dq+oJfmNwREDfqbDAKSU+JJUkt/apjGg7+alxm75ODF4\n\t gQanKXWrYMI1XPIlfvagSjJJitwmQWqgZadMoayLQWWtYzdEHn3EdJ9GrBwFM4wS6F\n\t sE0wogHvrgNzQ==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v6 08/24] PCI/sysfs: Warn about BAR resize failure in\n __resource_resize_store()","Date":"Wed, 22 Apr 2026 16:13:51 +0000","Message-ID":"<20260422161407.118748-9-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422161407.118748-1-kwilczynski@kernel.org>","References":"<20260422161407.118748-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Add a pci_warn() to __resource_resize_store(), so that BAR resize\nfailures are visible to the user, which can help troubleshoot any\npotential resource resize issues.\n\nWhile at it, rename the resource_resize_is_visible() to\nresource_resize_attr_is_visible() along with the corresponding\ngroup variable to align with the naming convention used by the\nresource attribute groups.\n\nAlso, change the order of pci_dev_groups[] such that the resize\ngroup is now located alongside the other resource groups.\n\nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 3508e29f6ad1..c0925bdc9ecd 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1703,6 +1703,9 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tsysfs_remove_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups);\n \n \tret = pci_resize_resource(pdev, n, size, 0);\n+\tif (ret)\n+\t\tpci_warn(pdev, \"Failed to resize BAR %d: %pe\\n\",\n+\t\t\t n, ERR_PTR(ret));\n \n \tpci_assign_unassigned_bus_resources(bus);\n \n@@ -1750,7 +1753,7 @@ static struct attribute *resource_resize_attrs[] = {\n \tNULL,\n };\n \n-static umode_t resource_resize_is_visible(struct kobject *kobj,\n+static umode_t resource_resize_attr_is_visible(struct kobject *kobj,\n \t\t\t\t\t struct attribute *a, int n)\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n@@ -1758,9 +1761,9 @@ static umode_t resource_resize_is_visible(struct kobject *kobj,\n \treturn pci_rebar_get_current_size(pdev, n) < 0 ? 0 : a->mode;\n }\n \n-static const struct attribute_group pci_dev_resource_resize_group = {\n+static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.attrs = resource_resize_attrs,\n-\t.is_visible = resource_resize_is_visible,\n+\t.is_visible = resource_resize_attr_is_visible,\n };\n \n int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n@@ -1881,6 +1884,7 @@ const struct attribute_group *pci_dev_groups[] = {\n \t&pci_dev_resource_uc_attr_group,\n \t&pci_dev_resource_wc_attr_group,\n #endif\n+\t&pci_dev_resource_resize_attr_group,\n \t&pci_dev_config_attr_group,\n \t&pci_dev_rom_attr_group,\n \t&pci_dev_reset_attr_group,\n@@ -1892,7 +1896,6 @@ const struct attribute_group *pci_dev_groups[] = {\n #ifdef CONFIG_ACPI\n \t&pci_dev_acpi_attr_group,\n #endif\n-\t&pci_dev_resource_resize_group,\n \tARCH_PCI_DEV_GROUPS\n \tNULL,\n };\n","prefixes":["v6","08/24"]}