{"id":2226442,"url":"http://patchwork.ozlabs.org/api/patches/2226442/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260422094649.57611-5-brian.ruley@gehealthcare.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422094649.57611-5-brian.ruley@gehealthcare.com>","list_archive_url":null,"date":"2026-04-22T09:46:43","name":"[5/5] video: imx: ipuv3: enable ipu clk before writing registers in CCF","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"831624ece7157cf7b5e130c44d9a48f2a96f163a","submitter":{"id":89422,"url":"http://patchwork.ozlabs.org/api/people/89422/?format=json","name":"Brian Ruley","email":"brian.ruley@gehealthcare.com"},"delegate":{"id":151988,"url":"http://patchwork.ozlabs.org/api/users/151988/?format=json","username":"festevam","first_name":"Fabio","last_name":"Estevam","email":"festevam@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260422094649.57611-5-brian.ruley@gehealthcare.com/mbox/","series":[{"id":501004,"url":"http://patchwork.ozlabs.org/api/series/501004/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=501004","date":"2026-04-22T09:46:40","name":"[1/5] clk: imx6q: cosmetic: keep pll definitions together","version":1,"mbox":"http://patchwork.ozlabs.org/series/501004/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226442/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226442/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gehealthcare.com header.i=@gehealthcare.com\n header.a=rsa-sha256 header.s=selector1 header.b=DspZ9V0C;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=gehealthcare.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gehealthcare.com header.i=@gehealthcare.com\n header.b=\"DspZ9V0C\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=gehealthcare.com","phobos.denx.de;\n spf=pass smtp.mailfrom=Brian.Ruley@gehealthcare.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0zFy749sz1yD5\n\tfor ; Wed, 22 Apr 2026 22:35:18 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B0A7B84258;\n\tWed, 22 Apr 2026 14:34:29 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id AB9568425F; Wed, 22 Apr 2026 11:47:07 +0200 (CEST)","from SN4PR0501CU005.outbound.protection.outlook.com\n (mail-southcentralusazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c10d::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 794D18426E\n for ; Wed, 22 Apr 2026 11:47:05 +0200 (CEST)","from PH8PR05CA0015.namprd05.prod.outlook.com (2603:10b6:510:2cc::16)\n by SA1PR22MB4185.namprd22.prod.outlook.com (2603:10b6:806:38d::8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Wed, 22 Apr\n 2026 09:47:01 +0000","from CY4PEPF0000EE3A.namprd03.prod.outlook.com\n (2603:10b6:510:2cc:cafe::db) by PH8PR05CA0015.outlook.office365.com\n (2603:10b6:510:2cc::16) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.19 via Frontend Transport; Wed,\n 22 Apr 2026 09:47:01 +0000","from atlrelay2.compute.ge-healthcare.net (165.85.157.49) by\n CY4PEPF0000EE3A.mail.protection.outlook.com (10.167.242.12) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9846.18 via Frontend Transport; Wed, 22 Apr 2026 09:47:01 +0000","from zoo11.fihel.lab.ge-healthcare.net\n (zoo11.fihel.lab.ge-healthcare.net [10.168.174.93])\n by builder1.fihel.lab.ge-healthcare.net (Postfix) with ESMTP id EFE281290C;\n Wed, 22 Apr 2026 12:46:59 +0300 (EEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,T_SPF_PERMERROR autolearn=ham autolearn_force=no\n version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=iQr5rawKrS65TzewbRO8RcqYv3LbKPFbqb2CYCe7uyVw6yI1llQviwHiSIlphfEG1jzS7804Q7TWaI8OObQZtomTaVdeki8hLgEotJpWTIDPAuhSQSMdeb1SMHcDxz2U/dBb1BVs9bFHgAmSsFmdWmVnYsPw61x1uvqt1TwWujmjDAf5R2hPBmydsILdSPToRYgIYICxOIa82xhXeLs3ab3kPLiC125YZoG/6AljviyDMYoA8uPavuECmT6PSD/xdYDLhXkIqpgXPXgRI1H0MlV8zLbtJAz3QCZpwP/7PMV5joOKLA3qVA80+WcM8UQHDTOfHwgh/lwqwne8K9PDHQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=YJyG8EWy5dtHdF20NmYGRPeDQ185wQfPiiwenqv01E8=;\n b=UHa7CUNCFiHYbN839thg7qpNFNFluATpNzVa3w+ZvCn6/O3LjHL7Vt9aXhEYAC7KMddAEUsQ2sUwpqoY3Ks2jXdmkvRrm4ZHmkp8LQRSBmCHhWbdI/VWcZNmiNdHT124LlfVijzs+rqq5KZ4jeQVPfvGjwCcpSBAJg+sGNGlXAlQKPkfY7kci6zL21vuXkFj6SBkD6vvT9k65g2+VFkZfbfw7VbxN5/TBblv9yLZsx5InmZawFaK4bZn4jzNb3kNIJ+imcRnRUFCv59soEzP+jsWLGlFkKWxvw+iSuXGmsEWfyS44GD99noSt2lJEDCvfNq68mJ0b6/D5MW0VyWZrQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=fail (sender ip is\n 165.85.157.49) smtp.rcpttodomain=lists.denx.de\n smtp.mailfrom=gehealthcare.com; dmarc=fail (p=quarantine sp=quarantine\n pct=100) action=quarantine header.from=gehealthcare.com; dkim=none (message\n not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gehealthcare.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=YJyG8EWy5dtHdF20NmYGRPeDQ185wQfPiiwenqv01E8=;\n b=DspZ9V0CQ144iAQA1Jicjxo6B3s/4/dR4rv3BKGDxgUKIAElxmWR6PLduXTuSgVI7C0EgjZoqnGEWSAN9LVRbuP5Cuk+GqAiiA/c0ysLJ968EEJfq93n+RZsNsVMqA+E0ApyT4h0JIN6B22Dq1OJs/7dxIZkF/Zf8l97NEP3qLe6sHUS4V/QNCoYvlcrmQzlgCLmtVMFNMdONtZOpRFIxC4+sOZ9qe4IbHYP9OfhWG6baKH29aZlK5cklG6AWSFfUW9Qc/OlYakwrfh790geTYqIkkpPKMRlUq3bcZE/Yw3ziCNPN25/Sj1J7p8ceaFC/0VuebIEj9NJyoZZ+26ngA==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 165.85.157.49)\n smtp.mailfrom=gehealthcare.com; dkim=none (message not signed)\n header.d=none;dmarc=fail action=quarantine header.from=gehealthcare.com;","Received-SPF":"Fail (protection.outlook.com: domain of gehealthcare.com does\n not designate 165.85.157.49 as permitted sender)\n receiver=protection.outlook.com; client-ip=165.85.157.49;\n helo=atlrelay2.compute.ge-healthcare.net;","From":"Brian Ruley ","To":"Anatolij Gustschin , Tom Rini ","Cc":"Brian Ruley ,\n\tu-boot@lists.denx.de","Subject":"[PATCH 5/5] video: imx: ipuv3: enable ipu clk before writing\n registers in CCF","Date":"Wed, 22 Apr 2026 12:46:43 +0300","Message-ID":"<20260422094649.57611-5-brian.ruley@gehealthcare.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260422094649.57611-1-brian.ruley@gehealthcare.com>","References":"<20260422094649.57611-1-brian.ruley@gehealthcare.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CY4PEPF0000EE3A:EE_|SA1PR22MB4185:EE_","Content-Type":"text/plain","X-MS-Office365-Filtering-Correlation-Id":"e5e79cad-9af5-4a1f-2cbf-08dea0541a62","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|376014|36860700016|82310400026|56012099003|22082099003|18096099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n JXZcvT6MBARjDSoP5pQUVNyPa8akaVvRMSZF2ayxxqOfx1I5mw9Y6XZ72Nzj4H1nn/rbR4dl8DwZt409zLCnKAxOXUy5m9XISN/EykchOe5wUJU6DihcRaU2+vTjM5UxGytJAmn0fmqyYq6iI+TC7mJriCyn25FYnqHEp6vKl2PWlAick62Y6C2PhvKZkCoa2bSBDrciGi7xXs4VrKnGhSSNpl91rnGzLmhR3CkkxaJV8pWSBMIBHyyBltRrSxFOZiF+7t+3i3JjtwPUyXBqeY+p1GNGjeribz0PB+7TssvBNY8AnahjgQWYi3sFh/krmtmnR15WWAODQ9EWR0Y8YzJJcZm8gCxnw+YBYBMjDldGCi1aJAj25GRcCzIVLQCbW8WWk2A24Kc7Y8602d8Anyri0ev91ZCjGACVHL3qd7buL4axIdlYS0VQKm6PX8kGmNixPXLBOlLhN1kp5sdAyLW1mUxpRT6DW/7uBquaYMOF8cXwqegaUsuccgfLeTuxljKo00QLdG/76SJOaxaNO/ebmd2TkeqggGSJUBzX3Z6Hv80w2p1FaNwvPeYfy1RZctxWmN3z0UyqivYxSG16iLPeG679sGdPmtFvCzEmsmmbjQR5CPkBBON7Q1A7V7LD1Twn8zET22XRGjZR0FTaySG8gxEyAAyP6PTE+ryInI96xiTVGGPBW6Ssh2hIcoWw8NKB0EtV45LMxuylzQFxe2t7h9PnsThd+ouDDYek6nv37SwCteHGcZ/Cn0Gb0t1CV+bfSORZWgzzxhCpMCYZ6w==","X-Forefront-Antispam-Report":"CIP:165.85.157.49; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:atlrelay2.compute.ge-healthcare.net;\n PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(36860700016)(82310400026)(56012099003)(22082099003)(18096099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n jPQUJF+VrAAoZFSxqtwc3uyBGTQsIR1LNXmLNND+SU07Anr86fDtM182dYhyWXhSJI0YwPxhPGokqNIuzXDr0mFlnq6NWZDwUbxnEcE9Fi5NG5Q7Mc4jTGXy8rYUv+MEmjGMqlI7y/tAzsMdEuCkH9wtCI1X3yEI9KwnYmTeRRnSBI728SJ7Y2BEEB9dWf4Rvp9QvNSiWzBzCv/3yC6Ym86hEb3N+04I2IivEkQEyxIp7fg0tfe4eGgFqtg4IsDifp0ACp/ccSnWb5VjjI1D/gfSENPGv43qtAHS3ABM5vtVwIun48uZnQPdiaqqWBbMJq8U69QK/HQEXiE/knOAxK3irlL/Amqbd9LzRhqhG4tAKdcftvRYw379ygCIkLuomuEskecZPkBYWx61RLZtATTBzG+3uCzQo7b1xjw7A8rqP4X0Drw0GqPEA99J9rWU","X-OriginatorOrg":"gehealthcare.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Apr 2026 09:47:01.1006 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n e5e79cad-9af5-4a1f-2cbf-08dea0541a62","X-MS-Exchange-CrossTenant-Id":"9a309606-d6ec-4188-a28a-298812b4bbbf","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=9a309606-d6ec-4188-a28a-298812b4bbbf; Ip=[165.85.157.49];\n Helo=[atlrelay2.compute.ge-healthcare.net]","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"\n TreatMessagesAsInternal-CY4PEPF0000EE3A.namprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SA1PR22MB4185","X-Mailman-Approved-At":"Wed, 22 Apr 2026 14:34:21 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Obviously, the clock has to be enabled if writing to it's registers.\nThis was missed because the board I tested on had enabled the clocks in\nearly init.\n\nAlso, remove the completely useless \"ipu_clk_enabled\" struct member and\nuse the accurate usecount / enabled_count instead.\n\nSigned-off-by: Brian Ruley \n---\n drivers/video/imx/ipu.h | 1 -\n drivers/video/imx/ipu_common.c | 13 +++++++------\n 2 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/video/imx/ipu.h b/drivers/video/imx/ipu.h\nindex ae40e20bc28..aecb6adffce 100644\n--- a/drivers/video/imx/ipu.h\n+++ b/drivers/video/imx/ipu.h\n@@ -136,7 +136,6 @@ struct ipu_ctx {\n \n \tstruct clk *ipu_clk;\n \tstruct clk *ldb_clk;\n-\tunsigned char ipu_clk_enabled;\n \tstruct clk *di_clk[2];\n \tstruct clk *pixel_clk[2];\n \ndiff --git a/drivers/video/imx/ipu_common.c b/drivers/video/imx/ipu_common.c\nindex 8630374a055..d3b52605731 100644\n--- a/drivers/video/imx/ipu_common.c\n+++ b/drivers/video/imx/ipu_common.c\n@@ -299,9 +299,9 @@ struct ipu_ctx *ipu_probe(struct udevice *dev)\n #if CONFIG_IS_ENABLED(IPU_CLK_LEGACY)\n \tclk_set_parent(ctx->pixel_clk[0], ctx->ipu_clk);\n \tclk_set_parent(ctx->pixel_clk[1], ctx->ipu_clk);\n+#endif\n \n \tclk_enable(ctx->ipu_clk);\n-#endif\n \n \tfor (int i = 0; i <= 1; i++) {\n \t\tret = ipu_di_clk_init(ctx, i);\n@@ -384,10 +384,8 @@ int32_t ipu_init_channel(struct ipu_ctx *ctx, ipu_channel_t channel,\n \n \tdebug(\"init channel = %d\\n\", IPU_CHAN_ID(channel));\n \n-\tif (ctx->ipu_clk_enabled == 0) {\n-\t\tctx->ipu_clk_enabled = 1;\n+\tif (!ipu_clk_enabled(ctx))\n \t\tclk_enable(ipu_clk);\n-\t}\n \n \tif (*channel_init_mask & (1L << IPU_CHAN_ID(channel))) {\n \t\tprintf(\"Warning: channel already initialized %d\\n\",\n@@ -543,7 +541,6 @@ void ipu_uninit_channel(struct ipu_ctx *ctx, ipu_channel_t channel)\n \n \tif (ipu_conf == 0) {\n \t\tclk_disable(ctx->ipu_clk);\n-\t\tctx->ipu_clk_enabled = 0;\n \t}\n }\n \n@@ -1045,5 +1042,9 @@ ipu_color_space_t format_to_colorspace(u32 fmt)\n \n bool ipu_clk_enabled(struct ipu_ctx *ctx)\n {\n-\treturn ctx->ipu_clk_enabled;\n+#if CONFIG_IS_ENABLED(IPU_CLK_LEGACY)\n+\treturn clk_get_usecount(ctx->ipu_clk);\n+#else\n+\treturn ctx->ipu_clk->enable_count;\n+#endif\n }\n","prefixes":["5/5"]}