{"id":2226345,"url":"http://patchwork.ozlabs.org/api/patches/2226345/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422-arm-v1-1-106a9a9e22dd@rsg.ci.i.u-tokyo.ac.jp/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422-arm-v1-1-106a9a9e22dd@rsg.ci.i.u-tokyo.ac.jp>","list_archive_url":null,"date":"2026-04-22T12:13:26","name":"target/arm/kvm: Mark host feature cache valid last","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"be962cbb33a19800b05c218298917259137215f6","submitter":{"id":90980,"url":"http://patchwork.ozlabs.org/api/people/90980/?format=json","name":"Akihiko Odaki","email":"odaki@rsg.ci.i.u-tokyo.ac.jp"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422-arm-v1-1-106a9a9e22dd@rsg.ci.i.u-tokyo.ac.jp/mbox/","series":[{"id":501000,"url":"http://patchwork.ozlabs.org/api/series/501000/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501000","date":"2026-04-22T12:13:26","name":"target/arm/kvm: Mark host feature cache valid last","version":1,"mbox":"http://patchwork.ozlabs.org/series/501000/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226345/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226345/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=rsg.ci.i.u-tokyo.ac.jp\n header.i=@rsg.ci.i.u-tokyo.ac.jp header.a=rsa-sha256 header.s=rs20250326\n header.b=K5Y+q+NE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0yps61KCz1y2d\n\tfor ; Wed, 22 Apr 2026 22:15:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFWT5-0003XN-Rl; Wed, 22 Apr 2026 08:14:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFWSv-0003WC-VD; Wed, 22 Apr 2026 08:14:03 -0400","from www3579.sakura.ne.jp ([49.212.243.89])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFWSt-0003VK-6C; Wed, 22 Apr 2026 08:14:01 -0400","from h205.csg.ci.i.u-tokyo.ac.jp (h205.csg.ci.i.u-tokyo.ac.jp\n [133.11.54.205]) (authenticated bits=0)\n by www3579.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 63MCDTNX030696\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Wed, 22 Apr 2026 21:13:47 +0900 (JST)\n (envelope-from odaki@rsg.ci.i.u-tokyo.ac.jp)"],"DKIM-Signature":"a=rsa-sha256; bh=c6f8xHZahEQDw28PGKsEGeLYdPm2CEUuNXUGAafH/bE=;\n c=relaxed/relaxed; d=rsg.ci.i.u-tokyo.ac.jp;\n h=From:Message-Id:To:Subject:Date;\n s=rs20250326; t=1776860027; v=1;\n b=K5Y+q+NEM9CIQi34hFmbkuZOigsKb3+zWv5nzi9VKx5LXXaUAAL6Y1NgK4lBjMEJ\n jLNYXhfgj8a8Ab9qMNxdYDRbEKorOdX8Ut4GUGI+UeId/7g85j1VszVX6UoP+ru0\n drQFgaLj6tjh0zeQjpCxxMn2NHQ7offGRKyeVu5CYjJmcF2G+eG+DXIv2dgF15Ze\n OqnovCytaaDKIQKabeR4PBhWktf6nffKZ+dqZRuw10Hk9C/cuBIaSUQjdFEiO6Bm\n 8TPxHuIXugT4nAlIZzC7UYt9mbibwaztojjLBJe7V4Ws9hJnHZ4RS10oJsB6zgCN\n TF+7ohEPHxzG/UnsJw/Wwg==","From":"Akihiko Odaki ","Date":"Wed, 22 Apr 2026 21:13:26 +0900","Subject":"[PATCH] target/arm/kvm: Mark host feature cache valid last","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260422-arm-v1-1-106a9a9e22dd@rsg.ci.i.u-tokyo.ac.jp>","X-B4-Tracking":"v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE\n vPSU3UzU4B8JSMDIzMDEyMj3cSiXF0LkyQj45TEFANTM0MloMqCotS0zAqwKdGxEH5xaVJWanI\n JSKtSbS0AP/7gvWcAAAA=","X-Change-ID":"20260422-arm-84b23dad0561","To":"qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Paolo Bonzini , qemu-arm@nongnu.org,\n kvm@vger.kernel.org, Akihiko Odaki ","X-Mailer":"b4 0.16-dev-16047","Received-SPF":"pass client-ip=49.212.243.89;\n envelope-from=odaki@rsg.ci.i.u-tokyo.ac.jp; helo=www3579.sakura.ne.jp","X-Spam_score_int":"-16","X-Spam_score":"-1.7","X-Spam_bar":"-","X-Spam_report":"(-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,\n DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"kvm_arm_set_cpu_features_from_host() treats dtb_compatible as the host\nfeature cache valid bit, but kvm_arm_get_host_cpu_features() set it\nbefore later register reads could fail.\n\nSet target and dtb_compatible only after the feature data is complete.\n\nSigned-off-by: Akihiko Odaki \n---\nThis fixes a semantic issue I found while writing the next version of [1].\nI am not aware of any case where it manifests as a real bug.\n\n[1] http://lore.kernel.org/qemu-devel/20260225-kvm-v2-1-b8d743db0f73@rsg.ci.i.u-tokyo.ac.jp/\n(\"[PATCH RFC v2] target/arm/kvm: Choose PMU backend\")\n---\n target/arm/kvm.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\n---\nbase-commit: 98b060da3a4f92b2a994ead5b16a87e783baf77c\nchange-id: 20260422-arm-84b23dad0561\n\nBest regards,\n-- \nAkihiko Odaki ","diff":"diff --git a/target/arm/kvm.c b/target/arm/kvm.c\nindex d4a68874b880..03c3346d50ed 100644\n--- a/target/arm/kvm.c\n+++ b/target/arm/kvm.c\n@@ -329,8 +329,6 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)\n return false;\n }\n \n- ahcf->target = init.target;\n- ahcf->dtb_compatible = \"arm,armv8\";\n int fd = fdarray[2];\n \n err = get_host_cpu_reg(fd, ahcf, ID_AA64PFR0_EL1_IDX);\n@@ -472,6 +470,8 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)\n }\n \n ahcf->features = features;\n+ ahcf->target = init.target;\n+ ahcf->dtb_compatible = \"arm,armv8\";\n \n return true;\n }\n","prefixes":[]}