{"id":2226277,"url":"http://patchwork.ozlabs.org/api/patches/2226277/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhubjjpeho.gcc.gcc-TEST.redi.25.1.2@forge-stage.sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-22T10:36:19","name":"[v1,2/4] libstdc++: Stop using _Self typedefs in std::list iterators","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6f51ae91c7cbc51961afddd57455267d9058d678","submitter":{"id":93210,"url":"http://patchwork.ozlabs.org/api/people/93210/?format=json","name":"Jonathan Wakely via Sourceware Forge","email":"forge-bot+redi@forge-stage.sourceware.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhubjjpeho.gcc.gcc-TEST.redi.25.1.2@forge-stage.sourceware.org/mbox/","series":[{"id":500985,"url":"http://patchwork.ozlabs.org/api/series/500985/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=500985","date":"2026-04-22T10:36:19","name":"libstdc++: Add fancy pointer support to std::list and std::forward_list [PR57272]","version":1,"mbox":"http://patchwork.ozlabs.org/series/500985/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226277/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226277/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0xCr2wbjz1y2d\n\tfor ; Wed, 22 Apr 2026 21:03:20 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 6372F429EA75\n\tfor ; Wed, 22 Apr 2026 11:03:18 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 1F0D142FA79B\n for ; Wed, 22 Apr 2026 10:37:13 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id EE60842B57\n for ; Wed, 22 Apr 2026 10:37:12 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 6372F429EA75","OpenDKIM Filter v2.11.0 sourceware.org 1F0D142FA79B"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 1F0D142FA79B","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 1F0D142FA79B","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776854233; cv=none;\n b=ZtY8HYgbZMrKWEUlLz30/tRZZzEmHq5j+WCKsv7BRJfJk5ljLaCXOvDWd3d/SQWOzlg4PmPj4KROJZ7uMo8dNDkPoiC3doUjPKh22N8WCF1ZQngNsA1lZctDoe+hPPQq2WIAdrwzwv7F+TClRQo8P7elHRQbaDbS2I6vbUwn51E=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776854233; c=relaxed/simple;\n bh=dVsmqoHlcIFLByrtBHtKRKUQdcGLTW4jUe6VARpm8lQ=;\n h=From:Date:Subject:To:Message-ID;\n b=Rmf0LtWjhoLB5eYTlpnFcbIUbs2FEogeUAutkkLCi14a8p9ZQZWUoaePVq8VRa4QkCDuVDBVuKVPRrvNYuTK8MVEkiKxSgaULvJWR03DGxSc+Md+N1XJRi+ZLlB2uQ2tVQT5zvOLomi/LpWZ953/KhgQ3GiUpeXT42oD0oFJvx0=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"Jonathan Wakely via Sourceware Forge\n ","Date":"Wed, 22 Apr 2026 10:36:19 +0000","Subject":"[PATCH v1 2/4] libstdc++: Stop using _Self typedefs in std::list\n iterators","To":"gcc-patches mailing list ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/25","References":"\n ","In-Reply-To":"\n ","X-Patch-URL":"\n https://forge.sourceware.org/redi/gcc/commit/184e42ec7a19b918ec239777d564f7c0203a523b","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"gcc-patches mailing list , redi@gcc.gnu.org","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Jonathan Wakely \n\nWe can just use the injected-class-name instead of defining a new name.\nThat seems simpler.\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/bits/stl_list.h (_List_iterator): Remove _Self typedef\n\tand just use injected-class-name instead.\n\t(_List_const_iterator): Likewise.\n---\n libstdc++-v3/include/bits/stl_list.h | 40 +++++++++++++++-------------\n 1 file changed, 21 insertions(+), 19 deletions(-)","diff":"diff --git a/libstdc++-v3/include/bits/stl_list.h b/libstdc++-v3/include/bits/stl_list.h\nindex d51fde90e2b8..b1ab335ba4c9 100644\n--- a/libstdc++-v3/include/bits/stl_list.h\n+++ b/libstdc++-v3/include/bits/stl_list.h\n@@ -254,7 +254,6 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER\n template\n struct _List_iterator\n {\n- typedef _List_iterator<_Tp>\t\t_Self;\n typedef _List_node<_Tp>\t\t\t_Node;\n \n typedef ptrdiff_t\t\t\t\tdifference_type;\n@@ -270,7 +269,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER\n _List_iterator(__detail::_List_node_base* __x) _GLIBCXX_NOEXCEPT\n : _M_node(__x) { }\n \n- _Self\n+ _List_iterator\n _M_const_cast() const _GLIBCXX_NOEXCEPT\n { return *this; }\n \n@@ -285,45 +284,47 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER\n operator->() const _GLIBCXX_NOEXCEPT\n { return static_cast<_Node*>(_M_node)->_M_valptr(); }\n \n- _Self&\n+ _List_iterator&\n operator++() _GLIBCXX_NOEXCEPT\n {\n \t_M_node = _M_node->_M_next;\n \treturn *this;\n }\n \n- _Self\n+ _List_iterator\n operator++(int) _GLIBCXX_NOEXCEPT\n {\n-\t_Self __tmp = *this;\n+\t_List_iterator __tmp = *this;\n \t_M_node = _M_node->_M_next;\n \treturn __tmp;\n }\n \n- _Self&\n+ _List_iterator&\n operator--() _GLIBCXX_NOEXCEPT\n {\n \t_M_node = _M_node->_M_prev;\n \treturn *this;\n }\n \n- _Self\n+ _List_iterator\n operator--(int) _GLIBCXX_NOEXCEPT\n {\n-\t_Self __tmp = *this;\n+\t_List_iterator __tmp = *this;\n \t_M_node = _M_node->_M_prev;\n \treturn __tmp;\n }\n \n _GLIBCXX_NODISCARD\n friend bool\n- operator==(const _Self& __x, const _Self& __y) _GLIBCXX_NOEXCEPT\n+ operator==(const _List_iterator& __x,\n+\t\t const _List_iterator& __y) _GLIBCXX_NOEXCEPT\n { return __x._M_node == __y._M_node; }\n \n #if __cpp_impl_three_way_comparison < 201907L\n _GLIBCXX_NODISCARD\n friend bool\n- operator!=(const _Self& __x, const _Self& __y) _GLIBCXX_NOEXCEPT\n+ operator!=(const _List_iterator& __x,\n+\t\t const _List_iterator& __y) _GLIBCXX_NOEXCEPT\n { return __x._M_node != __y._M_node; }\n #endif\n \n@@ -339,7 +340,6 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER\n template\n struct _List_const_iterator\n {\n- typedef _List_const_iterator<_Tp>\t\t_Self;\n typedef const _List_node<_Tp>\t\t_Node;\n typedef _List_iterator<_Tp>\t\titerator;\n \n@@ -375,45 +375,47 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER\n operator->() const _GLIBCXX_NOEXCEPT\n { return static_cast<_Node*>(_M_node)->_M_valptr(); }\n \n- _Self&\n+ _List_const_iterator&\n operator++() _GLIBCXX_NOEXCEPT\n {\n \t_M_node = _M_node->_M_next;\n \treturn *this;\n }\n \n- _Self\n+ _List_const_iterator\n operator++(int) _GLIBCXX_NOEXCEPT\n {\n-\t_Self __tmp = *this;\n+\t_List_const_iterator __tmp = *this;\n \t_M_node = _M_node->_M_next;\n \treturn __tmp;\n }\n \n- _Self&\n+ _List_const_iterator&\n operator--() _GLIBCXX_NOEXCEPT\n {\n \t_M_node = _M_node->_M_prev;\n \treturn *this;\n }\n \n- _Self\n+ _List_const_iterator\n operator--(int) _GLIBCXX_NOEXCEPT\n {\n-\t_Self __tmp = *this;\n+\t_List_const_iterator __tmp = *this;\n \t_M_node = _M_node->_M_prev;\n \treturn __tmp;\n }\n \n _GLIBCXX_NODISCARD\n friend bool\n- operator==(const _Self& __x, const _Self& __y) _GLIBCXX_NOEXCEPT\n+ operator==(const _List_const_iterator& __x,\n+\t\t const _List_const_iterator& __y) _GLIBCXX_NOEXCEPT\n { return __x._M_node == __y._M_node; }\n \n #if __cpp_impl_three_way_comparison < 201907L\n _GLIBCXX_NODISCARD\n friend bool\n- operator!=(const _Self& __x, const _Self& __y) _GLIBCXX_NOEXCEPT\n+ operator!=(const _List_const_iterator& __x,\n+\t\t const _List_const_iterator& __y) _GLIBCXX_NOEXCEPT\n { return __x._M_node != __y._M_node; }\n #endif\n \n","prefixes":["v1","2/4"]}