{"id":2226230,"url":"http://patchwork.ozlabs.org/api/patches/2226230/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-28-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422104042.3936506-28-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2026-04-22T10:40:28","name":"[PULL,27/40] ui/console-vc: unify the write path","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9c31e3f9961940f002a111aa6cd3313bf9b0d716","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-28-marcandre.lureau@redhat.com/mbox/","series":[{"id":500973,"url":"http://patchwork.ozlabs.org/api/series/500973/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973","date":"2026-04-22T10:40:02","name":"[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails","version":1,"mbox":"http://patchwork.ozlabs.org/series/500973/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226230/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226230/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=U930BS9i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wpL5TlRz1yCv\n\tfor ; Wed, 22 Apr 2026 20:44:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFV4L-00011L-0w; Wed, 22 Apr 2026 06:44:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFV3c-00006a-Q3\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:43:50 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFV3Y-00039D-3K\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:43:47 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-fhJ6Q04RNzuYM4K6jqWbeQ-1; Wed,\n 22 Apr 2026 06:43:35 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 70FA51956094; Wed, 22 Apr 2026 10:43:34 +0000 (UTC)","from localhost (unknown [10.44.22.21])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 40F373000C15; Wed, 22 Apr 2026 10:43:32 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854618;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=g0ttloNrFuyp/cULqVKONcBIJ9DfL2A0Mmull0Um73U=;\n b=U930BS9ixoaU6vidXOQNNkV6u5vrlOSrGJOuQfDbMIJDZhvhQuyKQljN1aNocQUIVjhHO3\n 1X4VOMTwYlL4eW7SfqLp1bWLcv+kufTBQ+Ib0XaKcL/edFuS66lKLCP4DzsefmK3L3k4l+\n 7n2T2ZLC2oEn6YGLvsjyKD/OJAd+EEU=","X-MC-Unique":"fhJ6Q04RNzuYM4K6jqWbeQ-1","X-Mimecast-MFC-AGG-ID":"fhJ6Q04RNzuYM4K6jqWbeQ_1776854614","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PULL 27/40] ui/console-vc: unify the write path","Date":"Wed, 22 Apr 2026 14:40:28 +0400","Message-ID":"<20260422104042.3936506-28-marcandre.lureau@redhat.com>","In-Reply-To":"<20260422104042.3936506-1-marcandre.lureau@redhat.com>","References":"<20260422104042.3936506-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Marc-André Lureau \n\nVT100 escape responses (DSR) used qemu_chr_be_write() to write directly\nto the chardev backend, bypassing the output FIFO, while keyboard input\nwent through the FIFO and flush path. This inconsistency could lead to\nout-of-order delivery when both paths are active.\n\nIntroduce qemu_text_console_write() that pushes data into the output\nFIFO and flushes it, and use it for both keyboard input and VT100\nresponses. Remove the now-unnecessary vc_respond_str() helper. Rename\nkbd_send_chars() to qemu_text_console_flush() to better reflect its\npurpose.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 29 ++++++++++++++---------------\n 1 file changed, 14 insertions(+), 15 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 2de096db3ac..107294af1cc 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -296,7 +296,7 @@ static void vt100_scroll(QemuVT100 *vt, int ydelta)\n vt100_refresh(vt);\n }\n \n-static void kbd_send_chars(QemuTextConsole *s)\n+static void qemu_text_console_flush(QemuTextConsole *s)\n {\n uint32_t len, avail;\n \n@@ -313,13 +313,21 @@ static void kbd_send_chars(QemuTextConsole *s)\n }\n }\n \n+static void qemu_text_console_write(QemuTextConsole *s, const void *buf, size_t len)\n+{\n+ uint32_t num_free;\n+\n+ num_free = fifo8_num_free(&s->out_fifo);\n+ fifo8_push_all(&s->out_fifo, buf, MIN(num_free, len));\n+ qemu_text_console_flush(s);\n+}\n+\n /* called when an ascii key is pressed */\n void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n {\n QemuVT100 *vt = &s->vt;\n uint8_t buf[16], *q;\n int c;\n- uint32_t num_free;\n \n switch(keysym) {\n case QEMU_KEY_CTRL_UP:\n@@ -358,9 +366,7 @@ void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n if (vt->echo) {\n qemu_chr_write(s->chr, buf, q - buf, true);\n }\n- num_free = fifo8_num_free(&s->out_fifo);\n- fifo8_push_all(&s->out_fifo, buf, MIN(num_free, q - buf));\n- kbd_send_chars(s);\n+ qemu_text_console_write(s, buf, q - buf);\n break;\n }\n }\n@@ -634,13 +640,6 @@ static void vc_put_one(VCChardev *vc, int ch)\n vt->x++;\n }\n \n-static void vc_respond_str(VCChardev *vc, const char *buf)\n-{\n- QemuTextConsole *s = vc->console;\n-\n- qemu_chr_be_write(s->chr, (const uint8_t *)buf, strlen(buf));\n-}\n-\n /* set cursor, checking bounds */\n static void vc_set_cursor(VCChardev *vc, int x, int y)\n {\n@@ -967,13 +966,13 @@ static void vc_putchar(VCChardev *vc, int ch)\n switch (vc->esc_params[0]) {\n case 5:\n /* report console status (always succeed)*/\n- vc_respond_str(vc, \"\\033[0n\");\n+ qemu_text_console_write(s, \"\\033[0n\", 4);\n break;\n case 6:\n /* report cursor position */\n response = g_strdup_printf(\"\\033[%d;%dR\",\n vt->y + 1, vt->x + 1);\n- vc_respond_str(vc, response);\n+ qemu_text_console_write(s, response, strlen(response));\n break;\n }\n break;\n@@ -1133,7 +1132,7 @@ static void vc_chr_accept_input(Chardev *chr)\n {\n VCChardev *drv = VC_CHARDEV(chr);\n \n- kbd_send_chars(drv->console);\n+ qemu_text_console_flush(drv->console);\n }\n \n static void vc_chr_set_echo(Chardev *chr, bool echo)\n","prefixes":["PULL","27/40"]}