{"id":2226222,"url":"http://patchwork.ozlabs.org/api/patches/2226222/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-20-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422104042.3936506-20-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2026-04-22T10:40:20","name":"[PULL,19/40] ui/console-vc: make invalidate_xy() take vt100","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eb1b05eae572b38c61bcfd10e603822a7c499019","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-20-marcandre.lureau@redhat.com/mbox/","series":[{"id":500973,"url":"http://patchwork.ozlabs.org/api/series/500973/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973","date":"2026-04-22T10:40:02","name":"[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails","version":1,"mbox":"http://patchwork.ozlabs.org/series/500973/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226222/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226222/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ToZet2N2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wnW4qtHz1yCv\n\tfor ; Wed, 22 Apr 2026 20:43:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFV3H-0008A6-41; Wed, 22 Apr 2026 06:43:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFV2i-0007hO-SA\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:42:57 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFV2g-0002pK-Pi\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:42:52 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-2w8yhG7fPN6N3XJAHyAqNA-1; Wed,\n 22 Apr 2026 06:42:46 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E5FC31956054; Wed, 22 Apr 2026 10:42:45 +0000 (UTC)","from localhost (unknown [10.44.22.21])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 2A1443000C15; Wed, 22 Apr 2026 10:42:43 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854570;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=C8c5Lj/GZu5gO8bWLEIHb18NdCCWVUVhn6fkUu0qHuE=;\n b=ToZet2N2yqFZlEXM4fohIosQ4KXMM2G0H3FUJIBXMvoieEBE266J78b5DDUQq3qBOH9A0H\n N1uSQ80/QZRPh60N0RqMmJs2jkIz5+uR8qpJoqVf4A6bQNVHYcN3T61ltah3p7cH5ef+zb\n r9eqV/Les0ZttBSHF0Lka1ztOex3sKA=","X-MC-Unique":"2w8yhG7fPN6N3XJAHyAqNA-1","X-Mimecast-MFC-AGG-ID":"2w8yhG7fPN6N3XJAHyAqNA_1776854566","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PULL 19/40] ui/console-vc: make invalidate_xy() take vt100","Date":"Wed, 22 Apr 2026 14:40:20 +0400","Message-ID":"<20260422104042.3936506-20-marcandre.lureau@redhat.com>","In-Reply-To":"<20260422104042.3936506-1-marcandre.lureau@redhat.com>","References":"<20260422104042.3936506-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Marc-André Lureau \n\nThis decouples glyph rendering from the console object, continuing the\nQemuVT100 abstraction introduced in the previous commits.\n\nStyle fixes.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 23 +++++++++++------------\n 1 file changed, 11 insertions(+), 12 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 3d73bdf2982..34d9101679a 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -176,21 +176,20 @@ static void vt100_putcharxy(QemuVT100 *vt, int x, int y, int ch,\n &fgcol, &bgcol, x, y, FONT_WIDTH, FONT_HEIGHT);\n }\n \n-static void invalidate_xy(QemuTextConsole *s, int x, int y)\n+static void vt100_invalidate_xy(QemuVT100 *vt, int x, int y)\n {\n- QemuVT100 *vt = &s->vt;\n-\n- if (!qemu_console_is_visible(QEMU_CONSOLE(s))) {\n- return;\n- }\n- if (vt->update_x0 > x * FONT_WIDTH)\n+ if (vt->update_x0 > x * FONT_WIDTH) {\n vt->update_x0 = x * FONT_WIDTH;\n- if (vt->update_y0 > y * FONT_HEIGHT)\n+ }\n+ if (vt->update_y0 > y * FONT_HEIGHT) {\n vt->update_y0 = y * FONT_HEIGHT;\n- if (vt->update_x1 < (x + 1) * FONT_WIDTH)\n+ }\n+ if (vt->update_x1 < (x + 1) * FONT_WIDTH) {\n vt->update_x1 = (x + 1) * FONT_WIDTH;\n- if (vt->update_y1 < (y + 1) * FONT_HEIGHT)\n+ }\n+ if (vt->update_y1 < (y + 1) * FONT_HEIGHT) {\n vt->update_y1 = (y + 1) * FONT_HEIGHT;\n+ }\n }\n \n static void console_show_cursor(QemuTextConsole *s, int show)\n@@ -219,7 +218,7 @@ static void console_show_cursor(QemuTextConsole *s, int show)\n } else {\n vt100_putcharxy(&s->vt, x, y, c->ch, &(c->t_attrib));\n }\n- invalidate_xy(s, x, y);\n+ vt100_invalidate_xy(&s->vt, x, y);\n }\n }\n \n@@ -591,7 +590,7 @@ static void vc_update_xy(VCChardev *vc, int x, int y)\n c = &vt->cells[y1 * vt->width + x];\n vt100_putcharxy(vt, x, y2, c->ch,\n &(c->t_attrib));\n- invalidate_xy(s, x, y2);\n+ vt100_invalidate_xy(&s->vt, x, y2);\n }\n }\n \n","prefixes":["PULL","19/40"]}