{"id":2226216,"url":"http://patchwork.ozlabs.org/api/patches/2226216/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-10-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422104042.3936506-10-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2026-04-22T10:40:10","name":"[PULL,09/40] ui/vnc-jobs: remove vnc_queue_clear()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"af005f1b8a771163eb320ab0dd34bcce2540bdd7","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-10-marcandre.lureau@redhat.com/mbox/","series":[{"id":500973,"url":"http://patchwork.ozlabs.org/api/series/500973/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973","date":"2026-04-22T10:40:02","name":"[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails","version":1,"mbox":"http://patchwork.ozlabs.org/series/500973/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226216/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226216/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=L9qFBH1t;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wmS0T1dz1yCv\n\tfor ; Wed, 22 Apr 2026 20:43:04 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFV1t-0004eU-Mc; Wed, 22 Apr 2026 06:42:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFV1h-0004Hz-Uf\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:41:51 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFV1f-0002Iu-O6\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:41:49 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-U_lnOwdaO1aLdr7yShSQ6w-1; Wed,\n 22 Apr 2026 06:41:45 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2E6CD1800352; Wed, 22 Apr 2026 10:41:44 +0000 (UTC)","from localhost (unknown [10.44.22.21])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B2B6119560AB; Wed, 22 Apr 2026 10:41:42 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854506;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=inYdvGCpIYu2N7toYOzj1Y5BVp2cO4Atp8Li2P8yAVQ=;\n b=L9qFBH1tDPI112l5N3zZgAmVxjD6T0fNVSut2gvdnvVkZpYHJ7baqwuWtItF9qCgR89Q66\n KgS8UvgFfgaqFTAc5b1eP08YVdkKAapXI9mgo2Qb4Ec6h9T/FkZK+wgFD5WSVKugkPNYWO\n sms9G7lBTHABRs1ix299bpXGbsCKUOA=","X-MC-Unique":"U_lnOwdaO1aLdr7yShSQ6w-1","X-Mimecast-MFC-AGG-ID":"U_lnOwdaO1aLdr7yShSQ6w_1776854504","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PULL 09/40] ui/vnc-jobs: remove vnc_queue_clear()","Date":"Wed, 22 Apr 2026 14:40:10 +0400","Message-ID":"<20260422104042.3936506-10-marcandre.lureau@redhat.com>","In-Reply-To":"<20260422104042.3936506-1-marcandre.lureau@redhat.com>","References":"<20260422104042.3936506-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Marc-André Lureau \n\nThe function was never called, since the worker thread was never\nexiting. Also it was incomplete (not clearing pending job list) and\nmixing global queue and argument. Let's remove it.\n\nNote: maybe the worker thread could be torn down when vnc_jobs_join()\nrealizes there is no job left.\n\nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n ui/vnc-jobs.c | 10 +---------\n 1 file changed, 1 insertion(+), 9 deletions(-)","diff":"diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex 9e536b07b90..28a4738f1ec 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -345,14 +345,6 @@ static VncJobQueue *vnc_queue_init(void)\n return queue;\n }\n \n-static void vnc_queue_clear(VncJobQueue *q)\n-{\n- qemu_cond_destroy(&queue->cond);\n- qemu_mutex_destroy(&queue->mutex);\n- g_free(q);\n- queue = NULL; /* Unset global queue */\n-}\n-\n static void *vnc_worker_thread(void *arg)\n {\n VncJobQueue *queue = arg;\n@@ -360,7 +352,7 @@ static void *vnc_worker_thread(void *arg)\n qemu_thread_get_self(&queue->thread);\n \n while (!vnc_worker_thread_loop(queue)) ;\n- vnc_queue_clear(queue);\n+ g_assert_not_reached();\n return NULL;\n }\n \n","prefixes":["PULL","09/40"]}