{"id":2226213,"url":"http://patchwork.ozlabs.org/api/patches/2226213/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-14-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422104042.3936506-14-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2026-04-22T10:40:14","name":"[PULL,13/40] ui/console-vc: ignore string-type escape sequences","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c4804fbc4c77ad32e40729e3ff09e08974bd4fc4","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-14-marcandre.lureau@redhat.com/mbox/","series":[{"id":500973,"url":"http://patchwork.ozlabs.org/api/series/500973/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973","date":"2026-04-22T10:40:02","name":"[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails","version":1,"mbox":"http://patchwork.ozlabs.org/series/500973/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226213/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226213/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=S7Gygel2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wm66QfXz1yHB\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:42:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFV2Q-0006H0-Nr; Wed, 22 Apr 2026 06:42:34 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV25-0005j4-Sj\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:42:17 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV24-0002Ut-9r\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:42:13 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-b6YB3bYhNHWHIEd2YJwDhA-1; Wed,\n 22 Apr 2026 06:42:10 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4402518001FB; Wed, 22 Apr 2026 10:42:09 +0000 (UTC)","from localhost (unknown [10.44.22.21])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A5B983000C15; Wed, 22 Apr 2026 10:42:07 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854531;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=twgYeKSfk/9iFKYxAn07J2tfYB24YSO2tHaeQMNeFm8=;\n b=S7Gygel2nRYJQB7/qgh/Y7jwPm+/V9IXk8UBVz7rWdfMiEMlrTz542T2LfEOXIFRElE8ov\n kVGZ0XXWXTPsSUoR+pAqb/DKmSgYM3VD8y22/bP4DW3TqrXzXBSuD+QycGYrLvzqhq0+XM\n IjTQ+1WqGJbwgUcOMEFJRjkHa1H5eM8=","X-MC-Unique":"b6YB3bYhNHWHIEd2YJwDhA-1","X-Mimecast-MFC-AGG-ID":"b6YB3bYhNHWHIEd2YJwDhA_1776854529","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>","Subject":"[PULL 13/40] ui/console-vc: ignore string-type escape sequences","Date":"Wed, 22 Apr 2026 14:40:14 +0400","Message-ID":"<20260422104042.3936506-14-marcandre.lureau@redhat.com>","In-Reply-To":"<20260422104042.3936506-1-marcandre.lureau@redhat.com>","References":"<20260422104042.3936506-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nModern terminals and applications emit OSC (Operating System Command),\nDCS, SOS, PM, and APC escape sequences (e.g. for setting window\ntitles).  The text console currently does not recognise these\nstring-type introducers, so each byte of the payload is interpreted as\na normal character or a new escape, producing garbage on screen.\n\nAdd a TTY_STATE_OSC state that silently consumes all bytes until the\nsequence is terminated by BEL or ST (ESC \\).\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/console-vc.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 8dee1f9bd01..62114d89ddd 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -44,6 +44,7 @@ enum TTYState {\n     TTY_STATE_CSI,\n     TTY_STATE_G0,\n     TTY_STATE_G1,\n+    TTY_STATE_OSC,\n };\n \n typedef struct QemuTextConsole {\n@@ -807,6 +808,10 @@ static void vc_putchar(VCChardev *vc, int ch)\n             vc->state = TTY_STATE_G0;\n         } else if (ch == ')') {\n             vc->state = TTY_STATE_G1;\n+        } else if (ch == ']' || ch == 'P' || ch == 'X'\n+                   || ch == '^' || ch == '_') {\n+            /* String sequences: OSC, DCS, SOS, PM, APC */\n+            vc->state = TTY_STATE_OSC;\n         } else if (ch == '7') {\n             vc_save_cursor(vc);\n             vc->state = TTY_STATE_NORM;\n@@ -965,6 +970,16 @@ static void vc_putchar(VCChardev *vc, int ch)\n             break;\n         }\n         break;\n+    case TTY_STATE_OSC: /* Operating System Command: ESC ] ... BEL/ST */\n+        if (ch == '\\a') {\n+            /* BEL terminates OSC */\n+            vc->state = TTY_STATE_NORM;\n+        } else if (ch == 27) {\n+            /* ESC might start ST (ESC \\) */\n+            vc->state = TTY_STATE_ESC;\n+        }\n+        /* All other bytes are silently consumed */\n+        break;\n     case TTY_STATE_G0: /* set character sets */\n     case TTY_STATE_G1: /* set character sets */\n         switch (ch) {\n","prefixes":["PULL","13/40"]}