{"id":2226159,"url":"http://patchwork.ozlabs.org/api/patches/2226159/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422101043.1234229-19-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422101043.1234229-19-alex.bennee@linaro.org>","list_archive_url":null,"date":"2026-04-22T10:10:29","name":"[v2,18/31] target/arm: make whpx use syndrome helpers for decode","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e732c0ac43d899c52ebb375ef7859a3b658173ca","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422101043.1234229-19-alex.bennee@linaro.org/mbox/","series":[{"id":500957,"url":"http://patchwork.ozlabs.org/api/series/500957/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500957","date":"2026-04-22T10:10:11","name":"target/arm: fully model WFxT instructions for A-profile","version":2,"mbox":"http://patchwork.ozlabs.org/series/500957/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226159/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226159/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=qxV6nDO/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wDK2WYQz1y2d\n\tfor ; Wed, 22 Apr 2026 20:18:41 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFUey-0007Vd-Ke; Wed, 22 Apr 2026 06:18:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFUeN-0006z3-SA\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:17:45 -0400","from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFUeL-0002Op-GF\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:17:43 -0400","by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-43eada6d900so5191194f8f.0\n for ; Wed, 22 Apr 2026 03:17:34 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4d5b1sm48556243f8f.30.2026.04.22.03.17.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 03:17:28 -0700 (PDT)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id D6D1F611AD;\n Wed, 22 Apr 2026 11:10:44 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776853053; x=1777457853; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1esNeOF5ufpO0cAxHdsE5rjzSjC5Q+4Ajm02teJ1954=;\n b=qxV6nDO/0F+3rFI7BAQwKgiX8CLJJMKNhXEmm2x6nHXLLYVsmWlqZaHWyvBh+z5E6o\n tApwgXOsBQbXIClOnHFXmMVTSboyFBo1EHOOdFcD7ZUVSWZNPKEHRt1InpZ8QW7G3569\n WRfu7ocCY3Vo3zYPx0bpXZma6rFFNDCHQZVK7AuEiLpVVYSdxjgNdjrt0hJRbo9VItFC\n DAnzSkISW/KIKlx4Fv2s2MTkMgWtIsDr3lXeyeYIUU1LstgMYvsTDfjelcSOvv+FTIG3\n tp2k/54D/MZYw2/41ZkTbdHu2VT1ZMJkbcXt5oPshmlbHr7u/s/8/A6bt37tIB1rmrTO\n Fihw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776853053; x=1777457853;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1esNeOF5ufpO0cAxHdsE5rjzSjC5Q+4Ajm02teJ1954=;\n b=dy0XbrqkzXwfWMFOYB4Jg19rirQ5hUz7+0F4chtAHyhBe7v3cGMZkZfEs7yJA/ZHPP\n 6b1+2KLOqL1eDLuBslFxugg3Jt15quNr6kBNavx0//pI+EgyvbNEL/0I4qK/65IFXw8O\n gV3r64Y1pdf/7jZcMtgbnEnNy3co8Mh3iJunJweQgkEsWUuzcOGAG132o/zfjOz3xZFi\n W/rN3j4Ovic0t70KscyhH4r1lxDvk//IoiaFAG7SHt2IEUTMtbW0Gj3XY+8UHifq2DKb\n bX8Z/36IK4cxDyNOduG8Qw8M7F2KHV0bGujrtoYb4amC552+LKRmdjavb3Esrc0WZ68G\n AlKg==","X-Gm-Message-State":"AOJu0YwUAsGdVS1rD5A1InCgTey1PLyn0LAPbUQo7u9VYTKynD0v3Eqb\n BqooaKCcjsmpX78GylkvXuPk6LUHHyc3DD82KwIOBI+2t+gFXLojo4mSEV66J9DGgY4=","X-Gm-Gg":"AeBDieu9gUK0Nv65nfhPf3Aoo59zF402lDPX8B0Zh3b2iU7Lp7P7OF1LMmV0L6p3io5\n RpnOU2OsgHk7rnOMww5KcVx4KOPbJS8BU811TSMO1+x6Tpou3IA+HS5N2+5Q7TXeJdN7Z48K2uf\n 40ujvmDmGLnD/JWlqoNmZ6/EsKIglTXf6BBsq/S25RImhx9M0bw5kIauGxn1B/reRafxGVNoWaz\n 7/07OrR/XJse69tYIshc32oebGNzOv/1fr7NKfXSQDgu6WDtCbZgcGoywWx1Zv+cdziOue+jpCF\n HqEvGtXDTvYOOqTUQvjADyeDvvMLHFHZHCPGCQIUePABgeGblM61ihRfpqCTzaIAajh1omXZGU1\n SKtVukNc8fAn9GlqljC+vzr9fuQBBCd7uyHQIHa8e8QuMZCRghPdextKMDD3d/EeFsaxKj7Wz1X\n 9JE4SAMUcDV7LbasNtuAlTsjJei3jvMR9wOA==","X-Received":"by 2002:a5d:5f43:0:b0:43c:fde6:212d with SMTP id\n ffacd0b85a97d-43fe3e13d46mr34364660f8f.33.1776853053246;\n Wed, 22 Apr 2026 03:17:33 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Alexander Graf , qemu-arm@nongnu.org,\n Peter Maydell ,\n Paolo Bonzini ,\n Mohamed Mediouni , kvm@vger.kernel.org,\n Pedro Barbuda ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Richard Henderson ","Subject":"[PATCH v2 18/31] target/arm: make whpx use syndrome helpers for\n decode","Date":"Wed, 22 Apr 2026 11:10:29 +0100","Message-ID":"<20260422101043.1234229-19-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260422101043.1234229-1-alex.bennee@linaro.org>","References":"<20260422101043.1234229-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42c;\n envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Rather than open coding a bunch of shifts and masks we can use the\nsyndrome definitions. While we are at it assert it really is a\nEC_DATAABORT.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Alex Bennée \n---\n target/arm/whpx/whpx-all.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c\nindex bbf0f6be961..4cfc7f99698 100644\n--- a/target/arm/whpx/whpx-all.c\n+++ b/target/arm/whpx/whpx-all.c\n@@ -356,15 +356,16 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_ACCESS_CONTEXT *ctx)\n {\n uint64_t syndrome = ctx->Syndrome;\n \n- bool isv = syndrome & ARM_EL_ISV;\n- bool iswrite = (syndrome >> 6) & 1;\n- bool sse = (syndrome >> 21) & 1;\n- uint32_t sas = (syndrome >> 22) & 3;\n+ bool isv = FIELD_EX32(syndrome, DABORT_ISS, ISV);\n+ bool iswrite = FIELD_EX32(syndrome, DABORT_ISS, WNR);\n+ bool sse = FIELD_EX32(syndrome, DABORT_ISS, SSE);\n+ uint32_t sas = FIELD_EX32(syndrome, DABORT_ISS, SAS);\n uint32_t len = 1 << sas;\n- uint32_t srt = (syndrome >> 16) & 0x1f;\n- uint32_t cm = (syndrome >> 8) & 0x1;\n+ uint32_t srt = FIELD_EX32(syndrome, DABORT_ISS, SRT);\n+ uint32_t cm = FIELD_EX32(syndrome, DABORT_ISS, CM);\n uint64_t val = 0;\n \n+ assert(syn_get_ec(syndrome) == EC_DATAABORT);\n assert(!cm);\n assert(isv);\n \n","prefixes":["v2","18/31"]}