{"id":2226158,"url":"http://patchwork.ozlabs.org/api/patches/2226158/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422101043.1234229-20-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422101043.1234229-20-alex.bennee@linaro.org>","list_archive_url":null,"date":"2026-04-22T10:10:30","name":"[v2,19/31] target/arm: make hvf use syndrome helpers for decode","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6627f3a40497ac5f2f90cdc02508ce7005b89222","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422101043.1234229-20-alex.bennee@linaro.org/mbox/","series":[{"id":500957,"url":"http://patchwork.ozlabs.org/api/series/500957/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500957","date":"2026-04-22T10:10:11","name":"target/arm: fully model WFxT instructions for A-profile","version":2,"mbox":"http://patchwork.ozlabs.org/series/500957/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226158/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226158/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=R/Hnzk4L;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wDG6xqkz1y2d\n\tfor ; Wed, 22 Apr 2026 20:18:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFUes-0007QQ-Ep; Wed, 22 Apr 2026 06:18:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFUeN-0006z0-RZ\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:17:45 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFUeJ-0002Pn-KP\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:17:42 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-4891cd41959so33540935e9.3\n for ; Wed, 22 Apr 2026 03:17:34 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a55dc9f58sm266237205e9.6.2026.04.22.03.17.28\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 03:17:33 -0700 (PDT)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id E967F611CD;\n Wed, 22 Apr 2026 11:10:44 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776853054; x=1777457854; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yq/bGIVh38nrtfwG2BReGAMOSU3dNrWCtccK7bpObt0=;\n b=R/Hnzk4LIMg5tAbF/6UzousfLH4uiWqR5BUnfAMyCjwhhdqiqSdIO/gpj8nnxuc7qx\n CrcmzgfswyC6nBNVWsGjpAnGNYcbgRkQBBAb8l527kmFK2M/NlLxq+8U7n0E7r22xXiC\n W7zUIGnkVOgMk2r7j4kHnqFH2cMlnKdnefDs0LYeh1uLdvKYK4DDVn6YG5pfB+VcczM7\n 84Aw8CKY4NQhujS7lHt1eb/wk+iyuftiQ4Diei19eRrjyFgEOZyFCRBQxMZqqfx7zZRQ\n to0EUAuim/apqZOWRd2qjiO5vShK03c10z8BnP1jNhjdH8ZJBn/7o+z032IDFwjW4b0o\n yqYQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776853054; x=1777457854;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yq/bGIVh38nrtfwG2BReGAMOSU3dNrWCtccK7bpObt0=;\n b=EUiSVslQlDNdhuLTRbf5WFurjETPwT/x+zStcCiysLDShRHJD7jqe9p4sjVoIC4Aqu\n DhKk26a5PkUL5UDB/Mkl5UBp6sZfEx9cCPk76Uo/psUpqLLLEYOSCyNITah7ySnSnOjB\n wcQ6ZOOD2hS8TfGUL9x2r8LGCS2ouN3SPYlTtFGJ9v7HwJLz9jZBWuI4r5TDf8V1Myn6\n yLZqQYv6zCRq1cxrE+EEdjc1QmlxKAotaiARkjxRgi3/lIvxpazZlcgSy3maKBL2hgKk\n W+13N8r9WeDkaS74saSSrBzl2y6WdIviDfO3sprsk1AEz2MwJubE+XIsBIw6JtDt8kEs\n XzGQ==","X-Gm-Message-State":"AOJu0YyJIjMbhhUGo2l3fvkJgzc42ZHBUVuchJXlUAipmnzD9w2LmGqf\n b8gDuukcTnaZ8qRNT7sRV6gSj0LmRbA+21wYA3U06xRTpLGhZB7nF28nSp/TUA8zMw8=","X-Gm-Gg":"AeBDietoW5DN4wA4WpJONu79fPruOOKSfjqp+Q9N15M2NUQfi2UlZj1lPT1/iHG/rWA\n niNgOYn1m6JSDvhXUPw25mXq4ezMe8oG7/4hMrtmTRESmfi2QSbsKkRDz+lxSugsJ9G3JZ3WM++\n WkzVte7CTHOrIWWl1EQXN5Oq5m/KGf/9mwBfUeNebHcVWB6zpjpRfWVrPKwlDkdRYXKNDdDUVAD\n OjppyUH8USpyTj3I2X4BuuUIHp8FqXk82pECC7XgjJsp6YLpt2FxkhouarYEx4qZO5/781ffrOT\n WkclQzf1ZZZYkUf7UR+nyhPDR22860GIAQ9opao2fQBL1eh7K3kX3bPp5RqFqOaXg+NYNh27zQM\n UsHFkm7sR55YCahFkOHvmw5V7ctO9YAfR8bOTlGK2VTHUyhnlKAqNe/nASt4MfSiYCvYLC9gosJ\n 9ueEc7IDXSBpGVnBVBMqzcpZ+WQdqK03RqXw==","X-Received":"by 2002:a05:600c:c0d5:b0:488:c683:be89 with SMTP id\n 5b1f17b1804b1-488fb74dffemr240575745e9.9.1776853053932;\n Wed, 22 Apr 2026 03:17:33 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Alexander Graf , qemu-arm@nongnu.org,\n Peter Maydell ,\n Paolo Bonzini ,\n Mohamed Mediouni , kvm@vger.kernel.org,\n Pedro Barbuda ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Richard Henderson ","Subject":"[PATCH v2 19/31] target/arm: make hvf use syndrome helpers for decode","Date":"Wed, 22 Apr 2026 11:10:30 +0100","Message-ID":"<20260422101043.1234229-20-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260422101043.1234229-1-alex.bennee@linaro.org>","References":"<20260422101043.1234229-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Rather than open coding a bunch of shifts and masks we can use the\nsyndrome definitions.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Alex Bennée \n---\n target/arm/hvf/hvf.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c\nindex 5fc8f6bbbd9..1c1c31f0b15 100644\n--- a/target/arm/hvf/hvf.c\n+++ b/target/arm/hvf/hvf.c\n@@ -2123,14 +2123,14 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp)\n break;\n }\n case EC_DATAABORT: {\n- bool isv = syndrome & ARM_EL_ISV;\n- bool iswrite = (syndrome >> 6) & 1;\n- bool s1ptw = (syndrome >> 7) & 1;\n- bool sse = (syndrome >> 21) & 1;\n- uint32_t sas = (syndrome >> 22) & 3;\n+ bool isv = FIELD_EX32(syndrome, DABORT_ISS, ISV);\n+ bool iswrite = FIELD_EX32(syndrome, DABORT_ISS, WNR);\n+ bool s1ptw = FIELD_EX32(syndrome, DABORT_ISS, S1PTW);\n+ bool sse = FIELD_EX32(syndrome, DABORT_ISS, SSE);\n+ uint32_t sas = FIELD_EX32(syndrome, DABORT_ISS, SAS);\n uint32_t len = 1 << sas;\n- uint32_t srt = (syndrome >> 16) & 0x1f;\n- uint32_t cm = (syndrome >> 8) & 0x1;\n+ uint32_t srt = FIELD_EX32(syndrome, DABORT_ISS, SRT);\n+ uint32_t cm = FIELD_EX32(syndrome, DABORT_ISS, CM);\n uint64_t val = 0;\n uint64_t ipa = excp->physical_address;\n AddressSpace *as = cpu_get_address_space(cpu, ARMASIdx_NS);\n","prefixes":["v2","19/31"]}