{"id":2226070,"url":"http://patchwork.ozlabs.org/api/patches/2226070/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422075429.341409-1-thuth@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422075429.341409-1-thuth@redhat.com>","list_archive_url":null,"date":"2026-04-22T07:54:29","name":"hw/sh4/sh7750: Remove forgotten abort() in the MM_ITLB_DATA handler","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"42fd28d034f20c30da77fe50df1b017c7a89075d","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422075429.341409-1-thuth@redhat.com/mbox/","series":[{"id":500936,"url":"http://patchwork.ozlabs.org/api/series/500936/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500936","date":"2026-04-22T07:54:29","name":"hw/sh4/sh7750: Remove forgotten abort() in the MM_ITLB_DATA handler","version":1,"mbox":"http://patchwork.ozlabs.org/series/500936/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226070/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226070/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RbSPCsmH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0s2S4xTXz1y2d\n\tfor ; Wed, 22 Apr 2026 17:54:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFSQ0-0003rX-7n; Wed, 22 Apr 2026 03:54:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFSPy-0003qO-1H\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 03:54:42 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFSPw-0006gl-Be\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 03:54:41 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-qG8JdtsqP1ylpwKsf6gZEw-1; Wed,\n 22 Apr 2026 03:54:35 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 3A9971800454; Wed, 22 Apr 2026 07:54:34 +0000 (UTC)","from thuth-p1g4.redhat.com (unknown [10.44.49.99])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7863F19560B7; Wed, 22 Apr 2026 07:54:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776844479;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=fQ/Gm5mXI5uP0dB7l1HO9HAOWfvVCU1YytbxxGf+WmM=;\n b=RbSPCsmHT+a2UOPolCMiwJaMEk9DMfkzPL3+wh4eKwKPso2d0+uykW8aVmBlfoJaMAvP/p\n wNaGh8bWNSbQd4AvJfqJDBbR+SJpbS9Bp1VPSs2jbPuPzWDk/rCUJVtDjymQ80/6OnGyT3\n a8tWFtKZupqibXQ2jy30/faIUBNRXAY=","X-MC-Unique":"qG8JdtsqP1ylpwKsf6gZEw-1","X-Mimecast-MFC-AGG-ID":"qG8JdtsqP1ylpwKsf6gZEw_1776844474","From":"Thomas Huth ","To":"qemu-devel@nongnu.org,\n\tYoshinori Sato ","Cc":"qemu-trivial@nongnu.org,\n\tAurelien Jarno ","Subject":"[PATCH] hw/sh4/sh7750: Remove forgotten abort() in the MM_ITLB_DATA\n handler","Date":"Wed, 22 Apr 2026 09:54:29 +0200","Message-ID":"<20260422075429.341409-1-thuth@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Thomas Huth \n\nQEMU currently aborts when the guest writes to the MM_ITLB_DATA register:\n\n echo \"writel 0xf3000000 0x11223344\" | \\\n ./qemu-system-sh4 -M r2d -display none -accel qtest -qtest stdio\n [I 0.000000] OPENED\n [R +0.004476] writel 0xf3000000 0x11223344\n Aborted (core dumped)\n\nLooking at the history of the code, the abort() here has likely just\nbeen forgotten when the register handler had been implemented (it used\nto be a reminder about unimplemented functionality initially):\n\n https://gitlab.com/qemu-project/qemu/-/commit/9f97309a70f12df5f9104f1f\n\nThus simply remove the abort() now to get rid of the problem.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3420\nSigned-off-by: Thomas Huth \n---\n hw/sh4/sh7750.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/hw/sh4/sh7750.c b/hw/sh4/sh7750.c\nindex 3ae71f99fe5..6aa7f637734 100644\n--- a/hw/sh4/sh7750.c\n+++ b/hw/sh4/sh7750.c\n@@ -687,7 +687,6 @@ static void sh7750_mmct_write(void *opaque, hwaddr addr,\n break;\n case MM_ITLB_DATA:\n cpu_sh4_write_mmaped_itlb_data(&s->cpu->env, addr, mem_value);\n- abort();\n break;\n case MM_OCACHE_ADDR:\n case MM_OCACHE_DATA:\n","prefixes":[]}