{"id":2226050,"url":"http://patchwork.ozlabs.org/api/patches/2226050/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260422050613.1136327-1-rajasimandalos@gmail.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422050613.1136327-1-rajasimandalos@gmail.com>","list_archive_url":null,"date":"2026-04-22T05:06:13","name":"[v2] smb: client: allow nolease option to be reconfigured on remount","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"de3bde5e7dacbaf24eb8232fc87c2dc336998e34","submitter":{"id":91740,"url":"http://patchwork.ozlabs.org/api/people/91740/?format=json","name":"RAJASI MANDAL","email":"rajasimandalos@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260422050613.1136327-1-rajasimandalos@gmail.com/mbox/","series":[{"id":500922,"url":"http://patchwork.ozlabs.org/api/series/500922/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500922","date":"2026-04-22T05:06:13","name":"[v2] smb: client: allow nolease option to be reconfigured on remount","version":2,"mbox":"http://patchwork.ozlabs.org/series/500922/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226050/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226050/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mBo6Q+nl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10999-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"mBo6Q+nl\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.180","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0nKr3bl2z1y2d\n\tfor ; Wed, 22 Apr 2026 15:08:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 987A2301F9B7\n\tfor ; Wed, 22 Apr 2026 05:06:34 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7640D2D238F;\n\tWed, 22 Apr 2026 05:06:34 +0000 (UTC)","from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 34DA62836BE\n\tfor ; Wed, 22 Apr 2026 05:06:33 +0000 (UTC)","by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-82f8892d4d6so2183802b3a.0\n for ;\n Tue, 21 Apr 2026 22:06:33 -0700 (PDT)","from dev-vm-rm.hzz4ddxqtfeetjrh00qlbgyytb.rx.internal.cloudapp.net\n ([20.197.52.255])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f8ec0307esm15854271b3a.53.2026.04.21.22.06.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 22:06:32 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776834394; cv=none;\n b=THlzMi3wGkZrSXqXuZmsforfOCzskswF5Uq/K5xwzbzgsJmUFuMyIEJgUem7xepz2S3qgNGQe8eWh2ussmQY/EDR1CM1sGuBlWhzmlRM2D1iWVnAGX7xKiCYhgVjcyMss3dChyEMYmOneWXNK2naJih91zx/unKFvZ1ZYT+xLZs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776834394; c=relaxed/simple;\n\tbh=8tqUhDwFGwuXjqhe2jM986k6o+3Bby8a7ng6Kt/J5SE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=ADA5MgHNekGoPzvPse+6AnX+Z8+Q4/zDMYJ1resDLdD+cZfNK5d3rSL3dSMIvJqviRNZ0yL8VHa/LFMl0CCiOHdV84bJG9Xz0VudQdv3rla3g/zx+B1NFQ41GcL8eEzyiZTkb7lvO5CL/ShainYCwkC5UieHAqQupZMs6vtBNhg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=mBo6Q+nl; arc=none smtp.client-ip=209.85.210.180","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776834392; x=1777439192;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TF9vfIdTBsK1gXD903+/RyAA96pAo1Q8ROFs39JYctc=;\n b=mBo6Q+nlBv4HqSzb+ASvh4H+Jdfbg7VXU6z3MwR8lNH7Youm4uunBKLOgSieO2M91u\n H49ZX4f8wrjpDXTavID/nkS7Z+QG9gFz2/NZK1oNdULl7hTbp4fB47AqLp5bjjAXrQFW\n iczfB86DIgFLsbazRJMV3tkP5/4DpSBRnC5t9xVDi/TUNNHmsyXJw1dJawaRuMNSN8Uc\n EhwialXBRVHnsGeTWDnQWrzX64xfxC4ZqduCOq4iQVX1ICANoM/xK91ri7jfXbbDkVxH\n R6WgOOcJkr1Rk5Kr+Y9UHYt6iM8Mm5KmtDMEzcPJ8Bnk4o3T5aXgOFEJghGHFvbPNQvr\n dTrw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776834392; x=1777439192;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=TF9vfIdTBsK1gXD903+/RyAA96pAo1Q8ROFs39JYctc=;\n b=kjeD07sW8b72nMZsE7mD5WsryIb/zOZlmxcOHI85dcyKM+0n+krCA2vAeFVjv6nSWF\n BbrL4CjJDk68I1J+lRt5hiuQ1jrXlCTnEZpVPgzrPF1ai8PZZp3Sc1B6ewmyhcWsUWWl\n 4LPQ9UqU34mYy9Ru4CsKQ5ShliuCOzVE4ZEC+sLoqirq4MrXuklIW/bOlXrCg375fJS6\n ml33TxWjY92eGBmGJDHoMZq1aAhYnF3oDC0JAXf5PyxEFGWojvXWkkdfc0Tmz0V26IJh\n LyH3umKowBL1e7jFNExeVNZoXcYvMpsfctejvKIOwV6fsZ6OVppsWOPeXKQCvIVDF9Uu\n +85Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/7cLba2SpDeeam8TTXCnCETFk+r8A4OcL/PpqCJZv60qO5xKXVd10mt33UrPjn6yaQDF/E6p3L0PHY@vger.kernel.org","X-Gm-Message-State":"AOJu0YwgKpD+vDRX8jr9/OJ+Wjmlms58WhrrWrXgiU2c+R4Nnn+hVeGy\n\t0/cYzoEsph3u2RA5nDuxtF+vh1/H0CQ4HH7Q4vQFn6RUa+xVpI0HTnQE","X-Gm-Gg":"AeBDiet9JDNn3ZCzhKN4VgBsVk/O0i80NWrFZUcN/xmWMcYSQ6xHMy8VkWTWDX98IO7\n\tT8Agty0Uqrh10QBf62eT28mG96AvvqI+wOktz/4jXi2psFESKAN2IwAGK5Jf+6I0DNqOVrI72C7\n\tMwdqNgHX+c/+M5ZLA7swmm5v03z6+B6RtZrQinTgf91Zp8caOHzX9qwaexRJHXD3Z0qQDtu+iGZ\n\tyP+JL5wBz7UvRSBVGJxPPBB6mL51mZ+CU2yelZ48cZONPntiPiOdUldS/a6AXWfzOq5grUjV3E/\n\t/m6Lcerpch+50pxfl9vwKi7r1FgjBn5lj7oRmaYBXwSTSGwI+qmwDCRNQuhGFs7HLex5xSl/+rT\n\tbo1xzspoNiS7LDP0uIP70yCfvaPgxmt7PhrWxp4hz2dCPgu45y6SOk66/mLnbh1ZHTv6Unq509P\n\tWvG6MWKYyeKkO7Rlm0iir5RqoW04yQKJiIj+74Z5pNIdsFK3UEfPYaWWnhFrcudZXeDIT2EEwju\n\trdglnQ/0tmg3DoO2ZRNleDUybFLMeL2RA==","X-Received":"by 2002:a05:6a00:bb84:b0:82f:1d38:f693 with SMTP id\n d2e1a72fcca58-82f8c8e0f98mr21053083b3a.35.1776834392581;\n Tue, 21 Apr 2026 22:06:32 -0700 (PDT)","From":"rajasimandalos@gmail.com","To":"sfrench@samba.org,\n\tlinux-cifs@vger.kernel.org","Cc":"rajasimandalos@gmail.com,\n\tRajasi Mandal ","Subject":"[PATCH v2] smb: client: allow nolease option to be reconfigured on\n remount","Date":"Wed, 22 Apr 2026 05:06:13 +0000","Message-ID":"<20260422050613.1136327-1-rajasimandalos@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260409095926.905020-6-rajasimandalos@gmail.com>","References":"<20260409095926.905020-6-rajasimandalos@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Rajasi Mandal \n\ntcon->no_lease controls whether the client requests leases from the\nserver. Changing nolease via remount is silently accepted but has\nno effect because the value is never propagated to the live tcon.\n\nAdd no_lease to smb3_sync_tcon_opts() so the flag is propagated to\nevery tcon on remount.\n\nWhen switching to nolease, close all deferred file handles via\ncifs_close_all_deferred_files_sb() outside the tlink_tree_lock,\nsince closing deferred handles can sleep. Deferred handles retain\nactive leases from before the switch; without closing them, those\nfiles continue using lease-based caching despite nolease being set.\n\nBoth transitions are safe:\n - lease -> nolease: deferred handles are closed, future opens\n get OPLOCK_LEVEL_NONE.\n - nolease -> lease: future opens request leases normally.\n\nSigned-off-by: Rajasi Mandal \n---\n fs/smb/client/fs_context.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c\nindex 45173f287f00..fb59b45c7f66 100644\n--- a/fs/smb/client/fs_context.c\n+++ b/fs/smb/client/fs_context.c\n@@ -1317,6 +1317,7 @@ static void smb3_sync_tcon_opts(struct cifs_sb_info *cifs_sb,\n \n \t\tspin_lock(&tcon->tc_lock);\n \t\ttcon->retry = ctx->retry;\n+\t\ttcon->no_lease = ctx->no_lease;\n \t\t/*\n \t\t * Note: this updates the limit for new cached dir opens\n \t\t * but does not resize or evict existing cached dirents.\n@@ -1325,6 +1326,14 @@ static void smb3_sync_tcon_opts(struct cifs_sb_info *cifs_sb,\n \t\tspin_unlock(&tcon->tc_lock);\n \t}\n \tspin_unlock(&cifs_sb->tlink_tree_lock);\n+\n+\t/*\n+\t * When switching to nolease, close all deferred file handles.\n+\t * cifs_close_all_deferred_files_sb() handles its own locking\n+\t * and must be called outside tlink_tree_lock since it can sleep.\n+\t */\n+\tif (ctx->no_lease)\n+\t\tcifs_close_all_deferred_files_sb(cifs_sb);\n }\n \n /*\n","prefixes":["v2"]}