{"id":2226013,"url":"http://patchwork.ozlabs.org/api/patches/2226013/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260422021042.4157510-14-yi.zhang@huaweicloud.com/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422021042.4157510-14-yi.zhang@huaweicloud.com>","list_archive_url":null,"date":"2026-04-22T02:10:33","name":"[v3,13/22] iomap: fix incorrect did_zero setting in iomap_zero_iter()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c42c636f26012732e9cc1b096baefed4f56fe2fa","submitter":{"id":85428,"url":"http://patchwork.ozlabs.org/api/people/85428/?format=json","name":"Zhang Yi","email":"yi.zhang@huaweicloud.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260422021042.4157510-14-yi.zhang@huaweicloud.com/mbox/","series":[{"id":500911,"url":"http://patchwork.ozlabs.org/api/series/500911/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=500911","date":"2026-04-22T02:10:23","name":"ext4: use iomap for regular file's buffered I/O path","version":3,"mbox":"http://patchwork.ozlabs.org/series/500911/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226013/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226013/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=rxuj=cv=vger.kernel.org=linux-ext4+bounces-15981-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.105.105.114 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15981-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=45.249.212.51","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=huaweicloud.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0jdw6QC5z1yD5\n\tfor ; Wed, 22 Apr 2026 12:21:40 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g0jdw5t0Xz4w1l\n\tfor ; Wed, 22 Apr 2026 12:21:40 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4g0jdw5prSz4wL0; Wed, 22 Apr 2026 12:21:40 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g0jdr5tTXz4w1l\n\tfor ; Wed, 22 Apr 2026 12:21:36 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 4AE9030532C6\n\tfor ; Wed, 22 Apr 2026 02:17:59 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 37D0336680F;\n\tWed, 22 Apr 2026 02:17:08 +0000 (UTC)","from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com\n [45.249.212.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C60793446B7;\n\tWed, 22 Apr 2026 02:17:02 +0000 (UTC)","from mail.maildlp.com (unknown [172.19.163.198])\n\tby dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4g0jWM4jN4zYQtrC;\n\tWed, 22 Apr 2026 10:15:59 +0800 (CST)","from mail02.huawei.com (unknown [10.116.40.252])\n\tby mail.maildlp.com (Postfix) with ESMTP id D3EB740604;\n\tWed, 22 Apr 2026 10:16:56 +0800 (CST)","from huaweicloud.com (unknown [10.50.85.155])\n\tby APP3 (Coremail) with SMTP id _Ch0CgB3JL6PL+hpqkgUBQ--.2635S17;\n\tWed, 22 Apr 2026 10:16:56 +0800 (CST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776824500; cv=pass;\n\tb=PJtlfo0Jb/l2/GhFrD1DTtVrm/Qrn0JU7JSeM9pdhe6v+Rdn+GaPZvvUQ2rjY/GtP9yU1wikIagBLWYajOlCCYE1Xcy/IEv8jqcPcDnSy+T26kzntbs3lLcADH2UIpPdu8khE7x0l5UmXE5fZnCeWmXixicS++5WFjeHYJz2DnG8Tt4LecAtrhlRcaXo+mAq08xyq9jV2KViwEbYef6CQHKoqNsPCdOhuUx6j2tAYtoQQuBuZFDknMxJwGol2V2nKAL45NCekCUFA1yBy/Iw5hybP24gNoxEw3EIMz0TKhrNluaG8dMcNFs6Z7JZ3JlFPnw0XUo4SK3FloO4BWZfeg==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776824227; cv=none;\n b=Ff4cXRIQ7IkwaluHiI4SEa0ppTalEcw2oISNZ4zAgMRToCBln0Y5iiUmAkvKABr+ClsUG9oj/3iyJJ+caw0LBtb7lOeCP3ClyOMrYfMkeMtAO7QT7oLXS21euWF1q8I086xH3580iOxHHn/Uxqsq+2NLTpB2ItIRsezYRZWigM4="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776824500; c=relaxed/relaxed;\n\tbh=DRcIeEXQJHKUY5MuGtNMcXYH68Ag/gEI0T5vvJICzEM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=UVDYJPsQooJijHbvKACtnKuoy2pUxdfmf7dAqlTeRdUPHv4CH7ggrq595XDhAihYISbEJmuyoJtLG24cmFZiqifEf4HOPTJDOdPUZYRxGqrx7iogocfM5UCT4Ydc549RukwcLf75odDaRjdLEHy5WvTy/L4iM093glgsLgEoHIOhXw0F0xICEbt+/T0pscqJTzd2I4AZThtzcnNEH1iQq93++JiZ3N2Ob590UzQkweciw+iGsAntZ08ERiEw5XvzsBrGAQ6ZZCmtpF7zDTWqfwpNENahZSzvTefEbvnncuSeI3Nevw3Pxc3pY5RUldO+wBkMH7h4Xg/gCU/briRLvg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776824227; c=relaxed/simple;\n\tbh=MgOzNx3i4g+Amum0Bg8TWTc4SNzjpmUBOxr9SspLvkM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=JpA1F4KeXFTHMFSq078bZZSDIfa1AZOpro+f1MuyjECdZ+au+TBTuNpEvBYRnqxlPAWmiTi75VPf/EsozgnFQUThIUhhvgh71hxvyo0apLZoSqyCq7KWptfSLqFLMU1riFIs1Xltg00+KQzzkv0gfIZvi1uN4yBgjJbqb7zVRpc="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15981-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51"],"From":"Zhang Yi ","To":"linux-ext4@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\ttytso@mit.edu,\n\tadilger.kernel@dilger.ca,\n\tlibaokun@linux.alibaba.com,\n\tjack@suse.cz,\n\tojaswin@linux.ibm.com,\n\tritesh.list@gmail.com,\n\tdjwong@kernel.org,\n\thch@infradead.org,\n\tyi.zhang@huawei.com,\n\tyi.zhang@huaweicloud.com,\n\tyizhang089@gmail.com,\n\tyangerkun@huawei.com,\n\tyukuai@fnnas.com","Subject":"[PATCH v3 13/22] iomap: fix incorrect did_zero setting in\n iomap_zero_iter()","Date":"Wed, 22 Apr 2026 10:10:33 +0800","Message-ID":"<20260422021042.4157510-14-yi.zhang@huaweicloud.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260422021042.4157510-1-yi.zhang@huaweicloud.com>","References":"<20260422021042.4157510-1-yi.zhang@huaweicloud.com>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_Ch0CgB3JL6PL+hpqkgUBQ--.2635S17","X-Coremail-Antispam":"1UD129KBjvJXoWxJr1UJr4fuw1kXF18uw4kZwb_yoW8tr48p3\n\t9xKayDCFn2qrW7uFn5JF9Ivr1Yyws5JrW7Wr4UGwn8ZF4qvr4YkF1FgayYvF1xJ34fA3Wa\n\tyF4jyas2qF4UCrDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUmS14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n\trVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI\n\tkIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2\n\tz4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F\n\t4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq\n\t3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7\n\tIYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4U\n\tM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2\n\tkIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkE\n\tbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67\n\tAF67kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVW8JVW5JwCI\n\t42IY6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF\n\t4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBI\n\tdaVFxhVjvjDU0xZFpf9x0JUWMKtUUUUU=","X-CM-SenderInfo":"d1lo6xhdqjqx5xdzvxpfor3voofrz/","X-Spam-Status":"No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDMARC_MISSING,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"From: Zhang Yi \n\nThe did_zero output parameter was unconditionally set after the loop,\nwhich is incorrect. It should only be set when the zeroing operation\nactually completes, not when IOMAP_F_STALE is set or when\nIOMAP_F_FOLIO_BATCH is set but !folio causes the loop to break early,\nor when iomap_iter_advance() returns an error.\n\nThis causes did_zero to be incorrectly set when zeroing a clean\nunwritten extent because the loop exits early without actually zeroing\nany data.\n\nFix it by using a local variable to track whether any folio was actually\nzeroed, and only set did_zero after the loop if zeroing happened.\n\nSigned-off-by: Zhang Yi \nReviewed-by: \"Darrick J. Wong\" \n---\nThis is cherry picked form:\n https://lore.kernel.org/linux-fsdevel/20260310082250.3535486-1-yi.zhang@huaweicloud.com/\nNo changes.\n\n fs/iomap/buffered-io.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c\nindex b17296b61a6e..0ffc2c3230af 100644\n--- a/fs/iomap/buffered-io.c\n+++ b/fs/iomap/buffered-io.c\n@@ -1542,6 +1542,7 @@ static int iomap_zero_iter(struct iomap_iter *iter, bool *did_zero,\n \t\tconst struct iomap_write_ops *write_ops)\n {\n \tu64 bytes = iomap_length(iter);\n+\tbool zeroed = false;\n \tint status;\n \n \tdo {\n@@ -1560,6 +1561,8 @@ static int iomap_zero_iter(struct iomap_iter *iter, bool *did_zero,\n \t\t/* a NULL folio means we're done with a folio batch */\n \t\tif (!folio) {\n \t\t\tstatus = iomap_iter_advance_full(iter);\n+\t\t\tif (status)\n+\t\t\t\treturn status;\n \t\t\tbreak;\n \t\t}\n \n@@ -1570,6 +1573,7 @@ static int iomap_zero_iter(struct iomap_iter *iter, bool *did_zero,\n \t\t\t\tbytes);\n \n \t\tfolio_zero_range(folio, offset, bytes);\n+\t\tzeroed = true;\n \t\tfolio_mark_accessed(folio);\n \n \t\tret = iomap_write_end(iter, bytes, bytes, folio);\n@@ -1579,10 +1583,10 @@ static int iomap_zero_iter(struct iomap_iter *iter, bool *did_zero,\n \n \t\tstatus = iomap_iter_advance(iter, bytes);\n \t\tif (status)\n-\t\t\tbreak;\n+\t\t\treturn status;\n \t} while ((bytes = iomap_length(iter)) > 0);\n \n-\tif (did_zero)\n+\tif (did_zero && zeroed)\n \t\t*did_zero = true;\n \treturn status;\n }\n","prefixes":["v3","13/22"]}