{"id":2225883,"url":"http://patchwork.ozlabs.org/api/patches/2225883/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260421181652.161719-1-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421181652.161719-1-pablo@netfilter.org>","list_archive_url":null,"date":"2026-04-21T18:16:50","name":"[nf,1/3] netfilter: replace skb_try_make_writable() by skb_ensure_writable()","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"3b60635e48b192e47154bfa3a93c818bc155ea23","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260421181652.161719-1-pablo@netfilter.org/mbox/","series":[{"id":500865,"url":"http://patchwork.ozlabs.org/api/series/500865/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500865","date":"2026-04-21T18:16:51","name":"[nf,1/3] netfilter: replace skb_try_make_writable() by skb_ensure_writable()","version":1,"mbox":"http://patchwork.ozlabs.org/series/500865/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225883/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225883/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=aZ3uxCNe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12118-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"aZ3uxCNe\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0VwC1DW2z1yGt\n\tfor ; Wed, 22 Apr 2026 04:18:19 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 40CF43011123\n\tfor ; Tue, 21 Apr 2026 18:17:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2099B33D6E3;\n\tTue, 21 Apr 2026 18:17:07 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A684533E379\n\tfor ; Tue, 21 Apr 2026 18:17:03 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id 9FFC660177\n\tfor ; Tue, 21 Apr 2026 20:16:55 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776795426; cv=none;\n b=AfO5GQ9qzs5GRaP/nNurj+DhqEWKNaobuQZKH3BcPB66Bi+39gxcEGZ8BzQchyw8SkBYQ5Os5JZXTlri/240B+IetY09nwZXVJfr8ul7MZ5jfB5N8Gb5FVsGVcgKJt2+DUVmvUfb2UzOXrH0rtslOl6XXWDXCBEeZ1mCIWtPOVE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776795426; c=relaxed/simple;\n\tbh=UUZ1A2Rr5bxBz8+HAj328MyQlWHLHDmlTx+8U8fOou4=;\n\th=From:To:Subject:Date:Message-ID:MIME-Version;\n b=dlHD4ZDBJLgniW9FnTmO1LD9H9Cp3SzcXblnWmqL7NW8J8B65hDIqVa0Et8fgm3YRukU1yd2miNQgJgQU8AbA5O0+LXHOj3hSl90rOVGFQLWwOldGDglLTb1geZr7KwSkinf0tS+JLtIZ2+g8LsvZHDfLVr3tTgctsCd9bso730=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=aZ3uxCNe; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776795415;\n\tbh=cIDHkEVVoe3LWJ/8WDCM31uPvOr5kBPwQXXT8IFZ2tA=;\n\th=From:To:Subject:Date:From;\n\tb=aZ3uxCNeTXzkFzxKVZEmpPXB2kEInUFoFmglaoZOHqF+/iNVXxUVKg15dWrxx0M4U\n\t ZA4e2qqaG1LfzXMbhIXK70EuezOHZiNaK17XEhZqJcCowKqGflVf1bBc7kWzl98Dv8\n\t 0hW3oXYP9loY3gB0vklsp33J/mItxNPTt0ADVqoe79Wu1+rifXHKiksp/o9iQ5VR+X\n\t 6FRBSijV0ppyp7m1Bwt3t3O8ieigUDRKZslxNXnUrJiRQXECzg5nU3LWXBNpBEY7r1\n\t 4IjmPjvWZuzXDn7XpFYZnULgWogEddl48StZv/aqyQaFkSMq/Fy5UGUgIBgn+Qax44\n\t 9U4qMCrDfrNTQ==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Subject":"[PATCH nf 1/3] netfilter: replace skb_try_make_writable() by\n skb_ensure_writable()","Date":"Tue, 21 Apr 2026 20:16:50 +0200","Message-ID":"<20260421181652.161719-1-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"skb_try_make_writable() only works on clones and uncloned packets might\nhave their network header in paged fragments.\n\nFixes: d32de98ea70f (\"netfilter: nft_fwd_netdev: allow to forward packets via neighbour layer\")\nFixes: 7d2086871762 (\"netfilter: nf_flow_table: move ipv4 offload hook code to nf_flow_table\")\nSigned-off-by: Pablo Neira Ayuso \n---\n net/netfilter/nf_flow_table_ip.c | 2 +-\n net/netfilter/nft_fwd_netdev.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c\nindex fd56d663cb5b..39b537fa6e51 100644\n--- a/net/netfilter/nf_flow_table_ip.c\n+++ b/net/netfilter/nf_flow_table_ip.c\n@@ -524,7 +524,7 @@ static int nf_flow_offload_forward(struct nf_flowtable_ctx *ctx,\n \t\treturn 0;\n \t}\n \n-\tif (skb_try_make_writable(skb, thoff + ctx->hdrsize))\n+\tif (skb_ensure_writable(skb, thoff + ctx->hdrsize))\n \t\treturn -1;\n \n \tflow_offload_refresh(flow_table, flow, false);\ndiff --git a/net/netfilter/nft_fwd_netdev.c b/net/netfilter/nft_fwd_netdev.c\nindex 4bce36c3a6a0..0bc0cf194849 100644\n--- a/net/netfilter/nft_fwd_netdev.c\n+++ b/net/netfilter/nft_fwd_netdev.c\n@@ -111,7 +111,7 @@ static void nft_fwd_neigh_eval(const struct nft_expr *expr,\n \t\t\tverdict = NFT_BREAK;\n \t\t\tgoto out;\n \t\t}\n-\t\tif (skb_try_make_writable(skb, sizeof(*iph))) {\n+\t\tif (skb_ensure_writable(skb, sizeof(*iph))) {\n \t\t\tverdict = NF_DROP;\n \t\t\tgoto out;\n \t\t}\n@@ -132,7 +132,7 @@ static void nft_fwd_neigh_eval(const struct nft_expr *expr,\n \t\t\tverdict = NFT_BREAK;\n \t\t\tgoto out;\n \t\t}\n-\t\tif (skb_try_make_writable(skb, sizeof(*ip6h))) {\n+\t\tif (skb_ensure_writable(skb, sizeof(*ip6h))) {\n \t\t\tverdict = NF_DROP;\n \t\t\tgoto out;\n \t\t}\n","prefixes":["nf","1/3"]}