{"id":2225710,"url":"http://patchwork.ozlabs.org/api/patches/2225710/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260421132357.29200-1-polacek@redhat.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421132357.29200-1-polacek@redhat.com>","list_archive_url":null,"date":"2026-04-21T13:23:57","name":"libcpp: fix typos in iconv_close [PR124930]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"41b64f5144131b50f6cd137566bdeb6b402cb6de","submitter":{"id":14370,"url":"http://patchwork.ozlabs.org/api/people/14370/?format=json","name":"Marek Polacek","email":"polacek@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260421132357.29200-1-polacek@redhat.com/mbox/","series":[{"id":500802,"url":"http://patchwork.ozlabs.org/api/series/500802/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=500802","date":"2026-04-21T13:23:57","name":"libcpp: fix typos in iconv_close [PR124930]","version":1,"mbox":"http://patchwork.ozlabs.org/series/500802/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225710/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225710/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=VBT7bo9n;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=VBT7bo9n","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0NPR5X21z1yGs\n\tfor ; Tue, 21 Apr 2026 23:24:42 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 0AB564B9DB6C\n\tfor ; Tue, 21 Apr 2026 13:24:40 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 2ABC84BA23FC\n for ; Tue, 21 Apr 2026 13:24:07 +0000 (GMT)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-mcfr1L1cPQ-8Rd6M1hEaJg-1; Tue,\n 21 Apr 2026 09:24:05 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 395C0195609F\n for ; Tue, 21 Apr 2026 13:24:04 +0000 (UTC)","from pdp-11.redhat.com (unknown [10.22.65.59])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 58E7019560AB; Tue, 21 Apr 2026 13:24:03 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 0AB564B9DB6C","OpenDKIM Filter v2.11.0 sourceware.org 2ABC84BA23FC"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 2ABC84BA23FC","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 2ABC84BA23FC","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776777847; cv=none;\n b=vIbvdmMzfXG/QSGbQ0czZFbplUBPXcgC2K78VxNZHjZnd0hs3+fmnn6uxuuBHcCYQfKgexE34xxgpku/wuONKfXR1YI1hiLYUNJ087GHhzd4F1NV/nr43wo8C0rt44XS91hS7q3s4j0MY+c5JIHxmswqAhuOBi3dD5bQaj+IqTw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776777847; c=relaxed/simple;\n bh=zyXLlLf2IQKvLoyPUpRjuV2ld29W2fIY0XVym49muyE=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=iUG7TNboczFGyXoj3CQD83jOTnxnvHRp/B7o7AW9Q4E0HIaz9mum7QF+K3iYg61GycP4jHKUNlwuZv3qyzlHlsaYYMUGZMxrodG13y488bc5BzzF61jFJOPq97jkfU/k6mJk8VRXXdHefXQNmdoiL3qWy68z9ZkHkIt9zeg5wf8=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776777846;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=K6FbuSpeFYabRziZbcWufj6QcSoKTx0ZyHSaVVMDXx0=;\n b=VBT7bo9nvlJ0LtPZKGFUYQeFiRrtmWGeLiPUaj8syIm3+aRcZsZH4i+OoCG4AwipWPro0v\n SK0BaT7nyYv1qBMhLPX+pM+gufAtz/LJujBFhnAiEtFrnHXq3xQkEM4SsYiPKAqxbCaiNf\n uP+ODGaaHfUQRlV5BGoToiMGfVqNA+I=","X-MC-Unique":"mcfr1L1cPQ-8Rd6M1hEaJg-1","X-Mimecast-MFC-AGG-ID":"mcfr1L1cPQ-8Rd6M1hEaJg_1776777844","From":"Marek Polacek ","To":"Jakub Jelinek , Jason Merrill ,\n Joseph Myers , GCC Patches ","Subject":"[PATCH] libcpp: fix typos in iconv_close [PR124930]","Date":"Tue, 21 Apr 2026 09:23:57 -0400","Message-ID":"<20260421132357.29200-1-polacek@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"cCd2iOwvRy7W0sf8NzjMBQc445CkXly3Ba0b5oDW5cg_1776777844","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?\n\n-- >8 --\nThis patch fixes two typos I made: the reverse_ prefix is missing\nin the iconv_close calls.\n\n\tPR preprocessor/124930\n\nlibcpp/ChangeLog:\n\n\t* charset.cc (_cpp_destroy_iconv): Correct two calls to\n\ticonv_close.\n---\n libcpp/charset.cc | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 727f2230548dd08fe1a0f9549cd7011290eaaf31","diff":"diff --git a/libcpp/charset.cc b/libcpp/charset.cc\nindex f07052087a8..563b7c55f79 100644\n--- a/libcpp/charset.cc\n+++ b/libcpp/charset.cc\n@@ -841,9 +841,9 @@ _cpp_destroy_iconv (cpp_reader *pfile)\n if (pfile->wide_cset_desc.func == convert_using_iconv)\n \ticonv_close (pfile->wide_cset_desc.cd);\n if (pfile->reverse_narrow_cset_desc.func == convert_using_iconv)\n-\ticonv_close (pfile->narrow_cset_desc.cd);\n+\ticonv_close (pfile->reverse_narrow_cset_desc.cd);\n if (pfile->reverse_utf8_cset_desc.func == convert_using_iconv)\n-\ticonv_close (pfile->utf8_cset_desc.cd);\n+\ticonv_close (pfile->reverse_utf8_cset_desc.cd);\n }\n }\n \n","prefixes":[]}