{"id":2225653,"url":"http://patchwork.ozlabs.org/api/patches/2225653/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260421113445.3834570-1-pranav.vinaytilak@amd.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421113445.3834570-1-pranav.vinaytilak@amd.com>","list_archive_url":null,"date":"2026-04-21T11:34:07","name":"[v3] net: phy: fix duplicate eth_phy binding","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ec6420bdb4c4b813682e049c96308d335d4cd568","submitter":{"id":92380,"url":"http://patchwork.ozlabs.org/api/people/92380/?format=json","name":"Pranav Tilak","email":"pranav.vinaytilak@amd.com"},"delegate":{"id":157425,"url":"http://patchwork.ozlabs.org/api/users/157425/?format=json","username":"jforissier","first_name":"Jerome","last_name":"Forissier","email":"jerome.forissier@linaro.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260421113445.3834570-1-pranav.vinaytilak@amd.com/mbox/","series":[{"id":500783,"url":"http://patchwork.ozlabs.org/api/series/500783/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500783","date":"2026-04-21T11:34:07","name":"[v3] net: phy: fix duplicate eth_phy binding","version":3,"mbox":"http://patchwork.ozlabs.org/series/500783/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225653/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225653/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256\n header.s=selector1 header.b=JCE2bLyl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.b=\"JCE2bLyl\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com","phobos.denx.de;\n spf=fail smtp.mailfrom=Pranav.VinayTilak@amd.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0L0C532kz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 21:36:11 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E42B983BC4;\n\tTue, 21 Apr 2026 13:36:07 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 93E8383E36; Tue, 21 Apr 2026 13:36:07 +0200 (CEST)","from CH4PR04CU002.outbound.protection.outlook.com\n (mail-northcentralusazlp170130007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c105::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 35B7E83B99\n for <u-boot@lists.denx.de>; Tue, 21 Apr 2026 13:36:03 +0200 (CEST)","from CH0PR08CA0018.namprd08.prod.outlook.com (2603:10b6:610:33::23)\n by DS7PR12MB5912.namprd12.prod.outlook.com (2603:10b6:8:7d::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.12; Tue, 21 Apr\n 2026 11:35:47 +0000","from CH1PEPF0000AD81.namprd04.prod.outlook.com\n (2603:10b6:610:33:cafe::4b) by CH0PR08CA0018.outlook.office365.com\n (2603:10b6:610:33::23) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9791.48 via Frontend Transport; Tue,\n 21 Apr 2026 11:35:47 +0000","from satlexmb08.amd.com (165.204.84.17) by\n CH1PEPF0000AD81.mail.protection.outlook.com (10.167.244.89) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9791.48 via Frontend Transport; Tue, 21 Apr 2026 11:35:47 +0000","from SATLEXMB04.amd.com (10.181.40.145) by satlexmb08.amd.com\n (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Tue, 21 Apr\n 2026 06:35:46 -0500","from satlexmb08.amd.com (10.181.42.217) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 21 Apr\n 2026 06:35:45 -0500","from xhdpvinayti50x.xilinx.com (10.180.168.240) by\n satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.17 via Frontend Transport; Tue, 21 Apr 2026 06:35:42 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=JD7Bq6nFzjsU2D55JAyxviAlPekv+0q+/zEKGd+03uJoZHc6kBJhY4NEDLr0YyFPhsSFsu2bB/LkQUL+CmsgPQk4tI+NpXVRPmEsfRoNlghtwl5VqRZDuQ8YS5blu8jjVMTQlMF6He8OLhkjKQL3wwvdIWMaLeAy6myu7QQplmP6sV0O3zlM1ve1DXwRk6dVaQcKTWlkHH9JER9ZFH+AtKtvEMkoyH+yCN4H8dfu7APuf5HdkpYhYdhzNr9rtL6fYu+gUVIUSaYXLHkV9sBToaoT3uoucvr95fgjzmjt65nxtmdJrmDmevTxthwMA/d5y1PDdSCXsYLDg3UwVhafbg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=D78miF7OflaJQ1GQKErni3RucGnytguBfbG2KIM5TLo=;\n b=JgLpkSeqTzcyHlZH6gUigWrnnDuT6Q5mziUz9VWrSxXUuft4RTJ0oSh68SuSgtyYutNNTFl4b3ouDZM94sKsqWI8Vd1/iD18ZmYr6Fy/L7vTqeEYIVoijrXtzGW3w79cZGJQ0qSldjNPR1mR8WxMBAisccWL82f/Hd/wp5SBbJVLZIIaedGoN0V5q3pVfzbTiKOdTlYUyWpxVXHtS4yPLBdxbl/L+EScCQJCUCgFXMSaW2UQ7a4ef8+4i7bccf+lF0KI8UWMntBXBLOd2kGwA8Bbw9tUb4OVyKCP2J04HOkmvR1smL59cy7iUsLC6yjwZjc1o4mlOicRJOk2yhImjg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=amd.com; dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=D78miF7OflaJQ1GQKErni3RucGnytguBfbG2KIM5TLo=;\n b=JCE2bLylQZa52vYdDik0Z0OLCaQken3n03CMxKbdnsTpeBsxWOBKpMhZfEE4Tt/eWx783ENpJ5xuT3h5tfoaE+vxkfxjtX5uEDKCzVnPbbO0JPerGcXtXJFMXxbKpIwSJJvOV6BWGtFXpIJtrt1hHbGO+MQrZ5biObxCO2ASSZY=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;","Received-SPF":["Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C","None (SATLEXMB04.amd.com: pranav.vinaytilak@amd.com does not\n designate permitted sender hosts)"],"From":"Pranav Tilak <pranav.vinaytilak@amd.com>","To":"<u-boot@lists.denx.de>, <michal.simek@amd.com>","CC":"<git@amd.com>, <padmarao.begari@amd.com>, Pranav Tilak\n <pranav.vinaytilak@amd.com>, Jerome Forissier <jerome.forissier@arm.com>, Tom\n Rini <trini@konsulko.com>, Patrice Chotard <patrice.chotard@foss.st.com>,\n SkyLake.Huang <skylake.huang@mediatek.com>, Lucien.Jheng\n <lucienzx159@gmail.com>, Peng Fan <peng.fan@nxp.com>, \"Siddharth Vadapalli\"\n <s-vadapalli@ti.com>, Marek Vasut <marek.vasut+renesas@mailbox.org>, Ramon\n Fried <rfried.dev@gmail.com>","Subject":"[PATCH v3] net: phy: fix duplicate eth_phy binding","Date":"Tue, 21 Apr 2026 17:04:07 +0530","Message-ID":"<20260421113445.3834570-1-pranav.vinaytilak@amd.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CH1PEPF0000AD81:EE_|DS7PR12MB5912:EE_","X-MS-Office365-Filtering-Correlation-Id":"9870fce4-6d00-4277-f413-08de9f9a21c0","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700016|1800799024|376014|7416014|82310400026|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n uCBPBCuYCyAWsmNLUA+bMu7CaSEcZuUx0vEx7hHxxDzy1DXO3KI7pncuNMnJT+7H5mG+QTUusnCZEcL8vaFlRJiZUfhOGeLPaJsFH5TdqEhJcOEMDp1v/l3I3AbANMmY86nKbQm6GblszXuw/RPElPdPrRZqHopMILnsrCzM6pKtZ59lL2pGx9P6/dv026Ds1qj+vCE7w1ODJa1xNPavp40X4Por7A0UkrVzD7J0xTra7QijE0t/EhMWU8rnnAv9P/BaRDMoWDEJllE9fIdVPab92OPRFxBybsJV1QdkU36BugPDbTrctcarDQTt5WmBVQqga4zln9HVfuZgPUrkkmFffmrkD7KB8vsBz2dKS/3YMVsHkpt1LnW2jHljzD31UoG3aomUBfIB8qKj6qhku8iZm/T7rgdVG6uKtn9xYDDG0+aeEkCHDk3T5At6f3qk0C74gBycRjDciMS8HIJ7w19t9GAk6A13EvDh7Q7gYueVZLxLIC+oFcNvglmjTUtWgqUpOezNK/Svg9SVfQqwwzcQC8GvidB1nUyqPGSF5NeXS2zl+YzMMaHugpt5xoJmzp2echneOLGGBEJQiSXvKlkGilWkcPav4IIwFtpF4LAaRVlAI1A4bhqUCXLf1TdCtzPrBor/yEto/ibvG4dfFzZPeUHmX0/8y+GJHKc+x8rb18Q/YJdtyQntGHob5jC4XeiLF6wnO5fFY6em5+dlOu5LrFD4d4UK5AAV0MbCbu+4ND1DouOTVUclpKKiD/NkdO2WwzvEudix2C/fjj7l1Q==","X-Forefront-Antispam-Report":"CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:satlexmb08.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(36860700016)(1800799024)(376014)(7416014)(82310400026)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n L0OjgfNXzdRB4rnjRiWksuYqnev1v6jWOpHUPk5oBO1y2fR7IqoKJMfpBztUiFEEr8XdD2dvqXLErh0nlvHsWrjS1197VpA9dbbSPAveyBYW3mNED6GgXn1kjpKKxXZ5FzX1Q6zZ8j1LGp4WWFoT4AmC69qFvsYjbcr7lLODhmp4NdvAlHJ6XGx9kPTGjIRBUx5nIL6RJf+vYAUPV+q1G3N/shyY66n5oVissTJr9vEuJbWYZp4NUaftZSOg8roBpFOfr8ouRujighuAKfi6aUIAY+Y65sttmMxViWp8weVZSzLIWlhiwvFvcrysI4F6iOUGBJwtXjx/9Vs/uVtcVifFWP56bSZIoWzDkYu/zXT9xdOZl1fmERxu3+SASyXWUW4smZHkZ5ICbg/WY9Tz+m9nRI5SQX633mPG1XjLXVlu5L49AsBpgrGAJ2LH7u36","X-OriginatorOrg":"amd.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"21 Apr 2026 11:35:47.2717 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 9870fce4-6d00-4277-f413-08de9f9a21c0","X-MS-Exchange-CrossTenant-Id":"3dd8961f-e488-4e60-8e11-a82d994e183d","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[satlexmb08.amd.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n CH1PEPF0000AD81.namprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS7PR12MB5912","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"When both CONFIG_PHY_ETHERNET_ID and CONFIG_DM_ETH_PHY are enabled,\neth_phy_binds_nodes() called from eth_post_bind() already binds the\nethernet PHY node to eth_phy_generic_drv. However, phy_connect_phy_id()\ncalled via phy_connect() also binds the same PHY node, resulting in\nduplicate entries in the DM tree.\n\nFix this by checking at the beginning of phy_connect() whether the PHY\nis already bound via uclass_get_device_by_phandle(). If so, skip all\ngeneric binding methods.\n\nFixes: 68a4d1506109 (\"net: phy: Bind ETH_PHY uclass driver to each new PHY\")\nSigned-off-by: Pranav Tilak <pranav.vinaytilak@amd.com>\n---\nChanges in v3:\n- Moved duplicate binding check to beginning of phy_connect()\n\nChanges in v2:\n- Move duplicate binding check to caller phy_connect()\n- Update commit description\n\n drivers/net/phy/phy.c | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c\nindex d7e0c4fe02d..b1eb5173fe8 100644\n--- a/drivers/net/phy/phy.c\n+++ b/drivers/net/phy/phy.c\n@@ -927,7 +927,12 @@ struct phy_device *phy_connect(struct mii_dev *bus, int addr,\n {\n \tstruct phy_device *phydev = NULL;\n \tuint mask = (addr >= 0) ? (1 << addr) : 0xffffffff;\n+\tstruct udevice *phy_dev;\n \n+\t/* Skip binding if PHY already bound by eth_phy_binds_nodes(). */\n+\tif (!IS_ENABLED(CONFIG_DM_ETH_PHY) ||\n+\t    uclass_get_device_by_phandle(UCLASS_ETH_PHY, dev,\n+\t\t\t\t\t \"phy-handle\", &phy_dev)) {\n #ifdef CONFIG_PHY_FIXED\n \tphydev = phy_connect_fixed(bus, dev);\n #endif\n@@ -946,6 +951,7 @@ struct phy_device *phy_connect(struct mii_dev *bus, int addr,\n \tif (!phydev)\n \t\tphydev = phy_connect_gmii2rgmii(bus, dev);\n #endif\n+\t}\n \n \tif (!phydev)\n \t\tphydev = phy_find_by_mask(bus, mask);\n","prefixes":["v3"]}