{"id":2225652,"url":"http://patchwork.ozlabs.org/api/patches/2225652/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/aedcwlyS96ASGI5e@tucnak/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-21T11:17:22","name":"testsuite: Adjust expected errors for aarch64/sme/streaming_mode_1.c and aarch64/sme/za_state_[12].c [PR122483]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"39793565a283b546fe4d81ea43fe81fea5fc07b8","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/?format=json","name":"Jakub Jelinek","email":"jakub@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/aedcwlyS96ASGI5e@tucnak/mbox/","series":[{"id":500782,"url":"http://patchwork.ozlabs.org/api/series/500782/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=500782","date":"2026-04-21T11:17:22","name":"testsuite: Adjust expected errors for aarch64/sme/streaming_mode_1.c and aarch64/sme/za_state_[12].c [PR122483]","version":1,"mbox":"http://patchwork.ozlabs.org/series/500782/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225652/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225652/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=TLhfKTw3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=TLhfKTw3","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0KbL2hpPz1yGt\n\tfor ; Tue, 21 Apr 2026 21:18:06 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 4A0844BA902B\n\tfor ; Tue, 21 Apr 2026 11:18:04 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id E84E64BA9001\n for ; Tue, 21 Apr 2026 11:17:32 +0000 (GMT)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-B4OEqYNsMzqhbd8uZsapbA-1; Tue,\n 21 Apr 2026 07:17:29 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 42A6E195608D; Tue, 21 Apr 2026 11:17:27 +0000 (UTC)","from tucnak.zalov.cz (unknown [10.44.48.12])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 1F55619560B7; Tue, 21 Apr 2026 11:17:25 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\n by tucnak.zalov.cz (8.18.1/8.18.1) with ESMTPS id 63LBHMe8918230\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Tue, 21 Apr 2026 13:17:23 +0200","(from jakub@localhost)\n by tucnak.zalov.cz (8.18.1/8.18.1/Submit) id 63LBHMCd918229;\n Tue, 21 Apr 2026 13:17:22 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 4A0844BA902B","OpenDKIM Filter v2.11.0 sourceware.org E84E64BA9001"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org E84E64BA9001","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org E84E64BA9001","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776770253; cv=none;\n b=I1zjeB7R8QgPhkwWcIBTJCnJDIt3i3SF5GcK6Sv2Euq6WquRhFxhHIoKCFQPv5I7hL5eutu5ZPeg2ouMum23jo67gqbOPiuMLtYplU1q7L3OiIakB4kRbRpmJMlkcWfYFM/BNEvcJfzYkCfP9WeQtuYqVMKs2RT9lO1zILvm3bw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776770253; c=relaxed/simple;\n bh=CxCfJpv4SpmigNLzKdmzNz3R5Is1QOPJenEgKTtmKlo=;\n h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version;\n b=PXRgCoWqq4oHvwHXe8Y+CHNUDRWU7k5a4rxerYQ3JKg8PjXYJB1yFwFeJn/PN7lYAIOuejC5S1xmnIQZTdovRPhJSA954VBi/CpbH5yz/Lh7PzbuTAo49TRrLswmIfJspoLexZBrQ1h7CpxHPUhOR6gIx60hQ/83fTxJsqWQIAA=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776770252;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to: references:references;\n bh=OEhF7sTEa+3f/ITNDeFoVtO1h8VuS0N113jHGuhlsW0=;\n b=TLhfKTw3yOzA2gl3t9Tl3e+cUcdRqRtxMx8LuDJlRGL5wZhjoCR8qCp7d8JNbo+HQZXp+h\n FNC+dPsP7Q0CoNgCEplEP/R+Unn6Ztbt6x9avuXLF+3P9uJUEBAmFff0e+nnj4lhSfM+WS\n TG70z1mf/iO/3mDzBUJm2Sby79NVjwY=","X-MC-Unique":"B4OEqYNsMzqhbd8uZsapbA-1","X-Mimecast-MFC-AGG-ID":"B4OEqYNsMzqhbd8uZsapbA_1776770247","Date":"Tue, 21 Apr 2026 13:17:22 +0200","From":"Jakub Jelinek ","To":"Alex Coplan ,\n \"Joseph S. Myers\" ,\n Richard Biener , Marek Polacek ,\n gcc-patches@gcc.gnu.org, Alice Carlotti ,\n Richard Sandiford ,\n Richard Earnshaw ,\n Tamar Christina ,\n Kyrylo Tkachov ,\n Andrew Pinski ,\n Wilco Dijkstra ","Subject":"[PATCH] testsuite: Adjust expected errors for\n aarch64/sme/streaming_mode_1.c and aarch64/sme/za_state_[12].c [PR122483]","Message-ID":"","References":"\n <91332677-b0d8-d097-151d-3690ff42c897@redhat.com>\n \n ","MIME-Version":"1.0","In-Reply-To":"","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"dSHTrmksQoUWtRgQazrXxsnl2lNXtYrrXnLaMDo5iYw_1776770247","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Jakub Jelinek ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"On Tue, Apr 21, 2026 at 12:57:49PM +0200, Jakub Jelinek wrote:\n> On Wed, Apr 08, 2026 at 03:28:18PM +0100, Alex Coplan wrote:\n> > I have now done so with a follow-up patch:\n> > https://gcc.gnu.org/pipermail/gcc-patches/2026-April/712482.html\n> > \n> > In the end it made more sense to add these tests separately, since the\n> > test itself won't start passing until the 3/4 aarch64 patch is applied\n> > anyway.\n> > \n> > Is this patch now OK for trunk? I'm hoping that mine and Richard's arguments\n> > were sufficiently persuasive as to why we want this behaviour for the\n> > relevant SME attributes.\n> \n> So, looking at this some more, I see that the r16-4667 commit just made\n> C FE behave like C++ FE used to behave already since PR15774 r0-105636.\n> And apparently clang behaves the same, both in C and C++ for many years\n> (tried both current clang and clang++ trunk and 9.0.0, unfortunately older\n> releases aren't on godbolt for aarch64; trying with regparm(3) instead of\n> the aarch64 specific ABI attributes, even clang and clang++ behaves that\n> way in 3.1, so also from at least 2011-ish).\n> \n> Thus, my strong preference would be to adjust the aarch64 testsuite\n> for the new behavior, which is now consistent between the FEs and different\n> compilers, accepting not specifying function type attributes if they have\n> been specified before (so, there is no risk of function being used with\n> different ABIs in between the declarations), but rejecting the case of\n> earlier declaration not specifying ABI relevant attributes and later one\n> which specifies those (because there is a risk of calls with a wrong ABI\n> in between). And I really don't buy the aarch64 ABI attributes being in any\n> way different from any other ABI attributes, all of those are ABI changes\n> which have to be visible to all callers of the function. By accepting\n> void foo () [[gnu::abi_changing_fntype_attribute]];\n> void foo ();\n> there is no risk of it being misused.\n\nSo, I think we should apply something like the patch below instead.\n\n2026-04-21 Jakub Jelinek \n\n\tPR target/122483\n\t* gcc.target/aarch64/sme/streaming_mode_1.c Don't expect error for\n\tsc_a, sc_c, sc_e, s_a, s_c, s_e and keyword_contradiction_1.\n\t* gcc.target/aarch64/sme/za_state_1.c: Don't expect error for shared_a,\n\tshared_c, shared_e, preserved_a, preserved_c, preserved_e and\n\tkeyword_conflict_1.\n\t* gcc.target/aarch64/sme/za_state_2.c: Don't expect error for shared_b\n\tand shared_d. Expect different error for shared_f and shared_h.\n\n\n\n\tJakub","diff":"--- gcc/testsuite/gcc.target/aarch64/sme/streaming_mode_1.c.jj\t2026-03-27 10:17:17.910269122 +0100\n+++ gcc/testsuite/gcc.target/aarch64/sme/streaming_mode_1.c\t2026-04-21 13:03:24.518242099 +0200\n@@ -1,19 +1,19 @@\n // { dg-options \"\" }\n \n void sc_a () [[arm::streaming_compatible]];\n-void sc_a (); // { dg-error \"conflicting types\" }\n+void sc_a ();\n \n void sc_b ();\n void sc_b () [[arm::streaming_compatible]]; // { dg-error \"conflicting types\" }\n \n void sc_c () [[arm::streaming_compatible]];\n-void sc_c () {} // { dg-error \"conflicting types\" }\n+void sc_c () {}\n \n void sc_d ();\n void sc_d () [[arm::streaming_compatible]] {} // { dg-error \"conflicting types\" }\n \n void sc_e () [[arm::streaming_compatible]] {}\n-void sc_e (); // { dg-error \"conflicting types\" }\n+void sc_e ();\n \n void sc_f () {}\n void sc_f () [[arm::streaming_compatible]]; // { dg-error \"conflicting types\" }\n@@ -27,19 +27,19 @@ extern void (*sc_h) (); // { dg-error \"c\n //----------------------------------------------------------------------------\n \n void s_a () [[arm::streaming]];\n-void s_a (); // { dg-error \"conflicting types\" }\n+void s_a ();\n \n void s_b ();\n void s_b () [[arm::streaming]]; // { dg-error \"conflicting types\" }\n \n void s_c () [[arm::streaming]];\n-void s_c () {} // { dg-error \"conflicting types\" }\n+void s_c () {}\n \n void s_d ();\n void s_d () [[arm::streaming]] {} // { dg-error \"conflicting types\" }\n \n void s_e () [[arm::streaming]] {}\n-void s_e (); // { dg-error \"conflicting types\" }\n+void s_e ();\n \n void s_f () {}\n void s_f () [[arm::streaming]]; // { dg-error \"conflicting types\" }\n@@ -118,7 +118,7 @@ void keyword_ok_5 () [[arm::streaming_co\n //----------------------------------------------------------------------------\n \n void keyword_contradiction_1 () __arm_streaming;\n-void keyword_contradiction_1 (); // { dg-error \"conflicting types\" }\n+void keyword_contradiction_1 ();\n \n void keyword_contradiction_2 ();\n void keyword_contradiction_2 () __arm_streaming; // { dg-error \"conflicting types\" }\n--- gcc/testsuite/gcc.target/aarch64/sme/za_state_1.c.jj\t2026-03-27 10:17:17.911269105 +0100\n+++ gcc/testsuite/gcc.target/aarch64/sme/za_state_1.c\t2026-04-21 13:05:01.711603896 +0200\n@@ -1,19 +1,19 @@\n // { dg-options \"\" }\n \n void shared_a () [[arm::inout(\"za\")]];\n-void shared_a (); // { dg-error \"conflicting types\" }\n+void shared_a ();\n \n void shared_b ();\n void shared_b () [[arm::inout(\"za\")]]; // { dg-error \"conflicting types\" }\n \n void shared_c () [[arm::inout(\"za\")]];\n-void shared_c () {} // { dg-error \"conflicting types\" }\n+void shared_c () {}\n \n void shared_d ();\n void shared_d () [[arm::inout(\"za\")]] {} // { dg-error \"conflicting types\" }\n \n void shared_e () [[arm::inout(\"za\")]] {}\n-void shared_e (); // { dg-error \"conflicting types\" }\n+void shared_e ();\n \n void shared_f () {}\n void shared_f () [[arm::inout(\"za\")]]; // { dg-error \"conflicting types\" }\n@@ -27,19 +27,19 @@ extern void (*shared_h) (); // { dg-erro\n //----------------------------------------------------------------------------\n \n void preserved_a () [[arm::preserves(\"za\")]];\n-void preserved_a (); // { dg-error \"conflicting types\" }\n+void preserved_a ();\n \n void preserved_b ();\n void preserved_b () [[arm::preserves(\"za\")]]; // { dg-error \"conflicting types\" }\n \n void preserved_c () [[arm::preserves(\"za\")]];\n-void preserved_c () {} // { dg-error \"conflicting types\" }\n+void preserved_c () {}\n \n void preserved_d ();\n void preserved_d () [[arm::preserves(\"za\")]] {} // { dg-error \"conflicting types\" }\n \n void preserved_e () [[arm::preserves(\"za\")]] {}\n-void preserved_e (); // { dg-error \"conflicting types\" }\n+void preserved_e ();\n \n void preserved_f () {}\n void preserved_f () [[arm::preserves(\"za\")]]; // { dg-error \"conflicting types\" }\n@@ -139,7 +139,7 @@ __arm_new(\"za\") void keyword_ok_6 () {}\n //----------------------------------------------------------------------------\n \n void keyword_conflict_1 () __arm_inout(\"za\");\n-void keyword_conflict_1 (); // { dg-error \"conflicting types\" }\n+void keyword_conflict_1 ();\n \n void keyword_conflict_2 ();\n void keyword_conflict_2 () __arm_inout(\"za\"); // { dg-error \"conflicting types\" }\n--- gcc/testsuite/gcc.target/aarch64/sme/za_state_2.c.jj\t2026-03-27 10:17:17.911269105 +0100\n+++ gcc/testsuite/gcc.target/aarch64/sme/za_state_2.c\t2026-04-21 13:12:03.818488094 +0200\n@@ -24,25 +24,25 @@ void new_za_f () {}\n void shared_a () [[arm::inout(\"za\")]]; // { dg-error \"conflicting types\" }\n \n void shared_b () [[arm::inout(\"za\")]];\n-[[arm::new(\"za\")]] void shared_b (); // { dg-error \"conflicting types\" }\n+[[arm::new(\"za\")]] void shared_b ();\n \n [[arm::new(\"za\")]] void shared_c ();\n void shared_c () [[arm::in(\"za\")]] {} // { dg-error \"conflicting types\" }\n \n void shared_d () [[arm::in(\"za\")]];\n-[[arm::new(\"za\")]] void shared_d () {} // { dg-error \"conflicting types\" }\n+[[arm::new(\"za\")]] void shared_d () {}\n \n [[arm::new(\"za\")]] void shared_e () {}\n void shared_e () [[arm::out(\"za\")]]; // { dg-error \"conflicting types\" }\n \n void shared_f () [[arm::out(\"za\")]] {}\n-[[arm::new(\"za\")]] void shared_f (); // { dg-error \"conflicting types\" }\n+[[arm::new(\"za\")]] void shared_f (); // { dg-error \"cannot apply attribute 'new' to 'shared_f' after the function has been defined\" }\n \n [[arm::new(\"za\")]] void shared_g () {}\n void shared_g () [[arm::preserves(\"za\")]]; // { dg-error \"conflicting types\" }\n \n void shared_h () [[arm::preserves(\"za\")]] {}\n-[[arm::new(\"za\")]] void shared_h (); // { dg-error \"conflicting types\" }\n+[[arm::new(\"za\")]] void shared_h (); // { dg-error \"cannot apply attribute 'new' to 'shared_h' after the function has been defined\" }\n \n //----------------------------------------------------------------------------\n \n","prefixes":[]}