{"id":2225634,"url":"http://patchwork.ozlabs.org/api/patches/2225634/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260421095947.868695-1-vinschen@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421095947.868695-1-vinschen@redhat.com>","list_archive_url":null,"date":"2026-04-21T09:59:47","name":"[net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"ad986d81dae8b735cb0ecf969195de99dc27aa4c","submitter":{"id":7921,"url":"http://patchwork.ozlabs.org/api/people/7921/?format=json","name":"Corinna Vinschen","email":"vinschen@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260421095947.868695-1-vinschen@redhat.com/mbox/","series":[{"id":500772,"url":"http://patchwork.ozlabs.org/api/series/500772/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500772","date":"2026-04-21T09:59:47","name":"[net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test","version":1,"mbox":"http://patchwork.ozlabs.org/series/500772/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225634/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225634/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=VrU4Zq8a;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0HsX5Rr9z1yGt\n\tfor ; Tue, 21 Apr 2026 20:00:16 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 66DDA60A53;\n\tTue, 21 Apr 2026 10:00:14 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id i18ls0TQ14QH; Tue, 21 Apr 2026 10:00:10 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 8C5C061167;\n\tTue, 21 Apr 2026 10:00:10 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 97A62259\n for ; Tue, 21 Apr 2026 10:00:08 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 7D81D40592\n for ; Tue, 21 Apr 2026 10:00:08 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id CbIE4Tvcuk8F for ;\n Tue, 21 Apr 2026 10:00:08 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id AD35140582\n for ; Tue, 21 Apr 2026 10:00:06 +0000 (UTC)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-MrF2qeuWNAixSeo9jOGlUQ-1; Tue,\n 21 Apr 2026 05:59:51 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8FF29180059B; Tue, 21 Apr 2026 09:59:50 +0000 (UTC)","from calimero.vinschen.de (unknown [10.44.32.45])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 48C353000C15; Tue, 21 Apr 2026 09:59:50 +0000 (UTC)","by calimero.vinschen.de (Postfix, from userid 500)\n id D56AAA80C62; Tue, 21 Apr 2026 11:59:47 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8C5C061167","OpenDKIM Filter v2.11.0 smtp4.osuosl.org AD35140582"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776765610;\n\tbh=DWNXyDIMPuVotJ3+gZWIDAoJFU9UkOtO5UaUXhqiC/c=;\n\th=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:Cc:From;\n\tb=VrU4Zq8aWC4pLJQhx/QsLQ9u4AJKXthP0Ue3txNp2swIBLsIw6VUsRbsjFtFdkzhn\n\t G4aE+WNZbekUcFmVre+dirihnLsf0ZiHc6KynTBIh1hudF8am2PZijZ1LzWVO9hf9k\n\t K3ziTup9gAEhFWFg9e9YlaIh3QD44KR2/BGb7d2I/nyFgnDixXaExNO6Nzn/6Lq6xD\n\t axMDj2HMREfCZvP+GAOsYH3VjwOdfqh8iGR4QdiRZjQigjdckn1vNJ2gxsf2stbWhr\n\t P2a117iMp16VCYEJphpSL47zNPmt7ar0S+xs4gAPjmoCJCGuA+ra/ZgEGq+gyArRry\n\t hXkyB8guV1E+A==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=vinschen@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org AD35140582","X-MC-Unique":"MrF2qeuWNAixSeo9jOGlUQ-1","X-Mimecast-MFC-AGG-ID":"MrF2qeuWNAixSeo9jOGlUQ_1776765590","From":"Corinna Vinschen ","To":"intel-wired-lan@osuosl.org,\n\tnetdev@vger.kernel.org","Date":"Tue, 21 Apr 2026 11:59:47 +0200","Message-ID":"<20260421095947.868695-1-vinschen@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-MFC-PROC-ID":"zdLpLXoYkrboHCgBTU5honuW_hyODXJa9tLeGHZFuUk_1776765590","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1776765605;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=DWNXyDIMPuVotJ3+gZWIDAoJFU9UkOtO5UaUXhqiC/c=;\n b=P1NkOs9Qmd5QUj6elpCzXFR6Fpp/fdILV29QRA9Vm3RDBaU9CAa3GV0TflM9C5sErwhG0M\n T26/ttzlkD/AqF9acYNMUIk9dRyEXi+Zvcax15Y3w1HVcanC5TmJx+ykzZJLrYazcYgdJj\n g8jdV0cK1TpSMSOudTHZBpYYUnXhNxU=","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp4.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=P1NkOs9Q"],"Subject":"[Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion: drop\n duplicate ether_addr_equal() test","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Corinna Vinschen ,\n Jose Ignacio Tornos Martinez ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"This is just a simple cleanup fix. Commit 35a2443d0910f (\"iavf: Add\nwaiting for response from PF in set mac\") introduced a duplicate\nether_addr_equal() check, so the current code tests the new MAC twice\nagainst the former MAC.\n\nRemove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b\n(\"iavf: fix MAC address setting for VFs when filter is rejected\")\n\nSigned-off-by: Corinna Vinschen \nFixes: 35a2443d0910f (\"iavf: Add waiting for response from PF in set mac\")\n---\n drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\nindex a52c100dcbc5..9b8e7e4376c2 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n@@ -2579,13 +2579,11 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter,\n \tcase VIRTCHNL_OP_ADD_ETH_ADDR:\n \t\tif (!v_retval)\n \t\t\tiavf_mac_add_ok(adapter);\n-\t\tif (!ether_addr_equal(netdev->dev_addr, adapter->hw.mac.addr))\n-\t\t\tif (!ether_addr_equal(netdev->dev_addr,\n-\t\t\t\t\t adapter->hw.mac.addr)) {\n-\t\t\t\tnetif_addr_lock_bh(netdev);\n-\t\t\t\teth_hw_addr_set(netdev, adapter->hw.mac.addr);\n-\t\t\t\tnetif_addr_unlock_bh(netdev);\n-\t\t\t}\n+\t\tif (!ether_addr_equal(netdev->dev_addr, adapter->hw.mac.addr)) {\n+\t\t\tnetif_addr_lock_bh(netdev);\n+\t\t\teth_hw_addr_set(netdev, adapter->hw.mac.addr);\n+\t\t\tnetif_addr_unlock_bh(netdev);\n+\t\t}\n \t\twake_up(&adapter->vc_waitqueue);\n \t\tbreak;\n \tcase VIRTCHNL_OP_GET_STATS: {\n","prefixes":["net"]}