{"id":2225558,"url":"http://patchwork.ozlabs.org/api/patches/2225558/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260421073646.144712-3-tzimmermann@suse.de/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421073646.144712-3-tzimmermann@suse.de>","list_archive_url":null,"date":"2026-04-21T07:29:06","name":"[2/5] drm/tegra: fbdev: Remove offset into framebuffer memory","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8b9ee49ecd9794058a923cfa64791fdf3b81d81d","submitter":{"id":74535,"url":"http://patchwork.ozlabs.org/api/people/74535/?format=json","name":"Thomas Zimmermann","email":"tzimmermann@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260421073646.144712-3-tzimmermann@suse.de/mbox/","series":[{"id":500750,"url":"http://patchwork.ozlabs.org/api/series/500750/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=500750","date":"2026-04-21T07:29:04","name":"drm/tegra: fbdev: Use client buffers","version":1,"mbox":"http://patchwork.ozlabs.org/series/500750/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225558/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225558/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13833-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.130","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.de","smtp-out1.suse.de;\n\tnone"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0DhY5zB7z1yCv\n\tfor ; Tue, 21 Apr 2026 17:37:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 1C5723000FFE\n\tfor ; Tue, 21 Apr 2026 07:37:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1E0C537C0EB;\n\tTue, 21 Apr 2026 07:37:14 +0000 (UTC)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB6A2BE05F\n\tfor ; Tue, 21 Apr 2026 07:37:12 +0000 (UTC)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out1.suse.de (Postfix) with ESMTPS id AF22B6A80A;\n\tTue, 21 Apr 2026 07:36:54 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 540D0593AF;\n\tTue, 21 Apr 2026 07:36:54 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid gJcRExYp52lgMQAAD6G6ig\n\t(envelope-from ); Tue, 21 Apr 2026 07:36:54 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776757033; cv=none;\n b=kyaIJ4ANq1zBXzRKqsUUa2JfPbZl3mCbqWxDUBZfr7cvE93a7PsjaSNvkGcOhCyEVuta+69sjYRSdSeYh1+fadDlW0HdX1F7L3LNGLN+XRlnQYlw9GXHtJXU3C9MAeFgNIxbT7YnM7I1996X8yvx5NzdmOLKjtlziqSuxPmDoPc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776757033; c=relaxed/simple;\n\tbh=ki1HgHKY8ZoIWHoe97XnbsILNU02SDwYyh4uE+QU3ew=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=fI5KTLAlqgyEXn3qVj+csjwu1br/LcdA2166UuLREaGOg6QF8e+0ezTM4P3GFjSqbJYhNJtoJRifcQKue1SLQtX2YJ8UaHBNJ7hge9bEvCWg8xDml7WEfBuYTyRJUt/iVhTm3j1l96rtKaFWv6+puLS7/mVX4cRhn1XR9JAIe4I=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de;\n spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130","From":"Thomas Zimmermann ","To":"thierry.reding@gmail.com,\n\tmperttunen@nvidia.com,\n\tairlied@gmail.com,\n\tsimona@ffwll.ch,\n\tjonathanh@nvidia.com","Cc":"dri-devel@lists.freedesktop.org,\n\tlinux-tegra@vger.kernel.org,\n\tThomas Zimmermann ,\n\tstable@vger.kernel.org","Subject":"[PATCH 2/5] drm/tegra: fbdev: Remove offset into framebuffer memory","Date":"Tue, 21 Apr 2026 09:29:06 +0200","Message-ID":"<20260421073646.144712-3-tzimmermann@suse.de>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260421073646.144712-1-tzimmermann@suse.de>","References":"<20260421073646.144712-1-tzimmermann@suse.de>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Rspamd-Pre-Result":["action=no action;\n\tmodule=replies;\n\tMessage is reply to one we originated","action=no action;\n\tmodule=replies;\n\tMessage is reply to one we originated"],"X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-4.00 / 50.00];\n\tREPLY(-4.00)[];\n\tTAGGED_RCPT(0.00)[]","X-Rspamd-Queue-Id":"AF22B6A80A","X-Rspamd-Action":"no action","X-Spam-Flag":"NO","X-Spam-Score":"-4.00","X-Spam-Level":""},"content":"The screen_buffer field in struct fb_info contains the kernel address\nof the first byte of framebuffer memory. Do not add the display offset.\nThis offset only describes scrolling during scanout.\n\nSigned-off-by: Thomas Zimmermann \nFixes: de2ba664c30f (\"gpu: host1x: drm: Add memory manager and fb\")\nCc: dri-devel@lists.freedesktop.org\nCc: linux-tegra@vger.kernel.org\nCc: # v3.10+\n---\n drivers/gpu/drm/tegra/fbdev.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c\nindex 19e39fa54bfa..793849199783 100644\n--- a/drivers/gpu/drm/tegra/fbdev.c\n+++ b/drivers/gpu/drm/tegra/fbdev.c\n@@ -76,7 +76,6 @@ int tegra_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,\n \tstruct fb_info *info = helper->info;\n \tunsigned int bytes_per_pixel;\n \tstruct drm_framebuffer *fb;\n-\tunsigned long offset;\n \tstruct tegra_bo *bo;\n \tsize_t size;\n \tint err;\n@@ -115,9 +114,6 @@ int tegra_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,\n \n \tdrm_fb_helper_fill_info(info, helper, sizes);\n \n-\toffset = info->var.xoffset * bytes_per_pixel +\n-\t\t info->var.yoffset * fb->pitches[0];\n-\n \tif (bo->pages) {\n \t\tbo->vaddr = vmap(bo->pages, bo->num_pages, VM_MAP,\n \t\t\t\t pgprot_writecombine(PAGE_KERNEL));\n@@ -129,9 +125,9 @@ int tegra_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,\n \t}\n \n \tinfo->flags |= FBINFO_VIRTFB;\n-\tinfo->screen_buffer = bo->vaddr + offset;\n+\tinfo->screen_buffer = bo->vaddr;\n \tinfo->screen_size = size;\n-\tinfo->fix.smem_start = (unsigned long)(bo->iova + offset);\n+\tinfo->fix.smem_start = (unsigned long)(bo->iova);\n \tinfo->fix.smem_len = size;\n \n \treturn 0;\n","prefixes":["2/5"]}