{"id":2225522,"url":"http://patchwork.ozlabs.org/api/patches/2225522/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/bb0b6d6c4543238c38d5d29a776d0674a8c0c180.1776752750.git.chleroy@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<bb0b6d6c4543238c38d5d29a776d0674a8c0c180.1776752750.git.chleroy@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/bb0b6d6c4543238c38d5d29a776d0674a8c0c180.1776752750.git.chleroy@kernel.org/","date":"2026-04-21T06:26:08","name":"powerpc/8xx: Fix interrupt mask in cpm1_gpiochip_add16()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"789b872ab268c2a1292ce909961d135319a9d648","submitter":{"id":92089,"url":"http://patchwork.ozlabs.org/api/people/92089/?format=json","name":"Christophe Leroy (CS GROUP)","email":"chleroy@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/bb0b6d6c4543238c38d5d29a776d0674a8c0c180.1776752750.git.chleroy@kernel.org/mbox/","series":[{"id":500742,"url":"http://patchwork.ozlabs.org/api/series/500742/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=500742","date":"2026-04-21T06:26:08","name":"powerpc/8xx: Fix interrupt mask in cpm1_gpiochip_add16()","version":1,"mbox":"http://patchwork.ozlabs.org/series/500742/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225522/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2225522/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linuxppc-dev+bounces-19867-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=N8sOAJN/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19867-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=N8sOAJN/;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0C9S221qz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 16:28:43 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g0C9Q62hcz2yfS;\n\tTue, 21 Apr 2026 16:28:42 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g0C9P5lGYz2xc8\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 21 Apr 2026 16:28:41 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id B90996011F;\n\tTue, 21 Apr 2026 06:28:38 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 806D7C2BCB0;\n\tTue, 21 Apr 2026 06:28:36 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776752922;\n\tcv=none;\n b=Wo9vbwh2YwhHUiTRbN+GWkFUK9UgCt2cV4iHvyMIabcrnV7G3jlWt56lgfZcffehMFwesG7tGEkAEpmfVU7xbZBrW1LzOdLdxmcz6n9bDldBXaSiZ4DZrSbMuE+gwYa19j6CQcQrGGEOkQ5xAtGCHL/kHra+1Zs1z8Ev5j3bDCD1LYvOSUKTmi778Bv7otzNrYjN3Cl9m6yNlmp5WpGzK7o/bQclBhaes3QmxXxVJew+8Vqece8afjkFpPMn7tiCYwAmaLF8E8GDPf+/Q4EmKu/qWtOXVBb4q86caCKrSTTZ1Mv040Ve/40ehwWwZUAlGIaF/xBwgeJmd/31MDgn3g==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776752922; c=relaxed/relaxed;\n\tbh=c0Maqhoq8dLjZM4LdYz0ZlFUgDU62xwhwPlaS3BjoiE=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=W2+SpOde+TC4VXYCioz0Y6bHCKB9jmwhVIxpO/NFz8Q2iCcJjHbkeppibxWSBjfazfHEPkEK1WyJF4PPALGnl4vWFzzXEn+DTxkBa0MG+M3k7+sV/n0ju3PRpM8f5WQHcFWos19csDdh2nw1o3dwCrXDMe0fGYoeed0PRqIO+NLxA0G0GfCv6g+mU14+CNe03txl1kCZvtRlUkeoDjUuKcla1DXcu7mFiJqPgDx9/rJu0CIlrTmMtg2uP61rPCtbV0SWR2PjMAl85QOXC3B6QurY0w8J/aOVVbHWb5DJStuRBcSJ/oYOsUqnXrJKewbk25TluDhmEjgVb9+Bzr0R6g==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=N8sOAJN/; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=chleroy@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776752918;\n\tbh=dHS0gPZI0H1Mm3DBnxFHJRq1QTSVEk6PBiQCtoOUiRM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=N8sOAJN/m9DLUmvktUQYI5VhDyt7bWPL6cUKLY0QqBIrL4bf2hm5v2ODzNt7waL+8\n\t V9iJniP7ewPdb6UGrS5rRj3t4dk+feOrWRnyu6Gp+bvsNn3zDLHrIQCI5HEldYTOzs\n\t cLOotQOJzgRfVMQN8VJlZMEo+VQ1RNtkhbvK4BWkNVWuwqH00L8Cl0WdaH6UTilDK1\n\t iI6gvT4YzDpx2PtQiqg+KZaJAuf5ge7geOpNDNY1nQGlvOF5fY53EMaHfbg7KJU2vH\n\t Ry50Q+UQLUbA7ACikWMgr/9jFio3B3xn8cG5H+5nQoaHfdAC3C3NFKB6pFMqD3bLQU\n\t na9oqY+TaQ0Cg==","From":"\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>","To":"Michael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>","Cc":"\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tlinux-kernel@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org","Subject":"[PATCH] powerpc/8xx: Fix interrupt mask in cpm1_gpiochip_add16()","Date":"Tue, 21 Apr 2026 08:26:08 +0200","Message-ID":"\n <bb0b6d6c4543238c38d5d29a776d0674a8c0c180.1776752750.git.chleroy@kernel.org>","X-Mailer":"git-send-email 2.49.0","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1358; i=chleroy@kernel.org;\n h=from:subject:message-id; bh=dHS0gPZI0H1Mm3DBnxFHJRq1QTSVEk6PBiQCtoOUiRM=;\n b=owGbwMvMwCV2d0KB2p7V54MZT6slMWQ+l2gUfvrA0u7+nc1sGjaLFmSs0NfeNPmijkf1pIBDL\n fWXb+Yd6ihlYRDjYpAVU2Q5/p9714yuL6n5U3fpw8xhZQIZwsDFKQATOSTA8L+m9cWqk7qCU41W\n Z0xf4lZXJ3n909YND3tFjvo8truUvaedkeHMm7+MNQKsT707n3ufyHTfffLmUp63/CkrpzQe1jc\n tv8QOAA==","X-Developer-Key":"i=chleroy@kernel.org; a=openpgp;\n fpr=10FFE6F8B390DE17ACC2632368A92FEB01B8DD78","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Allthough fsl,cpm1-gpio-irq-mask always contains a 16 bits value,\nit is a standard u32 OF property as documented in\nDocumentation/devicetree/bindings/soc/fsl/cpm_qe/gpio.txt\n\nThe driver erroneously uses of_property_read_u16() leading to a\nmask which is always 0.\n\nFix it by using of_property_read_u32() instead.\n\nFixes: 726bd223105c (\"powerpc/8xx: Adding support of IRQ in MPC8xx GPIO\")\nSigned-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>\n---\n arch/powerpc/platforms/8xx/cpm1.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/8xx/cpm1.c b/arch/powerpc/platforms/8xx/cpm1.c\nindex 7433be7d66ee..f00734f0590c 100644\n--- a/arch/powerpc/platforms/8xx/cpm1.c\n+++ b/arch/powerpc/platforms/8xx/cpm1.c\n@@ -477,7 +477,7 @@ int cpm1_gpiochip_add16(struct device *dev)\n \tstruct device_node *np = dev->of_node;\n \tstruct cpm1_gpio16_chip *cpm1_gc;\n \tstruct gpio_chip *gc;\n-\tu16 mask;\n+\tu32 mask;\n \n \tcpm1_gc = devm_kzalloc(dev, sizeof(*cpm1_gc), GFP_KERNEL);\n \tif (!cpm1_gc)\n@@ -485,7 +485,7 @@ int cpm1_gpiochip_add16(struct device *dev)\n \n \tspin_lock_init(&cpm1_gc->lock);\n \n-\tif (!of_property_read_u16(np, \"fsl,cpm1-gpio-irq-mask\", &mask)) {\n+\tif (!of_property_read_u32(np, \"fsl,cpm1-gpio-irq-mask\", &mask)) {\n \t\tint i, j;\n \n \t\tfor (i = 0, j = 0; i < 16; i++)\n","prefixes":[]}