{"id":2225416,"url":"http://patchwork.ozlabs.org/api/patches/2225416/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260421022044.1217503-4-songmuchun@bytedance.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260421022044.1217503-4-songmuchun@bytedance.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260421022044.1217503-4-songmuchun@bytedance.com/","date":"2026-04-21T02:20:43","name":"[v3,3/4] mm/sparse-vmemmap: Fix DAX vmemmap accounting with optimization","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"174c4eeb4a02ae8e4323adb4cf056d6c17c95c62","submitter":{"id":78930,"url":"http://patchwork.ozlabs.org/api/people/78930/?format=json","name":"Muchun Song","email":"songmuchun@bytedance.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260421022044.1217503-4-songmuchun@bytedance.com/mbox/","series":[{"id":500709,"url":"http://patchwork.ozlabs.org/api/series/500709/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=500709","date":"2026-04-21T02:20:40","name":"mm: Fix vmemmap optimization accounting and initialization","version":3,"mbox":"http://patchwork.ozlabs.org/series/500709/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225416/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225416/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bytedance.com header.i=@bytedance.com\n header.a=rsa-sha256 header.s=google header.b=QGR7md10;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19860-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::42b\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=bytedance.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bytedance.com header.i=@bytedance.com\n header.a=rsa-sha256 header.s=google header.b=QGR7md10;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=bytedance.com\n (client-ip=2607:f8b0:4864:20::42b; helo=mail-pf1-x42b.google.com;\n envelope-from=songmuchun@bytedance.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g05hF50Lcz1yHB\n\tfor ; Tue, 21 Apr 2026 12:21:33 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g05h73TBHz307K;\n\tTue, 21 Apr 2026 12:21:27 +1000 (AEST)","from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com\n [IPv6:2607:f8b0:4864:20::42b])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g05h65Gl4z2xT6\n\tfor ; Tue, 21 Apr 2026 12:21:26 +1000 (AEST)","by mail-pf1-x42b.google.com with SMTP id\n d2e1a72fcca58-82fb2d0c5d1so1090691b3a.0\n for ;\n Mon, 20 Apr 2026 19:21:26 -0700 (PDT)","from n232-176-004.byted.org ([240e:83:200::340])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f932dabd4sm11538780b3a.51.2026.04.20.19.21.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 19:21:23 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776738087;\n\tcv=none;\n b=TogBZ8nsNfgXUdkc0JbRDA+4wgH9Qy26QiTyZZaIWUjQuck0mOqCPbJ8/TrU4K+blf4K2N/bBcGJqDKlPv9rvzda7v+ALgQds+Zk+CQphSDRimMjGCJflDvtu5MLE+KmSCA+QcgiOWI0AODyX9q/2sdbevqJKkEEJywQlyAfqIGFup6BdLimNvev/fe7eA1BeDfi01HQzYwTjS8e3VgUWiuMh9UBW2v7Cyz7veGVl9uSxND+InADlHoOD9xBecK2MlxkBlDvWS/aXNTWuIBFOOl9v7bS7lPWxZROxsVEALEhuQkZ8j1MGjdmjn8LDiAja33kh+4Ondz8rumzGLPt7w==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776738087; c=relaxed/relaxed;\n\tbh=yQT9sgIl1x5UPRFaiEeld1v2vJgPbOqztRRBh4ZUxsY=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=Lwd/NN6zY0Q464N4DxhhIOZFgfg+mRRhT7paWGRzDzYg4MGytPIV6BAlGI4He9u0DbqK1T5jE4sJ4oOBe32GxSd1k2uPOF/y3zNyTPoPPaoczh7sEEDSVM98zPxuzN7xgYaylzzRNewCW2WAp7AKFwTx5Q7cmfKHlRBKK7DE0hTG9I4sIHLwnh2OK09PrL/OAjAI5tJ3VInB+wdMxawnMbDBJzsvqO28ajLkmE2Qvma3Pi0PQEUYxNWxqLJil+0TWa9nIWVUjRAqzRNNf4POh5ippDnZ+U4Mx6M0OCHRmalVmKcBNLugqj/piFVqJizEUadaiUdrdXcKOLPe5Y0gBA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=bytedance.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=bytedance.com header.i=@bytedance.com\n header.a=rsa-sha256 header.s=google header.b=QGR7md10; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::42b; helo=mail-pf1-x42b.google.com;\n envelope-from=songmuchun@bytedance.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=bytedance.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bytedance.com; s=google; t=1776738084; x=1777342884;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yQT9sgIl1x5UPRFaiEeld1v2vJgPbOqztRRBh4ZUxsY=;\n b=QGR7md10ySFJw0y9Rlc8HL1+qdh34O3QGHBRkXr+Zk5NNG+u7I++55pjIgexNq0rUh\n SFHWsLex1Oq8Y6bSYoH8e8C5zOqi/b/BODp3+xaR7LW7utxGdCB5RADFPX7CZcU3kkx4\n XEIN+DF/PbXEYoDyBI0ij2jsWMd6Jy2oc7F7bBorYOrRgFBK1puQiuz2o+nOSvrGdfxM\n vQuG8NxFGkCUV36kFA4OEUP1Pai8Zyna1nB2QTKLlDXmqx3UEmFsUd7nhtJi3Tk+uJSm\n mSDUZ0lbpUH6JpjKiYvWhdbYDAHS9NTYLBzdwF/JSzkU02fg4S/yhMJVvcYbPLHMItWO\n CJ1g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776738084; x=1777342884;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yQT9sgIl1x5UPRFaiEeld1v2vJgPbOqztRRBh4ZUxsY=;\n b=E5tXzU3NQGS4tJO9i1m5HyOj9dmuAVsv1Yel/1h5YEcuPQ3VrNaJFYCMTo2mlaYsFC\n FoSy3v7yTOBOLpG1+lBdmQ/TcD6tVczYIOs/2y1OE4b/6nopRrU/o630YJ8Z2xY9BaTj\n 3okGXgWw2b1hZTULeLtWxZIy9F+/yRRbQW0pOPVr4eu4R43bPZcWdWmkEeS8PLxzlIex\n j+QKG3VWOpzGUIle+KMlq8roEM/ycjQW/UdUZaaf6KOAxgY9fd4YlMCMxxX/VTMjCGVi\n Nx6g/GQzcOoi8jk+7/v3I5AXJviLB5nzLktheRZswFPhaL8FmRTT5z5g5Rbd2ctnpsKC\n Jzvw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/0F/HrshVdzR83YELk0Srj8rBJBMwF8s4i1W0hp9pABMGWdwripJ7gSkwpYl6hRUCZCaXHa77IyhPRJ1Y=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0YydGvprl4hIR4wcjSAdx/orwyHVsQtsMDwbnee4o8AiyG50ox7Y\n\tLp7yq2p1okV9OVcm7rYAsRe8ef05oOTcSCM2uhcDxgMQahSpGupqZRbmdRN+E4FB454=","X-Gm-Gg":"AeBDietmOLF1uorLxtIGtqOLwmm02n4j+cU3wqDhIg9d5e5ro48E3KShlNS/agpoUn9\n\tNqo0v+XbYBqZE9UDDCwfF3sUxacupvDBnUJV5qAdV6gqG6ramn3kW/gFKI9eKToZZmq3vmzmYCr\n\tu4lIioVAcq2uy07yljiSwNwnUWyVv27Be8i13lh3uh9+DYbAb1dFSXUmchzDyQWTQjGNLFH7X0x\n\t/Fzoo69zvWBeyVGlyiqEIXyEkr6z6L4DglbEL1Z629aq61Syo3Cjdq1iiV1QOrDLUk2WKLhQNZv\n\tSbKuQTSS4lMbOB1CMIlC2FsNITxIFHeZEkNxjpCJgO1ybYShELuUuYL/Qe25pFIOP4OVGaJqyt4\n\tkV24tO2Yt5Q6x5knSzBBHgvbm80JhVyhE5QdrL9RlgP1p3eXTCnWVC/xceSC/EgLP5XP3OlJbcZ\n\te5WOQIUj7mj18sh+mE30l2E63zXQiu","X-Received":"by 2002:a05:6a00:be8:b0:82f:9a88:9092 with SMTP id\n d2e1a72fcca58-82f9a889558mr7527975b3a.33.1776738084191;\n Mon, 20 Apr 2026 19:21:24 -0700 (PDT)","From":"Muchun Song ","To":"Andrew Morton ,\n\tDavid Hildenbrand ,\n\tMuchun Song ,\n\tOscar Salvador ,\n\tMichael Ellerman ,\n\tMadhavan Srinivasan ","Cc":"Muchun Song ,\n\tMike Rapoport ,\n\tLorenzo Stoakes ,\n\t\"Liam R . Howlett\" ,\n\tVlastimil Babka ,\n\tSuren Baghdasaryan ,\n\tMichal Hocko ,\n\tNicholas Piggin ,\n\tChristophe Leroy ,\n\taneesh.kumar@linux.ibm.com,\n\tjoao.m.martins@oracle.com,\n\tlinux-mm@kvack.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH v3 3/4] mm/sparse-vmemmap: Fix DAX vmemmap accounting with\n optimization","Date":"Tue, 21 Apr 2026 10:20:43 +0800","Message-Id":"<20260421022044.1217503-4-songmuchun@bytedance.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20260421022044.1217503-1-songmuchun@bytedance.com>","References":"<20260421022044.1217503-1-songmuchun@bytedance.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"When vmemmap optimization is enabled for DAX, the nr_memmap_pages\ncounter in /proc/vmstat is incorrect. The current code always accounts\nfor the full, non-optimized vmemmap size, but vmemmap optimization\nreduces the actual number of vmemmap pages by reusing tail pages. This\ncauses the system to overcount vmemmap usage, leading to inaccurate\npage statistics in /proc/vmstat.\n\nFix this by introducing section_vmemmap_pages(), which returns the exact\nvmemmap page count for a given pfn range based on whether optimization\nis in effect.\n\nFixes: 15995a352474 (\"mm: report per-page metadata information\")\nSigned-off-by: Muchun Song \nAcked-by: Mike Rapoport (Microsoft) \n---\n mm/sparse-vmemmap.c | 32 ++++++++++++++++++++++++++++----\n 1 file changed, 28 insertions(+), 4 deletions(-)","diff":"diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c\nindex 40290fbc1db4..05e3e2b94e32 100644\n--- a/mm/sparse-vmemmap.c\n+++ b/mm/sparse-vmemmap.c\n@@ -652,6 +652,29 @@ void offline_mem_sections(unsigned long start_pfn, unsigned long end_pfn)\n \t}\n }\n \n+static int __meminit section_vmemmap_pages(unsigned long pfn, unsigned long nr_pages,\n+\t\t\t\t\t struct vmem_altmap *altmap,\n+\t\t\t\t\t struct dev_pagemap *pgmap)\n+{\n+\tunsigned int order = pgmap ? pgmap->vmemmap_shift : 0;\n+\tunsigned long pages_per_compound = 1L << order;\n+\n+\tVM_WARN_ON_ONCE(!IS_ALIGNED(pfn | nr_pages, min(pages_per_compound,\n+\t\t\t\t\t\t\tPAGES_PER_SECTION)));\n+\tVM_WARN_ON_ONCE(pfn_to_section_nr(pfn) != pfn_to_section_nr(pfn + nr_pages - 1));\n+\n+\tif (!vmemmap_can_optimize(altmap, pgmap))\n+\t\treturn DIV_ROUND_UP(nr_pages * sizeof(struct page), PAGE_SIZE);\n+\n+\tif (order < PFN_SECTION_SHIFT)\n+\t\treturn VMEMMAP_RESERVE_NR * nr_pages / pages_per_compound;\n+\n+\tif (IS_ALIGNED(pfn, pages_per_compound))\n+\t\treturn VMEMMAP_RESERVE_NR;\n+\n+\treturn 0;\n+}\n+\n static struct page * __meminit populate_section_memmap(unsigned long pfn,\n \t\tunsigned long nr_pages, int nid, struct vmem_altmap *altmap,\n \t\tstruct dev_pagemap *pgmap)\n@@ -659,7 +682,7 @@ static struct page * __meminit populate_section_memmap(unsigned long pfn,\n \tstruct page *page = __populate_section_memmap(pfn, nr_pages, nid, altmap,\n \t\t\t\t\t\t pgmap);\n \n-\tmemmap_pages_add(DIV_ROUND_UP(nr_pages * sizeof(struct page), PAGE_SIZE));\n+\tmemmap_pages_add(section_vmemmap_pages(pfn, nr_pages, altmap, pgmap));\n \n \treturn page;\n }\n@@ -670,7 +693,7 @@ static void depopulate_section_memmap(unsigned long pfn, unsigned long nr_pages,\n \tunsigned long start = (unsigned long) pfn_to_page(pfn);\n \tunsigned long end = start + nr_pages * sizeof(struct page);\n \n-\tmemmap_pages_add(-1L * (DIV_ROUND_UP(nr_pages * sizeof(struct page), PAGE_SIZE)));\n+\tmemmap_pages_add(-section_vmemmap_pages(pfn, nr_pages, altmap, pgmap));\n \tvmemmap_free(start, end, altmap);\n }\n \n@@ -679,9 +702,10 @@ static void free_map_bootmem(struct page *memmap, struct vmem_altmap *altmap,\n {\n \tunsigned long start = (unsigned long)memmap;\n \tunsigned long end = (unsigned long)(memmap + PAGES_PER_SECTION);\n+\tunsigned long pfn = page_to_pfn(memmap);\n \n-\tmemmap_boot_pages_add(-1L * (DIV_ROUND_UP(PAGES_PER_SECTION * sizeof(struct page),\n-\t\t\t\t\t\t PAGE_SIZE)));\n+\tmemmap_boot_pages_add(-section_vmemmap_pages(pfn, PAGES_PER_SECTION,\n+\t\t\t\t\t\t altmap, pgmap));\n \tvmemmap_free(start, end, NULL);\n }\n \n","prefixes":["v3","3/4"]}