{"id":2225387,"url":"http://patchwork.ozlabs.org/api/patches/2225387/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260420220804.71564-3-heinrich.schuchardt@canonical.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420220804.71564-3-heinrich.schuchardt@canonical.com>","list_archive_url":null,"date":"2026-04-20T22:08:02","name":"[2/4] cmd/acpi: add optional index parameter to acpi dump","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d13213d9d23f2f717c28479b115b80280cac1707","submitter":{"id":82181,"url":"http://patchwork.ozlabs.org/api/people/82181/?format=json","name":"Heinrich Schuchardt","email":"heinrich.schuchardt@canonical.com"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260420220804.71564-3-heinrich.schuchardt@canonical.com/mbox/","series":[{"id":500693,"url":"http://patchwork.ozlabs.org/api/series/500693/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500693","date":"2026-04-20T22:08:00","name":"acpi: handle duplicate tables in acpi dump","version":1,"mbox":"http://patchwork.ozlabs.org/series/500693/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225387/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225387/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=YcMcsLHu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"YcMcsLHu\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com","phobos.denx.de; spf=pass\n smtp.mailfrom=heinrich.schuchardt@canonical.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g004Y74Ztz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 08:08:45 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0B6B784505;\n\tTue, 21 Apr 2026 00:08:22 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 8B73B844F4; Tue, 21 Apr 2026 00:08:14 +0200 (CEST)","from smtp-relay-canonical-0.canonical.com\n (smtp-relay-canonical-0.canonical.com [185.125.188.120])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 704F5844E5\n for <u-boot@lists.denx.de>; Tue, 21 Apr 2026 00:08:07 +0200 (CEST)","from LT03.fritz.box (ip-176-199-115-125.um44.pools.vodafone-ip.de\n [176.199.115.125])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id DB4DB40D85;\n Mon, 20 Apr 2026 22:08:06 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776722887;\n bh=0/iQs213IY7C2t9c7xtR5FjFqFW06mSlSrpy5PTDLus=;\n h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=YcMcsLHum9trxPKFdqDysl362ozpDLq4ujiIGo0B4Qgfn3FAB4vJ1m2/mGrEF4kJ3\n j5HMPVPSgg2QSe7y2yn7jalsJoCn8BjrWcu4vr5tnnDoarXhqpYkycvQxOPyWA9ZMu\n JD0wCAgs5IfiKzNxAX0hdK1tImy8gO8NurublLjYow8hly2+2/b8fOIo8ue2NHXpYa\n n1Tny8Fil1xpPI+4bIk01ijKShpTjFEe7aE1LPDaNWPfEbvGU52zCqqMJy16yQ4b3R\n 5My/X8rx3vz7fQjM5lFO01BQPLKLahH2CnKJaM1e2r5oZSMT69y6b+btRlZQq0jCib\n nVigJJB0qsyhWIaiP2W8xxYPjIMe9jp4yK0l5ypQjewUWwi6nkIBsQhz/rOdhlrk3H\n bPHWY5VgFzrlMQ2Q0hlD3m9/4/txdr4RIvy0GpsU5QPTFLBOW/DISKWevvxy45JcIr\n wA4aEU8x+pCg9dNg4UyjgVZGyOHnmjiRfasdtVCPYd0oLLJlcmI/swoD/fN9dM+HG0\n GzuitGa+qAbThquu1hExH8TCktVFqHQQu3Z2XTKA0NPOGz/hzkyFVdMrDjkdcqFRsP\n mdduZjltbQOFj5cZSBmxtyjNAYKaIKSR2kIF9O9HjBUGNe3TBMN140sB4HXHa8Xhat\n dKgNotj6xdNLXst7KJJUxKLs=","From":"Heinrich Schuchardt <heinrich.schuchardt@canonical.com>","To":"Simon Glass <sjg@chromium.org>","Cc":"Tom Rini <trini@konsulko.com>, Bin Meng <bmeng.cn@gmail.com>,\n u-boot@lists.denx.de,\n Heinrich Schuchardt <heinrich.schuchardt@canonical.com>","Subject":"[PATCH 2/4] cmd/acpi: add optional index parameter to acpi dump","Date":"Tue, 21 Apr 2026 00:08:02 +0200","Message-ID":"<20260420220804.71564-3-heinrich.schuchardt@canonical.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260420220804.71564-1-heinrich.schuchardt@canonical.com>","References":"<20260420220804.71564-1-heinrich.schuchardt@canonical.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Add an optional index parameter defaulting to the `acpi dump`\nsub-command.\n\nSigned-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>\n---\n cmd/acpi.c | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)","diff":"diff --git a/cmd/acpi.c b/cmd/acpi.c\nindex a88cd995460..3aba9ed7a16 100644\n--- a/cmd/acpi.c\n+++ b/cmd/acpi.c\n@@ -12,6 +12,7 @@\n #include <asm/acpi_table.h>\n #include <asm/global_data.h>\n #include <linux/errno.h>\n+#include <limits.h>\n #include <dm/acpi.h>\n \n DECLARE_GLOBAL_DATA_PTR;\n@@ -51,11 +52,11 @@ static void dump_hdr(struct acpi_table_header *hdr, bool chksums)\n \t}\n }\n \n-static int dump_table_name(const char *sig)\n+static int dump_table_name(const char *sig, ulong idx)\n {\n \tstruct acpi_table_header *hdr;\n \n-\thdr = acpi_find_table(sig, 0);\n+\thdr = acpi_find_table(sig, idx);\n \tif (!hdr)\n \t\treturn -ENOENT;\n \tprintf(\"%.*s @ %16lx\\n\", ACPI_NAME_LEN, hdr->signature,\n@@ -183,9 +184,11 @@ static int do_acpi_dump(struct cmd_tbl *cmdtp, int flag, int argc,\n {\n \tconst char *name;\n \tchar sig[ACPI_NAME_LEN];\n+\tchar *endp;\n+\tulong idx = 0;\n \tint ret;\n \n-\tif (argc < 2)\n+\tif (argc < 2 || argc > 3)\n \t\treturn CMD_RET_USAGE;\n \n \tname = argv[1];\n@@ -193,8 +196,12 @@ static int do_acpi_dump(struct cmd_tbl *cmdtp, int flag, int argc,\n \t\tprintf(\"Table name '%s' must be four characters\\n\", name);\n \t\treturn CMD_RET_FAILURE;\n \t}\n+\n+\tif (argc >= 3)\n+\t\tidx = hextoul(argv[2], &endp);\n+\n \tstr_to_upper(name, sig, ACPI_NAME_LEN);\n-\tret = dump_table_name(sig);\n+\tret = dump_table_name(sig, idx);\n \tif (ret) {\n \t\tprintf(\"Table '%.*s' not found\\n\", ACPI_NAME_LEN, sig);\n \t\treturn CMD_RET_FAILURE;\n@@ -207,10 +214,10 @@ U_BOOT_LONGHELP(acpi,\n \t\"list [-c] - list ACPI tables [check checksums]\\n\"\n \t\"acpi items [-d]   - List/dump each piece of ACPI data from devices\\n\"\n \t\"acpi set [<addr>] - Set or show address of ACPI tables\\n\"\n-\t\"acpi dump <name>  - Dump ACPI table\");\n+\t\"acpi dump <name> [<index>] - Dump ACPI table instance\");\n \n U_BOOT_CMD_WITH_SUBCMDS(acpi, \"ACPI tables\", acpi_help_text,\n \tU_BOOT_SUBCMD_MKENT(list, 2, 1, do_acpi_list),\n \tU_BOOT_SUBCMD_MKENT(items, 2, 1, do_acpi_items),\n \tU_BOOT_SUBCMD_MKENT(set, 2, 1, do_acpi_set),\n-\tU_BOOT_SUBCMD_MKENT(dump, 2, 1, do_acpi_dump));\n+\tU_BOOT_SUBCMD_MKENT(dump, 3, 1, do_acpi_dump));\n","prefixes":["2/4"]}