{"id":2225319,"url":"http://patchwork.ozlabs.org/api/patches/2225319/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420202032.714884-5-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420202032.714884-5-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2026-04-20T20:20:25","name":"[v2,04/10] vhost: replace .vhost_vq_get_addr() with .vhost_phys_vring_addr()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dd444c2de912a948155b9065c83a1dd4edeb2496","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420202032.714884-5-vsementsov@yandex-team.ru/mbox/","series":[{"id":500676,"url":"http://patchwork.ozlabs.org/api/series/500676/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500676","date":"2026-04-20T20:20:24","name":"vhost-user: VHOST_USER_PROTOCOL_F_GPA_ADDRESSES","version":2,"mbox":"http://patchwork.ozlabs.org/series/500676/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225319/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225319/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=G0JUjw7k;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxhr378fz1yCv\n\tfor ; Tue, 21 Apr 2026 06:21:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEv6y-000621-3o; Mon, 20 Apr 2026 16:20:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEv6r-00060f-Sw\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:20:45 -0400","from forwardcorp1a.mail.yandex.net ([178.154.239.72])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEv6q-0006OT-0B\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:20:45 -0400","from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net\n [IPv6:2a02:6b8:c0c:c00c:0:640:e0de:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id A9BC6C01BB;\n Mon, 20 Apr 2026 23:20:41 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id XKYwe10MOSw0-fKAZa2TE; Mon, 20 Apr 2026 23:20:40 +0300"],"X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776716441;\n bh=0FTFK55cw3rK/QycYXfqJNoLrOAw3LbH2p8qWtc8CYM=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=G0JUjw7kqvMLw1o3CkAOdS12dnn7vMF+lUP2ln/cNBJ7UAhXA5M5N9AzLwHOPrx/q\n PKfYEUrkRgp+wEs0FSA2BPmjjcutILQF2IeAZkt+8jtjbpJnUGad8PW8Kqb0oFg96Q\n MHCjPO0E7zXfqCga2/Zi+4AB+N4lh1N/5vhmEHFY=","From":"Vladimir Sementsov-Ogievskiy ","To":"mst@redhat.com","Cc":"sgarzare@redhat.com, qemu-devel@nongnu.org, vsementsov@yandex-team.ru,\n d-tatianin@yandex-team.ru","Subject":"[PATCH v2 04/10] vhost: replace .vhost_vq_get_addr() with\n .vhost_phys_vring_addr()","Date":"Mon, 20 Apr 2026 23:20:25 +0300","Message-ID":"<20260420202032.714884-5-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420202032.714884-1-vsementsov@yandex-team.ru>","References":"<20260420202032.714884-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.72;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Make a simper handler to consolidate the logic in one place. That\nhelps further changes.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n hw/virtio/vhost-vdpa.c | 13 +++----------\n hw/virtio/vhost.c | 12 ++++++------\n include/hw/virtio/vhost-backend.h | 6 ++----\n 3 files changed, 11 insertions(+), 20 deletions(-)","diff":"diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c\nindex 93474624898..9e1aa4860a8 100644\n--- a/hw/virtio/vhost-vdpa.c\n+++ b/hw/virtio/vhost-vdpa.c\n@@ -1571,16 +1571,9 @@ static int vhost_vdpa_set_owner(struct vhost_dev *dev)\n return 0;\n }\n \n-static int vhost_vdpa_vq_get_addr(struct vhost_dev *dev,\n- struct vhost_vring_addr *addr, struct vhost_virtqueue *vq)\n+static bool vhost_vdpa_phys_vring_addr(struct vhost_dev *dev)\n {\n- assert(dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_VDPA);\n- addr->desc_user_addr = (uint64_t)(unsigned long)vq->desc_phys;\n- addr->avail_user_addr = (uint64_t)(unsigned long)vq->avail_phys;\n- addr->used_user_addr = (uint64_t)(unsigned long)vq->used_phys;\n- trace_vhost_vdpa_vq_get_addr(dev, vq, addr->desc_user_addr,\n- addr->avail_user_addr, addr->used_user_addr);\n- return 0;\n+ return true;\n }\n \n static bool vhost_vdpa_force_iommu(struct vhost_dev *dev)\n@@ -1617,7 +1610,7 @@ const VhostOps vdpa_ops = {\n .vhost_send_device_iotlb_msg = NULL,\n .vhost_dev_start = vhost_vdpa_dev_start,\n .vhost_get_device_id = vhost_vdpa_get_device_id,\n- .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,\n+ .vhost_phys_vring_addr = vhost_vdpa_phys_vring_addr,\n .vhost_force_iommu = vhost_vdpa_force_iommu,\n .vhost_set_config_call = vhost_vdpa_set_config_call,\n .vhost_reset_status = vhost_vdpa_reset_status,\ndiff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex ffd7d404cc7..564a5d46982 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -1093,16 +1093,16 @@ static int vhost_virtqueue_set_addr(struct vhost_dev *dev,\n struct vhost_virtqueue *vq,\n unsigned idx, bool enable_log)\n {\n+ bool phys = dev->vhost_ops->vhost_phys_vring_addr &&\n+ dev->vhost_ops->vhost_phys_vring_addr(dev);\n struct vhost_vring_addr addr;\n int r;\n memset(&addr, 0, sizeof(struct vhost_vring_addr));\n \n- if (dev->vhost_ops->vhost_vq_get_addr) {\n- r = dev->vhost_ops->vhost_vq_get_addr(dev, &addr, vq);\n- if (r < 0) {\n- VHOST_OPS_DEBUG(r, \"vhost_vq_get_addr failed\");\n- return r;\n- }\n+ if (phys) {\n+ addr.desc_user_addr = (uint64_t)(unsigned long)vq->desc_phys;\n+ addr.avail_user_addr = (uint64_t)(unsigned long)vq->avail_phys;\n+ addr.used_user_addr = (uint64_t)(unsigned long)vq->used_phys;\n } else {\n addr.desc_user_addr = (uint64_t)(unsigned long)vq->desc;\n addr.avail_user_addr = (uint64_t)(unsigned long)vq->avail;\ndiff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-backend.h\nindex aab6bf3ef7e..7cc3bb54418 100644\n--- a/include/hw/virtio/vhost-backend.h\n+++ b/include/hw/virtio/vhost-backend.h\n@@ -141,9 +141,7 @@ typedef int (*vhost_set_inflight_fd_op)(struct vhost_dev *dev,\n \n typedef int (*vhost_dev_start_op)(struct vhost_dev *dev, bool started);\n \n-typedef int (*vhost_vq_get_addr_op)(struct vhost_dev *dev,\n- struct vhost_vring_addr *addr,\n- struct vhost_virtqueue *vq);\n+typedef bool (*vhost_phys_vring_addr_op)(struct vhost_dev *dev);\n \n typedef int (*vhost_get_device_id_op)(struct vhost_dev *dev, uint32_t *dev_id);\n \n@@ -211,7 +209,7 @@ typedef struct VhostOps {\n vhost_get_inflight_fd_op vhost_get_inflight_fd;\n vhost_set_inflight_fd_op vhost_set_inflight_fd;\n vhost_dev_start_op vhost_dev_start;\n- vhost_vq_get_addr_op vhost_vq_get_addr;\n+ vhost_phys_vring_addr_op vhost_phys_vring_addr;\n vhost_get_device_id_op vhost_get_device_id;\n vhost_force_iommu_op vhost_force_iommu;\n vhost_set_config_call_op vhost_set_config_call;\n","prefixes":["v2","04/10"]}