{"id":2225306,"url":"http://patchwork.ozlabs.org/api/patches/2225306/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-14-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420200339.708640-14-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2026-04-20T20:03:28","name":"[v6,13/22] vhost: move vrings mapping to the top of vhost_virtqueue_start()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b6da4f38aecd2c8ba5cba461b6624885477ddf9d","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-14-vsementsov@yandex-team.ru/mbox/","series":[{"id":500672,"url":"http://patchwork.ozlabs.org/api/series/500672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500672","date":"2026-04-20T20:03:18","name":"vhost refactoring and fixes","version":6,"mbox":"http://patchwork.ozlabs.org/series/500672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225306/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225306/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=sptKxpIc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxM56M2zz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 06:06:09 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEuqz-0001dt-0E; Mon, 20 Apr 2026 16:04:21 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1wEuqq-0001PP-Cr\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:13 -0400","from forwardcorp1d.mail.yandex.net ([178.154.239.200])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1wEuqo-0001xN-A4\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:12 -0400","from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 0868A8071E;\n Mon, 20 Apr 2026 23:04:09 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id f3YMX10K1Sw0-CjCKRb82; Mon, 20 Apr 2026 23:04:08 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776715448;\n bh=XocdcTcecnBxB/Sds6p3bzMTQMvxaXfbHbggfQ8XQGg=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=sptKxpIcclktT0cPCdkVSNOgpmjwrIoFuvJW7ZwXn1CkT6AX+nEsAV3EvvhmgiG5A\n OpBEmotuXWYgTi6V7WMl3N12q2B4lUcAE5fCwoGZXd/eUFbCM6IGdxxwq5lA+Dn/g1\n auyez3TtaeLBJxK3Kyv6L/aiQcdQcup3AdtpQ3Jo=","From":"Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>","To":"mst@redhat.com","Cc":"sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, Raphael Norwitz <raphael.s.norwitz@gmail.com>","Subject":"[PATCH v6 13/22] vhost: move vrings mapping to the top of\n vhost_virtqueue_start()","Date":"Mon, 20 Apr 2026 23:03:28 +0300","Message-ID":"<20260420200339.708640-14-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","References":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.200;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This simplifies further refactoring and final introduction\nof vhost backend live migration.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Raphael Norwitz <raphael.s.norwitz@gmail.com>\nReviewed-by: Daniil Tatianin <d-tatianin@yandex-team.ru>\n---\n hw/virtio/vhost.c | 45 ++++++++++++++++++++++-----------------------\n 1 file changed, 22 insertions(+), 23 deletions(-)","diff":"diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex f43e563f0de..d5bafbcc4b3 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -1303,29 +1303,6 @@ int vhost_virtqueue_start(struct vhost_dev *dev,\n         return 0;\n     }\n \n-    vq->num = state.num = virtio_queue_get_num(vdev, idx);\n-    r = dev->vhost_ops->vhost_set_vring_num(dev, &state);\n-    if (r) {\n-        VHOST_OPS_DEBUG(r, \"vhost_set_vring_num failed\");\n-        return r;\n-    }\n-\n-    state.num = virtio_queue_get_last_avail_idx(vdev, idx);\n-    r = dev->vhost_ops->vhost_set_vring_base(dev, &state);\n-    if (r) {\n-        VHOST_OPS_DEBUG(r, \"vhost_set_vring_base failed\");\n-        return r;\n-    }\n-\n-    if (vhost_needs_vring_endian(vdev)) {\n-        r = vhost_virtqueue_set_vring_endian_legacy(dev,\n-                                                    virtio_vdev_is_big_endian(vdev),\n-                                                    vhost_vq_index);\n-        if (r) {\n-            return r;\n-        }\n-    }\n-\n     l = vq->desc_size;\n     vq->desc = vhost_memory_map(dev, vq->desc_phys, l, false);\n     if (!vq->desc) {\n@@ -1347,6 +1324,28 @@ int vhost_virtqueue_start(struct vhost_dev *dev,\n         goto fail;\n     }\n \n+    vq->num = state.num = virtio_queue_get_num(vdev, idx);\n+    r = dev->vhost_ops->vhost_set_vring_num(dev, &state);\n+    if (r) {\n+        VHOST_OPS_DEBUG(r, \"vhost_set_vring_num failed\");\n+        goto fail;\n+    }\n+\n+    state.num = virtio_queue_get_last_avail_idx(vdev, idx);\n+    r = dev->vhost_ops->vhost_set_vring_base(dev, &state);\n+    if (r) {\n+        VHOST_OPS_DEBUG(r, \"vhost_set_vring_base failed\");\n+        goto fail;\n+    }\n+\n+    if (vhost_needs_vring_endian(vdev)) {\n+        r = vhost_virtqueue_set_vring_endian_legacy(\n+            dev, virtio_vdev_is_big_endian(vdev), vhost_vq_index);\n+        if (r) {\n+            goto fail;\n+        }\n+    }\n+\n     r = vhost_virtqueue_set_addr(dev, vq, vhost_vq_index, dev->log_enabled);\n     if (r < 0) {\n         goto fail;\n","prefixes":["v6","13/22"]}