{"id":2224998,"url":"http://patchwork.ozlabs.org/api/patches/2224998/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260420074827.3917463-1-aristo.chen@canonical.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420074827.3917463-1-aristo.chen@canonical.com>","list_archive_url":null,"date":"2026-04-20T07:48:05","name":"[1/1] test: fit: Use shared make_fname from fit_util","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1022a1af1507802f22f92017a86165ce52d59f19","submitter":{"id":92721,"url":"http://patchwork.ozlabs.org/api/people/92721/?format=json","name":"Aristo Chen","email":"aristo.chen@canonical.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260420074827.3917463-1-aristo.chen@canonical.com/mbox/","series":[{"id":500566,"url":"http://patchwork.ozlabs.org/api/series/500566/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500566","date":"2026-04-20T07:48:05","name":"[1/1] test: fit: Use shared make_fname from fit_util","version":1,"mbox":"http://patchwork.ozlabs.org/series/500566/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224998/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224998/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=f6zDL1Uu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"f6zDL1Uu\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com","phobos.denx.de;\n spf=pass smtp.mailfrom=aristo.chen@canonical.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzdQk0rNpz1yD4\n\tfor ; Mon, 20 Apr 2026 18:08:14 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 280FB842A4;\n\tMon, 20 Apr 2026 10:08:04 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 5A7A58426E; Mon, 20 Apr 2026 09:49:29 +0200 (CEST)","from smtp-relay-internal-0.canonical.com\n (smtp-relay-internal-0.canonical.com [185.125.188.122])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 474CC83693\n for ; Mon, 20 Apr 2026 09:49:27 +0200 (CEST)","from mail-pf1-f197.google.com (mail-pf1-f197.google.com\n [209.85.210.197])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DF83F3F129\n for ; Mon, 20 Apr 2026 07:49:26 +0000 (UTC)","by mail-pf1-f197.google.com with SMTP id\n d2e1a72fcca58-82f0f2b2641so2014417b3a.3\n for ; Mon, 20 Apr 2026 00:49:26 -0700 (PDT)","from noble-uboot.lxd (124-218-37-86.cm.dynamic.apol.com.tw.\n [124.218.37.86]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f8e981a0asm10134077b3a.3.2026.04.20.00.49.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 00:49:23 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776671366;\n bh=8ZwmdDQep1SdIjUDi9MdmGUbTqoIvotlY/qyRLmOGzY=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=f6zDL1UuLtuP8u94cmOL63A23ea/ULQiJMkHWbpnOp4ah8tbu8XrKl99Q6NDlHgMg\n KicIOxGLIs9xnK4ul0Zt/mQYo75f8A7dJZZDldrbDccYaGNCRZ+N5dLyurnwu7aCtI\n zZ2quEgjwcylMqaj6/638Sgv5bF1xhFrbSSHEACDy+Dq4BBLAJD2Nppk9IrSGNsEs5\n X0J9I97iNCCg/1drXPt/dU2gnm9Km5Cx9PkJCqArrF/G2fFzxXfG5Kpo8r1AJ+oewe\n lHwdc9wju0oacrsPN3Yj/5ZgLTRbe78fjoQ17HVQ6qClGPBc79EEF1VBO+vwKG8xfb\n iFKheUfvJ25RWIR1R2Mew3+U2u4w8rvtl9NjnBvIMKJHkOMmWptDY/5Omk6ag6+Dv6\n e5LVBsXlYRSah4UR7ieBtAxZlfYJESajDHNJIL4bsvmHLuMkBIE/nuHbGv2v5Gyi46\n rYZNPFMoHnigq+OsrDL6b/kTkxYglDkpOV+PyvC4UaRX17l8QGSDLL/86pz0ntJuGn\n Q9dUQ6Us/LmILlifp3Pf6qe5oz3+07e7NOTioXTSpDKOpYhvzLjpQ6OK+N+zKn7RSK\n fUbBtyu2eKcWmX/AAbGtu2Er+O0QE/Twj/6GyM49s7tlBHDRuJMhve8EHrouuHjWgN\n 6KwYpmcrYWChwo9z+umR3qnE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776671365; x=1777276165;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8ZwmdDQep1SdIjUDi9MdmGUbTqoIvotlY/qyRLmOGzY=;\n b=EGzeWM0D9ERNThTYXBIEUKRP8o4dIGk0KKFtcoemVrPvpeQ8UwTtnFeGWCkkakgVej\n D/Lp/w5mAITrUskT2Km8xQ2FSNaZnF1gTdsHmrBMxmCreg8HCUa0Y96jmASfksx57dd8\n ToHMHxoZsyppuwiKlNTFy5N74qMAO1qHCjnMjmvWKzIpF0ZhEiWs+ITbzhZEngIXy9SP\n 5VeQvzf8EPt6g1oi2jfseSDtdWVHoJGtTYV0g0sh/cj7cAXqUSnxomqEpo8+Uxp/8sJt\n ANatnXZPVA2nNaNF2e1oOwUIEDqZFiMLH/2QBWQMMov29vv+HQBjKqWD3evmR7Urb1Wz\n XuQw==","X-Gm-Message-State":"AOJu0YyhdIuC5wOCaoYfxAp9RJ5pHzM5svJ832up1MOy4utHCtrhECIc\n GIYKEhFR8ToxU5202p8zVH3KTsf9AzIZdqGuW0QLSY0oA1bHfO03GaVjhxOQ6gbbdfNXvXs7xOg\n pvmPIt/WdTiAYlxfaJp+KuWxzipXv4nRqcYqOHtgPfSnhN5OOTXPUV7ILw80xY49iyNi6fc48fW\n 8yvIM=","X-Gm-Gg":"AeBDietFKvvEM/wETyl6V4n++MLkAS8IvjRTdh45TMx7FMvuOEKqxOKFDROrWLbFBBT\n A6+RfgtEh51Q1kh9lyKS7aWJDil0aBoJC6kxxB5BKnhx3DNu+L1aKRsFwN4lDqqVenivZTYHJCP\n MCB7mxq1zQRQR72QcOD74cGIKmPL/Ay1H26yOVCg036RGnQfMyZpSOO8pTkv/hYHz3J5TVbuzRt\n 3F8UcdltzwuFj6YxVVIQBUsjjSa/x8uwacnuZyoxEmNqMySI9YKdqCDWEVOqoae7oiGxJww5Eff\n Vnb/LEkgNQFGTs20034lYFc16GpLZ7BkKeXQgbbc+aXWZXEmA/zjIrHJc01gpjuQ/UACs62u8Kq\n l4SROqUVRGgG3HVwfE5HQ8W0MM77Y4UrTvPzw0rytzO/rppr6ojqRjrbGfZK7L7+zWDaPF0F1te\n Sx3nVmxtc=","X-Received":["by 2002:a05:6a00:1956:b0:824:afe1:f7e3 with SMTP id\n d2e1a72fcca58-82f8c82bc5fmr13716621b3a.15.1776671364962;\n Mon, 20 Apr 2026 00:49:24 -0700 (PDT)","by 2002:a05:6a00:1956:b0:824:afe1:f7e3 with SMTP id\n d2e1a72fcca58-82f8c82bc5fmr13716586b3a.15.1776671364347;\n Mon, 20 Apr 2026 00:49:24 -0700 (PDT)"],"From":"Aristo Chen ","To":"u-boot@lists.denx.de","Cc":"Aristo Chen ,\n\tTom Rini ","Subject":"[PATCH 1/1] test: fit: Use shared make_fname from fit_util","Date":"Mon, 20 Apr 2026 07:48:05 +0000","Message-ID":"<20260420074827.3917463-1-aristo.chen@canonical.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Mon, 20 Apr 2026 10:08:02 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"test_fit.py declares a local make_fname closure that is byte-identical\nto fit_util.make_fname. Drop the local copy and call the shared helper\nat all seven call sites so there is one definition to maintain.\n\nNo behavioural change. Both implementations return\nos.path.join(ubman.config.build_dir, basename).\n\nSigned-off-by: Aristo Chen \n---\n test/py/tests/test_fit.py | 24 +++++++-----------------\n 1 file changed, 7 insertions(+), 17 deletions(-)","diff":"diff --git a/test/py/tests/test_fit.py b/test/py/tests/test_fit.py\nindex 619f73153a0..3b60f814c85 100755\n--- a/test/py/tests/test_fit.py\n+++ b/test/py/tests/test_fit.py\n@@ -119,16 +119,6 @@ host save hostfs 0 %(loadables2_addr)x %(loadables2_out)s %(loadables2_size)x\n @pytest.mark.buildconfigspec('fit_signature')\n @pytest.mark.requiredtool('dtc')\n def test_fit(ubman):\n- def make_fname(leaf):\n- \"\"\"Make a temporary filename\n-\n- Args:\n- leaf: Leaf name of file to create (within temporary directory)\n- Return:\n- Temporary filename\n- \"\"\"\n- return os.path.join(ubman.config.build_dir, leaf)\n-\n def filesize(fname):\n \"\"\"Get the size of a file\n \n@@ -156,7 +146,7 @@ def test_fit(ubman):\n Returns:\n Filename of ramdisk created\n \"\"\"\n- fname = make_fname(filename)\n+ fname = fit_util.make_fname(ubman, filename)\n data = ''\n for i in range(100):\n data += '%s %d was seldom used in the middle ages\\n' % (text, i)\n@@ -265,12 +255,12 @@ def test_fit(ubman):\n ramdisk = make_ramdisk('test-ramdisk.bin', 'ramdisk')\n loadables1 = fit_util.make_kernel(ubman, 'test-loadables1.bin', 'lenrek')\n loadables2 = make_ramdisk('test-loadables2.bin', 'ksidmar')\n- kernel_out = make_fname('kernel-out.bin')\n- fdt = make_fname('u-boot.dtb')\n- fdt_out = make_fname('fdt-out.dtb')\n- ramdisk_out = make_fname('ramdisk-out.bin')\n- loadables1_out = make_fname('loadables1-out.bin')\n- loadables2_out = make_fname('loadables2-out.bin')\n+ kernel_out = fit_util.make_fname(ubman, 'kernel-out.bin')\n+ fdt = fit_util.make_fname(ubman, 'u-boot.dtb')\n+ fdt_out = fit_util.make_fname(ubman, 'fdt-out.dtb')\n+ ramdisk_out = fit_util.make_fname(ubman, 'ramdisk-out.bin')\n+ loadables1_out = fit_util.make_fname(ubman, 'loadables1-out.bin')\n+ loadables2_out = fit_util.make_fname(ubman, 'loadables2-out.bin')\n \n # Set up basic parameters with default values\n params = {\n","prefixes":["1/1"]}