{"id":2224986,"url":"http://patchwork.ozlabs.org/api/patches/2224986/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260420061630.62077-1-changfengnan@bytedance.com/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420061630.62077-1-changfengnan@bytedance.com>","list_archive_url":null,"date":"2026-04-20T06:16:30","name":"[v2] iomap: avoid memset iomap when iter is done","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"2bf8903bbd57fd113d6143953ddcfa4972e621c9","submitter":{"id":80323,"url":"http://patchwork.ozlabs.org/api/people/80323/?format=json","name":"Fengnan Chang","email":"fengnanchang@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260420061630.62077-1-changfengnan@bytedance.com/mbox/","series":[{"id":500558,"url":"http://patchwork.ozlabs.org/api/series/500558/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=500558","date":"2026-04-20T06:16:30","name":"[v2] iomap: avoid memset iomap when iter is done","version":2,"mbox":"http://patchwork.ozlabs.org/series/500558/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224986/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224986/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=LnZ4j5QA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=p0td=ct=vger.kernel.org=linux-ext4+bounces-15909-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.234.253.10 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=LnZ4j5QA;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15909-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"LnZ4j5QA\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.173","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzb3W6Y88z1yGs\n\tfor ; Mon, 20 Apr 2026 16:21:26 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fzb3V6HvSz4wCG\n\tfor ; Mon, 20 Apr 2026 16:21:26 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fzb3V69g6z4wCJ; Mon, 20 Apr 2026 16:21:26 +1000 (AEST)","from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fzb3R22mmz4wCG\n\tfor ; Mon, 20 Apr 2026 16:21:23 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D5D75302BDDE\n\tfor ; Mon, 20 Apr 2026 06:16:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C6E1A3815F8;\n\tMon, 20 Apr 2026 06:16:41 +0000 (UTC)","from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF9C2C21FE\n\tfor ; Mon, 20 Apr 2026 06:16:39 +0000 (UTC)","by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-2b0afa0210bso11763825ad.2\n for ;\n Sun, 19 Apr 2026 23:16:39 -0700 (PDT)","from localhost.localdomain ([2408:8740:c4ff:1::4])\n by smtp.googlemail.com with ESMTPSA id\n d9443c01a7336-2b5fa9ff8d6sm88586055ad.1.2026.04.19.23.16.35\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Sun, 19 Apr 2026 23:16:37 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776666086; cv=pass;\n\tb=CTmvopfiLZeKTfHeV2UvSlITNReuZ4VfMY5P4wQQXs/qplPEqeGx53cUIOGcD3JikQFgW1pjhQOKtuY+f96DIEdFfME1QU9h9eYTgxiIY2LqFq6HIClnersU2E0zojV4pSZ/AqK2Ja8GY1as04hYVTA0XrqxbBzIh2SU0lt0zHR177JXBx7hM/xwb/Oejwy/YX8BICMWMca3wuKB7fjs79jOsPWz6zcCVUARo9pxs89c2n60GyNCGlxwzn0dPFv1bLS2VlqvowEa1XTCxPGSDLYwgjxdkUFPeA7HYTA5PGrURNqygBRUl4/hKMQYUBfd1LRdkT+w/a0ej7vonXv4Aw==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776665801; cv=none;\n b=Erl6KDn2ShxGG93AeiZPGq2QJsb7d6OfHx6zQlOitx2F7PYi+++w2y6xmft1QOIy1LPGuaZhPQbwiE154M0sRviA0vAHbsV7DdWxNlWfcNiza7F9cMNqpJ7ive9r90tvIAF4ZiCy76mWm3Uu5Fi3fhEpblGZZDZ/jLEYBxok3dw="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776666086; c=relaxed/relaxed;\n\tbh=sq8jVjaQsEQ037YnID8m/bdOr18FV4DJuvGfBEXqq74=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=trHsbjG9WyxESG9sBoI+Fzo0R95U4Cg1zq2EAnTE13x0nYY+AvvMzeD2PDveKx8lGfuI1tcAPLC2J3RwR1hz7hTb8vIDT39QAuFMPpiDD/vWamlQPNfM5Ql0UzgoVaOQ9r7iQgtPx9mO0G7ZTbaSqo3bhjUpVpF8SMuokot2JBLP50iRnAKd1s+iIm50VMtjvjoo1osfF+h0ufjwlOJRnUe9V4psRG4XHvMLWD9UGbBY16UOc7tlH4aTbYlxSjEhW2dEvOA6zD9QdblxRmyd3lQ+0OIlc66Za88xnfQ12iNFARUVeTiBRPLxdxIOFB/OvPU48GdkSeITSG53ER4mXw==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776665801; c=relaxed/simple;\n\tbh=l3l5LStnrkBdnCMkbwCq/lTh+1cpa2xztmlxm2P6lrg=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=DMTx3RYxBlRRunz51zFG1CXz3R2Yzmx6M+jNIhXebaLEVpCZIoo8/bO9BLyxo+qLrC54iK7KSpWv/CZhgEGE9fStZAze836Q233LOfHyqzmczTNT0r1pnNacIQ6oT0WLR/05tPGykEWu8l4gaj+pft/jA43N2RL1f3FMCBWersE="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=LnZ4j5QA; dkim-atps=neutral;\n spf=pass (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15909-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=LnZ4j5QA; arc=none smtp.client-ip=209.85.214.173"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776665798; x=1777270598;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=sq8jVjaQsEQ037YnID8m/bdOr18FV4DJuvGfBEXqq74=;\n b=LnZ4j5QAGU9lxr4ThzR3NWilS8l0d1Wxnb87+ltQeGp4VmTGkP9gN5//CoaAKoYHHx\n XhEfKa9+5jkhV6TNEd694cXefTyv+YmpYxugD9Xwjv2RnS7ukKlYBJNDOr/UfyNlC9nD\n FuUsTjt+39epxCjHPmNEd3I/E4gXyQczOhNluibtmjKLAU9UFa786+XIk+t/AmHJNfzD\n aenFiA/2iNIXVLBnJ/gb2WyLQu/5vk/Hphz2rHR0VGQ+H877Y5ylntnby9RvMuFoNU0J\n 5NiSSFzO4ZI6lgWhNOVGfjQoME97zbyDkusHX2HJh216v663dW51mL2Q03c5TnQmv38A\n 6jPA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776665798; x=1777270598;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=sq8jVjaQsEQ037YnID8m/bdOr18FV4DJuvGfBEXqq74=;\n b=goRZ99s1bmayjfckyI5JdM7Jv1zr+d1PDnA/cWVbZr5SRKlx9txCctfDTEdg+ojFMm\n EAGhfYPZAsXjx29DFaSpZQ7z+v38rdHGDSGAmkeo56BHlOr3Yt/WztXTDZ8HmU+Bh7eR\n sUQR5VIjNT0YehMDaC+7tG5Hhl6SBjWfTqtPftB/yIzh1RyS5roUa/0c1xHL1hR3/UYG\n 8AikMfSvF899BkbSpsyCPL+7u91yeEBtSuYCcpEl7NUDBQ5563jeYYNQqqBejfL3P1DQ\n QeFzJZudNDknmOKxEukXANb2QmYI9JrA1GmSddSA2kphq5OVxzoMaNObMqXZSL/PAiaX\n c4kw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9/+6YSCZHCP5tLnSN+gkMz0neEE7Y3pr5HYHwW9sbeWlzsvR8YzIyxeuoLGmmWhaFND69PqmAful1Q@vger.kernel.org","X-Gm-Message-State":"AOJu0Yw0Yr+huzncVkaFot+m6v7B5CFT8T3zE70IZdw4o50AB0TT+oqj\n\tdfOH2hZo2wqSXsbQ87eyCRYmKWPLQ7tFp1AdMZmihNbjSbN/xEAwLtE3","X-Gm-Gg":"AeBDievAJ8NeBNj2e8tgV/t06BfXfi/qFHBy1YrCbIB1hyc7MhuC54RX3trKSmu3WbT\n\tKT7bgM+ALYvXC51LRILfyGI1ZXjpl3TaGu2poWQyxWRRA4v0fmhx1AC2+8WpvskS0toevb0fZKJ\n\tG4pBjio5qwdo8+L3Wjy2Fh2dScIMeoX7LSDGB5sLfcLf8wu+THIFSYB02++0JnhHGocgEJyaQG4\n\tK35lpeQtcRRN/5fs8ZDmdpgsiJbatifbbG2pMIT4bVNCos1wjT0W5MH0Cwg9psYr9oLm7CTcAWB\n\twcMu2MMb4IHTjKx2mYIWHxzjtzp6rdrd6ipi9Cn3z8wJaLYhfJT/C8Z3KX6ScAFaNI5qEaqFrNv\n\tsbPjP5UaCvNjymH5qmu2RUbYjDaDQ1FDax7Wb2Ovrpf7zuQE95IAw3u4DxRi10ty0fH1PZipycf\n\tm6wXmnLUAaiwJ4kZ5mOyMVPSlDw85v8uCOd6P4JbpCz63bhxqQW4AO7aIrha/ggH2XUQ==","X-Received":"by 2002:a17:902:d590:b0:2b0:608d:d8a8 with SMTP id\n d9443c01a7336-2b5f9e8e4a9mr122014005ad.1.1776665798486;\n Sun, 19 Apr 2026 23:16:38 -0700 (PDT)","From":"Fengnan Chang ","X-Google-Original-From":"Fengnan Chang ","To":"brauner@kernel.org,\n\tdjwong@kernel.org,\n\thch@infradead.org,\n\tlinux-xfs@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-ext4@vger.kernel.org","Cc":"lidiangang@bytedance.com,\n\tFengnan Chang ","Subject":"[PATCH v2] iomap: avoid memset iomap when iter is done","Date":"Mon, 20 Apr 2026 14:16:30 +0800","Message-Id":"<20260420061630.62077-1-changfengnan@bytedance.com>","X-Mailer":"git-send-email 2.39.5 (Apple Git-154)","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"When iomap_iter() finishes its iteration (returns <= 0), it is no longer\nnecessary to memset the entire iomap and srcmap structures.\n\nIn high-IOPS scenarios (like 4k randread NVMe polling with io_uring),\nwhere the majority of I/Os complete in a single extent map, this wasted\nmemory write bandwidth, as the caller will just discard the iterator.\nUse this command to test:\ntaskset -c 30 ./t/io_uring -p1 -d512 -b4096 -s32 -c32 -F1 -B1 -R1 -X1\n-n1 -P1 /mnt/testfile\nIOPS improve about 5% on ext4 and XFS.\n\nHowever, we MUST still call iomap_iter_reset_iomap() to release the\nfolio_batch if IOMAP_F_FOLIO_BATCH is set, otherwise we leak page\nreferences. Therefore, split the cleanup logic: always release the\nfolio_batch, but skip the memset() when ret <= 0.\n\nSigned-off-by: Fengnan Chang \n---\n fs/iomap/iter.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c\nindex c04796f6e57f..e4a29829591a 100644\n--- a/fs/iomap/iter.c\n+++ b/fs/iomap/iter.c\n@@ -6,17 +6,13 @@\n #include \n #include \"trace.h\"\n \n-static inline void iomap_iter_reset_iomap(struct iomap_iter *iter)\n+static inline void iomap_iter_clean_fbatch(struct iomap_iter *iter)\n {\n \tif (iter->iomap.flags & IOMAP_F_FOLIO_BATCH) {\n \t\tfolio_batch_release(iter->fbatch);\n \t\tfolio_batch_reinit(iter->fbatch);\n \t\titer->iomap.flags &= ~IOMAP_F_FOLIO_BATCH;\n \t}\n-\n-\titer->status = 0;\n-\tmemset(&iter->iomap, 0, sizeof(iter->iomap));\n-\tmemset(&iter->srcmap, 0, sizeof(iter->srcmap));\n }\n \n /* Advance the current iterator position and decrement the remaining length */\n@@ -102,10 +98,14 @@ int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops)\n \t\tret = 0;\n \telse\n \t\tret = 1;\n-\tiomap_iter_reset_iomap(iter);\n+\tiomap_iter_clean_fbatch(iter);\n+\titer->status = 0;\n \tif (ret <= 0)\n \t\treturn ret;\n \n+\tmemset(&iter->iomap, 0, sizeof(iter->iomap));\n+\tmemset(&iter->srcmap, 0, sizeof(iter->srcmap));\n+\n begin:\n \tret = ops->iomap_begin(iter->inode, iter->pos, iter->len, iter->flags,\n \t\t\t &iter->iomap, &iter->srcmap);\n","prefixes":["v2"]}