{"id":2224982,"url":"http://patchwork.ozlabs.org/api/patches/2224982/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420060527.109013-1-xieyi@kylinos.cn/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420060527.109013-1-xieyi@kylinos.cn>","list_archive_url":null,"date":"2026-04-20T06:05:27","name":"[v2] net/filter-buffer: use qemu_del_net_queue() in cleanup","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5dbcc261389bcbb64464bc4b2e3dee9e7a8155fb","submitter":{"id":92913,"url":"http://patchwork.ozlabs.org/api/people/92913/?format=json","name":"Yi Xie","email":"xieyi@kylinos.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420060527.109013-1-xieyi@kylinos.cn/mbox/","series":[{"id":500555,"url":"http://patchwork.ozlabs.org/api/series/500555/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500555","date":"2026-04-20T06:05:27","name":"[v2] net/filter-buffer: use qemu_del_net_queue() in cleanup","version":2,"mbox":"http://patchwork.ozlabs.org/series/500555/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224982/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224982/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzZkg3sq3z1yCv\n\tfor ; Mon, 20 Apr 2026 16:06:49 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEhlw-0007gA-Uz; Mon, 20 Apr 2026 02:06:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wEhlm-0007eO-4g\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 02:06:06 -0400","from mailgw.kylinos.cn ([124.126.103.232])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wEhli-0007uV-Vu\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 02:06:05 -0400","from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn\n (envelope-from )\n (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256)\n with ESMTP id 210746808; Mon, 20 Apr 2026 14:05:44 +0800"],"X-UUID":["f7f9132a3c7e11f1aa26b74ffac11d73-20260420","f7f9132a3c7e11f1aa26b74ffac11d73-20260420"],"X-CID-P-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:a615cc00-81b8-4c5b-a239-b6907bf8ff9c,\n IP:0,\n U\n RL:0,TC:0,Content:0,EDM:-20,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO\n N:release,TS:-20","X-CID-META":"VersionHash:e7bac3a, CLOUDID:c317ed2a63b02614242deaf967ef4896,\n BulkI\n D:nil,BulkQuantity:0,Recheck:0,SF:102|850|898,TC:nil,Content:0|15|50,EDM:1\n ,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV\n :0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","X-User":"xieyi@kylinos.cn","From":"Yi Xie ","To":"qemu-devel@nongnu.org","Cc":"Yi Xie ","Subject":"[PATCH v2] net/filter-buffer: use qemu_del_net_queue() in cleanup","Date":"Mon, 20 Apr 2026 14:05:27 +0800","Message-Id":"<20260420060527.109013-1-xieyi@kylinos.cn>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=124.126.103.232; envelope-from=xieyi@kylinos.cn;\n helo=mailgw.kylinos.cn","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"incoming_queue is allocated by qemu_new_net_queue() and must be torn down with qemu_del_net_queue(), which frees any queued NetPacket nodes.\n\nUsing g_free() on the NetQueue struct directly could leak packets if the queue was not empty.\n\nClear the pointer after destroy.\n\nSigned-off-by: Yi Xie \n---\n net/filter-buffer.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/net/filter-buffer.c b/net/filter-buffer.c\nindex 427da24097..ce3e9027a0 100644\n--- a/net/filter-buffer.c\n+++ b/net/filter-buffer.c\n@@ -95,7 +95,8 @@ static void filter_buffer_cleanup(NetFilterState *nf)\n /* flush packets */\n if (s->incoming_queue) {\n filter_buffer_flush(nf);\n- g_free(s->incoming_queue);\n+ qemu_del_net_queue(s->incoming_queue);\n+ s->incoming_queue = NULL;\n }\n }\n \n","prefixes":["v2"]}