{"id":2224949,"url":"http://patchwork.ozlabs.org/api/patches/2224949/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260420012320.400472-1-marek.vasut+renesas@mailbox.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420012320.400472-1-marek.vasut+renesas@mailbox.org>","list_archive_url":null,"date":"2026-04-20T01:23:07","name":"common: update: Fix TFTP return value handling","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"bbcabe0f1a0dbda9608bb4227e1c3c08a44bdade","submitter":{"id":85650,"url":"http://patchwork.ozlabs.org/api/people/85650/?format=json","name":"Marek Vasut","email":"marek.vasut+renesas@mailbox.org"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260420012320.400472-1-marek.vasut+renesas@mailbox.org/mbox/","series":[{"id":500537,"url":"http://patchwork.ozlabs.org/api/series/500537/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500537","date":"2026-04-20T01:23:07","name":"common: update: Fix TFTP return value handling","version":1,"mbox":"http://patchwork.ozlabs.org/series/500537/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224949/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224949/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=mailbox.org header.i=@mailbox.org header.a=rsa-sha256\n header.s=mail20150812 header.b=o6S7nMfK;\n\tdkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org\n header.a=rsa-sha256 header.s=mail20150812 header.b=u9Bgj8zH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=mailbox.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=mailbox.org header.i=@mailbox.org header.b=\"o6S7nMfK\";\n\tdkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org\n header.b=\"u9Bgj8zH\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=mailbox.org","phobos.denx.de;\n spf=pass smtp.mailfrom=marek.vasut+renesas@mailbox.org","outgoing_mbo_mout;\n dkim=pass header.d=mailbox.org header.s=mail20150812 header.b=u9Bgj8zH;\n spf=pass (outgoing_mbo_mout: domain of marek.vasut+renesas@mailbox.org\n designates 2001:67c:2050:b231:465::102 as permitted sender)\n smtp.mailfrom=marek.vasut+renesas@mailbox.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzSRm5F3hz1yGt\n\tfor ; Mon, 20 Apr 2026 11:23:32 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 569D58428C;\n\tMon, 20 Apr 2026 03:23:30 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 434178428C; Mon, 20 Apr 2026 03:23:29 +0200 (CEST)","from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6261984286\n for ; Mon, 20 Apr 2026 03:23:27 +0200 (CEST)","from smtp102.mailbox.org (smtp102.mailbox.org\n [IPv6:2001:67c:2050:b231:465::102])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4fzSRf75hzz9tlP;\n Mon, 20 Apr 2026 03:23:26 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;\n s=mail20150812; t=1776648207;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=9sfQ4CaoU2xMDVWuS1f3hMEPLmMaHKxlNk5/JEp6hLc=;\n b=o6S7nMfKjsHuizoRfd5g9oljrLdeA6UP9wQTPa0B+pPXQXBTo4BvP4Ph9qHivk8HwP/4Wx\n c4aOLXDGPvOmJoVqhY6Ib08T7JMZxE+gD6yjxMSk9CRxVMfCy1efxdNBY5xzC5/JeHvufj\n QCMXufsV3dn0CCofZ/La9X6OFOkZwB8QasmVLtmGbPihIksGiHW0L8/N+tlIRRDunvpxUi\n fmsW/ee+u1u3yo3uJumx0f0XA9qxQheMkPqYnmRlpK00334+iTYzL3cuPQvIbmNAW68sG+\n Cfvoi5V0Ty+5VFn+crRPDVm659fGy5cf1uQObOKRHcNOkZamor5uxE4UcPDq5g==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;\n s=mail20150812; t=1776648205;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=9sfQ4CaoU2xMDVWuS1f3hMEPLmMaHKxlNk5/JEp6hLc=;\n b=u9Bgj8zHo2ZD6rjA79HVBf65FGD79DWFpFYCKYD5WvPNLYUo9/jKTl2NnBACqMNGTgcGmA\n gRJa82v1K9YSH9h+pm8e7oJVK5Yc4C6f30gIkHLEWZ0CCxpKYJv0UDHHT7k+oyszK8MoLM\n EUGrGkWfLz6O0VO4ubt9Et5UlZ43AOfVAEvSy3lbHwAld2brkHQCwpCETv2Gm2Y7tGQewh\n +krKhD4UMmRLrcDrtKFbVWJ/MlMuwcfhfvGfUpQ7y+zYk7iET1cD8ygeTogWBNAmzYtWCq\n xMfm6WzwAn6BQefxm52H+6V+6TYaH44D2HBaOyATFkIN0koMSs/okSA/C7yi+w=="],"From":"Marek Vasut ","To":"u-boot@lists.denx.de","Cc":"Marek Vasut ,\n Lukasz Majewski ,\n Mattijs Korpershoek ,\n Tom Rini ","Subject":"[PATCH] common: update: Fix TFTP return value handling","Date":"Mon, 20 Apr 2026 03:23:07 +0200","Message-ID":"<20260420012320.400472-1-marek.vasut+renesas@mailbox.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-MBO-RS-ID":"6bd5eceb798d25a809c","X-MBO-RS-META":"3x9oju5twtqwx7x977cbrjtfp9xwa93k","X-Rspamd-Queue-Id":"4fzSRf75hzz9tlP","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The net_loop() returns 1 on success, but update_load() returns 0 on\nsuccess. Do not assign rv which is the return value of update_load()\nto net_loop(), instead assign net_loop() return value to a temporary\nvariable and then update rv only if the temporary variable is negative.\nThis way the update_load() now correctly returns 0 on tftp success and\n1 only on failure.\n\nSigned-off-by: Marek Vasut \n---\nCc: Lukasz Majewski \nCc: Mattijs Korpershoek \nCc: Tom Rini \nCc: u-boot@lists.denx.de\n---\n common/update.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/common/update.c b/common/update.c\nindex 0bafffede9e..06e53cbd402 100644\n--- a/common/update.c\n+++ b/common/update.c\n@@ -32,7 +32,7 @@ static uchar *saved_prot_info;\n #endif\n static int update_load(char *filename, ulong msec_max, int cnt_max, ulong addr)\n {\n-\tint rv;\n+\tint rv, ret;\n \tulong saved_timeout_msecs;\n \tint saved_timeout_count;\n \tchar *saved_netretry, *saved_bootfile;\n@@ -54,9 +54,9 @@ static int update_load(char *filename, ulong msec_max, int cnt_max, ulong addr)\n \t/* download the update file */\n \timage_load_addr = addr;\n \tcopy_filename(net_boot_file_name, filename, sizeof(net_boot_file_name));\n-\trv = net_loop(TFTPGET);\n+\tret = net_loop(TFTPGET);\n \n-\tif (rv < 0)\n+\tif (ret < 0)\n \t\trv = 1;\n \telse\n \t\tflush_cache(addr, net_boot_file_size);\n","prefixes":[]}