{"id":2224939,"url":"http://patchwork.ozlabs.org/api/patches/2224939/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260419192555.3631327-1-boolli@google.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260419192555.3631327-1-boolli@google.com>","list_archive_url":null,"date":"2026-04-19T19:25:55","name":"idpf: do not perform flow ops when netdev is detached","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"6a9b3a31694c45554fe672c3b1df60f7447f1f87","submitter":{"id":92373,"url":"http://patchwork.ozlabs.org/api/people/92373/?format=json","name":"Li Li","email":"boolli@google.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260419192555.3631327-1-boolli@google.com/mbox/","series":[{"id":500527,"url":"http://patchwork.ozlabs.org/api/series/500527/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500527","date":"2026-04-19T19:25:55","name":"idpf: do not perform flow ops when netdev is detached","version":1,"mbox":"http://patchwork.ozlabs.org/series/500527/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224939/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224939/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=n4KlIroK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzJWt01Pqz1yGs\n\tfor ; Mon, 20 Apr 2026 05:26:33 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 8891440D78;\n\tSun, 19 Apr 2026 19:26:31 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id YdgbdKadquUy; Sun, 19 Apr 2026 19:26:29 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 6D4CE40D55;\n\tSun, 19 Apr 2026 19:26:29 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 293CD24D\n for ; Sun, 19 Apr 2026 19:26:28 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 0F20140448\n for ; Sun, 19 Apr 2026 19:26:28 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xMk9URfkJlGp for ;\n Sun, 19 Apr 2026 19:26:27 +0000 (UTC)","from mail-dy1-x134a.google.com (mail-dy1-x134a.google.com\n [IPv6:2607:f8b0:4864:20::134a])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 46023403DC\n for ; Sun, 19 Apr 2026 19:26:27 +0000 (UTC)","by mail-dy1-x134a.google.com with SMTP id\n 5a478bee46e88-2c0ba59a830so3429831eec.0\n for ; Sun, 19 Apr 2026 12:26:27 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6D4CE40D55","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 46023403DC"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776626789;\n\tbh=YmTe5QrSAhWmElkBtUPNEfvUQd8uWx+pL52ZTzPTjRg=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=n4KlIroKklzPXa9B/PdhgAsULRZ9cLuJR1ctKkG1EkBhEtePfYCGgiDRhoBnW6nHo\n\t RgJjsN7yCRnhzJKh+va/lMRVZct3b1aJNkUspaH6gH/kwARSTieeflnFlqvd2i5IXx\n\t ZF8IlNwl0yNWe8UIQ7mFXHQkKcPipb4yAQBXwLqTxnaVhMl7MsKYLHn1CCBnQYhKbS\n\t a1V2sjptgJkILaHD4NdLhX3K00+LFwVC6hqQrK9/nPBcMddtBFCe45iSJQ1eSB3xHV\n\t eh3nKC0EiUqTJVP2w/i4ix2rV/wch6+x+Dtf5DttlqpN3hv/lAt3WksNVYzyR0uMiq\n\t 6eM/8FgcTKe8Q==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::134a; helo=mail-dy1-x134a.google.com;\n envelope-from=3yszlaqykd6qfssppmksskpi.gsqmrxip-amvih-perpmwxw.swyswp.svk@flex--boolli.bounces.google.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 46023403DC","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776626786; x=1777231586;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=YmTe5QrSAhWmElkBtUPNEfvUQd8uWx+pL52ZTzPTjRg=;\n b=dydwAmqIZBU2OqQl4YxvGbowKSYj1wMNNcSfYfu+BhWv6x5/W3XDXDCr9ZYHkV1IF2\n G0kFl1Npw25NqIKFle2q6ubvhP7gsK4uKU++oaZPegRYCGhq3dc2Rk8ovpiBMlLTFKOM\n rJ/9fWx2g4X+0Ra3KN8ArlawD3A+viw3NRyYYNVGKnyQNFAdbmDURJ7d/opwartY5V77\n 8CGmox/XqjwAp2r2R3FEgCwdW4eHylzqE134DjQvwVtH7OoqM8ohil/2v1vwJsFYHl3k\n ip55LCNje7ePqtrX65Kx9RQb+L02bLh4Ri4WezSysQeYOIohATrTuXAiGUJt0OyqjtiP\n +gcg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8ozt/CZOlhM6hYr45fVtl0oneJ4JYrsESXYeQFnm7d+m7xxzLQ4HstFIGKRrRR40Cpwt8pUGiYANA7pydPtpk=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YyPamVT4BeDjhdM5H1b6oziz7g5LocjK1lQ2D8o76P1KI+2Bx0Q\n FLBhiHkY3e8l/+vcIUo1XjS+PrRLVXcxXLxRpeUNzIVxz9gC950pRoVqdNragLzTqRnSQisjmi7\n 3KcRlcA==","X-Received":"from dybtv6.prod.google.com\n ([2002:a05:7300:f486:b0:2d8:5b05:964b])\n (user=boolli job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7300:6c05:b0:2c7:3a7:c792\n with SMTP id 5a478bee46e88-2e47a1027ecmr5364749eec.20.1776626785796; Sun, 19\n Apr 2026 12:26:25 -0700 (PDT)","Date":"Sun, 19 Apr 2026 19:25:55 +0000","Mime-Version":"1.0","X-Mailer":"git-send-email 2.54.0.rc1.513.gad8abe7a5a-goog","Message-ID":"<20260419192555.3631327-1-boolli@google.com>","To":"Tony Nguyen ,\n Przemek Kitszel ,\n \"David S. Miller\" ,\n Jakub Kicinski , Eric Dumazet ,\n intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n David Decotigny ,\n Anjali Singhai ,\n Sridhar Samudrala ,\n Brian Vazquez ,\n Li Li , emil.s.tantilov@intel.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1776626786; x=1777231586; darn=lists.osuosl.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=YmTe5QrSAhWmElkBtUPNEfvUQd8uWx+pL52ZTzPTjRg=;\n b=WWom+1+QP1L+0a7PV0mcx/AtFvghpDjy2N0zm8MAkQ5327SJy2E48rULWfanXVDDrK\n jw74YY1tKctIrkMAJXPFt93xaT9N0pvFr8wYfdGFTVxvht4G5mOrtRqcX/UKlzHvuZeD\n Q0Ak4A5VMlaCmR3J7IobPXliD7/lmT30u1SA8OGoi+SUGS6fRvtEysvGCZ+U6y/8I/38\n dzfwQ9+UNsZpAEvhPnP3IA7TVfSXIJbKby+BN12B9Isb3ngc3D/Tj0fnO0zg/gqwfL1G\n tVjA9K4e5dwqMSI6CDc+3OsXGh2lsej6Sluk+WebH+Qp9KCri0J2ExZFSYjyV0nzn1rS\n LiPA==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=WWom+1+Q"],"Subject":"[Intel-wired-lan] [PATCH] idpf: do not perform flow ops when netdev\n is detached","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Li via Intel-wired-lan ","Reply-To":"Li Li ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Even though commit 2e281e1155fc (\"idpf: detach and close netdevs while\nhandling a reset\") prevents ethtool -N/-n operations to operate on\ndetached netdevs, we found that out-of-tree workflows like OpenOnload\ncan bypass ethtool core locks and call idpf_set_rxnfc directly during\nan idpf HW reset. When this happens, we could get kernel crashes like\nthe following:\n\n[ 4045.787439] BUG: kernel NULL pointer dereference, address: 0000000000000070\n[ 4045.794420] #PF: supervisor read access in kernel mode\n[ 4045.799580] #PF: error_code(0x0000) - not-present page\n[ 4045.804739] PGD 0\n[ 4045.806772] Oops: Oops: 0000 [#1] SMP NOPTI\n...\n[ 4045.836425] Workqueue: onload-wqueue oof_do_deferred_work_fn [onload]\n[ 4045.842926] RIP: 0010:idpf_del_flow_steer+0x24/0x170 [idpf]\n...\n[ 4045.946323] Call Trace:\n[ 4045.948796] \n[ 4045.950915] ? show_trace_log_lvl+0x1b0/0x2f0\n[ 4045.955293] ? show_trace_log_lvl+0x1b0/0x2f0\n[ 4045.959672] ? idpf_set_rxnfc+0x6f/0x80 [idpf]\n[ 4045.964142] ? __die_body.cold+0x8/0x12\n[ 4045.968000] ? page_fault_oops+0x148/0x160\n[ 4045.972117] ? exc_page_fault+0x6f/0x160\n[ 4045.976060] ? asm_exc_page_fault+0x22/0x30\n[ 4045.980262] ? idpf_del_flow_steer+0x24/0x170 [idpf]\n[ 4045.985245] idpf_set_rxnfc+0x6f/0x80 [idpf]\n[ 4045.989535] af_xdp_filter_remove+0x7c/0xb0 [sfc_resource]\n[ 4045.995069] oo_hw_filter_clear_hwports+0x6f/0xa0 [onload]\n[ 4046.000589] oo_hw_filter_update+0x65/0x210 [onload]\n[ 4046.005587] oof_hw_filter_update.constprop.0+0xe7/0x140 [onload]\n[ 4046.011716] oof_manager_update_all_filters+0xad/0x270 [onload]\n[ 4046.017671] __oof_do_deferred_work+0x15e/0x190 [onload]\n[ 4046.023014] oof_do_deferred_work+0x2c/0x40 [onload]\n[ 4046.028018] oof_do_deferred_work_fn+0x12/0x30 [onload]\n[ 4046.033277] process_one_work+0x174/0x330\n[ 4046.037304] worker_thread+0x246/0x390\n[ 4046.041074] ? __pfx_worker_thread+0x10/0x10\n[ 4046.045364] kthread+0xf6/0x240\n[ 4046.048530] ? __pfx_kthread+0x10/0x10\n[ 4046.052297] ret_from_fork+0x2d/0x50\n[ 4046.055896] ? __pfx_kthread+0x10/0x10\n[ 4046.059664] ret_from_fork_asm+0x1a/0x30\n[ 4046.063613] \n\nTo prevent this, we need to add checks in idpf_set_rxnfc and\nidpf_get_rxnfc to error out if the netdev is already detached.\n\nTested: implemented the following patch to synthetically force idpf into\na HW reset:","diff":"diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\nindex 4fc0bb14c5b1..27476d57bcf0 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n@@ -10,6 +10,9 @@\n #define idpf_tx_buf_next(buf)\t\t(*(u32 *)&(buf)->priv)\n LIBETH_SQE_CHECK_PRIV(u32);\n\n+static bool SIMULATE_TX_TIMEOUT;\n+module_param(SIMULATE_TX_TIMEOUT, bool, 0644);\n+\n /**\n * idpf_chk_linearize - Check if skb exceeds max descriptors per packet\n * @skb: send buffer\n@@ -46,6 +49,8 @@ void idpf_tx_timeout(struct net_device *netdev, unsigned int txqueue)\n\n \tadapter->tx_timeout_count++;\n\n+\tSIMULATE_TX_TIMEOUT = false;\n+\n \tnetdev_err(netdev, \"Detected Tx timeout: Count %d, Queue %d\\n\",\n \t\t adapter->tx_timeout_count, txqueue);\n \tif (!idpf_is_reset_in_prog(adapter)) {\n@@ -2225,6 +2230,8 @@ static bool idpf_tx_clean_complq(struct idpf_compl_queue *complq, int budget,\n \t\t\tgoto fetch_next_desc;\n \t\t}\n \t\ttx_q = complq->txq_grp->txqs[rel_tx_qid];\n+\t\tif (unlikely(SIMULATE_TX_TIMEOUT && (tx_q->idx % 2 == 1)))\n+\t\t\tgoto fetch_next_desc;\n\n \t\t/* Determine completion type */\n \t\tctype = le16_get_bits(tx_desc->common.qid_comptype_gen,\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex be66f9b2e101..ba5da2a86c15 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -8,6 +8,9 @@\n #include \"idpf_virtchnl.h\"\n #include \"idpf_ptp.h\"\n\n+static bool VIRTCHNL_FAILED;\n+module_param(VIRTCHNL_FAILED, bool, 0644);\n+\n /**\n * struct idpf_vc_xn_manager - Manager for tracking transactions\n * @ring: backing and lookup for transactions\n@@ -3496,6 +3499,11 @@ int idpf_vc_core_init(struct idpf_adapter *adapter)\n \t\tswitch (adapter->state) {\n \t\tcase __IDPF_VER_CHECK:\n \t\t\terr = idpf_send_ver_msg(adapter);\n+\n+\t\t\tif (unlikely(VIRTCHNL_FAILED)) {\n+\t\t\t\terr = -EIO;\n+\t\t\t}\n+\n \t\t\tswitch (err) {\n \t\t\tcase 0:\n \t\t\t\t/* success, move state machine forward */\n\nAnd tested by writing 1 to /sys/module/idpf/parameters/VIRTCHNL_FAILED\nand /sys/module/idpf/parameters/SIMULATE_TX_TIMEOUT, and running\nidpf_get_rxnfc() right after the HW reset.\n\nWithout the patch: encountered NULL pointer and kernel crash.\n\nWith the patch: no crashes.\n\nFixes: 2e281e1155fc (\"idpf: detach and close netdevs while handling a reset\")\nSigned-off-by: Li Li \n---\n drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\nindex bb99d9e7c65d..8368a7e6a754 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\n@@ -43,6 +43,9 @@ static int idpf_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd,\n \tunsigned int cnt = 0;\n \tint err = 0;\n \n+\tif (!netdev || !netif_device_present(netdev))\n+\t\treturn -ENODEV;\n+\n \tidpf_vport_ctrl_lock(netdev);\n \tvport = idpf_netdev_to_vport(netdev);\n \tvport_config = np->adapter->vport_config[np->vport_idx];\n@@ -349,6 +352,9 @@ static int idpf_set_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd)\n {\n \tint ret = -EOPNOTSUPP;\n \n+\tif (!netdev || !netif_device_present(netdev))\n+\t\treturn -ENODEV;\n+\n \tidpf_vport_ctrl_lock(netdev);\n \tswitch (cmd->cmd) {\n \tcase ETHTOOL_SRXCLSRLINS:\n","prefixes":[]}