{"id":2224834,"url":"http://patchwork.ozlabs.org/api/patches/2224834/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260418223320.51330-33-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260418223320.51330-33-mohamed@unpredictable.fr>","list_archive_url":null,"date":"2026-04-18T22:33:14","name":"[32/38] whpx: i386: set APIC ID only when APIC present","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"160427a8ee6ff775220baa436869f4d3beb52657","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260418223320.51330-33-mohamed@unpredictable.fr/mbox/","series":[{"id":500475,"url":"http://patchwork.ozlabs.org/api/series/500475/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500475","date":"2026-04-18T22:32:54","name":"WHPX x86 updates for QEMU 11.1","version":1,"mbox":"http://patchwork.ozlabs.org/series/500475/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224834/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224834/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=ejmpLXt5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fymnY5nDrz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 19 Apr 2026 08:36:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEEFF-0007PU-0Y; Sat, 18 Apr 2026 18:34:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wEEF9-0006nq-6G\n for qemu-devel@nongnu.org; Sat, 18 Apr 2026 18:34:27 -0400","from p-east2-cluster1-host8-snip4-10.eps.apple.com ([57.103.76.83]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wEEF7-0005Cf-Iz\n for qemu-devel@nongnu.org; Sat, 18 Apr 2026 18:34:26 -0400","from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id\n BB9DF18000DA; Sat, 18 Apr 2026 22:34:23 +0000 (UTC)","from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id\n D4CF118000B4; Sat, 18 Apr 2026 22:34:21 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776551664; x=1779143664;\n bh=AZNfvHRegyH4f70Ia13TlEC2emrhVTeWmibfHx3edKk=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=ejmpLXt5qpvauUoKZ6uumWxTk0cpeURi9zK5/Gf4qk0Tg68cmKGRFGYE+8nk/8wilksVYZODvY1UerE9/T4IXDH5DMfjvfoojG1Brt9e+L5yFu06hdljjBdGsTGu8g3xx9tspeFtZVUKVxw27YtKYDu5eU26szeWq+gScbGqsywiESe8nXbiRN5L2/gr1D5ghJrLPlGKHwlosaA141z0ToA/wQbNwt1E72+OMpqH/AHa5FPUhffx90zS79MY/afujNq+8V9PbGdrGSM72BSEQ+t+zLW41zOIUsTYrGGDxAFugIFlQbr3A/yQVACF+PFr23j8v692I9h8Nc4Y2kf+0A==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni <mohamed@unpredictable.fr>","To":"qemu-devel@nongnu.org","Cc":"Mohamed Mediouni <mohamed@unpredictable.fr>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>, Pedro Barbuda <pbarbuda@microsoft.com>,\n Roman Bolshakov <rbolshakov@ddn.com>, qemu-arm@nongnu.org,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>, Wei Liu <wei.liu@kernel.org>,\n Phil Dennis-Jordan <phil@philjordan.eu>","Subject":"[PATCH 32/38] whpx: i386: set APIC ID only when APIC present","Date":"Sun, 19 Apr 2026 00:33:14 +0200","Message-ID":"<20260418223320.51330-33-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260418223320.51330-1-mohamed@unpredictable.fr>","References":"<20260418223320.51330-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE4MDIyOSBTYWx0ZWRfX9BaruJKWq7+I\n 2TW2AX42esNfValEfAnwoBPgME4lDp8mvwzr4ZEkhOITCSEdGoFHI5uFLE9Ggaal+XXJp/bcnj5\n 4z44e6G3Ingj/9dvg+P7flqcjXHNWuAdfg+xNGMfJd7FGH1iJXlgYTVYXUvBFiLZBclDKegfRNg\n Y2um/N1mz/wm5wlajTdE5Tm9diV4mo8f0SNxrm14++6/Bi2Zsllo12HVWY4HDBQQ+yeL/OFtyYA\n P5XmyHEdDf/mJ/EHeL7+p27Rhia3nDCl33ACKIWRg7SfyolwnkG8CORu/ILOoRh6pOPD21mTvfO\n 6W2rSaG0d/AnO0bOn56x+0EGcq5DwunjJmFuE4psIaS3okRY4BUSQnDXQNen4g=","X-Proofpoint-ORIG-GUID":"50gl7cHmAjd8bQ56s2IUstAy5Mzs8F9N","X-Authority-Info-Out":"v=2.4 cv=ApPjHe9P c=1 sm=1 tr=0 ts=69e406f0\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=WHe3jrWR342bzmf78BwA:9","X-Proofpoint-GUID":"50gl7cHmAjd8bQ56s2IUstAy5Mzs8F9N","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-18_06,2026-04-17_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 clxscore=1030\n suspectscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 spamscore=0\n adultscore=0 mlxlogscore=869 phishscore=0 bulkscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604180229","Received-SPF":"pass client-ip=57.103.76.83;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"-M isapc doesn't have an APIC\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex cd0bc3d54e..0f50cf098a 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -2589,7 +2589,7 @@ int whpx_init_vcpu(CPUState *cpu)\n         goto error;\n     }\n \n-    if (!whpx_irqchip_in_kernel()) {\n+    if (!whpx_irqchip_in_kernel() && x86_cpu->apic_state != NULL) {\n         WHV_REGISTER_VALUE apic_id = {.Reg64 = x86_cpu->apic_state->initial_apic_id};\n         whpx_set_reg(cpu, WHvX64RegisterInitialApicId, apic_id);\n     }\n","prefixes":["32/38"]}