{"id":2224572,"url":"http://patchwork.ozlabs.org/api/patches/2224572/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260417162842.3565692-1-trozet@nvidia.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417162842.3565692-1-trozet@nvidia.com>","list_archive_url":null,"date":"2026-04-17T16:28:42","name":"[ovs-dev] dpif-offload: Log flow details for TC offload ERR failures.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b26c6fe72377ad064455d3d0100a4615b98f3fcd","submitter":{"id":93176,"url":"http://patchwork.ozlabs.org/api/people/93176/?format=json","name":"Tim Rozet","email":"trozet@nvidia.com"},"delegate":{"id":75123,"url":"http://patchwork.ozlabs.org/api/users/75123/?format=json","username":"echaudron","first_name":"Eelco","last_name":"Chaudron","email":"echaudro@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260417162842.3565692-1-trozet@nvidia.com/mbox/","series":[{"id":500371,"url":"http://patchwork.ozlabs.org/api/series/500371/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=500371","date":"2026-04-17T16:28:42","name":"[ovs-dev] dpif-offload: Log flow details for TC offload ERR failures.","version":1,"mbox":"http://patchwork.ozlabs.org/series/500371/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224572/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2224572/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=WvdKhL/Z;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key,\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=WvdKhL/Z","smtp4.osuosl.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp4.osuosl.org; dkim=pass (2048-bit key,\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=WvdKhL/Z"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy0hp5ZHNz1yD3\n\tfor ; Sat, 18 Apr 2026 02:29:46 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 96B2C60E74;\n\tFri, 17 Apr 2026 16:29:44 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id uupXLu_2CbhI; Fri, 17 Apr 2026 16:29:43 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id B6BF760E62;\n\tFri, 17 Apr 2026 16:29:43 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 864A0C058E;\n\tFri, 17 Apr 2026 16:29:43 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 6A8EAC058D\n for ; Fri, 17 Apr 2026 16:29:42 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 5653C40E9F\n for ; Fri, 17 Apr 2026 16:29:42 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HAesTo4viNop for ;\n Fri, 17 Apr 2026 16:29:41 +0000 (UTC)","from CO1PR03CU002.outbound.protection.outlook.com\n (mail-westus2azlp170100005.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c005::5])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 9110740E9C\n for ; Fri, 17 Apr 2026 16:29:41 +0000 (UTC)","from MN2PR14CA0002.namprd14.prod.outlook.com (2603:10b6:208:23e::7)\n by DM6PR12MB4187.namprd12.prod.outlook.com (2603:10b6:5:212::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Fri, 17 Apr\n 2026 16:29:36 +0000","from MN1PEPF0000F0E3.namprd04.prod.outlook.com\n (2603:10b6:208:23e:cafe::61) by MN2PR14CA0002.outlook.office365.com\n (2603:10b6:208:23e::7) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.52 via Frontend Transport; Fri,\n 17 Apr 2026 16:29:36 +0000","from mail.nvidia.com (216.228.117.160) by\n MN1PEPF0000F0E3.mail.protection.outlook.com (10.167.242.41) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Fri, 17 Apr 2026 16:29:34 +0000","from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Fri, 17 Apr\n 2026 09:29:13 -0700","from fedora (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Fri, 17 Apr\n 2026 09:29:12 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org B6BF760E62","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9110740E9C"],"Received-SPF":["Pass (mailfrom) identity=mailfrom;\n client-ip=2a01:111:f403:c005::5;\n helo=co1pr03cu002.outbound.protection.outlook.com;\n envelope-from=trozet@nvidia.com; receiver=","Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9110740E9C","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=vJiiYcbQHVhMeCNkOgjPguBYH7XPvqrBbS2MsQWrwrMj2WXqe6yERVvNpIhKLBKfqVNDWRnz7bWJrzXWFz3FkJRXtFXewCnQAtbSa4dw0mGVV5iEGEsbwm5U2tkYgXLArbQ/c1RAWacR4u8VaVG1UZJOCzZwYIEMz4/BH2UqMhtJ+f/XFcsH1CROuL5a7hrqm8e68RNE1AQNyoze8YmAuIN6gu3PUkc34+ulGWOEVrNPJMq+LqhAQvAOM22ZS910j+WpyJD2sEyfFz+rLqvNjJFxXwIhs7XfU6Gx33lx/JErIftNpPh0eZohBI0MbnBMrjsi2TMrI19yvtpoNaxN9Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=RDVhv5v22W4kzsjxfj5Hpt7o6rsxUGDJ0ZlMcmFEaFs=;\n b=bMaiHtt3dfeAvzMXSgXQHunUcAbvQNa1TZi4pxCmdZoV0gfTg7y/y3Dj1oEI+zT3JWrzsk2e25sxDwSdQcdW2qbjxKkWFwdPO3+54RDKSjI8a2sPp5VjUUfCusI1RjgKeC2B51JFNVsl7hpMvCtAwOtTgBHKNIaXXO6hPG/7TGLojrSS/H02KClIQc9SKLfk+7r4l4azgTnpfepezUWrvrmLNqWY0tkf3xsALBUaIHxeprnz/R/00tpmzX2qkxGcH2Qf+oc++ktIjdwuecoZA7GvJaGxMTmZybkqhJyppAL/fAhUVmxbm3ClgQx7DvAi0AKmXNufjYivvQqm7NKtDQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RDVhv5v22W4kzsjxfj5Hpt7o6rsxUGDJ0ZlMcmFEaFs=;\n b=WvdKhL/ZHJeZGNpx6AVofwhd4sqBLqBRln5TBjYS8B+WV34yfNx7rg131CgDdbp9MPaXMTSVvU2vXeCMtWkppFQk6HsozdZ2WcF9QtTJp9npOwM3IFvLf763c1T7Tm+w892/TMGGGSQiFWvybP2LV+RG19/vLFHpl/LVRJ9aRwC8xcuwvVavrB8r0bneI/kTL7YYSPxBGxQS5aqJU+0UhfQDvmj0Bbj1eHekC0T5cmgrnfBiURT2vmf5PxoGpoA78EuVG4uVt2/l97GuVw8IwAVWc4A7f/Zdcj/slRKJQQERbDNXyclA65EEr6MGPsvDgFlBAmqDwasYY1kUc8TW9g==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;","To":"","Date":"Fri, 17 Apr 2026 12:28:42 -0400","Message-ID":"<20260417162842.3565692-1-trozet@nvidia.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Originating-IP":"[10.126.230.37]","X-ClientProxiedBy":"rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MN1PEPF0000F0E3:EE_|DM6PR12MB4187:EE_","X-MS-Office365-Filtering-Correlation-Id":"75478cc0-328c-4e2b-2d4d-08de9c9e82d7","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|36860700016|82310400026|376014|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n rpuXCnLuN/ZtKIq/+72pYup7/A/GxJrhNAOL/nvqU59FKd0v7tm15csa7rMLsBSIvgfT+itI8BWR4rhm74IKM6hk79/jSUoSv0SV03z8AkpxtpMlZa0A59gk7QBKu80XCMx0C54bsYbTbE2pWeZoQqkmPKG7sRjLVa2SoGqrNHBcB3JiH76J5SpANTOyXiJth2jeCE4/pIicnqobilAzSmq4F7GSr4Qnd2LkO7/2mxZcd6Nf7zuzltpvJvLsxu/1Yl8P8VU/9JSRnsLnoBEYG51sssl7t7xRLLJbFilA4teVKIHhSVNeIXLjvDZMUtnIH0FLJtChLhOpi3Zkl+XfAm5RjOwZRf7esFNOb8HKwqsvI7SBP+1wytuP6I2wRdKbQZcdAKiJZo9lmdRruv2+wmbIiqbUzj9YaWH7uU5Ky+Q1Bkak9ShiiGk7Cgc4GtIeiAxG2bUa+UPAxdyuv9qvjmF2P8rTBNinPqDeC0bPIOco8eA7yyr59N1/8v74YL0/41X2lXWPd+9xzvRTIE4iQ0KqiQ0tJFH0hvD8ltl/PImE37AUyoe+xxDNmM3vJzEZyrC+/rfZys2E+gMbQcJ+T56z9WJPJmwTcdEoTD8wFReZVl/fKA4xjCh/Ph64Ypmjrg5B8cFgsjTcUZ4PnhfquNI04zULLzGsgeg4C1ydZaPbVZ50oJKPtFPEdrfWAdUpEPA76mDqBhpbCVdzZuMNNTVExT8rr1liUJNgzzOjYNnXkVOsX1sVCWAD4TMxQvrgidJjyuywDNafTmbvr8ASzA==","X-Forefront-Antispam-Report":"CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n r1A+6lpCuxwnYYwwEeIIItNV553wvRpsuJ7S9bm6iUA9sEds7LhDnBJpydilt0soOkZtGWPKFA3eK6gi81LYDSj/3WCMAuFqYt22gbPxUwJnlEpT2SXmiNDIXjEywNBsKFFdrd+GtTMfU9U5UZTwdb+55VIc2NoqJXonk1JfDsgNG6P0DYmd1RfZmZe+8bAewTtDibOGhdalqYSJB0h8CdZGERXA/xWFvJcYdsTEKjzHQzZEbUSDpCVbKPnt5L5YF6bJ+6ExIbXeDa3RAB1I9fasBi3iuFoMKxgAIpwh8oDHf+8mvIgGRliNa7wrXk5msnDEvcSLPnaFwUdF8LHkUJEMMm4iy4Zvl1khUiJP06M+Pe3N35tVT29yEpwOC73p+tk8fct9JzmEkQIUN35Waj7j9yh5hGdMPTPAp8LmCvfdr3fOQS27uAgk/uADdIN3","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Apr 2026 16:29:34.5310 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 75478cc0-328c-4e2b-2d4d-08de9c9e82d7","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n MN1PEPF0000F0E3.namprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM6PR12MB4187","Subject":"[ovs-dev] [PATCH] dpif-offload: Log flow details for TC offload ERR\n failures.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Tim Rozet via dev ","Reply-To":"Tim Rozet ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"When there are offload errors we see error messages that only include\nthe netdev such as:\n\n2026-03-19T19:42:43.103Z|03122|dpif_netlink(handler367)|ERR|failed to offload flow: Invalid argument: ovn-d2586f-0\n\nThis error message lacks the flow information in order to debug why the\nflow failed to be offloaded. This then requires a user to go reproduce\nthe problem and turn on debug logging to try to correlate the error to a\nflow.\n\nPass the provider error to log_flow_put_message() for flow put failures,\nwhile keeping ENOSPC on the existing debug-only path. This makes the\noffload layer emit the failed flow match/actions for cases like EINVAL,\nso root-causing TC offload failures does not require enabling debug\nlogging.\n\nSigned-off-by: Tim Rozet \n---\n lib/dpif-offload.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/lib/dpif-offload.c b/lib/dpif-offload.c\nindex bb2feced9..290dee2c7 100644\n--- a/lib/dpif-offload.c\n+++ b/lib/dpif-offload.c\n@@ -1279,8 +1279,14 @@ dpif_offload_operate(struct dpif *dpif, struct dpif_op **ops, size_t n_ops,\n \n switch (op->type) {\n case DPIF_OP_FLOW_PUT:\n+ /* Keep ENOSPC and unresolved sentinel values on the\n+ * existing debug-only path, but include full flow\n+ * details for real offload failures. */\n log_flow_put_message(dpif, &this_module,\n- &op->flow_put, 0);\n+ &op->flow_put,\n+ op->error > 0\n+ && op->error != ENOSPC\n+ ? op->error : 0);\n break;\n case DPIF_OP_FLOW_DEL:\n log_flow_del_message(dpif, &this_module,\n","prefixes":["ovs-dev"]}