{"id":2224504,"url":"http://patchwork.ozlabs.org/api/patches/2224504/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20260417132808.235562-4-adhemerval.zanella@linaro.org/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417132808.235562-4-adhemerval.zanella@linaro.org>","list_archive_url":null,"date":"2026-04-17T13:24:57","name":"[3/3] io: Sync fts with gnulib","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cd3473b259e78f2654eb25b6de5c0b98c3fe4085","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/?format=json","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20260417132808.235562-4-adhemerval.zanella@linaro.org/mbox/","series":[{"id":500340,"url":"http://patchwork.ozlabs.org/api/series/500340/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=500340","date":"2026-04-17T13:24:54","name":"Consolidate and sync fts/ftw","version":1,"mbox":"http://patchwork.ozlabs.org/series/500340/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224504/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224504/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=YSRh4Nnx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=YSRh4Nnx","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","sourceware.org; spf=pass smtp.mailfrom=linaro.org","server2.sourceware.org;\n arc=none smtp.remote-ip=2607:f8b0:4864:20::122c"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxwh75X8kz1yD3\n\tfor ; Fri, 17 Apr 2026 23:28:55 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id C70644C9176B\n\tfor ; Fri, 17 Apr 2026 13:28:53 +0000 (GMT)","from mail-dl1-x122c.google.com (mail-dl1-x122c.google.com\n [IPv6:2607:f8b0:4864:20::122c])\n by sourceware.org (Postfix) with ESMTPS id 299844C900D8\n for ; Fri, 17 Apr 2026 13:28:21 +0000 (GMT)","by mail-dl1-x122c.google.com with SMTP id\n a92af1059eb24-12c726ef332so755875c88.1\n for ; Fri, 17 Apr 2026 06:28:21 -0700 (PDT)","from mandiga.. ([2804:1b3:a7c3:d5d0:abc1:209f:f276:2b34])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c74a20eb5sm2556236c88.14.2026.04.17.06.28.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 06:28:18 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org C70644C9176B","OpenDKIM Filter v2.11.0 sourceware.org 299844C900D8"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 299844C900D8","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 299844C900D8","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776432501; cv=none;\n b=UU9yamGR7/fONTOdDYR77NTve3XvuvZ8ZqUYnLhu6WaEsrr0HZ4EdBO3eLr6qEkThj1FyUfphiDeWrI0npnJAPasL+PX5hqDoZCt5xeSttw2h1YxK3R9nnWMc/GPwsq/zcgqwbqK7ksKP9Qu9zAdpswrtDFdsx74e63PoTbrW1Y=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776432501; c=relaxed/simple;\n bh=UC7GJY1aeUdOP1+zLRDB2zDvLuQF2nwhjb2gGhil/cA=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=OYBQpBUwVV9jht2Y1rQ4uG0WjauTfLYMneDAkiv6SPAtNi3PxUOzx8ET8E8PTaBdrve2BNwJ7gQkeEyMgXGnZbwByUvmJumt7wQTj7iQ0XCMb2wDhUk3SyzT8uwhnCvLX+sQQeBhMX7Yym2PxCerSRcVT7zunCU9YBFepd6UpcM=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776432500; x=1777037300; darn=sourceware.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yoQdqde49UxXTPSKq78XUUSuRsA6IVvrLEIPcMJZpco=;\n b=YSRh4NnxRSpDndzoF7oWfRaEoPBH9x7fa10ohDq2lvInprwtH74O1lw66nOGJW7Crq\n n8WyqRiy1ch+WQRFwtJyYhgPoZ+Az4kS196inRxXRYmgT68VQ9G0H/9SSJavpwfqv76z\n nxaN3k2q7BnfeR/fY9viAY3cDPUVliyaDx1PZtK3U+zqTzoPr+MSTPpTRlyijc0LnA0m\n 90xxpkCzLN83+YlaGFVtqYAMTUDgvweaD5ZvxjwuHgvo2ajImBQ6M9X9NDez1Ksn7g8c\n eqiU4S+75KWnZzP1GyLADPwiRDemHq+JyeuzziCfY+BBKKa/VjuUqQSzk75jp5AtyYR6\n h2yg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776432500; x=1777037300;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yoQdqde49UxXTPSKq78XUUSuRsA6IVvrLEIPcMJZpco=;\n b=N0gcv/pxp4HE3GIqEZaaNSneALP9niR8u75t1e+bxgnk31sdivVRh1cq2+qF4p/ZEf\n w7LfLyapXjjqrxUCPG/NK17YasWQe184LM9+WoaBuhJkmAgU8z+JuRqDaUqSfs8ixk5p\n 6ItraQzSivWt4aqt4uFujeUfnL0sgQVKR28dxO4Lde82js49Ueq9/VQpoIuUujFPH6aZ\n o/TddhUlOYPYHe4U6JqcJW/Xp04Q9CUQJBh5uLYhJE9rrbfN8Zfe7bXaGPp5gYqrCGwS\n 9fr9ZaSM9zDflneroM3I3/akwWeU2bh4SmkkMCat6BNO8hh11LwaTMwxBfCEFJWyJZvq\n lkEg==","X-Gm-Message-State":"AOJu0YyjzJD+CMvLIMiB9X2TH52hYZKy9jtnqu3WWAVeaJrqaKuJPo6f\n j3eVnujU2bIs/2Ynztm33AzYFKTNJgEYfYDaAfRuQ8TrbkM8S59WQkTefFcLFMmmQr+Om5dOCO0\n jP1TI","X-Gm-Gg":"AeBDiesyfA+WlzQ+57YN32R+z6v6FlsTSK8Sfv4j0HDy5uTKIveNAQ9oiYaAu1XjVe/\n mtmmywIfODEMUADGh4wdimhFp0YT2DGbMPJuF/fdAkRT6CqjpoNjzEFwR3O6BQ23UNx/pfZkrej\n oJ0W6JjWgG8DkzC3d6W9rvYa0DcXAfKa0VNYZOIpFjcKuZTgCKydXIO0NYja6Tp8IXrepfqHPeU\n sA0nQRG+DMsMEACIh9wKwWjrH1L4+M4J1FGCcOZ71My4mqwInX+JszU8qWgI36C1HUIsTrEHUDI\n O+VdV82HS4DuzFDK8vdDCZK6CGRNMLVHP9lVlPHNQKMDuy2ZcCDtia0e4gEPESrShxWYW0b86Ha\n OC+1Xt4mt+Nv4S6KzvgZXMRqPHj/6FuJ0JdCLZ1UzM3RHfAoUBhrB0mj576WBEAiOgQQRMHd3cP\n 9b8LHUfjlpbfWG73rFGd1L1HlRvwz/wSdEU5eiReE2DDNjEg==","X-Received":"by 2002:a05:7022:fe08:b0:12b:f881:d8d0 with SMTP id\n a92af1059eb24-12c73f9987dmr1204063c88.18.1776432499577;\n Fri, 17 Apr 2026 06:28:19 -0700 (PDT)","From":"Adhemerval Zanella ","To":"libc-alpha@sourceware.org","Cc":"Collin Funk ,\n\tPaul Eggert ","Subject":"[PATCH 3/3] io: Sync fts with gnulib","Date":"Fri, 17 Apr 2026 10:24:57 -0300","Message-ID":"<20260417132808.235562-4-adhemerval.zanella@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260417132808.235562-1-adhemerval.zanella@linaro.org>","References":"<20260417132808.235562-1-adhemerval.zanella@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"},"content":"With both f5ee21eacc5be459a7d08b344196f2245a5de801 and\n9ab4bbed73172085c57b38a337d3dc279b1043b0 to document better FTS_NOSTAT.\n\nChecked on x86_64-linux-gnu and i686-linux-gnu.\n---\n io/fts-common.c | 1 +\n io/fts.h | 13 +++++++++----\n 2 files changed, 10 insertions(+), 4 deletions(-)","diff":"diff --git a/io/fts-common.c b/io/fts-common.c\nindex 3825f0aeb4..8252d716f8 100644\n--- a/io/fts-common.c\n+++ b/io/fts-common.c\n@@ -554,6 +554,7 @@ FTS_OPEN (char * const *argv,\n FTS_XDEV) requires that. */\n if (defer_stat && root != NULL) {\n p->fts_info = FTS_NSOK;\n+ p->fts_statp->st_mode = 0;\n fts_set_stat_required(p, true);\n } else {\n p->fts_info = fts_stat(sp, p, false);\ndiff --git a/io/fts.h b/io/fts.h\nindex 50636e6c87..23518cba32 100644\n--- a/io/fts.h\n+++ b/io/fts.h\n@@ -90,6 +90,13 @@ typedef struct {\n #define\tFTS_COMFOLLOW\t0x0001\t\t/* follow command line symlinks */\n #define\tFTS_LOGICAL\t0x0002\t\t/* logical walk */\n #define\tFTS_NOCHDIR\t0x0004\t\t/* don't change directories */\n+\n+ /* For efficiency do not set *fts_statp except for fts_statp->st_mode,\n+ which is set to zero if the file type is unknown,\n+ and which otherwise has at least its S_IFMT type bits set.\n+ When fts_info == FTS_NSOK this supports expressions like\n+ (fts_statp->st_mode ? !!S_ISDIR (fts_statp->st_mode): -1), which yields\n+ 1 for a directory, 0 for a non-directory, and -1 for unknown. */\n #define\tFTS_NOSTAT\t0x0008\t\t/* don't get stat info */\n #define\tFTS_PHYSICAL\t0x0010\t\t/* physical walk */\n #define\tFTS_SEEDOT\t0x0020\t\t/* return dot and dot-dot */\n@@ -139,10 +146,8 @@ typedef struct {\n Use this flag to make fts_open and fts_read defer the stat/lstat/fststat\n of each entry until it is actually processed. However, note that if you\n use this option and also specify a comparison function, that function may\n- not examine any data via fts_statp. However, when fts_statp->st_mode is\n- nonzero, the S_IFMT type bits are valid, with mapped dirent.d_type data.\n- Of course, that happens only on file systems that provide useful\n- dirent.d_type data. */\n+ not examine any data via fts_statp, other than fts_statp->st_mode\n+ which is set similarly to how FTS_NOSTAT behaves. */\n #define FTS_DEFER_STAT\t0x1000\n \n /* Use this flag to disable stripping of trailing slashes\n","prefixes":["3/3"]}