{"id":2224502,"url":"http://patchwork.ozlabs.org/api/patches/2224502/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417132645.121192-3-sgarzare@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417132645.121192-3-sgarzare@redhat.com>","list_archive_url":null,"date":"2026-04-17T13:26:45","name":"[2/2] libvduse: fix buffer overflow in vduse_queue_read_indirect_desc()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"61997d25f9ffadf890c04a8ca9c2c5dbb0f3f598","submitter":{"id":75453,"url":"http://patchwork.ozlabs.org/api/people/75453/?format=json","name":"Stefano Garzarella","email":"sgarzare@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417132645.121192-3-sgarzare@redhat.com/mbox/","series":[{"id":500339,"url":"http://patchwork.ozlabs.org/api/series/500339/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500339","date":"2026-04-17T13:26:43","name":"libvhost-user, libvduse: fix buffer overflow (CVE-2026-6425)","version":1,"mbox":"http://patchwork.ozlabs.org/series/500339/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224502/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224502/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NqXf6oe+;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=lgzCXc2m;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxwfk5jMyz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 23:27:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDjDu-0003xJ-4T; Fri, 17 Apr 2026 09:27:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <sgarzare@redhat.com>)\n id 1wDjDr-0003wl-1l\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 09:27:03 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <sgarzare@redhat.com>)\n id 1wDjDp-0008T7-Kl\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 09:27:02 -0400","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-561-Bp_rsrDeM8qFEL25jYRISA-1; Fri, 17 Apr 2026 09:26:59 -0400","by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-488d2cd2674so5688045e9.0\n for <qemu-devel@nongnu.org>; Fri, 17 Apr 2026 06:26:59 -0700 (PDT)","from stex1.redhat.corp (host-87-16-204-83.retail.telecomitalia.it.\n [87.16.204.83]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e59f97sm4819635f8f.37.2026.04.17.06.26.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 06:26:55 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776432420;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=TkKEtBNLy2N5J1c6O82yD0C+DpO7PoG1KTI1MijcaHc=;\n b=NqXf6oe+CDLvOnbYwI4vN3c3EWcykSDOiYWuRTsbW9bVsrgAUquWC41gYlmhO8iQJJ9FPd\n kVhAuLx/EgwNnei1tvws0jPSq+mbBj3YLMzuOyQcZWBYHVTIWQzyUxIbISSc9nM8v4dUmm\n mWWSfiiH8hZrBrD4KRESjQso4/5AeFM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776432417; x=1777037217; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TkKEtBNLy2N5J1c6O82yD0C+DpO7PoG1KTI1MijcaHc=;\n b=lgzCXc2mDYbOeIBt4Bo0+ZgNRd3/kNNmHPqb+giWC6LFwpzAzkbA+cdjrsvNBo3Tn4\n ssIvk4L1iTQffunjBygrwZrqqSQMH1BGfTA2mPKsPqKRQd4KRm75cZ2OcXHUI3r4dmM/\n 6cHLy5NP1QcHjulwyADw249i9zYcxxqjjXoBpjqn2r21EJ/HKG7+s5KRJLqDOKvoC0Ax\n N9aB3tKAlZ6dMWBH9dTpWuLiF4TL8zpAn+O4CeSnIoxJvEuFAe9Lr6YL86NS3vYfs50M\n 3C0TH3ZPKMv8yXbeEkNcg0NTGk7MvsoXNJC/I0YHoCCNlGWpyoS6fv5jrrJOEA2gsTCQ\n /FYA=="],"X-MC-Unique":"Bp_rsrDeM8qFEL25jYRISA-1","X-Mimecast-MFC-AGG-ID":"Bp_rsrDeM8qFEL25jYRISA_1776432418","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776432417; x=1777037217;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=TkKEtBNLy2N5J1c6O82yD0C+DpO7PoG1KTI1MijcaHc=;\n b=SJT0UZw4yordYXCwQhdn2MDk9c8RCvuiANIsOiyM18XLoIg0K5vj6dtX9drGUeiWm6\n fCFlA2gpbiYT/JvZdmF6IJgQhlYrJs/Wpjh34f/Y0hQ/SWGI9eEqI6Fe8NOmTSOX9VY2\n lUtnRAs+oo7eDw3sQIDkP5V0HYgBzUXU+gIXRUm3mAq13S2SKnZNWLXrYEjnZ3e39T4W\n MwlPEdvAW85L/7uk1nOhqNFbDzqZxPVuwK0Vh4hTOD7Gf1ZEO1wqLkIwx5EuIyVFicVg\n +TG0g08MIaADhLJTztYAPn/hkKJESApyyOCgtZFreX6he5F2avbKDJ09H4n70bAmUFBy\n 5Qkg==","X-Gm-Message-State":"AOJu0Yyr24coylA2dlguyYpoVuth433ulDCPytIPbCiXQE+774inHSK5\n yTtHzHX6rDkRJjat0VSW7TPrTfZyAdUQVpzNIqVvTsZgy7cnreKFt0BNeFDOhpDmGzgZcGLqjIJ\n u+ER1+c/6D3DFWQzNSq2ZBmoZeFEh8Ffg20B25zqPfcbJUGxTLNGKFN4AmuWCTaVKAslg23XQCo\n AxLdRQcoRLBtEPNVLfBf8R4wv0dL3lrUzNYUtUzTA7","X-Gm-Gg":"AeBDiesv9mUosCLLg/V88B5ykUl0jw97v+TeYe7Fc5Af3NuOg+TDrV6V7W7sgmGOjL+\n AiDhlyMo4iIPWdLxz4LXleXd9FYEEhZ4JHwPbkVKSzYiRWcfzqBAdZt1xcpXNHzDOAjyPq59DeY\n smZs89ZtH992z0rd0wCdijoAIYAe1oCkbDMMS9/abU/Vv1icLimhZonwiWGOCqQTlZANeNsGt0F\n KC0MD2lhhK0qtDiBDhv9JL8R5jedZONHF/ZhSkaH4aVqN327GO4AnbdgBSy4Dua1O6jk+LhjwJ7\n Fw3C1jkxUi8xXJpMxTGpfKupNYg1PYifeRRxfAUqcPIAPCTKdtAjDquwUIYw5unk0EQ28qsoWCo\n qKt23b5uRCsWP/ujbZhdyQFCraJflEQgnJmsBuGOCviuzDjrpaoJFUs7EzWUwJNgLQpkZGFxTOT\n /40J8O3r1+","X-Received":["by 2002:a05:600c:8588:b0:488:9619:9bf4 with SMTP id\n 5b1f17b1804b1-488fb771b04mr32560365e9.20.1776432417193;\n Fri, 17 Apr 2026 06:26:57 -0700 (PDT)","by 2002:a05:600c:8588:b0:488:9619:9bf4 with SMTP id\n 5b1f17b1804b1-488fb771b04mr32559645e9.20.1776432416610;\n Fri, 17 Apr 2026 06:26:56 -0700 (PDT)"],"From":"Stefano Garzarella <sgarzare@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Xie Yongji <xieyongji@bytedance.com>, qemu-stable@nongnu.org,\n \"Michael S. Tsirkin\" <mst@redhat.com>,\n Stefano Garzarella <sgarzare@redhat.com>, DARKNAVY <vr@darknavy.com>","Subject":"[PATCH 2/2] libvduse: fix buffer overflow in\n vduse_queue_read_indirect_desc()","Date":"Fri, 17 Apr 2026 15:26:45 +0200","Message-ID":"<20260417132645.121192-3-sgarzare@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260417132645.121192-1-sgarzare@redhat.com>","References":"<20260417132645.121192-1-sgarzare@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=sgarzare@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Stefano Garzarella <sgarzare@redhat.com>\n\nvduse_queue_read_indirect_desc() copies an indirect descriptor table\ninto a buffer in chunks when the table crosses a memory region\nboundary. The destination is a struct vring_desc pointer but is\nadvanced by a byte count, so each increment moves the pointer by\nread_len elements instead of read_len bytes, writing beyond the\nbuffer.\n\nUse a char pointer for the destination so that the arithmetic\nadvances correctly.\n\nWhile at it, change the source from a struct vring_desc pointer\nto a void pointer: when the table is split across regions,\niova_to_va() can return a pointer into the middle of a descriptor,\nso casting it to a struct vring_desc pointer is wrong. The pointer is\nonly used as a memcpy() source, so a void pointer is fine.\n\nFixes: CVE-2026-6425\nFixes: a6caeee811 (\"libvduse: Add VDUSE (vDPA Device in Userspace) library\")\nCc: qemu-stable@nongnu.org\nReported-by: DARKNAVY <vr@darknavy.com>\nSigned-off-by: Stefano Garzarella <sgarzare@redhat.com>\n---\n subprojects/libvduse/libvduse.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/subprojects/libvduse/libvduse.c b/subprojects/libvduse/libvduse.c\nindex 21ffbb5b8d..df9ca5e56f 100644\n--- a/subprojects/libvduse/libvduse.c\n+++ b/subprojects/libvduse/libvduse.c\n@@ -465,8 +465,9 @@ static int\n vduse_queue_read_indirect_desc(VduseDev *dev, struct vring_desc *desc,\n                                uint64_t addr, size_t len)\n {\n-    struct vring_desc *ori_desc;\n+    char *dst_desc = (char *)desc;\n     uint64_t read_len;\n+    void *ori_desc;\n \n     if (len > (VIRTQUEUE_MAX_SIZE * sizeof(struct vring_desc))) {\n         return -1;\n@@ -483,10 +484,10 @@ vduse_queue_read_indirect_desc(VduseDev *dev, struct vring_desc *desc,\n             return -1;\n         }\n \n-        memcpy(desc, ori_desc, read_len);\n+        memcpy(dst_desc, ori_desc, read_len);\n         len -= read_len;\n         addr += read_len;\n-        desc += read_len;\n+        dst_desc += read_len;\n     }\n \n     return 0;\n","prefixes":["2/2"]}