{"id":2224384,"url":"http://patchwork.ozlabs.org/api/patches/2224384/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-7-magnuskulke@linux.microsoft.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417105618.3621-7-magnuskulke@linux.microsoft.com>","list_archive_url":null,"date":"2026-04-17T10:55:50","name":"[06/34] accel/accel-irq: add generic commit_route_changes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"89a3e981cf15182713430789cc8b3046473c4f0d","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/?format=json","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-7-magnuskulke@linux.microsoft.com/mbox/","series":[{"id":500310,"url":"http://patchwork.ozlabs.org/api/series/500310/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500310","date":"2026-04-17T10:55:44","name":"Add migration support to the MSHV accelerator","version":1,"mbox":"http://patchwork.ozlabs.org/series/500310/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224384/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224384/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=kE/Mp9sg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxsKy730Gz1yD3\n\tfor ; Fri, 17 Apr 2026 20:57:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDgsU-0000N5-UB; Fri, 17 Apr 2026 06:56:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDgsT-0000Mp-A0\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:56:49 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wDgsR-0001XG-OI\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:56:49 -0400","from DESKTOP-TUU1E5L.fritz.box (p5086d620.dip0.t-ipconnect.de\n [80.134.214.32])\n by linux.microsoft.com (Postfix) with ESMTPSA id 063B620B7128;\n Fri, 17 Apr 2026 03:56:43 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com 063B620B7128","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1776423406;\n bh=/agQnXNBT1WkQmDfzU3UPBeR7shsVTN7r5KTnFUfoDg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=kE/Mp9sglD4u3Y+T7H/EYSbuNQFxkKd9hWWVFtf9UaBFTMOGGk8kPeFwc3cASeQVf\n IcXb1/vF4mER7Hz+UZ3tc+VMjCU6Y24E4PfPYoU4ahASH3ixljrQ8sCaCXapsp4F90\n MyYNNc/RfIBbZ5Tmsr/oXhEqB7MZnQIlbAyMdicg=","From":"Magnus Kulke ","To":"qemu-devel@nongnu.org","Cc":"kvm@vger.kernel.org, Magnus Kulke ,\n Wei Liu , \"Michael S. Tsirkin\" ,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Zhao Liu ,\n Richard Henderson ,\n Paolo Bonzini , Wei Liu ,\n Magnus Kulke ,\n Alex Williamson ,\n Marcel Apfelbaum , =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?q?aud=C3=A9?= ,\n Marcelo Tosatti ","Subject":"[PATCH 06/34] accel/accel-irq: add generic commit_route_changes","Date":"Fri, 17 Apr 2026 12:55:50 +0200","Message-Id":"<20260417105618.3621-7-magnuskulke@linux.microsoft.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260417105618.3621-1-magnuskulke@linux.microsoft.com>","References":"<20260417105618.3621-1-magnuskulke@linux.microsoft.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-42","X-Spam_score":"-4.3","X-Spam_bar":"----","X-Spam_report":"(-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"A generic accel_irqchip_commit_route_changes() fn has been introduced for\nusage in the MSHV accelerator. The respective kvm_ fn can be removed\nsince we handle the commit op in a generic way.\n\nSigned-off-by: Magnus Kulke \n---\n accel/accel-irq.c | 10 +++-------\n hw/misc/ivshmem-pci.c | 2 +-\n hw/vfio/pci.c | 4 ++--\n include/system/kvm.h | 8 --------\n target/i386/kvm/kvm.c | 2 +-\n 5 files changed, 7 insertions(+), 19 deletions(-)","diff":"diff --git a/accel/accel-irq.c b/accel/accel-irq.c\nindex 3815f6727c..7e71b52555 100644\n--- a/accel/accel-irq.c\n+++ b/accel/accel-irq.c\n@@ -45,13 +45,9 @@ int accel_irqchip_update_msi_route(int vector, MSIMessage msg, PCIDevice *dev)\n \n void accel_irqchip_commit_route_changes(AccelRouteChange *c)\n {\n-#ifdef CONFIG_MSHV_IS_POSSIBLE\n- if (mshv_msi_via_irqfd_enabled()) {\n- mshv_irqchip_commit_routes();\n- }\n-#endif\n- if (kvm_enabled()) {\n- kvm_irqchip_commit_route_changes(c);\n+ if (c->changes) {\n+ accel_irqchip_commit_routes();\n+ c->changes = 0;\n }\n }\n \ndiff --git a/hw/misc/ivshmem-pci.c b/hw/misc/ivshmem-pci.c\nindex fa23562886..536475e9de 100644\n--- a/hw/misc/ivshmem-pci.c\n+++ b/hw/misc/ivshmem-pci.c\n@@ -436,7 +436,7 @@ static void ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector,\n error_setg(errp, \"kvm_irqchip_add_msi_route failed\");\n return;\n }\n- kvm_irqchip_commit_route_changes(&c);\n+ accel_irqchip_commit_route_changes(&c);\n \n s->msi_vectors[vector].virq = ret;\n s->msi_vectors[vector].pdev = pdev;\ndiff --git a/hw/vfio/pci.c b/hw/vfio/pci.c\nindex 35b4545482..fb20902412 100644\n--- a/hw/vfio/pci.c\n+++ b/hw/vfio/pci.c\n@@ -695,7 +695,7 @@ static int vfio_msix_vector_do_use(PCIDevice *pdev, unsigned int nr,\n } else {\n vfio_route_change = accel_irqchip_begin_route_changes();\n vfio_pci_add_kvm_msi_virq(vdev, vector, nr, true);\n- kvm_irqchip_commit_route_changes(&vfio_route_change);\n+ accel_irqchip_commit_route_changes(&vfio_route_change);\n vfio_connect_kvm_msi_virq(vector, nr);\n }\n }\n@@ -804,7 +804,7 @@ void vfio_pci_commit_kvm_msi_virq_batch(VFIOPCIDevice *vdev)\n assert(vdev->defer_kvm_irq_routing);\n vdev->defer_kvm_irq_routing = false;\n \n- kvm_irqchip_commit_route_changes(&vfio_route_change);\n+ accel_irqchip_commit_route_changes(&vfio_route_change);\n \n for (i = 0; i < vdev->nr_vectors; i++) {\n vfio_connect_kvm_msi_virq(&vdev->msi_vectors[i], i);\ndiff --git a/include/system/kvm.h b/include/system/kvm.h\nindex fec24d2135..cdd1856ac5 100644\n--- a/include/system/kvm.h\n+++ b/include/system/kvm.h\n@@ -476,14 +476,6 @@ int kvm_irqchip_update_msi_route(KVMState *s, int virq, MSIMessage msg,\n PCIDevice *dev);\n void kvm_irqchip_commit_routes(KVMState *s);\n \n-static inline void kvm_irqchip_commit_route_changes(AccelRouteChange *c)\n-{\n- if (c->changes) {\n- kvm_irqchip_commit_routes(KVM_STATE(c->accel));\n- c->changes = 0;\n- }\n-}\n-\n int kvm_irqchip_get_virq(KVMState *s);\n void kvm_irqchip_release_virq(KVMState *s, int virq);\n \ndiff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c\nindex 03312922d5..64cc421abe 100644\n--- a/target/i386/kvm/kvm.c\n+++ b/target/i386/kvm/kvm.c\n@@ -6690,7 +6690,7 @@ void kvm_arch_init_irq_routing(KVMState *s)\n exit(1);\n }\n }\n- kvm_irqchip_commit_route_changes(&c);\n+ accel_irqchip_commit_route_changes(&c);\n }\n }\n \n","prefixes":["06/34"]}