{"id":2224383,"url":"http://patchwork.ozlabs.org/api/patches/2224383/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-15-magnuskulke@linux.microsoft.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417105618.3621-15-magnuskulke@linux.microsoft.com>","list_archive_url":null,"date":"2026-04-17T10:55:58","name":"[14/34] target/i386/mshv: move apic logic into own file","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9d79a24dd3ce8af58bc67016ec7b8eab94059a55","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/?format=json","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-15-magnuskulke@linux.microsoft.com/mbox/","series":[{"id":500310,"url":"http://patchwork.ozlabs.org/api/series/500310/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500310","date":"2026-04-17T10:55:44","name":"Add migration support to the MSHV accelerator","version":1,"mbox":"http://patchwork.ozlabs.org/series/500310/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224383/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224383/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=pCtQQ8/u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxsKn6d7cz1yD3\n\tfor ; Fri, 17 Apr 2026 20:57:49 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDgt2-0001G1-8y; Fri, 17 Apr 2026 06:57:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDgsx-0001Cl-P8\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:57:20 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wDgsv-0001bL-HM\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:57:19 -0400","from DESKTOP-TUU1E5L.fritz.box (p5086d620.dip0.t-ipconnect.de\n [80.134.214.32])\n by linux.microsoft.com (Postfix) with ESMTPSA id EFCDC20B7129;\n Fri, 17 Apr 2026 03:57:12 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com EFCDC20B7129","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1776423435;\n bh=kAv+LDx2C4ktwPdqcp1byyxTrJZIOpxr4ispcmeai88=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pCtQQ8/u06ztShHZMaxq6QkWoKHL8hHK02vn3C0K60/tUu5/7j8mcQQ+4Ok7atcFd\n oVBtwIbsq5FDCg9Jvx4y3fTUd2b5lk3Om0/K4DVLd3uLOrEYYezvMV91aJ6Dhd7gsL\n 4zYPoIPWIAAiDTPD9b44kZQLNKrOS9yCfLN67oww=","From":"Magnus Kulke ","To":"qemu-devel@nongnu.org","Cc":"kvm@vger.kernel.org, Magnus Kulke ,\n Wei Liu , \"Michael S. Tsirkin\" ,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Zhao Liu ,\n Richard Henderson ,\n Paolo Bonzini , Wei Liu ,\n Magnus Kulke ,\n Alex Williamson ,\n Marcel Apfelbaum , =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?q?aud=C3=A9?= ,\n Marcelo Tosatti ","Subject":"[PATCH 14/34] target/i386/mshv: move apic logic into own file","Date":"Fri, 17 Apr 2026 12:55:58 +0200","Message-Id":"<20260417105618.3621-15-magnuskulke@linux.microsoft.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260417105618.3621-1-magnuskulke@linux.microsoft.com>","References":"<20260417105618.3621-1-magnuskulke@linux.microsoft.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-42","X-Spam_score":"-4.3","X-Spam_bar":"----","X-Spam_report":"(-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use a new file to unclutter the vcpu code gradually from APIC related\nlogic.\n\nSigned-off-by: Magnus Kulke \n---\n include/system/mshv_int.h | 8 ++++\n target/i386/mshv/meson.build | 1 +\n target/i386/mshv/mshv-apic.c | 78 ++++++++++++++++++++++++++++++++++++\n 3 files changed, 87 insertions(+)\n create mode 100644 target/i386/mshv/mshv-apic.c","diff":"diff --git a/include/system/mshv_int.h b/include/system/mshv_int.h\nindex 7af5bcf022..f86c7a3be6 100644\n--- a/include/system/mshv_int.h\n+++ b/include/system/mshv_int.h\n@@ -16,6 +16,8 @@\n \n #define MSHV_MSR_ENTRIES_COUNT 64\n \n+struct mshv_get_set_vp_state;\n+\n typedef struct hyperv_message hv_message;\n \n typedef struct MshvHvCallArgs {\n@@ -84,6 +86,12 @@ void mshv_arch_destroy_vcpu(CPUState *cpu);\n void mshv_arch_amend_proc_features(\n union hv_partition_synthetic_processor_features *features);\n int mshv_arch_post_init_vm(int vm_fd);\n+int mshv_set_lapic(int cpu_fd,\n+ const struct hv_local_interrupt_controller_state *state);\n+int mshv_get_lapic(int cpu_fd,\n+ struct hv_local_interrupt_controller_state *state);\n+int mshv_get_vp_state(int cpu_fd, struct mshv_get_set_vp_state *state);\n+int mshv_set_vp_state(int cpu_fd, const struct mshv_get_set_vp_state *state);\n \n typedef struct mshv_root_hvcall mshv_root_hvcall;\n int mshv_hvcall(int fd, const mshv_root_hvcall *args);\ndiff --git a/target/i386/mshv/meson.build b/target/i386/mshv/meson.build\nindex 49f28d4a5b..5eb6e833a6 100644\n--- a/target/i386/mshv/meson.build\n+++ b/target/i386/mshv/meson.build\n@@ -1,6 +1,7 @@\n i386_mshv_ss = ss.source_set()\n \n i386_mshv_ss.add(files(\n+ 'mshv-apic.c',\n 'mshv-cpu.c',\n ))\n \ndiff --git a/target/i386/mshv/mshv-apic.c b/target/i386/mshv/mshv-apic.c\nnew file mode 100644\nindex 0000000000..e0e8b8cacf\n--- /dev/null\n+++ b/target/i386/mshv/mshv-apic.c\n@@ -0,0 +1,78 @@\n+/*\n+ * QEMU MSHV support\n+ *\n+ * Copyright Microsoft, Corp. 2026\n+ *\n+ * Authors: Magnus Kulke \n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"qemu/memalign.h\"\n+#include \"qemu/error-report.h\"\n+\n+#include \"system/mshv.h\"\n+#include \"system/mshv_int.h\"\n+\n+#include \"linux/mshv.h\"\n+#include \"hw/hyperv/hvgdk.h\"\n+#include \"hw/hyperv/hvhdk_mini.h\"\n+#include \"hw/hyperv/hvgdk_mini.h\"\n+\n+#include \n+\n+int mshv_get_lapic(int cpu_fd,\n+ struct hv_local_interrupt_controller_state *state)\n+{\n+ int ret;\n+ size_t size = 4096;\n+ /* buffer aligned to 4k, as *state requires that */\n+ void *buffer = qemu_memalign(size, size);\n+ struct mshv_get_set_vp_state mshv_state = { 0 };\n+\n+ mshv_state.buf_ptr = (uint64_t) buffer;\n+ mshv_state.buf_sz = size;\n+ mshv_state.type = MSHV_VP_STATE_LAPIC;\n+\n+ ret = mshv_get_vp_state(cpu_fd, &mshv_state);\n+ if (ret == 0) {\n+ memcpy(state, buffer, sizeof(*state));\n+ }\n+ qemu_vfree(buffer);\n+ if (ret < 0) {\n+ error_report(\"failed to get lapic\");\n+ return -1;\n+ }\n+\n+ return 0;\n+}\n+\n+int mshv_set_lapic(int cpu_fd,\n+ const struct hv_local_interrupt_controller_state *state)\n+{\n+ int ret;\n+ size_t size = 4096;\n+ /* buffer aligned to 4k, as *state requires that */\n+ void *buffer = qemu_memalign(size, size);\n+ struct mshv_get_set_vp_state mshv_state = { 0 };\n+\n+ if (!state) {\n+ error_report(\"lapic state is NULL\");\n+ return -1;\n+ }\n+ memcpy(buffer, state, sizeof(*state));\n+\n+ mshv_state.buf_ptr = (uint64_t) buffer;\n+ mshv_state.buf_sz = size;\n+ mshv_state.type = MSHV_VP_STATE_LAPIC;\n+\n+ ret = mshv_set_vp_state(cpu_fd, &mshv_state);\n+ qemu_vfree(buffer);\n+ if (ret < 0) {\n+ error_report(\"failed to set lapic: %s\", strerror(errno));\n+ return -1;\n+ }\n+\n+ return 0;\n+}\n","prefixes":["14/34"]}