{"id":2224337,"url":"http://patchwork.ozlabs.org/api/patches/2224337/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417-sdcard-performance-b4-v4-7-119e66be10c2@avm.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417-sdcard-performance-b4-v4-7-119e66be10c2@avm.de>","list_archive_url":null,"date":"2026-04-17T09:51:40","name":"[v4,7/7] hw/sd: Update trace events for buf+len data","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2891e752f128c08f57b228aede07161c1bbe94ab","submitter":{"id":91343,"url":"http://patchwork.ozlabs.org/api/people/91343/?format=json","name":"Christian Speich","email":"c.speich@avm.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417-sdcard-performance-b4-v4-7-119e66be10c2@avm.de/mbox/","series":[{"id":500297,"url":"http://patchwork.ozlabs.org/api/series/500297/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500297","date":"2026-04-17T09:51:34","name":"hw/sd: Improve performance of read/write/erase","version":4,"mbox":"http://patchwork.ozlabs.org/series/500297/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224337/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224337/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=avm.de header.i=@avm.de header.a=rsa-sha256\n header.s=mail header.b=R98l8Psu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxr1m2bBcz1yDF\n\tfor ; Fri, 17 Apr 2026 19:58:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDfxo-0003ca-QR; Fri, 17 Apr 2026 05:58:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfxC-0002qB-1D; Fri, 17 Apr 2026 05:57:38 -0400","from mail.avm.de ([2001:bf0:244:244::119])\n by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfx9-000385-Fu; Fri, 17 Apr 2026 05:57:37 -0400","from [172.16.0.1] (helo=mail.avm.de)\n by mail.avm.de with ESMTP (eXpurgate 4.55.2)\n (envelope-from )\n id 69e20406-1e6c-7f0000032729-7f000001b2d8-1\n for ; Fri, 17 Apr 2026 11:57:26 +0200","from mail-notes.avm.de (mail-notes.avm.de [172.16.0.1])\n by mail.avm.de (Postfix) with ESMTP;\n Fri, 17 Apr 2026 11:57:26 +0200 (CEST)","from [127.0.1.1] ([172.17.89.139])\n by mail-notes.avm.de (HCL Domino Release 14.0FP4)\n with ESMTP id 2026041711572446-2980 ;\n Fri, 17 Apr 2026 11:57:24 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=avm.de; s=mail;\n t=1776419846; bh=SRP0r66lkPbAsXef7wraN73YdZHRb8aL7UMn1EI5U3Q=;\n h=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n b=R98l8PsuL/yWR09LLVXQ6ScreJePL0C6Aj7xtTdXrjSQJIZmvLwu13Ep/steuNdP8\n N5TQw3Uhe+DD++DaHZ711S8QK5gA7qHeq3yzCLFjYw7U6CU4Vlqsqb+vIxbRUDir+Y\n gDEMMW+uYtcHsg7NMC+PjM1xEueP2RkmydvBiuMA=","From":"Christian Speich ","Date":"Fri, 17 Apr 2026 11:51:40 +0200","Subject":"[PATCH v4 7/7] hw/sd: Update trace events for buf+len data","MIME-Version":"1.0","Message-Id":"<20260417-sdcard-performance-b4-v4-7-119e66be10c2@avm.de>","References":"<20260417-sdcard-performance-b4-v4-0-119e66be10c2@avm.de>","In-Reply-To":"<20260417-sdcard-performance-b4-v4-0-119e66be10c2@avm.de>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Bin Meng , qemu-block@nongnu.org,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Christian Speich ","X-Mailer":"b4 0.14.2","X-MIMETrack":"Itemize by SMTP Server on ANIS1/AVM(Release 14.0FP4|March 10,\n 2025) at 17.04.2026 11:57:24,\n Serialize by Router on ANIS1/AVM(Release 14.0FP4|March 10, 2025) at\n 17.04.2026 11:57:26, Serialize complete at 17.04.2026 11:57:26","X-TNEFEvaluated":"1","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"utf-8\"","X-purgate-ID":"149429::1776419846-48727373-546759EF/0/0","X-purgate-type":"clean","X-purgate-size":"6295","X-purgate-Ad":"Categorized by eleven eXpurgate (R) https://www.eleven.de","X-purgate":["This mail is considered clean (visit https://www.eleven.de for\n further information)","clean"],"Received-SPF":"pass client-ip=2001:bf0:244:244::119;\n envelope-from=c.speich@avm.de; helo=mail.avm.de","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"After switching sdbuf and sdcard over to use buf+len instead of single\nbyte operation, the trace events need to be updated.\n\nThis patch updates sdbus_{read,write} and sdcard_write_data to output the\nbuffer that is worked on.\n\nsdcard_read_data is left unchanged, as it did not print the read byte\nbefore anyways.\n\nSigned-off-by: Christian Speich \n---\n hw/sd/core.c | 27 +++++++++++++++++++++++++--\n hw/sd/sd.c | 19 +++++++++++++++----\n hw/sd/trace-events | 6 +++---\n 3 files changed, 43 insertions(+), 9 deletions(-)","diff":"diff --git a/hw/sd/core.c b/hw/sd/core.c\nindex 594c5e011ba30940a33799f9032c92494ee0ca19..eaa186fbfca3cdf000c200c3a844aac373ba7fec 100644\n--- a/hw/sd/core.c\n+++ b/hw/sd/core.c\n@@ -24,6 +24,7 @@\n #include \"hw/sd/sd.h\"\n #include \"qemu/module.h\"\n #include \"qapi/error.h\"\n+#include \"qemu/cutils.h\"\n #include \"sdmmc-internal.h\"\n #include \"trace.h\"\n \n@@ -43,6 +44,26 @@ static SDState *get_card(SDBus *sdbus)\n return SDMMC_COMMON(kid->child);\n }\n \n+static void sdbus_write_dump(const char *bus_name, const void *buf, size_t len)\n+{\n+ g_autoptr(GString) str = NULL;\n+\n+ if (trace_event_get_state_backends(TRACE_SDBUS_WRITE)) {\n+ str = qemu_hexdump_line(NULL, buf, len, 8, 0);\n+ trace_sdbus_write(bus_name, str->str);\n+ }\n+}\n+\n+static void sdbus_read_dump(const char *bus_name, const void *buf, size_t len)\n+{\n+ g_autoptr(GString) str = NULL;\n+\n+ if (trace_event_get_state_backends(TRACE_SDBUS_READ)) {\n+ str = qemu_hexdump_line(NULL, buf, len, 8, 0);\n+ trace_sdbus_read(bus_name, str->str);\n+ }\n+}\n+\n uint8_t sdbus_get_dat_lines(SDBus *sdbus)\n {\n SDState *slave = get_card(sdbus);\n@@ -109,7 +130,7 @@ void sdbus_write_byte(SDBus *sdbus, uint8_t value)\n {\n SDState *card = get_card(sdbus);\n \n- trace_sdbus_write(sdbus_name(sdbus), value);\n+ sdbus_write_dump(sdbus_name(sdbus), &value, 1);\n if (card) {\n SDCardClass *sc = SDMMC_COMMON_GET_CLASS(card);\n \n@@ -121,6 +142,7 @@ void sdbus_write_data(SDBus *sdbus, const void *buf, size_t length)\n {\n SDState *card = get_card(sdbus);\n \n+ sdbus_write_dump(sdbus_name(sdbus), buf, length);\n if (card) {\n SDCardClass *sc = SDMMC_COMMON_GET_CLASS(card);\n \n@@ -145,7 +167,7 @@ uint8_t sdbus_read_byte(SDBus *sdbus)\n \n sc->read_data(card, &value, 1);\n }\n- trace_sdbus_read(sdbus_name(sdbus), value);\n+ sdbus_read_dump(sdbus_name(sdbus), &value, 1);\n \n return value;\n }\n@@ -166,6 +188,7 @@ void sdbus_read_data(SDBus *sdbus, void *buf, size_t length)\n length -= read;\n }\n }\n+ sdbus_read_dump(sdbus_name(sdbus), buf, length);\n }\n \n bool sdbus_receive_ready(SDBus *sdbus)\ndiff --git a/hw/sd/sd.c b/hw/sd/sd.c\nindex d1ff9badb39b699ce734a533ccebfab894958d2d..13039187fcda2444d1b4aa173ab64c601bc71924 100644\n--- a/hw/sd/sd.c\n+++ b/hw/sd/sd.c\n@@ -2690,11 +2690,22 @@ static bool sd_generic_read_data(SDState *sd, void *buf, size_t *len)\n return false;\n }\n \n+static void sdcard_write_data_dump(const char *proto, const char *cmd_desc,\n+ uint8_t cmd, uint32_t offset,\n+ const void *buf, size_t len)\n+{\n+ g_autoptr(GString) str = NULL;\n+\n+ if (trace_event_get_state_backends(TRACE_SDCARD_WRITE_DATA)) {\n+ str = qemu_hexdump_line(NULL, buf, len, 8, 0);\n+ trace_sdcard_write_data(proto, cmd_desc, cmd, offset, str->str);\n+ }\n+}\n+\n static size_t sd_write_data(SDState *sd, const void *buf, size_t length)\n {\n unsigned int partition_access;\n int i;\n- const uint8_t *value = buf;\n \n if (!sd->blk || !blk_is_inserted(sd->blk)) {\n return length;\n@@ -2709,9 +2720,9 @@ static size_t sd_write_data(SDState *sd, const void *buf, size_t length)\n if (sd->card_status & (ADDRESS_ERROR | WP_VIOLATION))\n return length;\n \n- trace_sdcard_write_data(sd->proto->name,\n- sd->last_cmd_name,\n- sd->current_cmd, sd->data_offset, value[0]);\n+ sdcard_write_data_dump(sd->proto->name,\n+ sd->last_cmd_name,\n+ sd->current_cmd, sd->data_offset, buf, length);\n switch (sd->current_cmd) {\n case 24: /* CMD24: WRITE_SINGLE_BLOCK */\n if (sd_generic_write_data(sd, buf, &length)) {\ndiff --git a/hw/sd/trace-events b/hw/sd/trace-events\nindex 4ec52d2a81995ddf8d4ebef9dcc79224c90a2982..c6811f3a08e018fc45ec4f259b5895998b86bd77 100644\n--- a/hw/sd/trace-events\n+++ b/hw/sd/trace-events\n@@ -15,8 +15,8 @@ bcm2835_sdhost_update_irq(uint32_t irq) \"IRQ bits 0x%x\"\n \n # core.c\n sdbus_command(const char *bus_name, uint8_t cmd, uint32_t arg) \"@%s CMD%02d arg 0x%08x\"\n-sdbus_read(const char *bus_name, uint8_t value) \"@%s value 0x%02x\"\n-sdbus_write(const char *bus_name, uint8_t value) \"@%s value 0x%02x\"\n+sdbus_read(const char *bus_name, const char *hexdump) \"@%s data %s\"\n+sdbus_write(const char *bus_name, const char *hexdump) \"@%s data %s\"\n sdbus_set_voltage(const char *bus_name, uint16_t millivolts) \"@%s %u (mV)\"\n sdbus_get_dat_lines(const char *bus_name, uint8_t dat_lines) \"@%s dat_lines: %u\"\n sdbus_get_cmd_line(const char *bus_name, bool cmd_line) \"@%s cmd_line: %u\"\n@@ -54,7 +54,7 @@ sdcard_unlock(void) \"\"\n sdcard_req_addr(uint32_t req_arg, uint64_t addr) \"req 0x%\" PRIx32 \" addr 0x%\" PRIx64\n sdcard_read_block(uint64_t addr, uint32_t len) \"addr 0x%\" PRIx64 \" size 0x%x\"\n sdcard_write_block(uint64_t addr, uint32_t len) \"addr 0x%\" PRIx64 \" size 0x%x\"\n-sdcard_write_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint32_t offset, uint8_t value) \"%s %20s/ CMD%02d ofs %\"PRIu32\" value 0x%02x\"\n+sdcard_write_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint32_t offset, const char *hexdump) \"%s %20s/ CMD%02d ofs %\"PRIu32\" data %s\"\n sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint32_t offset, uint64_t size, uint32_t blklen) \"%s %20s/ CMD%02d ofs %\"PRIu32\" size %\"PRIu64\" blklen %\" PRIu32\n sdcard_set_voltage(uint16_t millivolts) \"%u mV\"\n sdcard_ext_csd_update(unsigned index, uint8_t oval, uint8_t nval) \"index %u: 0x%02x -> 0x%02x\"\n","prefixes":["v4","7/7"]}