{"id":2224233,"url":"http://patchwork.ozlabs.org/api/patches/2224233/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417062954.1241900-2-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417062954.1241900-2-aleksandr.loktionov@intel.com>","list_archive_url":null,"date":"2026-04-17T06:29:51","name":"[iwl-net,1/4] ice: fix asymmetric pause negotiation reporting in ethtool","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"03b81c9adc2f88def1def158ec73a1859c32ac10","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417062954.1241900-2-aleksandr.loktionov@intel.com/mbox/","series":[{"id":500242,"url":"http://patchwork.ozlabs.org/api/series/500242/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500242","date":"2026-04-17T06:29:50","name":"ice: fixes for pause reporting, autoneg, RDMA and EIPE","version":1,"mbox":"http://patchwork.ozlabs.org/series/500242/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224233/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224233/checks/","tags":{},"related":[],"headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=5OeqjPmm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxlNt0lBdz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 16:30:05 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 7A01860BFD;\n\tFri, 17 Apr 2026 06:30:03 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id z1Gfz5Zu6eNY; Fri, 17 Apr 2026 06:30:02 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0171460A37;\n\tFri, 17 Apr 2026 06:30:02 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id BC352259\n for <intel-wired-lan@lists.osuosl.org>; Fri, 17 Apr 2026 06:30:00 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id B63E740544\n for <intel-wired-lan@lists.osuosl.org>; Fri, 17 Apr 2026 06:29:59 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9F8gkiZMV48r for <intel-wired-lan@lists.osuosl.org>;\n Fri, 17 Apr 2026 06:29:59 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.8])\n by smtp2.osuosl.org (Postfix) with ESMTPS id D5A7840549\n for <intel-wired-lan@lists.osuosl.org>; Fri, 17 Apr 2026 06:29:58 +0000 (UTC)","from orviesa004.jf.intel.com ([10.64.159.144])\n by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2026 23:29:58 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa004.jf.intel.com with ESMTP; 16 Apr 2026 23:29:57 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0171460A37","OpenDKIM Filter v2.11.0 smtp2.osuosl.org D5A7840549"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776407402;\n\tbh=t5nGa4RIb/4T3Kha6mskKhZqMMTdqNUDUWtdHUuDgWM=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=5OeqjPmmeR2/ZhSlsYnlI8xi9asTesLRIIkacQI2+VjTJO9MTnGBdNupRA5daxbuN\n\t y91qsAQ+WuSb0+ARL1mxe3VX0swbHvYpxaRBvYphjIN1H34uEzR6w70NOMftiyY9qS\n\t qJuqMLJ3RizUdp7C/OcMkIsqP6lTcx7h37404oP/wDy/+tJZzm2vthQCx/3bkv5F2c\n\t T++jwCUNHJ+XJOJvT8MbAPzaY2V6IllrfB3U4tHaQiNtlz5Uy9QFrODQ0smyx39iOk\n\t Ma2RXocs2tseylw0Q0jn5FmlJDd7KnwJ9qwqOY19oXzV8QsZOdags3QYkavlgkZMBq\n\t Wfj9gCDMj//xA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.8;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org D5A7840549","X-CSE-ConnectionGUID":["X/KlItGgRdWbHx7EMSRibg==","hjiE5TySS0mSobvm8mwu2w=="],"X-CSE-MsgGUID":["yppb9PzrQtiITdBFhcpRLQ==","nSUJVnO1Qt2511GUbNuZcw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11761\"; a=\"94987401\"","E=Sophos;i=\"6.23,183,1770624000\"; d=\"scan'208\";a=\"94987401\"","E=Sophos;i=\"6.23,183,1770624000\"; d=\"scan'208\";a=\"235329565\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov <aleksandr.loktionov@intel.com>","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org,\n\tTomasz Lichwala <tomasz.lichwala@intel.com>","Date":"Fri, 17 Apr 2026 08:29:51 +0200","Message-ID":"<20260417062954.1241900-2-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260417062954.1241900-1-aleksandr.loktionov@intel.com>","References":"<20260417062954.1241900-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776407398; x=1807943398;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Ft/kcfML2Lvq20vgPFkL9YTpdxCIU+mdWRUQIMyuaGs=;\n b=NCalqbGTYeXbAWgNn3tPrubRb+6NwPF0xWbj4Wi04YLzqkauFlbh9m8C\n Y5aojDTikNtT4Ydl9J5VQtdCAJoKSJgAyMnQlurnALEw9AooV68fulIrT\n iV0c9mfNkxeoXgcaBgyataljgNjnM8N9aSppdbRRifTiG/chgyXG6+gdz\n up7HJnrE+6S1BFZTadDniHf7QxeJNQGeX0XzMY9KVrmmr4oNyxPGEZBzJ\n gT4/nB/pHA8ZmpWrO6Ajca3e1jrpIUQQGd/IQBEwabDuNHFMKo+LwF8KR\n yNVuGeU1R6Q3aJrohc+eFDKlYdemn0itGAvxjvGeM/bn5r9sQf0vQK3f6\n g==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=NCalqbGT"],"Subject":"[Intel-wired-lan] [PATCH iwl-net 1/4] ice: fix asymmetric pause\n negotiation reporting in ethtool","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"},"content":"From: Tomasz Lichwala <tomasz.lichwala@intel.com>\n\nAdd Asym_Pause to the supported link modes so that asymmetric pause\nnegotiation is properly reported via ethtool. Without Asym_Pause in\nthe supported modes, 'ethtool -a' incorrectly shows 'RX/TX negotiated: off'\nfor asymmetric pause configurations, even when pause is properly\nnegotiated and functional at the hardware level.\n\nFixes: 5a056cd7ead2 (\"ice: add lp_advertising flow control support\")\nSigned-off-by: Tomasz Lichwala <tomasz.lichwala@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\n--\n2.52.0","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex e6a20af..30d2550 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -2373,8 +2373,9 @@ ice_get_link_ksettings(struct net_device *netdev,\n \t\tbreak;\n \t}\n\n-\t/* flow control is symmetric and always supported */\n+\t/* flow control is symmetric or asymmetric and always supported */\n \tethtool_link_ksettings_add_link_mode(ks, supported, Pause);\n+\tethtool_link_ksettings_add_link_mode(ks, supported, Asym_Pause);\n\n \tcaps = kzalloc_obj(*caps);\n \tif (!caps)\n","prefixes":["iwl-net","1/4"]}