{"id":2224205,"url":"http://patchwork.ozlabs.org/api/patches/2224205/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417033452.640551-1-tactii@gmail.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417033452.640551-1-tactii@gmail.com>","list_archive_url":null,"date":"2026-04-17T03:34:52","name":"[iwl-net] igbvf: Fix leak in TX DMA error cleanup","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"462387b60dae99da40fce45f44b08a22e9893334","submitter":{"id":92679,"url":"http://patchwork.ozlabs.org/api/people/92679/?format=json","name":"Matt Vollrath","email":"tactii@gmail.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417033452.640551-1-tactii@gmail.com/mbox/","series":[{"id":500230,"url":"http://patchwork.ozlabs.org/api/series/500230/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500230","date":"2026-04-17T03:34:52","name":"[iwl-net] igbvf: Fix leak in TX DMA error cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/500230/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224205/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224205/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=zBIUxfvh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxgWK2tShz1yGt\n\tfor ; Fri, 17 Apr 2026 13:35:24 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 3F61660BBD;\n\tFri, 17 Apr 2026 03:35:22 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id RZeaHcB6_m0e; Fri, 17 Apr 2026 03:35:20 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id A77736073D;\n\tFri, 17 Apr 2026 03:35:20 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 057D5259\n for ; Fri, 17 Apr 2026 03:35:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id DF6AF81208\n for ; Fri, 17 Apr 2026 03:35:19 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id nqcMrAolSNhn for ;\n Fri, 17 Apr 2026 03:35:19 +0000 (UTC)","from mail-dl1-x1231.google.com (mail-dl1-x1231.google.com\n [IPv6:2607:f8b0:4864:20::1231])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 3DDDF811F7\n for ; Fri, 17 Apr 2026 03:35:19 +0000 (UTC)","by mail-dl1-x1231.google.com with SMTP id\n a92af1059eb24-12c726c30efso218244c88.1\n for ; Thu, 16 Apr 2026 20:35:19 -0700 (PDT)","from devobuntu.lan ([2600:6c5c:6b00:ba4:7419:7bc9:9c2a:7cc2])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c749c46c8sm511978c88.1.2026.04.16.20.35.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 20:35:15 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org A77736073D","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3DDDF811F7"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776396920;\n\tbh=hvouVp4w0YbHvQbdpa7mn27k6mvB2sHRdWB4T5BpS3c=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=zBIUxfvhX7+wDAggQg4qOGxiqnyf0BeHEyfG3flzMauqwrrLiMeCVGN03cHsFHZG1\n\t pVMSbPpgwUUfJO095a9WuQFaqenPu7f9ieY/TCqsPJ+uNDADlYCz8gQr0RxNluQDJ3\n\t hNU3NRXgSM91+jQ2DaBxb78m0WnP+Z+9PwVv46VOl8jozJO/xNSmaDyVs57pf2zZGz\n\t n9ZZjpaEYAzgoFzaar3FUCM2l33YyfMQaUmAeVwnMhAWSo0GLGkGl5jAVcmTpziI7C\n\t xW7iL8EgoWLYIoJ5UUoswfraRFrrAMgWEbUyCm3a88iHahykhAdIZdFLVLNiok0k3Q\n\t +PbD/N9uq9Y+Q==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::1231; helo=mail-dl1-x1231.google.com;\n envelope-from=tactii@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 3DDDF811F7","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776396918; x=1777001718;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hvouVp4w0YbHvQbdpa7mn27k6mvB2sHRdWB4T5BpS3c=;\n b=AvDI5m6+ALNFydEBWxokTCNojuaQBUPyAbf8ZtMA4GVjAY7z6uMk5TdSobfLLPHUPE\n gm0l6GZZvwF1vWvJNf5qHeOkOli92N5vKFzOT/SLn7quUTwMUlj4Qm+ejuqgRJXdIxAP\n CSNFKpmvI39m/IqHjD6SvjYatQTyeRE7EyfDcW+N5oiB4iOzoSyDTb/eznsBgo2vRVsW\n xZyaeUTj3Ri0+AB7LSfiaoAmjtEpaMIKUCeS+Fi658XS+1mQ8flm6LEEwVZ0SH41cjGB\n tp3V89iFEkrcFE52GzuG9dh2NlskZ/oBa+ypZQQOEme1G2Z7o4/0JP4X786hXMe6uobe\n Aztw==","X-Gm-Message-State":"AOJu0Yw8OM1dMD0rhewo/1cz4Rbc1jU2EiQqx2h3/K6V4XxbpKt6/e7p\n fJo+9wcgOVsYTPjSPi7CDqLujEOAuxBfEaR/AU6jnm7fFRc6ZuL2ccaKaBm0lpV9cFs=","X-Gm-Gg":"AeBDiesN4yHR4ENTyCZljgkOpAvLY68Fa2pPJ+sp/pMAbqp0sFGmrh8AL15Ga1gPwFq\n P3T2KnQiM0wSYBASxEQwxe6TtZxYCwhcrQKvhxwCPQlJAOSMMTcx5WtUOCXizey6mzNP4RsIraY\n 7U6DvpQTc/dfTzZ+LTcA5YILvwJENs1ofvL5A/+DCb9RejIaGKg3DahvgeEnB3tmvwBvlmhnGi7\n rAhlJMN8aySsNlGmKlpUJ6GCuvuXjaS6A99LbPDrk0e4sq5OXTxHg5OhjxmJ80isUuWD3njS/BS\n adNnsPrW6Uws65n6gMBDYt3+k7D28CE6EJGdjfWHac+xwY9lqfr3mB3ehhTurgfaX+POkGX5U3E\n U+DpwMP74wfXaer1sfct/F5SXy19cLTL7IXw6eSvOvnyIR4aIuN84+9IzOIRxYx2WrlNocMx7Sn\n YyMskz+X9+0PMIjAIteRmmo/+A03FXtiKBMK0=","X-Received":"by 2002:a05:7022:220f:b0:127:5cd6:fa45 with SMTP id\n a92af1059eb24-12c73f72632mr449412c88.14.1776396917545;\n Thu, 16 Apr 2026 20:35:17 -0700 (PDT)","From":"Matt Vollrath ","To":"intel-wired-lan@lists.osuosl.org","Cc":"Matt Vollrath ,\n\tstable@vger.kernel.org","Date":"Thu, 16 Apr 2026 23:34:52 -0400","Message-ID":"<20260417033452.640551-1-tactii@gmail.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776396918; x=1777001718; darn=lists.osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=hvouVp4w0YbHvQbdpa7mn27k6mvB2sHRdWB4T5BpS3c=;\n b=s8qqftE9LWJmp/JmG8UAcDwRlI5IbObXTOyaJ7jcGI07GLi/hbiCLU7L9h52/kkq8d\n RVrqe2hcqRGYr8caDgzEG2tinTZX2c50sffbYhthOPzQt7HPcIo5j8lMqnf0ElSVEqS1\n BFBXFk20FvySKc8J+UGN3OL9QyFlwnBi0QZ7Zs96o6nPijPfjfRpbpa2kZReeQIUlC5G\n gwe0oYaPn7tVgaY0K6wtpLt98GonSZUAV9J0GPWkG+zMwvCSkUZeNHexh/+wU4x9nq2V\n o8BHDmGbPBDhqb7VzsXDFXeZMdiAHfI454v43ieKu1FoLpzIFd7peTms9OikrHAWQdXg\n mbdw==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=s8qqftE9"],"Subject":"[Intel-wired-lan] [PATCH iwl-net] igbvf: Fix leak in TX DMA error\n cleanup","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"If an error is encountered while mapping TX buffers, the driver should\nunmap any buffers already mapped for that skb.\n\nBecause count is incremented before each frag mapping, it will always\nmatch the correct number of unmappings needed when dma_error is reached.\nDecrementing count before the while loop in dma_error causes an\noff-by-one error. If any mapping was successful before an unsuccessful\nmapping, exactly one DMA mapping (the head) would leak.\n\nThis bug was introduced by a 2010 fix for an endless loop in dma_error.\nAll other affected drivers have already been fixed.\n\nFixes: c1fa347f20f1 (\"e1000/e1000e/igb/igbvf/ixgb/ixgbe: Fix tests of unsigned in *_tx_map()\")\nCc: stable@vger.kernel.org\nAssisted-by: Claude:claude-4-7-opus\nSigned-off-by: Matt Vollrath \n---\n drivers/net/ethernet/intel/igbvf/netdev.c | 2 --\n 1 file changed, 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c\nindex ac57212ab02bd..19b2228e80bae 100644\n--- a/drivers/net/ethernet/intel/igbvf/netdev.c\n+++ b/drivers/net/ethernet/intel/igbvf/netdev.c\n@@ -2190,8 +2190,6 @@ static inline int igbvf_tx_map_adv(struct igbvf_adapter *adapter,\n \tbuffer_info->time_stamp = 0;\n \tbuffer_info->length = 0;\n \tbuffer_info->mapped_as_page = false;\n-\tif (count)\n-\t\tcount--;\n \n \t/* clear timestamp and dma mappings for remaining portion of packet */\n \twhile (count--) {\n","prefixes":["iwl-net"]}