{"id":2224107,"url":"http://patchwork.ozlabs.org/api/patches/2224107/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416200513.27100-3-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416200513.27100-3-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-16T20:05:13","name":"[v5,2/2] target/mips: Use probe_access_full() in Atomic Load/Store helpers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"022daac2206f8aeb1ad9b963c7fd5eae7dd25756","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416200513.27100-3-philmd@linaro.org/mbox/","series":[{"id":500201,"url":"http://patchwork.ozlabs.org/api/series/500201/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500201","date":"2026-04-16T20:05:11","name":"target/mips: Use probe_access_full() in Atomic Load/Store helpers","version":5,"mbox":"http://patchwork.ozlabs.org/series/500201/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224107/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224107/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QEhotvu2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxTXl3nKKz1yHV\n\tfor ; Fri, 17 Apr 2026 06:05:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDSyG-0000KY-Hj; Thu, 16 Apr 2026 16:05:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDSxz-0008V5-C4\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 16:05:37 -0400","from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDSxx-0008I9-3m\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 16:05:34 -0400","by mail-wr1-x42b.google.com with SMTP id\n ffacd0b85a97d-43d76dd4ee8so4325910f8f.2\n for ; Thu, 16 Apr 2026 13:05:31 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43ead3ebaaasm16889893f8f.32.2026.04.16.13.05.29\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 16 Apr 2026 13:05:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776369930; x=1776974730; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9K4LtXD4htqKcuCzEDGNxbXS9ukINIj2XSlyTHvWnFM=;\n b=QEhotvu2VHZ77qHEUeRPgtDdDRi4C8IchU+XmXAwp943n2fK3jwl5B7wg2ydgUW4xQ\n UdnbecfyCeLOWR6AeehA8l97pffn0jljWs5z+WSUxIb5Ms2tslbRalwjTDEx+Fb2O/f8\n 0+M6easQBcD45OpSZn/pR9rnrcHltbKnyti4bcDXIZvuDzKIDsN4gtAOB/UjS4CclY3v\n R30UjMVRGvLUJgZFNBVNT4BC+/+s9HQ7c1A4706BWNTUybVcdCmEFul1JBn6jR70KlJL\n fEoZ0H565yw1m5YkEmX/D/VIsLzQs5lce+qPFwdWE1QmlsTM9A3IiqtADSNVzWOfFSDU\n /O7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776369930; x=1776974730;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=9K4LtXD4htqKcuCzEDGNxbXS9ukINIj2XSlyTHvWnFM=;\n b=MogmlHciErmDhRdaclaqpyAdZEHlI977ljW0lmAooDCTsMxVUINM0zL3c2fp0hpRGX\n jW+IBitHSJ1+1++isEjGOIS6Y7Me09DLsaMMtKlxhRUwVUN+7FMIuDWGJnsZuceTexS8\n IM61grvB+VgX08i0R5FnqqIFXd/rPmnmN448EDqoh0QR8WybBRwQi/a1Qhy/8AcMaqs9\n qr2LLMw89C3ddvHYxRLliqpkABV9jOdBtlgGr9EYC8GcyfnOy3HWyIHiC17ZkMspyibm\n DYq0WFYDuhduRKeKwAtK1gzsc+fvneXRjUm1Qqeg6rSJGUUDpcxlZvUZ7BLkkRJ2Cdcw\n p8uw==","X-Gm-Message-State":"AOJu0Yzl9I74PrF4GPYKqaXKauDk7sZYunRvetjxXHoCO8XKWhbQxrhi\n rXzPHewJfBDVqrCdxT2LkWzceOLlBmfY4T0YI5xZ1FqlRhqymKqe9RwJzhUBGf5JD9egkWVVzPt\n AU+WEtE8=","X-Gm-Gg":"AeBDietL71Iw/0aMf0JfUuQByBVcooB5vvJER5aSLO1v23YR0Qt7DUfU59BLGYPFThq\n mNfXig9c+faVpu3WaLTxSw+ILKQlHcByJs0n4ze1m2/fV+O19X7mVkV6+itQUV9hB7869hoVJo2\n 0vINpoWgB3OwqIwMf/TbimYaiXrt8Z7YjlaUnl89gouHOdcrsKEUbHiroBJN+cwfSI8dD56Cl6s\n 9dmvOoo/i+8vyoA7XIQyQjlQ27Gtm/5mQHJPdAzAaz83Z7wQulUvHGGK0vRyOtvvtZkooELLViZ\n DWaANyx3++NR7jTdRF1wMp4GwiivcOnsNT5WRPcOK9TtqCkBsJFU3NqrfNmBSQXqA6hC4ACDHCR\n nrCsYS2Rr0/FnZ0fsptlbYVWi+vWla9b5U2881pNmTQgdRbiXW+xOl8P8wFVlnQ6iUkIuiBm13J\n zIA18whyAv1AjucvKCDqEzusG+rKK3Lst/0XGSxpOD4/763Gb8xhbQf0hKvGKFVDH2gFwrtsiXn\n v1b7Y6+LUE=","X-Received":"by 2002:a5d:64e3:0:b0:43d:7b23:bc99 with SMTP id\n ffacd0b85a97d-43fe0eaf176mr1181929f8f.15.1776369930018;\n Thu, 16 Apr 2026 13:05:30 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n Jiaxun Yang , Aurelien Jarno ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Aleksandar Rikalo ","Subject":"[PATCH v5 2/2] target/mips: Use probe_access_full() in Atomic\n Load/Store helpers","Date":"Thu, 16 Apr 2026 22:05:13 +0200","Message-ID":"<20260416200513.27100-3-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416200513.27100-1-philmd@linaro.org>","References":"<20260416200513.27100-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42b;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Let the probe_access() API check the address alignment\n(request MO_ALIGN in the MemOp bits).\n\nMove env->CP0_LLAddr and env->lladdr assignments so we\ndon't update them when an alignment fault occurs.\n\nSince we have a handy MemOpIdx, replace the legacy\ncpu_ld*_mmuidx_ra() calls by cpu_ld*_mmu() equivalent.\n\nSuggested-by: Richard Henderson \nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/mips/tcg/ldst_helper.c | 21 +++++++++++++++------\n target/mips/tcg/translate.c | 2 +-\n 2 files changed, 16 insertions(+), 7 deletions(-)","diff":"diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c\nindex b725c6d0333..4ebf72d610e 100644\n--- a/target/mips/tcg/ldst_helper.c\n+++ b/target/mips/tcg/ldst_helper.c\n@@ -28,23 +28,32 @@\n #include \"internal.h\"\n \n #ifndef CONFIG_USER_ONLY\n+#include \"accel/tcg/probe.h\"\n+#include \"exec/tlb-flags.h\"\n \n #define HELPER_LD_ATOMIC(name, insn, almask, do_cast) \\\n target_ulong helper_##name(CPUMIPSState *env, target_ulong arg, \\\n uint32_t memop_idx) \\\n { \\\n- MemOpIdx oi = memop_idx; \\\n- unsigned mem_idx = get_mmuidx(oi); \\\n- if (arg & almask) { \\\n+ MemOpIdx oi = memop_idx; \\\n+ unsigned mem_idx = get_mmuidx(oi); \\\n+ unsigned size = memop_size(get_memop(oi)); \\\n+ uintptr_t ra = GETPC(); \\\n+ CPUTLBEntryFull *full; \\\n+ void *host_unused; \\\n+ int flags; \\\n+ \\\n+ env->llval = do_cast cpu_##insn##_mmu(env, arg, oi, ra); \\\n+ flags = probe_access_full(env, arg, size, MMU_DATA_LOAD, mem_idx, \\\n+ true, &host_unused, &full, ra); \\\n+ if (unlikely(flags & TLB_INVALID_MASK)) { \\\n if (!(env->hflags & MIPS_HFLAG_DM)) { \\\n env->CP0_BadVAddr = arg; \\\n } \\\n do_raise_exception(env, EXCP_AdEL, GETPC()); \\\n } \\\n- env->CP0_LLAddr = cpu_mips_translate_address(env, arg, MMU_DATA_LOAD, \\\n- GETPC()); \\\n+ env->CP0_LLAddr = full->phys_addr; \\\n env->lladdr = arg; \\\n- env->llval = do_cast cpu_##insn##_mmuidx_ra(env, arg, mem_idx, GETPC()); \\\n return env->llval; \\\n }\n HELPER_LD_ATOMIC(ll, ldl, 0x3, (target_long)(int32_t))\ndiff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c\nindex 839bfe18bab..4889bd1e518 100644\n--- a/target/mips/tcg/translate.c\n+++ b/target/mips/tcg/translate.c\n@@ -1936,7 +1936,7 @@ static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx_ignored, \\\n static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, \\\n DisasContext *ctx) \\\n { \\\n- MemOpIdx oi = make_memop_idx(memop, mem_idx); \\\n+ MemOpIdx oi = make_memop_idx(memop | MO_ALIGN, mem_idx); \\\n gen_helper_##insn(ret, tcg_env, arg1, tcg_constant_i32(oi)); \\\n }\n #endif\n","prefixes":["v5","2/2"]}