{"id":2224093,"url":"http://patchwork.ozlabs.org/api/patches/2224093/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260416180107.777065-13-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416180107.777065-13-kwilczynski@kernel.org>","list_archive_url":null,"date":"2026-04-16T18:00:56","name":"[v5,12/23] alpha/PCI: Use BAR index in sysfs attr->private instead of resource pointer","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"77620b44cfe2a7851f97f1972d3a4c3e65ba0c64","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260416180107.777065-13-kwilczynski@kernel.org/mbox/","series":[{"id":500193,"url":"http://patchwork.ozlabs.org/api/series/500193/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=500193","date":"2026-04-16T18:00:44","name":"PCI: Convert all dynamic sysfs attributes to static","version":5,"mbox":"http://patchwork.ozlabs.org/series/500193/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224093/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224093/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=OiGTWIqp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52636-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"OiGTWIqp\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxQx66NMLz1yCv\n\tfor ; Fri, 17 Apr 2026 04:08:26 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id A9AD131FA3DE\n\tfor ; Thu, 16 Apr 2026 18:01:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AC9E5191F91;\n\tThu, 16 Apr 2026 18:01:54 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 89B9B1514F8;\n\tThu, 16 Apr 2026 18:01:54 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 17CB5C2BCB5;\n\tThu, 16 Apr 2026 18:01:50 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776362514; cv=none;\n b=BSXDH9S4VEmFUwEr2RyfdQzI3CjirwNDqOxgLH9uI/vStfETL6D/5+ViqwosXzkqGuQWjtg4W+wl/JV6ocVmP0nwWE7raZhNEeaaMuzP5uSVmMYrFX43jD5awRzNb5viho4sX3NYGOJp9CcFmgWRa62FOcxXgC3HqW6nf7LUtTs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776362514; c=relaxed/simple;\n\tbh=LSXfSjgBz15fSxwbvqqVboBWJc4CbgupbkaWY3yx6kA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=JirkxSEBoU7C9pmrp2TXYpPnS6LNqs7958IS+nWbXGev7t2koaWR9i0KLl8fI7qvvC3wn4ArdTvlObEtwUUXU7PCnaqZM6+rBg3K0tL7MnDwoJWwvfLL1AzfwCET+yosMJp1rXwQrsRV9Ik7CK1O8kHcBI6WTiuJtbkZejIr7lo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=OiGTWIqp; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776362514;\n\tbh=LSXfSjgBz15fSxwbvqqVboBWJc4CbgupbkaWY3yx6kA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OiGTWIqpmv4YGnWuufZIAg9U6Mv3LXjBtSjahu2SURo0/CKF7KTFO1fzqBRV1muaM\n\t WEm/ZZZDlGzSivb66L9p0h/cU4SVd/le0juBJhskNSGPxhe7yLWQTdweFqSuajcIl1\n\t HDwLhSOXK2CJsAyMYvb+X9CJ5yzMLkUt7dPmhE9um67LS2KOffaArsYp+cFLt1t0h6\n\t Sn26D9YUYUOpOfxmuQp4YoobCYPeJIl6Iq3LUvUVy8cwVk4NHSFpgbWLU6PnCwfHcX\n\t qsW6tiii16rqzpUz8zXPbxC73G7J56SDc76vcM3JK/loOeeD5qgpMTl7ixb7PjcUSr\n\t d36CWK6ktDTKg==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v5 12/23] alpha/PCI: Use BAR index in sysfs attr->private\n instead of resource pointer","Date":"Thu, 16 Apr 2026 18:00:56 +0000","Message-ID":"<20260416180107.777065-13-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416180107.777065-1-kwilczynski@kernel.org>","References":"<20260416180107.777065-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Currently, Alpha's pci_create_one_attr() stores a resource pointer in\nattr->private, and pci_mmap_resource() loops through all BARs to find\nthe matching index.\n\nThus, store the BAR index directly in attr->private and retrieve the\nresource via pci_resource_n(). This eliminates the loop and aligns\nwith the convention used by the generic PCI sysfs code.\n\nThe PCI core change was first added in the commit dca40b186b75 (\"PCI:\nUse BAR index in sysfs attr->private instead of resource pointer\").\n\nTested-by: Magnus Lindholm \nReviewed-by: Ilpo Järvinen \nAcked-by: Magnus Lindholm \nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/kernel/pci-sysfs.c | 15 +++++----------\n 1 file changed, 5 insertions(+), 10 deletions(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 2324720c3e83..2330ab84d59c 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -69,25 +69,20 @@ static int pci_mmap_resource(struct kobject *kobj,\n \t\t\t struct vm_area_struct *vma, int sparse)\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n-\tstruct resource *res = attr->private;\n+\tint barno = (unsigned long)attr->private;\n+\tstruct resource *res = pci_resource_n(pdev, barno);\n \tenum pci_mmap_state mmap_type;\n \tstruct pci_bus_region bar;\n-\tint i, ret;\n+\tint ret;\n \n \tret = security_locked_down(LOCKDOWN_PCI_ACCESS);\n \tif (ret)\n \t\treturn ret;\n \n-\tfor (i = 0; i < PCI_STD_NUM_BARS; i++)\n-\t\tif (res == &pdev->resource[i])\n-\t\t\tbreak;\n-\tif (i >= PCI_STD_NUM_BARS)\n-\t\treturn -ENODEV;\n-\n \tif (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))\n \t\treturn -EINVAL;\n \n-\tif (!__pci_mmap_fits(pdev, i, vma, sparse))\n+\tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n \t\treturn -EINVAL;\n \n \tpcibios_resource_to_bus(pdev->bus, &bar, res);\n@@ -170,7 +165,7 @@ static int pci_create_one_attr(struct pci_dev *pdev, int num, char *name,\n \tres_attr->attr.name = name;\n \tres_attr->attr.mode = S_IRUSR | S_IWUSR;\n \tres_attr->size = sparse ? size << 5 : size;\n-\tres_attr->private = &pdev->resource[num];\n+\tres_attr->private = (void *)(unsigned long)num;\n \treturn sysfs_create_bin_file(&pdev->dev.kobj, res_attr);\n }\n \n","prefixes":["v5","12/23"]}