{"id":2224090,"url":"http://patchwork.ozlabs.org/api/patches/2224090/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260416180107.777065-9-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416180107.777065-9-kwilczynski@kernel.org>","list_archive_url":null,"date":"2026-04-16T18:00:52","name":"[v5,08/23] PCI/sysfs: Warn about BAR resize failure in __resource_resize_store()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"59dc2111873ebb11231ed7590e5f6a1bc6db8075","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260416180107.777065-9-kwilczynski@kernel.org/mbox/","series":[{"id":500193,"url":"http://patchwork.ozlabs.org/api/series/500193/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=500193","date":"2026-04-16T18:00:44","name":"PCI: Convert all dynamic sysfs attributes to static","version":5,"mbox":"http://patchwork.ozlabs.org/series/500193/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224090/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224090/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=b042CshG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52632-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"b042CshG\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxQwb71ygz1yCv\n\tfor ; Fri, 17 Apr 2026 04:07:59 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 0D7EE31F5037\n\tfor ; Thu, 16 Apr 2026 18:01:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8407432AAA3;\n\tThu, 16 Apr 2026 18:01:40 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 59FFD1514F8;\n\tThu, 16 Apr 2026 18:01:40 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 15D63C2BCAF;\n\tThu, 16 Apr 2026 18:01:36 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776362500; cv=none;\n b=S5CjGE4Bi/RYQ+NnfMfWlZg/fLPHcfTvzU8D/G3+l4ucv9OFvi3oa72j/f0sdbTeIEjv5CqQAbPG3b3KV/fshI6L3CVuW7A8Vs6kCafnerFstCiTRGtm6mZzOFDW64uNS/ubUUKgxlIvp6L4AYgC4cW1EbgyW5pRAO/Phf65ZQ4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776362500; c=relaxed/simple;\n\tbh=ETL+W+tW2dvlxsZyN2YnEvNwnvTJRalLy+LfLN3MvZw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=mAADHSFv0wl6A4gOCaTNms9/fgNK2OV+bTSNcFBBlvRp7uH2QPpQj+9nirXvHZfrAeOf7Rq0SM4RpNd+jIZGnzZ/dRDqKyKeMEwgQeK9ZdYlUpaYx7oi3zl05QTzCvxoYiy9MbtFGClAyOfPJsBut4W/L4xXyPq+Yq0NYG4TheE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=b042CshG; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776362500;\n\tbh=ETL+W+tW2dvlxsZyN2YnEvNwnvTJRalLy+LfLN3MvZw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=b042CshGS+igON2yWBtn6udjzMZFtQhv7UWmyvNYZaBt43mqSpPQ8xm4hGIS5RaUB\n\t 8aQ5bIz4Ot/Kq5PDQ66D8Oc7nEdUb+nPAKQ6JLS2WX0gUBEyz+mFZX05pxmmDiGXMM\n\t HZpK7Cm4oVD4fj5FuOV8Ph2JSBbw4j+/ehFkJwqUoK4Eq7oqT3hvgl11OmcwnsVWFO\n\t SsPMl1G/jdAMnXz2v/EyslDXsRqy5fuq+Mdk9etXSSWRVVEN3pqwp5LTo7PN62XDGE\n\t 01XrANtGSZvZIJWw5G+S1xFUhCcTpBL6s3xrrn3dKw2zNHSsVWd8u9tNJlmAoN0FJR\n\t svcuY5lMOrdMA==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v5 08/23] PCI/sysfs: Warn about BAR resize failure in\n __resource_resize_store()","Date":"Thu, 16 Apr 2026 18:00:52 +0000","Message-ID":"<20260416180107.777065-9-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416180107.777065-1-kwilczynski@kernel.org>","References":"<20260416180107.777065-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Add a pci_warn() to __resource_resize_store(), so that BAR resize\nfailures are visible to the user, which can help troubleshoot any\npotential resource resize issues.\n\nWhile at it, rename the resource_resize_is_visible() to\nresource_resize_attr_is_visible() along with the corresponding\ngroup variable to align with the naming convention used by the\nresource attribute groups.\n\nAlso, change the order of pci_dev_groups[] such that the resize\ngroup is now located alongside the other resource groups.\n\nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 3508e29f6ad1..c0925bdc9ecd 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1703,6 +1703,9 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tsysfs_remove_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups);\n \n \tret = pci_resize_resource(pdev, n, size, 0);\n+\tif (ret)\n+\t\tpci_warn(pdev, \"Failed to resize BAR %d: %pe\\n\",\n+\t\t\t n, ERR_PTR(ret));\n \n \tpci_assign_unassigned_bus_resources(bus);\n \n@@ -1750,7 +1753,7 @@ static struct attribute *resource_resize_attrs[] = {\n \tNULL,\n };\n \n-static umode_t resource_resize_is_visible(struct kobject *kobj,\n+static umode_t resource_resize_attr_is_visible(struct kobject *kobj,\n \t\t\t\t\t struct attribute *a, int n)\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n@@ -1758,9 +1761,9 @@ static umode_t resource_resize_is_visible(struct kobject *kobj,\n \treturn pci_rebar_get_current_size(pdev, n) < 0 ? 0 : a->mode;\n }\n \n-static const struct attribute_group pci_dev_resource_resize_group = {\n+static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.attrs = resource_resize_attrs,\n-\t.is_visible = resource_resize_is_visible,\n+\t.is_visible = resource_resize_attr_is_visible,\n };\n \n int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n@@ -1881,6 +1884,7 @@ const struct attribute_group *pci_dev_groups[] = {\n \t&pci_dev_resource_uc_attr_group,\n \t&pci_dev_resource_wc_attr_group,\n #endif\n+\t&pci_dev_resource_resize_attr_group,\n \t&pci_dev_config_attr_group,\n \t&pci_dev_rom_attr_group,\n \t&pci_dev_reset_attr_group,\n@@ -1892,7 +1896,6 @@ const struct attribute_group *pci_dev_groups[] = {\n #ifdef CONFIG_ACPI\n \t&pci_dev_acpi_attr_group,\n #endif\n-\t&pci_dev_resource_resize_group,\n \tARCH_PCI_DEV_GROUPS\n \tNULL,\n };\n","prefixes":["v5","08/23"]}