{"id":2224074,"url":"http://patchwork.ozlabs.org/api/patches/2224074/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260416180107.777065-14-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260416180107.777065-14-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260416180107.777065-14-kwilczynski@kernel.org/","date":"2026-04-16T18:00:57","name":"[v5,13/23] alpha/PCI: Use PCI resource accessor macros","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"7cc0706417dacc6b2532ec94eb1f6973a6a971b4","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260416180107.777065-14-kwilczynski@kernel.org/mbox/","series":[{"id":500194,"url":"http://patchwork.ozlabs.org/api/series/500194/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=500194","date":"2026-04-16T18:00:44","name":"PCI: Convert all dynamic sysfs attributes to static","version":5,"mbox":"http://patchwork.ozlabs.org/series/500194/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224074/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224074/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hxnW1p0u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19804-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hxnW1p0u;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxQpm69K2z1yD3\n\tfor ; Fri, 17 Apr 2026 04:02:56 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fxQnh3n81z3bk1;\n\tFri, 17 Apr 2026 04:02:00 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fxQng3hPkz2yYK\n\tfor ; Fri, 17 Apr 2026 04:01:59 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id E565840E36;\n\tThu, 16 Apr 2026 18:01:57 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 98A7FC2BCAF;\n\tThu, 16 Apr 2026 18:01:54 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776362520;\n\tcv=none;\n b=dsAp1vs9QQTWOviR6crXvQBc3767OWFe18P1WRWSobLnjdkJt3fQxoEZNIMLDk8XBDiF3roPSNR6x/7YgrHldKEKWiU0Wr97kg1Yx8rlp+sqqPxPMXuxe36Lr8vf7cajVCopMrGvAd1h/NG/3zze2BL0ksC8MARBa+POO1f2lEMJNBl6a97EtMF5ctaOf5N/xe4WUBZt1Wva+iCKEXKQPz0MnEhOwwhT4eQuHZKcDgBsnwusqQPbaENAM69INPoVIJ3M2yu2zozIapH30DtPnk6VHGOicZq6a9g968ZCLVXANW8JttBi+ZmPypNi0vmVeWvDmVGF+BjEUS9O3ThYhA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776362520; c=relaxed/relaxed;\n\tbh=O+demXVb/7u4PctkTwvU5TG82BsX3vOBjADpfyuGQC0=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=QNi5Q/nR1m85q0c/Ux77AL0vQ0qwPP1O09QjZuLqvNg8ZKcZ2fL2taaakDE4sVlBKBu7tY8iliKdBE4liqRzhG3uyL1J4q3VsoAdoA0HmtRIowrc9QrgY6KeLde69wcr30dSMQ9pf/pYxVV1l4LYL+6qzp8b9uarl2tvYQRTydCEeAqpCHlOlhtqFbj9UDdLIqUtxi+5ZTzUgTDgdStWjN+cQZvRyv+BxogTnbw2hRepPmRZk0G9bEozc0mDdcohYWcKeowqp8/+ylPb3HrJ5yGxbyqqKB3jZgavq1f1LCqAJHU3lUgHCDLocDpV4k6IQ0ZPwmJ1iqiRTht7FxbhWA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hxnW1p0u; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776362517;\n\tbh=RnJpCjE7Q+Cz5gLfhuPI4aXF0NyoVhuEIoGAkwXA5ZA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hxnW1p0urI+O5qr7Z0zglyRfAGglr5AQy/cTAcaAtUydpguea4iMqz7RjmIQIWNSY\n\t 0S+TKPVcajwNcZzLcEDVLzIwtX1teKHFma8LBaEvdx5ADxIRv6o5PdapwoaTw/NKA2\n\t Oc+zk5ZBIYYMZESrMEhUAiQR4rsYwRuivpP3pYFlI0NUZux9FWSoFAX2BApZymhtmp\n\t CHYRmcg/0xY+esHsSNvlexQwe9HlYawEw3kzdGXQhRiptZ2WfHnO8wox8fcXcr/Pyw\n\t X8R/01q579lXQo7roXSXblbysmXdbqkklexcb9436dDST9M3vS5pJO08Py4BJ3RRMM\n\t C7ZZYLuiXD0yQ==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v5 13/23] alpha/PCI: Use PCI resource accessor macros","Date":"Thu, 16 Apr 2026 18:00:57 +0000","Message-ID":"<20260416180107.777065-14-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416180107.777065-1-kwilczynski@kernel.org>","References":"<20260416180107.777065-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Replace direct pdev->resource[] accesses with pci_resource_n(),\nand pdev->resource[].flags accesses with pci_resource_flags().\n\nAlso, replace open-coded res->flags type checks with new\npci_resource_is_mem() and pci_resource_start() helpers.\n\nWhile at it, move the pci_resource_n() call directly into\npcibios_resource_to_bus() and drop the local struct\nresource pointer.\n\nNo functional changes intended.\n\nTested-by: Magnus Lindholm \nReviewed-by: Ilpo Järvinen \nAcked-by: Magnus Lindholm \nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/kernel/pci-sysfs.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 2330ab84d59c..5c29f1d2821c 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -70,7 +70,6 @@ static int pci_mmap_resource(struct kobject *kobj,\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n \tint barno = (unsigned long)attr->private;\n-\tstruct resource *res = pci_resource_n(pdev, barno);\n \tenum pci_mmap_state mmap_type;\n \tstruct pci_bus_region bar;\n \tint ret;\n@@ -79,15 +78,16 @@ static int pci_mmap_resource(struct kobject *kobj,\n \tif (ret)\n \t\treturn ret;\n \n-\tif (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))\n+\tif (pci_resource_is_mem(pdev, barno) &&\n+\t iomem_is_exclusive(pci_resource_start(pdev, barno)))\n \t\treturn -EINVAL;\n \n \tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n \t\treturn -EINVAL;\n \n-\tpcibios_resource_to_bus(pdev->bus, &bar, res);\n+\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, barno));\n \tvma->vm_pgoff += bar.start >> (PAGE_SHIFT - (sparse ? 5 : 0));\n-\tmmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;\n+\tmmap_type = pci_resource_is_mem(pdev, barno) ? pci_mmap_mem : pci_mmap_io;\n \n \treturn hose_mmap_page_range(pdev->sysdata, vma, mmap_type, sparse);\n }\n@@ -141,7 +141,7 @@ static int sparse_mem_mmap_fits(struct pci_dev *pdev, int num)\n \tlong dense_offset;\n \tunsigned long sparse_size;\n \n-\tpcibios_resource_to_bus(pdev->bus, &bar, &pdev->resource[num]);\n+\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, num));\n \n \t/* All core logic chips have 4G sparse address space, except\n \t CIA which has 16G (see xxx_SPARSE_MEM and xxx_DENSE_MEM\n@@ -181,7 +181,7 @@ static int pci_create_attr(struct pci_dev *pdev, int num)\n \tsuffix = \"\";\t/* Assume bwx machine, normal resourceN files. */\n \tnlen1 = 10;\n \n-\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n+\tif (pci_resource_is_mem(pdev, num)) {\n \t\tsparse_base = hose->sparse_mem_base;\n \t\tdense_base = hose->dense_mem_base;\n \t\tif (sparse_base && !sparse_mem_mmap_fits(pdev, num)) {\n","prefixes":["v5","13/23"]}