{"id":2224060,"url":"http://patchwork.ozlabs.org/api/patches/2224060/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260416180107.777065-6-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260416180107.777065-6-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260416180107.777065-6-kwilczynski@kernel.org/","date":"2026-04-16T18:00:49","name":"[v5,05/23] PCI/sysfs: Add CAP_SYS_ADMIN check to __resource_resize_store()","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"c49e0a73cbc2101568fc3de0ec56b181777ddad3","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260416180107.777065-6-kwilczynski@kernel.org/mbox/","series":[{"id":500194,"url":"http://patchwork.ozlabs.org/api/series/500194/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=500194","date":"2026-04-16T18:00:44","name":"PCI: Convert all dynamic sysfs attributes to static","version":5,"mbox":"http://patchwork.ozlabs.org/series/500194/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224060/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224060/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GNzaUOlO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19796-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GNzaUOlO;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxQnY2FQ4z1yD3\n\tfor ; Fri, 17 Apr 2026 04:01:53 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fxQn81MPTz30Tc;\n\tFri, 17 Apr 2026 04:01:32 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fxQn73B47z2yvR\n\tfor ; Fri, 17 Apr 2026 04:01:31 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id C5CE540135;\n\tThu, 16 Apr 2026 18:01:29 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7A97AC2BCB5;\n\tThu, 16 Apr 2026 18:01:26 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776362492;\n\tcv=none;\n b=E6735RPCqQraNhuL9aHqF4HU4+bQhGPJalrmaPsY/zU/6+tM1ai9WHxd+Gf8ajMnd5vAVO5xVWO6hruF7Cde5lEBxC0Znw+TR8ABydMGc5oiWFJkSVVi7TC3lE6S3S/LR+ZO6oUr+6JmxsmnI4lB0+ipkQKwTRXOkPoybvhQ9jJtl/z1ZNUVW/MEs7gTn9TIusvnfpaNl5CKycouZP8KXW4+PERbDwFfayT0Ad5+OXGZpks8tMsVr1xsZtBVncseOij3fkPurNlrPC5B42mOcdDk1IYp1zaIw9sZq4KuQ5uyiygws7UhsOH5bJ4geFx5DexWvImMp7AIBuczedkaJA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776362492; c=relaxed/relaxed;\n\tbh=yR0dagUpafQq6IBa8FUHt9Th4B7BFsnHVbv1XXpWmi8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=W+BC8C7Y1nmCRYXrYbaZN4KkWQS+ZQ0qwSMZqkB/bHW+OhbqkWQJP4NLZ5JKx0oogyb1LSxpRNPL6VhuPBq3hNEzDrxB86VHDXjaIEBFQZIFo8GZH9bw7lZOM81fwtYSnqrpfIhyArslf/quEL7gsjs4PuWPG1M0qblGfRqLOX6txjkw1PL3tQ1ykSzjx3aut/EktlECZFQfvrwfy7Iaef5viOnuVE8fumY1yNdeZh5hXw2YzTl/vyE4RZZI5O6tHURPoDwyz4D2rzpyP9JKS6IoCmEsv84N6RkEj0IhIhan8YBtwHbsL0LLWxWmMqWMV62Dd7ay1o2CNQ72QMq3KA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GNzaUOlO; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776362489;\n\tbh=u/k9TMeqaPQPWgW7ILWQ8kth1orOPivoorazdGxMwic=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GNzaUOlOxZWEgLbDs808/Oq3wDidFRb5nqJauRfHZ90l18YrYeKlEoChUM8QgraAz\n\t oreTnPAqoCd0iLRCrSAlVLLiNPzFq20CJoC/Iq+cmUxWe7h5z2T0rwGqLIpnXqtHdC\n\t xZJz7DYMXdM2amhZXAy5y9A/1f4FGDFl8j5nb0HPEZ+0xDa8/y+gX2M9fRfvDMiJfk\n\t lSQYfbpIAe2Iqhb1LnGqDvn579zIWLUWvhkp0LnB0sCbLuaI0zQ+BsHGFMW0UXgQXE\n\t di5s/47rwYqehx34VPcP3qlETFcKZ/54zFsaWGxzcD5uuRraX3FlZabm13M3jCdw/x\n\t Ph+agkyZNjW3A==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v5 05/23] PCI/sysfs: Add CAP_SYS_ADMIN check to\n __resource_resize_store()","Date":"Thu, 16 Apr 2026 18:00:49 +0000","Message-ID":"<20260416180107.777065-6-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416180107.777065-1-kwilczynski@kernel.org>","References":"<20260416180107.777065-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Currently, the __resource_resize_store() allows writing to the\nresourceN_resize sysfs attribute to change a BAR's size without\nchecking for capabilities, currently relying only on the file\naccess check.\n\nResizing a BAR modifies PCI device configuration and can disrupt\nactive drivers. After the upcoming conversion to static attributes,\nit will also trigger resource file updates via sysfs_update_groups().\n\nThus, add a CAP_SYS_ADMIN check to prevent unprivileged users from\nperforming BAR resize operations.\n\nReviewed-by: Ilpo Järvinen \nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 73a9ae9d289b..4f95b336cc34 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1619,6 +1619,9 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tint ret;\n \tu16 cmd;\n \n+\tif (!capable(CAP_SYS_ADMIN))\n+\t\treturn -EPERM;\n+\n \tif (kstrtoul(buf, 0, &size) < 0)\n \t\treturn -EINVAL;\n \n","prefixes":["v5","05/23"]}