{"id":2224047,"url":"http://patchwork.ozlabs.org/api/patches/2224047/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/aeEZp0R-bmxrR1_Z@tucnak/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-16T17:17:27","name":"[committed] c++: Temporarily ignore -Wformat* warnings in dump_data_member_spec","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"908281290c8bfd24bf772db9168a3540c42d8e61","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/?format=json","name":"Jakub Jelinek","email":"jakub@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/aeEZp0R-bmxrR1_Z@tucnak/mbox/","series":[{"id":500188,"url":"http://patchwork.ozlabs.org/api/series/500188/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=500188","date":"2026-04-16T17:17:27","name":"[committed] c++: Temporarily ignore -Wformat* warnings in dump_data_member_spec","version":1,"mbox":"http://patchwork.ozlabs.org/series/500188/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224047/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224047/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=B/dw9VFC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=B/dw9VFC","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxPrM3VhPz1yD3\n\tfor ; Fri, 17 Apr 2026 03:19:15 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id D1A0E4C318BE\n\tfor ; Thu, 16 Apr 2026 17:19:12 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 3B3BC4C515FE\n for ; Thu, 16 Apr 2026 17:17:36 +0000 (GMT)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-gMYwBLm2O9i9gXqhDRsmpg-1; Thu,\n 16 Apr 2026 13:17:32 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 85432195606F; Thu, 16 Apr 2026 17:17:31 +0000 (UTC)","from tucnak.zalov.cz (unknown [10.44.33.129])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id A810B180047F; Thu, 16 Apr 2026 17:17:30 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\n by tucnak.zalov.cz (8.18.1/8.18.1) with ESMTPS id 63GHHRHY1139085\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Thu, 16 Apr 2026 19:17:27 +0200","(from jakub@localhost)\n by tucnak.zalov.cz (8.18.1/8.18.1/Submit) id 63GHHRae1139084;\n Thu, 16 Apr 2026 19:17:27 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org D1A0E4C318BE","OpenDKIM Filter v2.11.0 sourceware.org 3B3BC4C515FE"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 3B3BC4C515FE","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 3B3BC4C515FE","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776359856; cv=none;\n b=x85TzvDIFc21MA85poZve6dDrBwleMvVPSAFDrJEH7laIyi49R3JoAF/FMRLAFZY6AT8/2wnWv0ZoPCIbBEXWNhes4i6tR1bdkluIWUEnMv+wnM0rBr6g3J8nVYnq/+7dE+Kugx+64Ycpb1YOcgNMHHqjUKcIZoRLMLvqicWdTg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776359856; c=relaxed/simple;\n bh=ZSOpA8gJc+Yq2JU6NHViZJWj417falYYhjten1dahuQ=;\n h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version;\n b=ZO0jUBPRo3xtXmWnC1kMy8LpEQvMNfiUQeD01VlF4ZYgrbrGvXxvOryYJKvLXSNHS+9wcNZjqtrhtBGVQ4ieXD0x/48GAwDNclzCLYk7kb6dWGR1xyeeBRsGn4FnsRqSNN8t5WkbLYMYWHdG8N8Yr8mpU9ma5wEpXEIa3JvHoCM=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776359855;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jwSRlT3KmaJ9L/o+0GuZvcptp3qOAS3uwRe98N7CRaQ=;\n b=B/dw9VFCJ7ZKUp64Z05zf6CJ1Ge8RNqwsioSDlJzTOvqsh87OFOznS+X85DV2+LgKdIfgS\n PpV4TxweuxQNxlHj3wi9255N8t1o09HODAipErwLT0uBVuph17FA5Z5NHDj4dWqnuVSM7s\n pRHQZiSDHsDPwhbJjjlCglvV0n9XM5Y=","X-MC-Unique":"gMYwBLm2O9i9gXqhDRsmpg-1","X-Mimecast-MFC-AGG-ID":"gMYwBLm2O9i9gXqhDRsmpg_1776359851","Date":"Thu, 16 Apr 2026 19:17:27 +0200","From":"Jakub Jelinek ","To":"\"Richard Earnshaw (foss)\" ","Cc":"Marek Polacek , gcc-patches@gcc.gnu.org","Subject":"[committed] c++: Temporarily ignore -Wformat* warnings in\n dump_data_member_spec","Message-ID":"","References":"<20260416164643.343FD4BB58B4@sourceware.org>\n <8897b800-909e-45e8-bb40-286dc42be44d@arm.com>","MIME-Version":"1.0","In-Reply-To":"<8897b800-909e-45e8-bb40-286dc42be44d@arm.com>","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"ufrEp-d6VLhngUoWhgr1qWMn5UjbhrDV-GvNfcRso0s_1776359851","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Jakub Jelinek ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"On Thu, Apr 16, 2026 at 05:54:44PM +0100, Richard Earnshaw (foss) wrote:\n> ../../gcc/gcc/cp/reflect.cc: In function ‘void dump_data_member_spec(pretty_printer*, tree)’:\n> ../../gcc/gcc/cp/reflect.cc:3687:18: error: ‘T’ conversion used unquoted [-Werror=format-diag]\n> 3687 | pp_printf (pp, \"(%T, %E, %E, %E, %s, {\", TREE_VEC_ELT (r, 0),\n> | ^~~~~~~~~~~~~~~~~~~~~~~~\n> ../../gcc/gcc/cp/reflect.cc:3687:18: error: spurious trailing punctuation sequence ‘{’ in format [-Werror=format-diag]\n> ../../gcc/gcc/cp/reflect.cc:3687:18: error: unbalanced punctuation character ‘{’ in format [-Werror=format-diag]\n> ../../gcc/gcc/cp/reflect.cc:3694:18: error: unbalanced punctuation character ‘}’ in format [-Werror=format-diag]\n> 3694 | pp_printf (pp, \"})\");\n> | ^~~~\n> ../../gcc/gcc/cp/reflect.cc:3694:18: error: unbalanced punctuation character ‘)’ in format [-Werror=format-diag]\n> cc1plus: all warnings being treated as errors\n> make[3]: *** [Makefile:1218: cp/reflect.o] Error 1\n> make[3]: *** Waiting for unfinished jobs....\n> \n> Marek, looks like it was your change.\n\nThe body of this function has been moved from eval_display_string_of,\nwhich ignored some warnings already.\nThe new function doesn't ignore those, we we get\n../../gcc/cp/reflect.cc: In function ‘void dump_data_member_spec(pretty_printer*, tree)’:\n../../gcc/cp/reflect.cc:3692:18: warning: ‘T’ conversion used unquoted [-Wformat=]\n 3692 | pp_printf (pp, \"(%T, %E, %E, %E, %s, {\", TREE_VEC_ELT (r, 0),\n | ^~~~~~~~~~~~~~~~~~~~~~~~\n../../gcc/cp/reflect.cc:3692:18: warning: spurious trailing punctuation sequence ‘{’ in format [-Wformat-diag]\n../../gcc/cp/reflect.cc:3692:18: warning: unbalanced punctuation character ‘{’ in format [-Wformat-diag]\n../../gcc/cp/reflect.cc:3699:18: warning: unbalanced punctuation character ‘}’ in format [-Wformat-diag]\n 3699 | pp_printf (pp, \"})\");\n | ^~~~\n../../gcc/cp/reflect.cc:3699:18: warning: unbalanced punctuation character ‘)’ in format [-Wformat-diag]\nextra warnings which can break bootstrap when promoted into errors.\n\nBriefly tested on x86_64-linux, pushed as obvious to unbreak bootstrap.\n\n2026-04-16 Jakub Jelinek \n\n\t* reflect.cc (dump_data_member_spec): Temporarily ignore\n\t-Wformat and -Wformat-diag warnings.\n\n\n\n\tJakub","diff":"--- gcc/cp/reflect.cc.jj\t2026-04-16 18:56:51.669066785 +0200\n+++ gcc/cp/reflect.cc\t2026-04-16 19:12:30.183472799 +0200\n@@ -3684,6 +3684,11 @@ eval_identifier_of (location_t loc, cons\n void\n dump_data_member_spec (pretty_printer *pp, tree r)\n {\n+#if __GNUC__ >= 10\n+#pragma GCC diagnostic push\n+#pragma GCC diagnostic ignored \"-Wformat\"\n+#pragma GCC diagnostic ignored \"-Wformat-diag\"\n+#endif\n pp_printf (pp, \"(%T, %E, %E, %E, %s, {\", TREE_VEC_ELT (r, 0),\n \t TREE_VEC_ELT (r, 1), TREE_VEC_ELT (r, 2), TREE_VEC_ELT (r, 3),\n \t TREE_VEC_ELT (r, 4) == boolean_true_node\n@@ -3692,6 +3697,9 @@ dump_data_member_spec (pretty_printer *p\n pp_printf (pp, \"%s%E\", i == 5 ? \"\" : \", \",\n \t REFLECT_EXPR_HANDLE (TREE_VEC_ELT (r, i)));\n pp_printf (pp, \"})\");\n+#if __GNUC__ >= 10\n+#pragma GCC diagnostic pop\n+#endif\n }\n \n /* Process std::meta::{,u8}display_string_of.\n","prefixes":["committed"]}