{"id":2224033,"url":"http://patchwork.ozlabs.org/api/patches/2224033/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416150649.23671-3-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416150649.23671-3-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-16T15:06:49","name":"[v4,2/2] target/mips: Use probe_access_full() in Atomic Load/Store helpers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0a993e4b289c9561ac1604ddf6b42a15f78514a7","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416150649.23671-3-philmd@linaro.org/mbox/","series":[{"id":500176,"url":"http://patchwork.ozlabs.org/api/series/500176/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500176","date":"2026-04-16T15:06:47","name":"target/mips: Use probe_access_full() in Atomic Load/Store helpers","version":4,"mbox":"http://patchwork.ozlabs.org/series/500176/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224033/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224033/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=VnNAT0Ou;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxLwR4svnz1yCv\n\tfor ; Fri, 17 Apr 2026 01:07:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDOJG-0007rp-Rg; Thu, 16 Apr 2026 11:07:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDOJC-0007n3-SU\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 11:07:10 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDOJB-0000lH-Cv\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 11:07:10 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-48334ee0aeaso79210795e9.1\n for ; Thu, 16 Apr 2026 08:07:09 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f0e71f5dsm68350215e9.6.2026.04.16.08.07.05\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 16 Apr 2026 08:07:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776352027; x=1776956827; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/8eTKiduCZMg9yJhYc+PUDvB0qmyxyEaSBVvhdpHjpQ=;\n b=VnNAT0OumMm8S25cvdMesFlgWfRI8bVlbbM2dnYLLBh9H17S+43KqVeesMpm/5HwPZ\n dzM8U1HSimV8TEmXMfGgEiRM8da596JL+ZLHalydnQ2hH6XkR1osOAeyT8xrAE73yfSq\n VdLLqTf29KPYY9xwQDqfD5yGVtls54oYe7CiWMP13omQCYlmCDgyDzObb8V0n3FexB8N\n E4pc0D9gegGozYF+3RmaFcSId9nmRP8QqWuPKKDsvgbQAqHJi1/GyUzbUESDWlvZem4M\n l5yjtF1dvLB3sva/l3nj5QhFRlr6S+APoDsqFRwMuyvIKNrnqrfpdgSip0a2Q6eSo2+x\n czZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776352027; x=1776956827;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=/8eTKiduCZMg9yJhYc+PUDvB0qmyxyEaSBVvhdpHjpQ=;\n b=FgimNhkN1mqpZqio5VynOTBDbye7uTVH4SjnHoBMJixKVQGpxuDcdiLOXgL4aE1Teg\n tqEROvvTk8S7Tq79zjs93mMyFTX8Cr7jK1D+oYi081Yo2uY1cOqb+xyZyWcr2SOggqPy\n wCJF5nO2ZCD7Nqgd3szGMfclsDI674daPK9s7sMIWcqALwS1qILD7e/5QWLYSSiCCVFB\n pJuLOXaJC6+1+6Vdn5G6DRVwX2nF8+GJktVvkCo3lEYWOWaqo40FkoDLGFRudWNjYo8m\n Bp4ik7k6wJB24vVM/T8P2arKdszl3PI7yARFNjJkd13olXRn4+T+PN+WWcJozlRcRjph\n t+6A==","X-Gm-Message-State":"AOJu0Yw4ImHAnn3fUpiLVynw/9rMmZ6AmHK+zAqMQWk77yIAmC9R6/oe\n +80YcKbAZN+AX34Xowht4C3QyvECyXDBHUoLQzxCTzG6PfF8kDXqEKv3+8QxyMRzb1vk9VQdQmV\n Bg++x2uo=","X-Gm-Gg":"AeBDieuhU6gxW63nUh5kZ/pT77gjg5vIeWx3m+0rlRow9iLkty1+p4SAvspcqW+eR4K\n IITVEd+4w2RuN9V2ivH35aoWTh6X61ptyjwu8Gh9pAmrolCsYXUfcZCkyfNXWNMNC/B1O1H6j51\n dOYzMv6XlDRoGPVwntqcFM91VWkvHoAUDEOLKafonFDTJLpcjXU6RiZOIL1rH776X07jYeW7QPB\n slJdKsbX+L50ajS4Hcg1IbN66Uh2fpQf21JrIdpDQlUFTssYw0MYVIuvjuSulIWcuqgnZtIHSZB\n 6OQ2EIgCerEh+7wpaUwLCa0wSwHwxIkiOL7e1T+u/0e04ts6W1aHrKrQeUkaItFtkx775utGe9/\n V/pa/rQq36Y+ES1ztdsR3VbIZ9n1vEx6fGqfV6rn04e+DgiuBKlsVv9XgRcBuP9OM4guyacrNm7\n q0f5MvONW+jNL7F3P/7xD//CPl6a6ldKg2OMEtW+2ck96TonjqYo8vAS5JBpOyiNvz11jp3YcC","X-Received":"by 2002:a05:600c:5292:b0:486:fe39:28b7 with SMTP id\n 5b1f17b1804b1-488d67fa48emr383437815e9.9.1776352027386;\n Thu, 16 Apr 2026 08:07:07 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aleksandar Rikalo , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ,\n Richard Henderson ,\n Aurelien Jarno ","Subject":"[PATCH v4 2/2] target/mips: Use probe_access_full() in Atomic\n Load/Store helpers","Date":"Thu, 16 Apr 2026 17:06:49 +0200","Message-ID":"<20260416150649.23671-3-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416150649.23671-1-philmd@linaro.org>","References":"<20260416150649.23671-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Let the probe_access() API check the address alignment.\n\nMove env->CP0_LLAddr and env->lladdr assignments so we\ndon't update them when an alignment fault occurs.\n\nSince we have a handy MemOpIdx, replace the legacy\ncpu_ld*_mmuidx_ra() calls by cpu_ld*_mmu() equivalent.\n\nSuggested-by: Richard Henderson \nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/mips/tcg/ldst_helper.c | 21 +++++++++++++++------\n 1 file changed, 15 insertions(+), 6 deletions(-)","diff":"diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c\nindex b725c6d0333..4ebf72d610e 100644\n--- a/target/mips/tcg/ldst_helper.c\n+++ b/target/mips/tcg/ldst_helper.c\n@@ -28,23 +28,32 @@\n #include \"internal.h\"\n \n #ifndef CONFIG_USER_ONLY\n+#include \"accel/tcg/probe.h\"\n+#include \"exec/tlb-flags.h\"\n \n #define HELPER_LD_ATOMIC(name, insn, almask, do_cast) \\\n target_ulong helper_##name(CPUMIPSState *env, target_ulong arg, \\\n uint32_t memop_idx) \\\n { \\\n- MemOpIdx oi = memop_idx; \\\n- unsigned mem_idx = get_mmuidx(oi); \\\n- if (arg & almask) { \\\n+ MemOpIdx oi = memop_idx; \\\n+ unsigned mem_idx = get_mmuidx(oi); \\\n+ unsigned size = memop_size(get_memop(oi)); \\\n+ uintptr_t ra = GETPC(); \\\n+ CPUTLBEntryFull *full; \\\n+ void *host_unused; \\\n+ int flags; \\\n+ \\\n+ env->llval = do_cast cpu_##insn##_mmu(env, arg, oi, ra); \\\n+ flags = probe_access_full(env, arg, size, MMU_DATA_LOAD, mem_idx, \\\n+ true, &host_unused, &full, ra); \\\n+ if (unlikely(flags & TLB_INVALID_MASK)) { \\\n if (!(env->hflags & MIPS_HFLAG_DM)) { \\\n env->CP0_BadVAddr = arg; \\\n } \\\n do_raise_exception(env, EXCP_AdEL, GETPC()); \\\n } \\\n- env->CP0_LLAddr = cpu_mips_translate_address(env, arg, MMU_DATA_LOAD, \\\n- GETPC()); \\\n+ env->CP0_LLAddr = full->phys_addr; \\\n env->lladdr = arg; \\\n- env->llval = do_cast cpu_##insn##_mmuidx_ra(env, arg, mem_idx, GETPC()); \\\n return env->llval; \\\n }\n HELPER_LD_ATOMIC(ll, ldl, 0x3, (target_long)(int32_t))\n","prefixes":["v4","2/2"]}