{"id":2224032,"url":"http://patchwork.ozlabs.org/api/patches/2224032/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416150649.23671-2-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416150649.23671-2-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-16T15:06:48","name":"[v4,1/2] target/mips: Pass MemOpIdx argument to Linked Load/Store helpers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f115a9caf9f4cef4feb0ac5c4eeae4f9ee644c91","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416150649.23671-2-philmd@linaro.org/mbox/","series":[{"id":500176,"url":"http://patchwork.ozlabs.org/api/series/500176/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500176","date":"2026-04-16T15:06:47","name":"target/mips: Use probe_access_full() in Atomic Load/Store helpers","version":4,"mbox":"http://patchwork.ozlabs.org/series/500176/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224032/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224032/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZUbzEHsU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxLw60WvKz1yCv\n\tfor ; Fri, 17 Apr 2026 01:07:18 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDOJA-0007mc-7e; Thu, 16 Apr 2026 11:07:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDOJ8-0007mK-AU\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 11:07:06 -0400","from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDOJ6-0000jx-Ov\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 11:07:06 -0400","by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-43d74086e5bso3544999f8f.0\n for ; Thu, 16 Apr 2026 08:07:04 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43ead3d5c8fsm15254949f8f.19.2026.04.16.08.06.58\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 16 Apr 2026 08:06:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776352022; x=1776956822; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=iHZbH8NF/lYrzFgfuFqRfZFX4V6yynxs314wd9vwmAA=;\n b=ZUbzEHsUSRdkI0ONEyZUySOV5WdX/IC3ceezWvTaoDjWVz/y4/xVJKRXxM5Kn2HBYK\n G1c97OxkBHdewQ7R4jh+SWHgxLFhWouiJYRKyNUf9tiM/lQ79K7w5so1t5jrmVVQT8XL\n 68ZIgLByUHFaAc4YnOCOflzyf7gTxnnBpPNVoK5G0ubpQqDpopULBHgSslspnwrC8EO4\n dObAAR0gyfuDNi+AgMiifZDsUUDHuPdrLASikSaQluccMdld9CYs+i4HmKtwUfSAKopH\n CJ2hrZuwCKGVqOflo6O9s7AwaIRz8F7Af94L6SvpdgWcJSlB3NY3PeRdFfY5vO1FfEmu\n tG3g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776352022; x=1776956822;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=iHZbH8NF/lYrzFgfuFqRfZFX4V6yynxs314wd9vwmAA=;\n b=jH260RdSJ+EuaJWt+265jVoxqXqkU4CTDbffIQnmRcFGildxs9+SQoGuxLga1bSKps\n p5R/jsdaWEam/+bjSdWGk7DGCco/ujVPHQLBNTT/5jfTFPgmlNk64uFo4aO4rhYwzZ4V\n u4ctm0rBnTTPj8eqgzBi77QH0RisrROtFU61CSDxfQqBfTUjcLJnjbg0DbQfW4+xw1/9\n kKFIh1otCZ3WY6G3tEZGmm0YhJnmj4lUaA/hLFQPCIt87BdTzdXy4SOZXpPjgr0jubeU\n WRuQO925TZOITnATydAHrY2YiHeBVKgYVm0DpI+1kk4fYutWqUFSalIyRkMkyMlaPR/T\n /kCw==","X-Gm-Message-State":"AOJu0YxjAfcN1QrWU+EELW/p21qjMA/+FOXYGychCNW7r56fL8z/BZQH\n 8zdrd73MJcpE+aHr4s2BUwWMTjbVuTOgAnwA3y7oybwBxdwgovJWTp1LoP9ru97ogcIP8bEnI1N\n jclpq0R4=","X-Gm-Gg":"AeBDievR+EOAAtf5Ksuj07UBZF3lzIlbtgrgjYMIVRMGyKKpWLcWN51GjFX2utUpIi/\n 3vWikbVpkIjC5DNa270MPt+4S8vDPExordeUy9t5xmbFqVGeEwWR1gAiaNL9CNob9RBVVgwoxhP\n QIzuvrKe05FWUNMLZNcgYhjk/3EMDqQ+ggg3G1DnJxSNhgqssZziCGvCq+zuB1PsmnQnvP/YAvT\n lllKGsExq1E6cbTqkcRihnn8EuqxumtVWTa5splHlhT9WSSy5AiScOc9UU9UiNBsCU5TVojFuTA\n ZOFUyGGpcOCTF0u1il/gnBL3MypvlU0BOiRjvKRyC9p4zvC+DUzQSnNYbfuxkqYmeoFxNTcvRpI\n vloQ9Uj9fnpcX5FgHF3s3vM5tU1MZ8wt9WCmKgKzCRmjLtkpHBhD0iDO6LWfFEdlRMQGSQhsmgZ\n VugHdQ0OZ/rWzFpzsoXLZ9ImB4ortDdK8v807SbHDbm6LRD4lCphMP8W7JiH1kiSb6QeOAMBRM","X-Received":"by 2002:a05:6000:2dc1:b0:43d:7af0:3a7c with SMTP id\n ffacd0b85a97d-43d7af03e24mr22688225f8f.29.1776352019989;\n Thu, 16 Apr 2026 08:06:59 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aleksandar Rikalo , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ,\n Richard Henderson ,\n Aurelien Jarno ","Subject":"[PATCH v4 1/2] target/mips: Pass MemOpIdx argument to Linked\n Load/Store helpers","Date":"Thu, 16 Apr 2026 17:06:48 +0200","Message-ID":"<20260416150649.23671-2-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416150649.23671-1-philmd@linaro.org>","References":"<20260416150649.23671-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::435;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"In preparation of using the MemOp content in the next commit\n(thus stopping ignoring it), pass it as MemOpIdx.\n\nThe helper prototype declaration always took a TCGv_i32 as\nlast argument, correct that.\n\nRename the ignored 'mem_idx' argument on user emulation.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/mips/helper.h | 4 ++--\n target/mips/tcg/ldst_helper.c | 5 ++++-\n target/mips/tcg/translate.c | 7 ++++---\n 3 files changed, 10 insertions(+), 6 deletions(-)","diff":"diff --git a/target/mips/helper.h b/target/mips/helper.h\nindex e70a3942fac..10c6470514d 100644\n--- a/target/mips/helper.h\n+++ b/target/mips/helper.h\n@@ -10,9 +10,9 @@ DEF_HELPER_4(swl, void, env, tl, tl, int)\n DEF_HELPER_4(swr, void, env, tl, tl, int)\n \n #ifndef CONFIG_USER_ONLY\n-DEF_HELPER_3(ll, tl, env, tl, int)\n+DEF_HELPER_3(ll, tl, env, tl, i32)\n #ifdef TARGET_MIPS64\n-DEF_HELPER_3(lld, tl, env, tl, int)\n+DEF_HELPER_3(lld, tl, env, tl, i32)\n #endif\n #endif\n \ndiff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c\nindex 10319bf03a6..b725c6d0333 100644\n--- a/target/mips/tcg/ldst_helper.c\n+++ b/target/mips/tcg/ldst_helper.c\n@@ -30,8 +30,11 @@\n #ifndef CONFIG_USER_ONLY\n \n #define HELPER_LD_ATOMIC(name, insn, almask, do_cast) \\\n-target_ulong helper_##name(CPUMIPSState *env, target_ulong arg, int mem_idx) \\\n+target_ulong helper_##name(CPUMIPSState *env, target_ulong arg, \\\n+ uint32_t memop_idx) \\\n { \\\n+ MemOpIdx oi = memop_idx; \\\n+ unsigned mem_idx = get_mmuidx(oi); \\\n if (arg & almask) { \\\n if (!(env->hflags & MIPS_HFLAG_DM)) { \\\n env->CP0_BadVAddr = arg; \\\ndiff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c\nindex 6d4b6412d70..4889bd1e518 100644\n--- a/target/mips/tcg/translate.c\n+++ b/target/mips/tcg/translate.c\n@@ -1922,7 +1922,7 @@ FOP_CONDNS(s, FMT_S, 32, gen_store_fpr32(ctx, fp0, fd))\n /* load/store instructions. */\n #ifdef CONFIG_USER_ONLY\n #define OP_LD_ATOMIC(insn, memop) \\\n-static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, \\\n+static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx_ignored, \\\n DisasContext *ctx) \\\n { \\\n TCGv t0 = tcg_temp_new(); \\\n@@ -1932,11 +1932,12 @@ static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, \\\n tcg_gen_st_tl(ret, tcg_env, offsetof(CPUMIPSState, llval)); \\\n }\n #else\n-#define OP_LD_ATOMIC(insn, ignored_memop) \\\n+#define OP_LD_ATOMIC(insn, memop) \\\n static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, \\\n DisasContext *ctx) \\\n { \\\n- gen_helper_##insn(ret, tcg_env, arg1, tcg_constant_i32(mem_idx)); \\\n+ MemOpIdx oi = make_memop_idx(memop | MO_ALIGN, mem_idx); \\\n+ gen_helper_##insn(ret, tcg_env, arg1, tcg_constant_i32(oi)); \\\n }\n #endif\n OP_LD_ATOMIC(ll, mo_endian(ctx) | MO_SL);\n","prefixes":["v4","1/2"]}